Re: Should usb_gadget_disconnect() call driver's ->disconnect?

2018-08-10 Thread Felipe Balbi
Hi, Alan Stern writes: >> >> > The documentation doesn't state whether a gadget driver's >> >> > ->disconnect() callback will be invoked when usb_gadget_disconnect() >> >> > runs. Probably the UDC drivers' behavior has changed over the years. >> >> > >> >> > In any case, it's likely that vari

patch ACS ACR122U

2018-08-10 Thread Julien F.
Hello, I'm sending you this email because i found this topic https://patchwork.kernel.org/patch/10407169/ on the error -11 when we plug a NFC ACR122U reader, and ... that's exactly my problem ! and nobodies on forums were able to help me ^^. So apparently you fixed the issue ? do you now if th

Re: patch ACS ACR122U

2018-08-10 Thread Greg KH
On Fri, Aug 10, 2018 at 01:47:37PM +, Julien F. wrote: > Hello, > > I'm sending you this email because i found this topic > https://patchwork.kernel.org/patch/10407169/ on the error -11 when we > plug a NFC ACR122U reader, and ... that's exactly my problem ! and > nobodies on forums were able

Re: [PATCH] Add quirk to support DJI CineSSD

2018-08-10 Thread Alan Stern
On Thu, 9 Aug 2018, Tim Anderson wrote: > This device does not correctly handle the LPM operations. > > Also, the device cannot handle ATA pass-through commands > and locks up when attempted while running in super speed. In theory, we could allow ATA pass-through when running at high speed. Bu

g_audio regression on dwc3 udc

2018-08-10 Thread Bin Liu
Hi Felipe, I noticed a regression on g_audio (uac2) with dwc3 udc on v4.14: - nosound in playback - playback can only play once, the following error happens from the 2nd playback aplay: set_params:1361: Unable to install hw params: A manual bisect tells the two issues are seperate and the r

[PATCH 0/2] USB: gadget core: Call ->disconnect() from usb_gadget_disconnect()

2018-08-10 Thread Alan Stern
Felipe: The following patches concern ->disconnect() callbacks made when a gadget's D+ pullup is turned off. Currently we don't have a fixed rule for such callbacks. The first patch makes usb_gadget_disconnect() issue the callback automatically, so that it will always happen and UDC drivers d

[PATCH 2/2] USB: net2280: Remove ->disconnect() callback from net2280_pullup()

2018-08-10 Thread Alan Stern
The net2280 UDC driver invokes the gadget driver's ->disconnect() callback routine when the net2280_pullup() routine turns off the D+ pullup. This is now unnecessary, because the gadget core performs the callback on our behalf. This patch removes the unneeded callback. Signed-off-by: Alan Stern

[PATCH 1/2] USB: gadget core: Issue ->disconnect() callback from usb_gadget_disconnect()

2018-08-10 Thread Alan Stern
The gadget documentation doesn't state clearly whether a gadget driver's ->disconnect() callback should be invoked when the D+ pullup is turned off. Some UDC drivers do this and some don't. This patch settles the issue by making the core function usb_gadget_disconnect() issue the callback, so tha

Re: patch ACS ACR122U

2018-08-10 Thread Julien F.
Hello, I'm running 4.15.0-30-generic (Ubuntu 18.04.1 LTS), so it shoud be ok, but i still have the error :/ I really don't know what's the problem... here is my dmesg extract : [ 144.142205] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [ 144.142209] usb 2-2: Product: ACR

Re: patch ACS ACR122U

2018-08-10 Thread Greg KH
On Fri, Aug 10, 2018 at 07:42:07PM +, Julien F. wrote: > Hello, > > I'm running 4.15.0-30-generic (Ubuntu 18.04.1 LTS), so it shoud be ok, but i > still have the error :/ I would go file a bug with Ubuntu and tell them to upgrade their kernel :) The patch was never in any 4.15 kernel releas

Re: g_audio regression on dwc3 udc

2018-08-10 Thread Thinh Nguyen
Hi Bin, On 8/10/2018 12:05 PM, Bin Liu wrote: > Hi Felipe, > > I noticed a regression on g_audio (uac2) with dwc3 udc on v4.14: > > - nosound in playback > - playback can only play once, the following error happens from the 2nd > playback > > aplay: set_params:1361: Unable to install hw params