Re: [PATCH V2 2/2] usb: gadget: storage: Remove reference counting

2018-07-05 Thread Michał Nazarewicz
Acked-by: Michal Nazarewicz 2018-07-04 5:51 GMT+01:00 Jaejoong Kim : > The kref used to be needed because sharing of fsg_common among multiple USB > function instances was handled by fsg. Now this is managed by configfs, we > don't need it anymore. So let's eliminate kref from this driver. > > Si

usb: usbtest: TEST 13: set/clear 1 halts is getting failed with super speed

2018-07-05 Thread Pradeep Das
Hi, Posting this query again as I received some mail delivery failure notification on the previous attempt. I am running usbtest test cases and facing following issues: Setup: I am using two custom board running on Linux. One is configured as host and loaded with usbtest.ko module. Another one

Re: Incorrect PID in drivers/usb/serial/kl5kusb105.h

2018-07-05 Thread Johan Hovold
On Wed, Jul 04, 2018 at 05:18:34PM +0100, Chris Jakob wrote: > Thanks. > Apologies I may have been a little premature as the device still does > not seem to be working (although it is now recognised) > > dmesg provides: > [6.864734] kl5kusb105: loading out-of-tree module taints kernel. > [

dwc3 usb2 as host not working

2018-07-05 Thread Ricardo Ribalda Delgado
Hi I have started playing around with a board based on the DragonBoard 820c and I cannot manage to get the USB2 working as host. If I connect a mouse, before I start the board I can see how the system powers up the port (vbus) and enumerates the device, just to kill it a couple of seconds later.

Re: USB Type-C hub detection is flaky

2018-07-05 Thread Heikki Krogerus
Hi, On Fri, Jun 29, 2018 at 10:26:46PM +0200, Timur Krist?f wrote: > Hi Heikki, > > On Fri, 2018-06-29 at 14:42 +0300, Heikki Krogerus wrote: > > Hi Tim, > > > > On Tue, Jun 26, 2018 at 02:10:57PM +0200, Timur Krist?f wrote: > > > > Can you send the dmesg output after you have plugged the powere

Re: [PATCH -next] usb: typec: altmodes: Fix missing unlock on error in dp_altmode_activate()

2018-07-05 Thread Heikki Krogerus
On Wed, Jul 04, 2018 at 09:25:43AM +, Wei Yongjun wrote: > Add the missing unlock before return from function > dp_altmode_activate() in the error handling case. > > Fixes: 0e3bb7d6894d ("usb: typec: Add driver for DisplayPort alternate mode") > Signed-off-by: Wei Yongjun > --- > drivers/usb

Re: cp20x GPIO from user application

2018-07-05 Thread Johan Hovold
[ Adding linux-usb as other may be interested in this. ] On Thu, Jul 05, 2018 at 01:57:29PM +0100, Antonio Santagiuliana wrote: > Thank you for the information. > What I don't understand is that if I use the CP2105 are its GPIOs usable by > this driver ? Yes, they should be. But if I remember cor

Re: [PATCH V2 2/2] usb: gadget: storage: Remove reference counting

2018-07-05 Thread Alan Stern
On Wed, 4 Jul 2018, Jaejoong Kim wrote: > The kref used to be needed because sharing of fsg_common among multiple USB > function instances was handled by fsg. Now this is managed by configfs, we > don't need it anymore. So let's eliminate kref from this driver. > > Signed-off-by: Jaejoong Kim A

Re: Zero Packets in Isochronous Transfer Reception

2018-07-05 Thread Alan Stern
On Wed, 4 Jul 2018, R0b0t1 wrote: > On Sun, Jul 1, 2018 at 9:12 AM, Alan Stern wrote: > > On Sat, 30 Jun 2018, R0b0t1 wrote: > > > >> The problem seems more noticeable when using the Python libusb > >> bindings but it still exists when using libusb directly. Can anyone > >> suggest what to look i

[PATCH 1/2] usb: dwc2: Fix DMA alignment to start at allocated boundary

2018-07-05 Thread Antti Seppälä
The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more supported way") introduced a common way to align DMA allocations. The code in the commit aligns the struct dma_aligned_buffer but the actual DMA address pointed by data[0] gets aligned to an offset from the allocated boundary by t

[PATCH 0/2] usb: dwc2: DMA alignment fixes

2018-07-05 Thread Antti Seppälä
Here are two patches that improve DMA alignment handling of the dwc2 driver significantly. The first one ("usb: dwc2: Fix DMA alignment to start at allocated boundary") fixes an actual crash regression on some platforms introduced by commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more

[PATCH 2/2] usb: dwc2: Fix inefficient copy of unaligned buffers

2018-07-05 Thread Antti Seppälä
Make sure only to copy any actual data rather than the whole buffer, when releasing the temporary buffer used for unaligned non-isochronous transfers. Taken directly from commit 0efd937e27d5e ("USB: ehci-tegra: fix inefficient copy of unaligned buffers") Tested with Lantiq xRX200 (MIPS) and RPi M

[PATCH 1/2] USB: serial: cp210x: make line-speed quantisation data driven

2018-07-05 Thread Johan Hovold
Older cp210x devices only support a fixed set of line speeds to which a requested speed is mapped. Reimplement this mapping using a table instead of a long if-else construct. Signed-off-by: Johan Hovold --- drivers/usb/serial/cp210x.c | 99 + 1 file changed, 5

[PATCH 0/2] USB: serial: cp210x: clean up line-speed handling

2018-07-05 Thread Johan Hovold
This cleans up the current line-speed handling somewhat, while avoiding requesting an unsupported line speed (which can lead to undefined behaviour) by determining the maximum speed supported by the device type in question. Karoly, how did your line-speed tests with cp2102n go? I think we should j

[PATCH 2/2] USB: serial: cp210x: honour device-type maximum line speed

2018-07-05 Thread Johan Hovold
Newer cp210x devices support higher line speeds than the older ones which supported a discrete set of speeds up to 921.6 kbaud. To support these higher speeds, we have for some time mapped speeds lower than 1 Mbaud to the speeds supported by older devices, while allowing the device to pick the clo

Re: usb: usbtest: TEST 13: set/clear 1 halts is getting failed with super speed

2018-07-05 Thread Alan Stern
On Thu, 5 Jul 2018, Pradeep Das wrote: > Hi, > > Posting this query again as I received some mail delivery failure > notification on the previous attempt. > > I am running usbtest test cases and facing following issues: > > Setup: > I am using two custom board running on Linux. One is configur

Re: [PATCH 0/2] USB: serial: cp210x: clean up line-speed handling

2018-07-05 Thread Karoly Pados
Hi, > Karoly, how did your line-speed tests with cp2102n go? I indeed tested this. I first built a version of the module where I skip calling cp210x_quantise_baudrate(). Then I attached a scope to the TX line of my UART adapter and looked at various non-standard values in both low (<10k) and high

Re: usb: usbtest: TEST 13: set/clear 1 halts is getting failed with super speed

2018-07-05 Thread Pradeep Das
Thanks, Alan Stern for a quick reply. Can you please suggest a probable area to look out for the failure of the endpoint halt test case for the superspeed devices. On Thu, Jul 5, 2018 at 8:31 PM Alan Stern wrote: > > On Thu, 5 Jul 2018, Pradeep Das wrote: > > > Hi, > > > > Posting this query agai