Re: [PATCH] USB: serial: cp210x: add Silicon Labs IDs for Windows Update

2018-06-18 Thread Johan Hovold
On Sat, Jun 09, 2018 at 01:26:08PM +0200, Karoly Pados wrote: > Silicon Labs defines alternative VID/PID pairs for some chips that when > used will automatically install drivers for Windows users without manual > intervention. Unfortunately, these IDs are not recognized by the Linux > module, so us

Re: [PATCH] USB: serial: cp210x: add Silicon Labs IDs for Windows Update

2018-06-18 Thread Karoly Pados
Hello, > How does this work; do these chips now come with the "windows update" > PIDs, and the silabs drivers then reprogram them to use other PIDs once > installed? > The way this works is that the chips still come with the standard SiLabs IDs. When the chip is integrated into an end-user prod

Re: [PATCH] USB: serial: cp210x: add Silicon Labs IDs for Windows Update

2018-06-18 Thread Johan Hovold
On Mon, Jun 18, 2018 at 07:26:24AM +, Karoly Pados wrote: > The way this works is that the chips still come with the standard > SiLabs IDs. When the chip is integrated into an end-user product, the > product manufacturer has the choice to reprogram the IDs. If they are > left on the factory st

Re: Inquiry for adding PID to Cp2102 driver

2018-06-18 Thread Johan Hovold
On Fri, Jun 15, 2018 at 05:05:38PM +0200, Carlos Barcala Lara wrote: > Dear Johan (and rest of the team) > > This is Carlos Barcala, from CESINEL SL, in Spain. We are a little > manufacturer > of Power Quality Analyzers and Energy Meters. We include in all our products > the Silabs CP2102 chip fo

Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-18 Thread Johan Hovold
On Thu, Jun 14, 2018 at 10:08:46PM +0200, Loic Poulain wrote: > Most of FTDI's devices have an EEPROM which records FTDI devices > configuration setting (e.g. the VID, PID, I/O config...) and user > data. FT230R chip integrates a 128-byte eeprom, FT230X a 2048-byte > eeprom... > > This patch adds

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Johan Hovold
On Mon, Jun 18, 2018 at 11:15:41AM +0300, Felipe Balbi wrote: > I don't use this glue layer, actually. As long as there are no > regressions, you can change it to your heart's content. I still it's > best to start with pm runtime blocked and let userspace decide what and > when should have pm runt

Re: Inquiry for adding PID to Cp2102 driver

2018-06-18 Thread Johan Hovold
On Mon, Jun 18, 2018 at 10:53:35AM +0200, Carlos Barcala Lara wrote: > Thank you very much, Johan. > > The PIDs are all right. Thanks for checking. > I´m sorry, but I don´t know how to use the patch, if needed in the > future. It would need to be applied (e.g. using git-am) to the kernel source

Re: Inquiry for adding PID to Cp2102 driver

2018-06-18 Thread Carlos Barcala Lara
Thanks again, Johan. Should I have a user to do the git-am (if needed in the future)? Regards, El 18/06/2018 a las 11:27, Johan Hovold escribió: On Mon, Jun 18, 2018 at 10:53:35AM +0200, Carlos Barcala Lara wrote: Thank you very much, Johan. The PIDs are all right. Thanks for checking. I

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Felipe Balbi
Hi, Johan Hovold writes: > On Mon, Jun 18, 2018 at 11:15:41AM +0300, Felipe Balbi wrote: > >> I don't use this glue layer, actually. As long as there are no >> regressions, you can change it to your heart's content. I still it's >> best to start with pm runtime blocked and let userspace decide w

Re: Inquiry for adding PID to Cp2102 driver

2018-06-18 Thread Johan Hovold
On Mon, Jun 18, 2018 at 11:29:51AM +0200, Carlos Barcala Lara wrote: > Thanks again, Johan. > > Should I have a user to do the git-am (if needed in the future)? That would only be needed if you ever want to add further device ids. Then you can create a patch (e.g. by committing you changes to a l

Re: Inquiry for adding PID to Cp2102 driver

2018-06-18 Thread Felipe Balbi
Johan Hovold writes: > On Mon, Jun 18, 2018 at 11:29:51AM +0200, Carlos Barcala Lara wrote: >> Thanks again, Johan. >> >> Should I have a user to do the git-am (if needed in the future)? > > That would only be needed if you ever want to add further device ids. > Then you can create a patch (e.g.

Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-18 Thread Srinivas Kandagatla
On 18/06/18 09:46, Johan Hovold wrote: On Thu, Jun 14, 2018 at 10:08:46PM +0200, Loic Poulain wrote: Most of FTDI's devices have an EEPROM which records FTDI devices configuration setting (e.g. the VID, PID, I/O config...) and user data. FT230R chip integrates a 128-byte eeprom, FT230X a 2048

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Johan Hovold
On Mon, Jun 18, 2018 at 12:33:44PM +0300, Felipe Balbi wrote: > Johan Hovold writes: > > I suggest merging this fix for 4.18-rc, and then Roger can rework the > > driver so that it works also on OMAP. > > omap has its own glue layer for several reasons. If you're talking about > Keystone device

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Felipe Balbi
Hi, Johan Hovold writes: > On Mon, Jun 18, 2018 at 12:33:44PM +0300, Felipe Balbi wrote: > >> Johan Hovold writes: > >> > I suggest merging this fix for 4.18-rc, and then Roger can rework the >> > driver so that it works also on OMAP. >> >> omap has its own glue layer for several reasons. If y

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Felipe Balbi
Hi, Johan Hovold writes: > On Wed, Jun 13, 2018 at 12:39:18PM +0300, Felipe Balbi wrote: >> Roger Quadros writes: > >> > I'm still trying to get my head around this. >> > >> > in probe() we do >> > { >> >enable all clocks; >> > pm_runtime_set_active(dev); >> > pm_runtime_ena

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Roger Quadros
On 18/06/18 12:51, Felipe Balbi wrote: > > Hi, > > Johan Hovold writes: >> On Mon, Jun 18, 2018 at 12:33:44PM +0300, Felipe Balbi wrote: >> >>> Johan Hovold writes: >> I suggest merging this fix for 4.18-rc, and then Roger can rework the driver so that it works also on OMAP. >>> >>> o

Re: USB role switches, usb-connector, typec and device trees

2018-06-18 Thread Heikki Krogerus
Hi Mats, On Fri, Jun 15, 2018 at 11:51:17PM +0200, Mats Karrman wrote: > I hacked away to see if I could make some sense of this but I didn't get far. > Do you mean that the device_connection_find_match() function should be > extended with code for finding matches in devicetrees as well? Yes. >

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Felipe Balbi
Hi, Roger Quadros writes: > On 18/06/18 12:51, Felipe Balbi wrote: >> >> Hi, >> >> Johan Hovold writes: >>> On Mon, Jun 18, 2018 at 12:33:44PM +0300, Felipe Balbi wrote: >>> Johan Hovold writes: >>> > I suggest merging this fix for 4.18-rc, and then Roger can rework the > driver

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18 Thread Roger Quadros
+Tero, Tony and some TI folks On 18/06/18 15:21, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> On 18/06/18 12:51, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Johan Hovold writes: On Mon, Jun 18, 2018 at 12:33:44PM +0300, Felipe Balbi wrote: > Johan Hovold writes: >>>