PID bitfield in descriptor should be set based on particular request
length, not based on EP's mc value. PID value can't be set to 0 even
request length is 0.
If request length is 0 then SP bit should be set along PID.
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/gadget.c | 15
> From: Greg Kroah-Hartman, Sent: Wednesday, May 30, 2018 12:31 AM
>
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Felipe Balbi
> Cc: Yoshihiro Sh
PID bitfield in descriptor should be set based on particular request
length, not based on EP's mc value. PID value can't be set to 0 even
request length is 0.
If request length is 0 then SP bit should be set along PID.
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/gadget.c | 15
+Guenter
On Tue, May 29, 2018 at 05:30:46PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Clean up the tcpm.c code to
On Wed, May 30, 2018 at 01:30:20PM +0300, Heikki Krogerus wrote:
> +Guenter
>
> On Tue, May 29, 2018 at 05:30:46PM +0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> >
Hi,
Laurent Pinchart writes:
>> I've been working on this series for a while now. I feels like
>> after this series the transfer management code is far easier to
>> read and understand.
>>
>> Based on my tests, I have no regressions. Tested g_mass_st
Hello Bin Liu,
The patch bcb8fd3a2fba: "usb: musb: break the huge isr
musb_stage0_irq() into small functions" from May 21, 2018, leads to
the following static checker warning:
drivers/usb/musb/musb_core.c:797 musb_handle_intr_connect()
error: we previously assumed 'musb->hcd' coul
On 05/30/2018 03:30 AM, Heikki Krogerus wrote:
+Guenter
On Tue, May 29, 2018 at 05:30:46PM +0200, Greg Kroah-Hartman wrote:
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different base
On 05/30/2018 03:36 AM, Greg Kroah-Hartman wrote:
On Wed, May 30, 2018 at 01:30:20PM +0300, Heikki Krogerus wrote:
+Guenter
On Tue, May 29, 2018 at 05:30:46PM +0200, Greg Kroah-Hartman wrote:
When calling debugfs functions, there is no need to ever check the
return value. The function can wor
On Wed, 30 May 2018, Rindt, Daniel wrote:
> Dear Mr. Stern,
>
> i stumbled over your conversation regarding the sleep thing:
> https://www.spinics.net/lists/linux-usb/msg168671.html
>
> I am not familiar with the handling of the mailing list, for that
> reason i wrote you.
Discussions like this
Hi,
On Wed, May 30, 2018 at 4:04 AM, Manu Gautam wrote:
> Move from dwc3-of-simple to dwc3-qcom glue driver to
> support peripheral mode which requires qscratch wrapper
> programming on VBUS event.
Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
> Signed-off-by: Manu Gautam
>
Hi,
On 29/05/2018 17:31:02+0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> There is also no need to keep the file dentrie
On Wed, May 30, 2018 at 07:31:13PM +0200, Alexandre Belloni wrote:
> Hi,
>
> On 29/05/2018 17:31:02+0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do somethi
On 29/05/2018 17:31:02+0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> There is also no need to keep the file dentries aro
Mathias,
On 5/22/2018 2:55 PM, Adam Wallis wrote:
> The xhci driver forces DMA memory to be node aware, however, there are
> several ring-related memory allocations that are not memory node aware.
> This patch resolves those *alloc functions to be allocated on the proper
> memory node.
>
> Signed
On Mon, 28 May 2018, Anshuman Gupta wrote:
> > It sounds like you want the code in usb_port_resume() to check and see
> > whether the port has already received a wakeup signal and hasn't
> > finished processing it yet.
> yes.
> >
> > There's no way to do this for ports on external hubs, but in
On Mon, May 28, 2018 at 10:52:33AM +0800, Li Jun wrote:
> Add bindings supported by current typec driver, so user can pass
> all those properties via dt.
>
> Signed-off-by: Li Jun
> ---
> .../bindings/connector/usb-connector.txt | 44 +++
> include/dt-bindings/usb/pd.h
Hi Felipe,
Felipe Balbi writes:
< snip >
> thinking about this a little more. This extra list_empty() check is
> not wrong at all :-) I've amended this series with the 3 patches
> below. I'll resend the series once I've given more time for people to
> test. Patches have been updated to the bran
Hi,
Paul Zimmerman writes:
> Hi Felipe,
>
> Felipe Balbi writes:
>
> < snip >
>
>> thinking about this a little more. This extra list_empty() check is
>> not wrong at all :-) I've amended this series with the 3 patches
>> below. I'll resend the series once I've given more time for people to
>>
19 matches
Mail list logo
