RE: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-16 Thread Peter Chen
> Add bingdings supported by current typec driver, so user can pass all those > properties via dt. > %s/bingdings/bindings Peter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

2018-05-16 Thread Greg KH
On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote: > Dear Greg, > > > As always, thank you for the prompt response. > > > On 05/15/18 18:00, Greg KH wrote: > > On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote: > > > > Linux 4.17-rc5 shows the error below on the Dell XPS 13

[PATCH v3] usb: dwc2: Fix kernel doc's warnings.

2018-05-16 Thread Grigor Tovmasyan
Added descriptions for all not described parameters. Fix all kernel doc's warnings. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core.c | 7 ++ drivers/usb/dwc2/core.h | 170 ++- drivers/usb/dwc2/debug.h | 2 +- drivers/usb/dwc2/d

Re: [PATCH v3] usb: dwc2: Fix kernel doc's warnings.

2018-05-16 Thread Grigor Tovmasyan
Hi Felipe, I rebase this patch to your current testing/next (3196f73ff844) BR, Grigor. On 5/16/2018 12:04 PM, Grigor Tovmasyan wrote: > Added descriptions for all not described parameters. > Fix all kernel doc's warnings. > > Signed-off-by: Grigor Tovmasyan > --- > drivers/usb/dwc2/core.c

RE: [PATCH v5 12/14] staging: typec: tcpci: keep the not connecting cc line open

2018-05-16 Thread Peter Chen
> > While set polarity, we should keep the not connecting cc line to be open. > keep the disconnected cc line open? Peter > Signed-off-by: Li Jun > --- > drivers/staging/typec/tcpci.c | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/drivers/stag

Re: [PATCH net-next v2 0/2] of: mdio: Fall back to mdiobus_register() with NULL device_node

2018-05-16 Thread Geert Uytterhoeven
Hi Florian, Thanks for your series! I like the effect on simplifying drivers. On Wed, May 16, 2018 at 1:56 AM, Florian Fainelli wrote: > This patch series updates of_mdiobus_register() such that when the device_node > argument is NULL, it calls mdiobus_register() directly. This is consistent >

[balbi-usb:next 49/82] drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared; did you mean 'dwc3'?

2018-05-16 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next head: 3196f73ff8444f6b8bfce3dce1900b4eae27c324 commit: 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61 [49/82] usb: dwc3: gadget: remove unnecessary 'dwc' parameter config: x86_64-randconfig-i0-201819 (attached as .config) compi

Re: [hid:for-4.18/multitouch 7/7] drivers/hid/hid-multitouch.c:1209:9-10: WARNING: return of 0/1 in function 'mt_need_to_apply_feature' with return type bool

2018-05-16 Thread Jiri Kosina
On Fri, 27 Apr 2018, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git > for-4.18/multitouch > head: 02946f4b43b11026b1a76857a33b09078b900939 > commit: 02946f4b43b11026b1a76857a33b09078b900939 [7/7] HID: multitouch: > implement precision touchpad

[PATCH] USB: serial: use tty_port_register_device()

2018-05-16 Thread Johan Hovold
We already have the tty port when probing a usb-serial port so use tty_port_register_device() directly instead of tty_port_install() later to set up the port link. This is a step towards enabling serdev for usb-serial (but we need to determine how to handle hotplugging first). Signed-off-by: Joha

Re: [PATCH] USB: serial: use tty_port_register_device()

2018-05-16 Thread Greg Kroah-Hartman
On Wed, May 16, 2018 at 11:42:07AM +0200, Johan Hovold wrote: > We already have the tty port when probing a usb-serial port so use > tty_port_register_device() directly instead of tty_port_install() later > to set up the port link. > > This is a step towards enabling serdev for usb-serial (but we

[balbi-usb:next 49/82] drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared

2018-05-16 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next head: 3196f73ff8444f6b8bfce3dce1900b4eae27c324 commit: 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61 [49/82] usb: dwc3: gadget: remove unnecessary 'dwc' parameter config: x86_64-randconfig-s2-05161806 (attached as .config) com

Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

2018-05-16 Thread Jose Abreu
On 16-05-2018 00:56, Florian Fainelli wrote: > A number of drivers have the following pattern: > > if (np) > of_mdiobus_register() > else > mdiobus_register() > > which the implementation of of_mdiobus_register() now takes care of. > Remove that pattern in drivers that strictly adhere t

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-16 Thread Heikki Krogerus
On Tue, May 15, 2018 at 11:24:07PM +0200, Mats Karrman wrote: > Hi Heikki, > > On 05/15/2018 09:30 AM, Heikki Krogerus wrote: > > > Hi Mats, > > > > On Fri, May 11, 2018 at 09:28:04PM +0200, Mats Karrman wrote: > >> On 2018-05-11 13:14, Heikki Krogerus wrote: > >> > >>> On Fri, May 11, 2018 at 11

Re: Not enough bandwidth with Magewell XI100DUSB-HDMI

2018-05-16 Thread Mathias Nyman
On 15.05.2018 12:22, Michael Tretter wrote: Hi Mathias, On Tue, 10 Apr 2018 18:22:03 +0300, Mathias Nyman wrote: On 09.04.2018 11:21, Michael Tretter wrote: On Tue, 20 Feb 2018 15:29:28 +0200, Mathias Nyman wrote: On 16.02.2018 15:28, Michael Tretter wrote: On Mon, 29 Jan 2018 14:02:57 +0200

Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

2018-05-16 Thread Heikki Krogerus
Hi, On Wed, May 16, 2018 at 10:02:26AM +0200, Greg KH wrote: > On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote: > > Dear Greg, > > > > > > As always, thank you for the prompt response. > > > > > > On 05/15/18 18:00, Greg KH wrote: > > > On Tue, May 15, 2018 at 04:34:03PM +0200, Pau

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-16 Thread Heikki Krogerus
Hi guys, On Tue, May 15, 2018 at 10:52:57PM +0200, Mats Karrman wrote: > Hi, > > On 05/14/2018 11:36 AM, Jun Li wrote: > > > Hi > >> -Original Message- > >> From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > >> Sent: 2018???5???12??? 3:56 > >> To: Jun Li ; robh...@kernel.org; > >> gr

Re: [PATCH net-next v2 0/2] of: mdio: Fall back to mdiobus_register() with NULL device_node

2018-05-16 Thread Andrew Lunn
On Wed, May 16, 2018 at 10:54:12AM +0200, Geert Uytterhoeven wrote: > Hi Florian, > > Thanks for your series! > I like the effect on simplifying drivers. > > On Wed, May 16, 2018 at 1:56 AM, Florian Fainelli > wrote: > > This patch series updates of_mdiobus_register() such that when the > > de

Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

2018-05-16 Thread Paul Menzel
Dear Heikki, On 05/16/18 13:58, Heikki Krogerus wrote: On Wed, May 16, 2018 at 10:02:26AM +0200, Greg KH wrote: On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote: On 05/15/18 18:00, Greg KH wrote: On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote: Linux 4.17-rc5 sho

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-05-16 Thread kbuild test robot
Hi Matthew, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc5 next-20180516] [cannot apply to target/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

[RFC PATCH] iscsit_wait_for_tag() can be static

2018-05-16 Thread kbuild test robot
Fixes: 5aff7a710f13 ("Convert target drivers to use sbitmap") Signed-off-by: Fengguang Wu --- iscsi_target_util.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c index 28bcffa..e147aef 100

usb: dwc2: Regression on 96Boards Hikey due to enabling power down

2018-05-16 Thread Manivannan Sadhasivam
Hello, Commit 03ea6d6e9e1ff1b0222eb723eee5990d3511cc4d introduced the powerdown feature in USB DWC2 driver which stops USB from working on 96Boards HiKey board. During bootup, USB host controller goes into hibernation state and when any USB device is plugged onto the port, the host finishes execu

Re: [PATCH] usbserial: pl2303 tx xon/xoff flow control

2018-05-16 Thread Johan Hovold
On Mon, May 14, 2018 at 05:15:11AM +0200, Florian Zumbiehl wrote: > Support hardware-level Xon/Xoff flow control in transmit direction with > pl2303. > > Signed-off-by: Florian Zumbiehl > --- > Note that the patch has only been fully tested with kernel 4.9.28, and > test-compiled against 4.16.8.

Re: [PATCH v3 0/2] add support for HiSilicon STB xHCI host controller

2018-05-16 Thread Mathias Nyman
On 14.05.2018 09:20, sunj...@163.com wrote: From: Jianguo Sun This patch set adds bindings doc and xhci driver for xHCI host controller on HiSilicon STB SoCs. Looks good to me, adding to queue -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

[PATCH V3 3/3] usb: xhci: tegra: Add support for managing powergates

2018-05-16 Thread Jon Hunter
The Tegra XHCI controller requires that the XUSBA (for superspeed) and XUSBC (for host) power-domains are enabled. Commit 8df127456f29 ("soc/tegra: pmc: Enable XUSB partitions on boot") was added to force on these power-domains if the XHCI driver is enabled while proper power-domain support is adde

[PATCH V3 1/3] usb: xhci: tegra: Prepare for adding runtime PM support

2018-05-16 Thread Jon Hunter
When adding runtime PM support to the Tegra XHCI driver, it is desirable to move the function calls to enable the clocks, regulators and PHY from the tegra_xusb_probe into the runtime PM handlers. Currently, the clocks, regulators and PHY are all enabled before we call usb_create_hcd() in tegra_xus

[PATCH V3 2/3] usb: xhci: tegra: Add runtime PM support

2018-05-16 Thread Jon Hunter
Add runtime PM support to the Tegra XHCI driver and move the function calls to enable/disable the clocks, regulators and PHY into the runtime PM callbacks. Signed-off-by: Jon Hunter Acked-by: Thierry Reding --- Changes since V2: - Remove extra unnecessary blank line - Add Thierry's ACK Changes

Re: [PATCH] usbip: usbip_host: fix bad unlock balance during stub_probe()

2018-05-16 Thread Shuah Khan
On 05/15/2018 11:49 PM, Greg KH wrote: > On Tue, May 15, 2018 at 05:57:23PM -0600, Shuah Khan (Samsung OSG) wrote: >> stub_probe() calls put_busid_priv() in an error path when device isn't >> found in the busid_table. Fix it by making put_busid_priv() safe to be >> called with null struct bus_id_pr

RE: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

2018-05-16 Thread Mario.Limonciello
> -Original Message- > From: Paul Menzel [mailto:pmenzel+linux-...@molgen.mpg.de] > Sent: Wednesday, May 16, 2018 7:36 AM > To: Heikki Krogerus > Cc: Greg KH; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; > Limonciello, > Mario > Subject: Re: `ucsi_acpi: probe of USBC000:00 fa

Re: Pandaboard OMAP4 MUSB short packet hang on UVC gadget

2018-05-16 Thread Bin Liu
Hi, On Tue, May 15, 2018 at 10:58:16PM +0100, Kieran Bingham wrote: > Hi Bin, Felipe, > > We have been trying to get a UVC gadget operational on the Pandaboard ES > platform, and we believe we've hit an issue with short packets on the MUSB in > DMA mode. I don't have a Pandaboard. Does it use M

[PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-16 Thread Adam Thomson
For supply registration, provide of_node pointer of the port device, via the power_supply_config structure, to allow other psy drivers to add us as a supplier using the 'power-supplies' DT property. Signed-off-by: Adam Thomson --- drivers/usb/typec/tcpm.c | 1 + 1 file changed, 1 insertion(+) d

RE: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

2018-05-16 Thread Mario.Limonciello
> -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: Wednesday, May 16, 2018 6:58 AM > To: Greg KH; Paul Menzel > Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Limonciello, > Mario > Subject: Re: `ucsi_acpi: probe of USBC000:00 fail

Re: [PATCH net-next 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

2018-05-16 Thread kbuild test robot
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-mdio-Fall-back-to-mdiobus_register-with-np-is-NULL/20180516-203317 config: arm-allmodconfig (attached as .config) compiler

Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

2018-05-16 Thread Greg KH
On Wed, May 16, 2018 at 04:13:31PM +, mario.limoncie...@dell.com wrote: > > > [1] When the power supply for the docking station is bigger than the > > > laptop's power supply, you begin to wonder what is in that thing and > > > stop using it after a while... > > Mostly to satisfy letti

Re: [PATCH net-next 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

2018-05-16 Thread kbuild test robot
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-mdio-Fall-back-to-mdiobus_register-with-np-is-NULL/20180516-203317 config: arm-omap2plus_defconfig (attached as .config

Re: Renesas uPD720202 USB 3.0

2018-05-16 Thread Christian Brauns
I'm running 4.16.8-1-ARCH and that controller does not work, whereas I remember it was working sometime before. Now I'm travelling, don't have the controller with me, especially because it does not work anymore. This is what a part of dmesg looked like in 4.16.8-1-ARCH: [

Re: [PATCH net-next v2 0/2] of: mdio: Fall back to mdiobus_register() with NULL device_node

2018-05-16 Thread David Miller
From: Florian Fainelli Date: Tue, 15 May 2018 16:56:17 -0700 > This patch series updates of_mdiobus_register() such that when the device_node > argument is NULL, it calls mdiobus_register() directly. This is consistent > with > the behavior of of_mdiobus_register() when CONFIG_OF=n. > > I only

Re: [PATCH net-next v2 0/2] of: mdio: Fall back to mdiobus_register() with NULL device_node

2018-05-16 Thread Geert Uytterhoeven
Hi David, On Wed, May 16, 2018 at 8:21 PM, David Miller wrote: > From: Florian Fainelli > Date: Tue, 15 May 2018 16:56:17 -0700 > >> This patch series updates of_mdiobus_register() such that when the >> device_node >> argument is NULL, it calls mdiobus_register() directly. This is consistent >

[PATCH] usb-storage: Add quirks to make G-Technology "G-Drive" work

2018-05-16 Thread Alexander Kappner
The "G-Drive" (sold by G-Technology) external USB 3.0 drive hangs on write access under UAS: [ 136.079121] sd 15:0:0:0: [sdi] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE [ 136.079144] sd 15:0:0:0: [sdi] tag#0 Sense Key : Illegal Request [current] [ 136.079152] sd 15:0:0:0: [s

Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

2018-05-16 Thread Sergei Shtylyov
Hello! On 05/16/2018 02:56 AM, Florian Fainelli wrote: > A number of drivers have the following pattern: > > if (np) > of_mdiobus_register() > else > mdiobus_register() > > which the implementation of of_mdiobus_register() now takes care of. > Remove that pattern in drivers that str

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-16 Thread Mats Karrman
Hi, On 05/16/2018 02:25 PM, Heikki Krogerus wrote: > Hi guys, > > On Tue, May 15, 2018 at 10:52:57PM +0200, Mats Karrman wrote: >> Hi, >> >> On 05/14/2018 11:36 AM, Jun Li wrote: >> >>> Hi -Original Message- From: Mats Karrman [mailto:mats.dev.l...@gmail.com] Sent: 2018???5

Re: [PATCH] usb-storage: Add quirks to make G-Technology "G-Drive" work

2018-05-16 Thread Alan Stern
On Wed, 16 May 2018, Alexander Kappner wrote: > The "G-Drive" (sold by G-Technology) external USB 3.0 drive > hangs on write access under UAS: > > [ 136.079121] sd 15:0:0:0: [sdi] tag#0 FAILED Result: hostbyte=DID_OK > driverbyte=DRIVER_SENSE > [ 136.079144] sd 15:0:0:0: [sdi] tag#0 Sense Key

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-16 Thread Mats Karrman
On 05/16/2018 01:43 PM, Heikki Krogerus wrote: > On Tue, May 15, 2018 at 11:24:07PM +0200, Mats Karrman wrote: >> Hi Heikki, >> >> On 05/15/2018 09:30 AM, Heikki Krogerus wrote: >> >>> Hi Mats, >>> >>> On Fri, May 11, 2018 at 09:28:04PM +0200, Mats Karrman wrote: On 2018-05-11 13:14, Heikki K

[PATCH] usbip: vhci_sysfs: fix potential Spectre v1

2018-05-16 Thread Gustavo A. R. Silva
pdev_nr and rhport can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: drivers/usb/usbip/vhci_sysfs.c:238 detach_store() warn: potential spectre issue 'vhcis' drivers/usb/usbip/vhci_sysf

Re: [PATCH] usbserial: pl2303 tx xon/xoff flow control

2018-05-16 Thread Florian Zumbiehl
Hi, > > Note that the patch has only been fully tested with kernel 4.9.28, and > > test-compiled against 4.16.8. Tested only with the pl2303 adapters I have > > available (which seem to be type 0 if I interpret the code correctly), I > > don't have a clue whether this works with other versions of

Re: [PATCH v3] usb: dwc2: Fix kernel doc's warnings.

2018-05-16 Thread Minas Harutyunyan
On 5/16/2018 12:04 PM, Grigor Tovmasyan wrote: > Added descriptions for all not described parameters. > Fix all kernel doc's warnings. > > Signed-off-by: Grigor Tovmasyan > --- Acked-by: Minas Harutyunyan > drivers/usb/dwc2/core.c | 7 ++ > drivers/usb/dwc2/core.h | 170 > +

Re: [PATCH] usbip: vhci_sysfs: fix potential Spectre v1

2018-05-16 Thread Greg Kroah-Hartman
On Wed, May 16, 2018 at 05:22:00PM -0500, Gustavo A. R. Silva wrote: > pdev_nr and rhport can be controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > drivers/usb/usbip/vhci_sysfs.c:238 d

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-05-16 Thread Tushar Nimkar
Hi All, On 2018-04-24 14:42, Oliver Neukum wrote: Am Montag, den 23.04.2018, 18:35 +0530 schrieb Tushar Nimkar: hi, On 2018-04-23 18:20, Oliver Neukum wrote: > Am Donnerstag, den 19.04.2018, 20:18 +0530 schrieb Tushar Nimkar: > No. But for testing we don't need to. Can you confirm that > th