Hi,
(please, always Cc linux-usb@vger.kernel.org)
Fernando writes:
> Hi Felipe.
>
> Sorry to bother you, but your name is all over the place on the DWC3 code
> and I was wondering if you could help me with something (I promise there
> won't be future emails with further questions).
>
>
> The th
Hi Li Jun,
Are you working on an updated version of this patch series?
I'm pondering other changes that builds on these patches (the documentation
and the fwnode added to the tcpc_dev and tcpm primarily).
Btw, there is a semi-colon missing in your example below.
BR // Mats
On 2018-03-28 18:06,
> which platform is this? Which kernel version?
This is a custom design based on an LS1046a reference board from NxP
running kernel 4.4.74 with patches from the LEDE/Openwrt project.
> you need to sign agreement with Synopsys to get it.
I'll work on that. Thanks. But... based on what you know,
Hi,
Fernando writes:
>> which platform is this? Which kernel version?
>
> This is a custom design based on an LS1046a reference board from NxP
> running kernel 4.4.74 with patches from the LEDE/Openwrt project.
in that case, you need to ask for support from NxP. Either that, or you
need to swit
Hi,
On Thu, Mar 29, 2018 at 12:06:06AM +0800, Li Jun wrote:
> +Optional properties for usb-c-connector:
> +- power-type: should be one of "source", "sink" or "dual"(DRP) if typec
> + connector has power support.
> +- try-power-role: preferred power role if "dual"(DRP) can support Try.SNK
> + or
I've done some further testing using a different kernel (4.14.38) and
enabled debug messages in the DWC2 driver. Here's the capture from dmesg
when the error occurs (the full dmesg log can be found at
https://paste.ee/p/YKpGn):
[ 84.167126] dwc2 101c.usb: --Host Channel 0 Interrupt: Transact
Trying to determine the USB port type with this mux is very
difficult. To simplify the situation, always allowing user
control, even if the port is USB Type-C port.
Signed-off-by: Heikki Krogerus
---
drivers/usb/roles/intel-xhci-usb-role-switch.c | 15 +--
1 file changed, 1 insertion
Removing the "fusb302" debugfs directory when unloading
the driver. That allows the driver to be loaded more then
ones.
This fixes an issue where the driver, if unloaded, can't be
re-loaded, as the "fusb302" debugfs directory already
exists. While here, removing useless condition when creating
the
The driver will not probe unless bq24190 is loaded, so
making it a dependency.
Signed-off-by: Heikki Krogerus
Cc: Wolfram Sang
Cc: Darren Hart
Cc: Andy Shevchenko
---
drivers/i2c/busses/Kconfig | 3 +--
drivers/platform/x86/Kconfig | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
The ref count for the USB role switch device must be
released after we are done using the switch.
Fixes: c6962c29729c ("usb: typec: tcpm: Set USB role switch to device mode when
configured as such")
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tcpm.c | 1 +
1 file changed, 1 insertion(+
Hi,
I now have a GPD Win device - Intel Cherry Trail based board with
FUSB302 USB Type-C PHY - that I started using for testing my alternate
mode patches. I noticed a few dependency issues, and some other
problems with the fusb302 driver. These were the most obvious ones.
Hans, I included the pat
This commit adds a driver for the Xaptum ENF Access Card, a TPM2.0
hardware module for authenticating IoT devices and gateways.
The card consists of a SPI TPM 2.0 chip and a USB-SPI bridge. This
driver configures the bridge, registers the bridge as an SPI
controller, and adds the TPM 2.0 as an SPI
Normally the system platform (i.e., BIOS/UEFI for x86) is responsible
for performing initialization of the TPM. For these modules, the host
kernel is the platform, so we perform the initialization in the driver
before registering the TPM with the kernel TPM subsystem.
The initialization consists
This commit adds a driver for the Xaptum ENF Access Card, a TPM2.0
hardware module for authenticating IoT devices and gateways.
The card consists of a SPI TPM 2.0 chip and a USB-SPI bridge. This
driver configures the bridge, registers the bridge as an SPI
controller, and adds the TPM 2.0 as an SPI
On 04/30/2018 05:41 AM, Heikki Krogerus wrote:
Removing the "fusb302" debugfs directory when unloading
the driver. That allows the driver to be loaded more then
ones.
This fixes an issue where the driver, if unloaded, can't be
re-loaded, as the "fusb302" debugfs directory already
exists. While h
On 04/30/2018 05:41 AM, Heikki Krogerus wrote:
The ref count for the USB role switch device must be
released after we are done using the switch.
Fixes: c6962c29729c ("usb: typec: tcpm: Set USB role switch to device mode when
configured as such")
Signed-off-by: Heikki Krogerus
Reviewed-by: Gu
Currently, logical and is being used instead of *bitwise* and.
Fix this by using a proper bitwise and operator.
Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator")
Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related
messages")
Signed-off-by: Gustavo A. R. Silva
---
d
On 30 April 2018 14:23, Gustavo A. R. Silva wrote:
> Currently, logical and is being used instead of *bitwise* and.
>
> Fix this by using a proper bitwise and operator.
>
> Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator")
> Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink P
On Mon, Apr 30, 2018 at 03:49:19PM +0300, Kyprianos Papadimitriou wrote:
> Dear Greg,
>
> I am still monitoring the behavior. Please let me come back to you when I am
> sure about that.
>
> Where should I send the "patch"? As I told you it is not a 100% fix!
If you run the tool, scripts/get_main
Hi,
Felipe Balbi writes:
> That function is used for both Bulk and Interrupt transfer types,
> let's make it clear on the function name and provide one extra helper
> for queueing bulk transfers.
>
> Signed-off-by: Felipe Balbi
gentle reminder about this series.
--
balbi
--
To unsubscribe fr
Hi Stefan,
Thanks for report. We will try to repro issue and contact you if need more
details.
Regards,
Woojung
> -Original Message-
> From: Stefan Wahren [mailto:stefan.wah...@i2se.com]
> Sent: Saturday, April 28, 2018 3:59 AM
> To: Nisar Sayed - I17970 ; Woojung Huh - C21699
>
> Cc:
On Fri, Apr 27, 2018 at 11:09:50AM +0300, Felipe Balbi wrote:
>
> Hi Greg,
>
> here's a tiny, 7 fixes only, pull request for the current -rc cycle. Let
> me know if you want anything to be changed.
>
> cheers
>
> The following changes since commit 6d08b06e67cd117f6992c46611dfb4ce267cd71e:
>
>
On Mon, Apr 30, 2018 at 07:54:17AM -0500, David R. Bild wrote:
> This commit adds a driver for the Xaptum ENF Access Card, a TPM2.0
> hardware module for authenticating IoT devices and gateways.
>
> The card consists of a SPI TPM 2.0 chip and a USB-SPI bridge. This
> driver configures the bridge,
Hi Greg,
Here are musb fixes for v4.17-rc4 to fix two NULL pointer dereference cases.
Please let me know if any change is needed.
Regards,
-Bin.
Bin Liu (2):
usb: musb: host: fix potential NULL pointer dereference
usb: musb: trace: fix NULL pointer dereference in musb_g_tx()
drivers/u
The usb_request pointer could be NULL in musb_g_tx(), where the
tracepoint call would trigger the NULL pointer dereference failure when
parsing the members of the usb_request pointer.
Move the tracepoint call to where the usb_request pointer is already
checked to solve the issue.
Fixes: fc78003e5
musb_start_urb() doesn't check the pass-in parameter if it is NULL. But
in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is
returned from first_qh(), which could be NULL.
So wrap the musb_start_urb() call here with a if condition check to
avoid the potential NULL pointer derefe
On Mon, Apr 30, 2018 at 11:20:53AM -0500, Bin Liu wrote:
> musb_start_urb() doesn't check the pass-in parameter if it is NULL. But
> in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is
> returned from first_qh(), which could be NULL.
>
> So wrap the musb_start_urb() call here w
On Mon, Apr 30, 2018 at 09:42:15AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 30, 2018 at 11:20:53AM -0500, Bin Liu wrote:
> > musb_start_urb() doesn't check the pass-in parameter if it is NULL. But
> > in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is
> > returned from fi
On Mon, Apr 30, 2018 at 01:11:34PM -0500, Bin Liu wrote:
> On Mon, Apr 30, 2018 at 09:42:15AM -0700, Greg Kroah-Hartman wrote:
> > On Mon, Apr 30, 2018 at 11:20:53AM -0500, Bin Liu wrote:
> > > musb_start_urb() doesn't check the pass-in parameter if it is NULL. But
> > > in musb_bulk_nak_timeout()
On Mon, Apr 30, 2018 at 11:24:48AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 30, 2018 at 01:11:34PM -0500, Bin Liu wrote:
> > On Mon, Apr 30, 2018 at 09:42:15AM -0700, Greg Kroah-Hartman wrote:
> > > On Mon, Apr 30, 2018 at 11:20:53AM -0500, Bin Liu wrote:
> > > > musb_start_urb() doesn't chec
Hi,
Le samedi 21 avril 2018 à 09:34 -0500, Bin Liu a écrit :
> Okay, this came down to an argument that whether we should require
> loading a gadget driver on a dual-role port to work in host mode,
> which is currently required on musb since a long long time ago.
>
> I understand the requirement
Device is left in the busid_table after unbind and rebind. Rebind
initiates usb bus scan and the original driver claims the device.
After rescan the device should be deleted from the busid_table as
it no longer belongs to usbip_host.
Fix it to delete the device after device_attach() succeeds.
Sig
After removing usbip_host module, devices it releases are left without
a driver. For example, when a keyboard or a mass storage device are
bound to usbip_host when it is removed, these devices are no longer
bound to any driver.
Fix it to run device_attach() from the module exit routine to restore
On Mon, Apr 30, 2018 at 04:17:19PM -0600, Shuah Khan (Samsung OSG) wrote:
> Device is left in the busid_table after unbind and rebind. Rebind
> initiates usb bus scan and the original driver claims the device.
> After rescan the device should be deleted from the busid_table as
> it no longer belong
On 04/30/2018 04:48 PM, Greg KH wrote:
> On Mon, Apr 30, 2018 at 04:17:19PM -0600, Shuah Khan (Samsung OSG) wrote:
>> Device is left in the busid_table after unbind and rebind. Rebind
>> initiates usb bus scan and the original driver claims the device.
>> After rescan the device should be deleted f
35 matches
Mail list logo
