Re: [PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc

2018-04-11 Thread Simon Horman
On Tue, Apr 10, 2018 at 09:44:31AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman, Sent: Tuesday, April 10, 2018 6:34 PM > > > > On Tue, Apr 10, 2018 at 01:28:33AM +, Yoshihiro Shimoda wrote: > > > Hi Simon-san, > > > > > > > From: Simon Horman, Sent: Monday, April 9

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

2018-04-11 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >>> On 4/9/2018 4:28 AM, Felipe Balbi wrote: In case we get an event with status set to Missed Isoc, this means we have missed an isochronous interval and should issue End Transfer command and wait for the following XferNotReady. >>> >>> Why does DWC3 need

Re: [PATCH] usb: role: rcar-usb3-role-switch: add support for R-Car SoCs

2018-04-11 Thread Heikki Krogerus
On Tue, Apr 10, 2018 at 09:03:46PM +0900, Yoshihiro Shimoda wrote: > This patch adds role switch support for R-Car SoCs. Some R-Car SoCs > (e.g. R-Car H3) have USB 3.0 dual-role device controller which has > the USB 3.0 xHCI host and Renesas USB 3.0 peripheral. > > Unfortunately, the mode change r

Re: [PATCH 1/2] usb: gadget: udc: renesas_usb3: add property "renesas,ignore-id"

2018-04-11 Thread Simon Horman
On Tue, Apr 10, 2018 at 09:13:53PM +0900, Yoshihiro Shimoda wrote: > This patch adds a new property to ignore the ID signal on a board. > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++ > drivers/usb/gadget/udc/renesas_usb3.c

Re: [PATCH] usb: role: rcar-usb3-role-switch: add support for R-Car SoCs

2018-04-11 Thread Heikki Krogerus
On Wed, Apr 11, 2018 at 03:15:23AM +, Yoshihiro Shimoda wrote: > > > + host_node = of_parse_phandle(pdev->dev.of_node, "renesas,host", > > > 0); > > > + if (!host_node) > > > + return -ENODEV; > > > + > > > + pdev_host = of_find_device_by_node(host_node); > > >

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

2018-04-11 Thread Felipe Balbi
Hi, Felipe Balbi writes: >>> Without XferNotReady, we won't have a reliable way to know the uFrame >>> number. Read the Isochronous programming sequence from your databook. >> >> Right. We need XferNotReady to know when to start isoc transfer. But if >> there are still queued requests, DWC3 can

RE: [PATCH] usb: role: rcar-usb3-role-switch: add support for R-Car SoCs

2018-04-11 Thread Yoshihiro Shimoda
Hi Heikki, > From: Heikki Krogerus, Sent: Wednesday, April 11, 2018 4:26 PM > > On Tue, Apr 10, 2018 at 09:03:46PM +0900, Yoshihiro Shimoda wrote: > > +Example of R-Car H3 ES2.0: > > + usb3_peri0: usb@ee02 { > > + compatible = "renesas,r8a7795-usb3-peri", > > +

RE: [PATCH] usb: role: rcar-usb3-role-switch: add support for R-Car SoCs

2018-04-11 Thread Yoshihiro Shimoda
Hi Heikki, Thank you for the comments! > From: Heikki Krogerus, Sent: Wednesday, April 11, 2018 5:02 PM > > On Wed, Apr 11, 2018 at 03:15:23AM +, Yoshihiro Shimoda wrote: > > > > + host_node = of_parse_phandle(pdev->dev.of_node, "renesas,host", > > > > 0); > > > > + if (!host_no

[PATCH] lan78xx: Correctly indicate invalid OTP

2018-04-11 Thread Phil Elwell
lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP content, but the value gets overwritten before it is returned and the read goes ahead anyway. Make the read conditional as it should be and preserve the error code. Signed-off-by: Phil Elwell --- drivers/net/usb/lan78xx.c | 3 +

[PATCH] lan78xx: Avoid spurious kevent 4 "error"

2018-04-11 Thread Phil Elwell
lan78xx_defer_event generates an error message whenever the work item is already scheduled. lan78xx_open defers three events - EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware of the likelihood (or certainty) of an error message, the DEV_OPEN event is added to the set of pending

[PATCH] cdc_ether: flag the Cinterion AHS8 modem by gemalto as WWAN

2018-04-11 Thread Bassem Boubaker
The Cinterion AHS8 is a 3G device with one embedded WWAN interface using cdc_ether as a driver. The modem is controlled via AT commands through the exposed TTYs. AT+CGDCONT write command can be used to activate or deactivate a WWAN connection for a PDP context defined with th

Re: Lenovo ThinkVision X1 27" USB-C occasionally hangs the kernel (usbhid) and isn't setting a proper resolution when USB 3.0 (FHD) switched to USB 2.0 (UHD)

2018-04-11 Thread Heikki Krogerus
On Wed, Apr 11, 2018 at 02:09:29PM +0300, Heikki Krogerus wrote: > On Wed, Apr 11, 2018 at 08:28:44AM +, andrey.ara...@nixaid.com wrote: > > Thank you for the insights, Heikki! > > > > Please find the acpi.dump.tgz file is a attached. > > > > I do not have the USBC* and INT3515* devices, > >

Re: [PATCH] cdc_ether: flag the Cinterion AHS8 modem by gemalto as WWAN

2018-04-11 Thread Oliver Neukum
Am Mittwoch, den 11.04.2018, 13:15 +0200 schrieb Bassem Boubaker: >     The Cinterion AHS8 is a 3G device with one embedded WWAN interface >     using cdc_ether as a driver. > >     The modem is  controlled via AT commands through the exposed TTYs. > >     AT+CGDCONT write command can be used to

Re: [PATCH] lan78xx: Correctly indicate invalid OTP

2018-04-11 Thread Andrew Lunn
On Wed, Apr 11, 2018 at 10:59:17AM +0100, Phil Elwell wrote: > lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP > content, but the value gets overwritten before it is returned and the > read goes ahead anyway. Make the read conditional as it should be > and preserve the error co

Re: [PATCH] lan78xx: Correctly indicate invalid OTP

2018-04-11 Thread Phil Elwell
Hi Andrew. On 11/04/2018 13:57, Andrew Lunn wrote: > On Wed, Apr 11, 2018 at 10:59:17AM +0100, Phil Elwell wrote: >> lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP >> content, but the value gets overwritten before it is returned and the >> read goes ahead anyway. Make the rea

usb: storage: uas: want to print the all IN ACK(Data-in)

2018-04-11 Thread Tushar Nimkar
Hi, Talking about UASP Rev 1.0.pdf (http://www.usb.org/developers/docs/devclass_docs/) "5.4.3 Data-in transfer" As part of my debug..want to understand the flow. suspecting IN ACK(Data-in) is missing as per the lecroy log. And same I want to check/print. Is there any way to do so? I am re

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-04-11 Thread Marc Zyngier
On Wed, 11 Apr 2018 14:11:52 +0100, Bockholdt Arne wrote: > > Hi all, > > is there anything new, I've just tried the new stable 4.16.1 kernel > without any change. The Renesys USB3 controller is still not > functional. I'm willing to test any patch that is based on a stable > kernel version becau

[PATCH] USB: ftdi_sio: Use jtag quirk for Arrow USB Blaster

2018-04-11 Thread Vasyl Vavrychuk
Arrow USB Blaster integrated on MAX1000 board uses the same vendor ID (0x0403) and product ID (0x6010) as the "original" FTDI device. This patch avoids picking up by ftdi_sio of the first interface of this USB device. After that this device can be used by Arrow user-space JTAG driver. Signed-off-

Re: [PATCH] lan78xx: Correctly indicate invalid OTP

2018-04-11 Thread David Miller
From: Phil Elwell Date: Wed, 11 Apr 2018 10:59:17 +0100 > lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP > content, but the value gets overwritten before it is returned and the > read goes ahead anyway. Make the read conditional as it should be > and preserve the error code.

Re: [PATCH] lan78xx: Avoid spurious kevent 4 "error"

2018-04-11 Thread David Miller
From: Phil Elwell Date: Wed, 11 Apr 2018 12:02:47 +0100 > lan78xx_defer_event generates an error message whenever the work item > is already scheduled. lan78xx_open defers three events - > EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware > of the likelihood (or certainty) of an

RE: [PATCH] lan78xx: Don't reset the interface on open

2018-04-11 Thread Nisar.Sayed
Hi Phil, > Hi Nisar, > > On 10/04/2018 15:16, nisar.sa...@microchip.com wrote: > > Thanks Phil, for identifying the issues. > > > >> - ret = lan78xx_reset(dev); > >> - if (ret < 0) > >> - goto done; > >> - > >>phy_start(net->phydev); > >> > >>netif_dbg(dev, ifup, dev->net, "phy

Re: [PATCH] cdc_ether: flag the Cinterion AHS8 modem by gemalto as WWAN

2018-04-11 Thread David Miller
From: Oliver Neukum Date: Wed, 11 Apr 2018 13:25:38 +0200 > Am Mittwoch, den 11.04.2018, 13:15 +0200 schrieb Bassem Boubaker: >>     The Cinterion AHS8 is a 3G device with one embedded WWAN interface >>     using cdc_ether as a driver. >> >>     The modem is  controlled via AT commands through t

Re: [PATCH] lan78xx: Don't reset the interface on open

2018-04-11 Thread David Miller
From: Phil Elwell Date: Tue, 10 Apr 2018 13:18:25 +0100 > Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY > initialisation into lan78xx_probe, but lan78xx_open subsequently calls > lan78xx_reset. As well as forcing a second round of link negotiation, > this reset frequently preve

[PATCH 2/3] usbip: usbip_host: delete device from busid_table after rebind

2018-04-11 Thread Shuah Khan
Device is left in the busid_table after unbind and rebind. Rebind initiates usb bus scan and the original driver claims the device. After rescan the device should be deleted from the busid_table as it no longer belongs to usbip_host. Fix it to delete the device after device_attach() succeeds. Sig

[PATCH 1/3] usbip: usbip_host: refine probe and disconnect debug msgs to be useful

2018-04-11 Thread Shuah Khan
Refine probe and disconnect debug msgs to be useful and say what is in progress. Signed-off-by: Shuah Khan --- drivers/usb/usbip/stub_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/usbip/stub_dev.c b/drivers/usb/usbip/stub_dev.c index dd8ef36ab10e..7813

[PATCH 3/3] usbip: usbip_host: run rebind from exit when module is removed

2018-04-11 Thread Shuah Khan
After removing usbip_host module, devices it releases are left without a driver. For example, when a keyboard or a mass storage device are bound to usbip_host when it is removed, these devices are no longer bound to any driver. Fix it to run device_attach() from the module exit routine to restore

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

2018-04-11 Thread Thinh Nguyen
Hi, On 4/11/2018 1:21 AM, Felipe Balbi wrote: > > Hi, > > Felipe Balbi writes: Without XferNotReady, we won't have a reliable way to know the uFrame number. Read the Isochronous programming sequence from your databook. >>> >>> Right. We need XferNotReady to know when to start isoc tra

RE: [PATCH 1/2] usb: gadget: udc: renesas_usb3: add property "renesas,ignore-id"

2018-04-11 Thread Yoshihiro Shimoda
Hi Simon-san, > From: Simon Horman, Sent: Wednesday, April 11, 2018 4:28 PM > > On Tue, Apr 10, 2018 at 09:13:53PM +0900, Yoshihiro Shimoda wrote: > > This patch adds a new property to ignore the ID signal on a board. > > > > Signed-off-by: Yoshihiro Shimoda > > --- > > Documentation/devicetre

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-04-11 Thread Ard Biesheuvel
On 12 April 2018 at 07:05, Bockholdt Arne wrote: > > On Wed, 2018-04-11 at 15:02 +0100, Marc Zyngier wrote: > > On Wed, 11 Apr 2018 14:11:52 +0100, > Bockholdt Arne wrote: > > > Hi all, > > is there anything new, I've just tried the new stable 4.16.1 kernel > without any change. The Renesys USB3 c

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-04-11 Thread Bockholdt Arne
On Thu, 2018-04-12 at 07:20 +0200, Ard Biesheuvel wrote: > On 12 April 2018 at 07:05, Bockholdt Arne > wrote: > > > > On Wed, 2018-04-11 at 15:02 +0100, Marc Zyngier wrote: > > > > On Wed, 11 Apr 2018 14:11:52 +0100, > > Bockholdt Arne wrote: > > > > > > Hi all, > > > > is there anything ne