Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Marc Zyngier
On Fri, 02 Mar 2018 17:38:26 +, Bockholdt Arne wrote: Hi Arne, > > On Thu, 2018-03-01 at 17:37 +, Marc Zyngier wrote: > > On 01/03/18 08:01, Bockholdt Arne wrote: > > > > > > On Thu, 2018-02-15 at 19:29 +, Marc Zyngier wrote: > > > > [+ Ard, who helped me chasing the initial issue]

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
On 25 March 2018 at 11:37, Marc Zyngier wrote: > On Fri, 02 Mar 2018 17:38:26 +, > Bockholdt Arne wrote: > > Hi Arne, > >> >> On Thu, 2018-03-01 at 17:37 +, Marc Zyngier wrote: >> > On 01/03/18 08:01, Bockholdt Arne wrote: >> > > >> > > On Thu, 2018-02-15 at 19:29 +, Marc Zyngier wrote

Re: 4.14.13: Kernel panic, NULL pointer dereference in xhci_hcd

2018-03-25 Thread Juho Tykkälä
Hello, Similar panic occurs on manually compiled 4.14.0. However, same issue occurs like bellow on 4.9.82 (debian compiled with package linux-image-4.9.0-6-amd64) One failure behavior: [70684.574901] xhci_hcd :00:14.0: ERROR Transfer event for disabled endpoint slot 12 ep 17 [70684.5749

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Marc Zyngier
On Sun, 25 Mar 2018 11:48:35 +0100, Ard Biesheuvel wrote: Hi Ard, [...] > > I finally found some time to work on this, and came up with an > > alternative approach (it turns out that this chip is even more > > braindead than I thought). > > > > It is slightly scary, in the sense that the USB con

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
On 25 March 2018 at 12:51, Marc Zyngier wrote: > On Sun, 25 Mar 2018 11:48:35 +0100, > Ard Biesheuvel wrote: > > Hi Ard, > > [...] > >> > I finally found some time to work on this, and came up with an >> > alternative approach (it turns out that this chip is even more >> > braindead than I thought

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Marc Zyngier
On Sun, 25 Mar 2018 12:57:55 +0100, Ard Biesheuvel wrote: > > On 25 March 2018 at 12:51, Marc Zyngier wrote: > > On Sun, 25 Mar 2018 11:48:35 +0100, > > Ard Biesheuvel wrote: > > > > Hi Ard, > > > > [...] > > > >> > I finally found some time to work on this, and came up with an > >> > alternative

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
On 25 March 2018 at 13:31, Marc Zyngier wrote: > On Sun, 25 Mar 2018 12:57:55 +0100, > Ard Biesheuvel wrote: >> >> On 25 March 2018 at 12:51, Marc Zyngier wrote: >> > On Sun, 25 Mar 2018 11:48:35 +0100, >> > Ard Biesheuvel wrote: >> > >> > Hi Ard, >> > >> > [...] >> > >> >> > I finally found some

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Marc Zyngier
On Sun, 25 Mar 2018 13:38:19 +0100, Ard Biesheuvel wrote: > > On 25 March 2018 at 13:31, Marc Zyngier wrote: > > On Sun, 25 Mar 2018 12:57:55 +0100, > > Ard Biesheuvel wrote: > >> > >> On 25 March 2018 at 12:51, Marc Zyngier wrote: > >> > On Sun, 25 Mar 2018 11:48:35 +0100, > >> > Ard Biesheuvel

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
On 25 March 2018 at 13:52, Marc Zyngier wrote: > On Sun, 25 Mar 2018 13:38:19 +0100, > Ard Biesheuvel wrote: >> >> On 25 March 2018 at 13:31, Marc Zyngier wrote: >> > On Sun, 25 Mar 2018 12:57:55 +0100, >> > Ard Biesheuvel wrote: >> >> >> >> On 25 March 2018 at 12:51, Marc Zyngier wrote: >> >> >

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Marc Zyngier
On Sun, 25 Mar 2018 14:26:58 +0100 Ard Biesheuvel wrote: > On 25 March 2018 at 13:52, Marc Zyngier wrote: > > On Sun, 25 Mar 2018 13:38:19 +0100, > > Ard Biesheuvel wrote: > >> > >> On 25 March 2018 at 13:31, Marc Zyngier wrote: > >> > On Sun, 25 Mar 2018 12:57:55 +0100, > >> > Ard Biesheuv

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
> On 25 Mar 2018, at 15:14, Marc Zyngier wrote: > > On Sun, 25 Mar 2018 14:26:58 +0100 > Ard Biesheuvel wrote: > >>> On 25 March 2018 at 13:52, Marc Zyngier wrote: >>> On Sun, 25 Mar 2018 13:38:19 +0100, >>> Ard Biesheuvel wrote: > On 25 March 2018 at 13:31, Marc Zyngier wrote:

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2018-03-25 Thread Jonathan Liu
Hi, On 25 March 2018 at 12:21, Jonathan Liu wrote: > On 8 February 2018 at 14:55, Jeffy Chen wrote: >> From: AMAN DEEP >> >> There is a race condition between finish_unlinks->finish_urb() function >> and usb_kill_urb() in ohci controller case. The finish_urb calls >> spin_unlock(&ohci->lock) be

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Tony Lindgren
* Pavel Machek [180324 20:03]: > On Sat 2018-03-24 07:25:17, Tony Lindgren wrote: > > * Dan Williams [180324 14:00]: > > > On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > > > > Does ofonod work for you? I could not get that one to work... > > > > > > Because it's looking for a Gobi mode

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Pavel Machek
Hi! > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it seems > > to react to AT commands, and in particular reacts to ADT123; (; is > > important). > > Is that to dial a voice call? Yes. And it is ATD123; not ATD. > > AT+CMGF=1 > > AT+CMGS="123" > > foo^Z > > > > Works for SMS

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Tony Lindgren
* Pavel Machek [180325 19:00]: > Hi! > > > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it seems > > > to react to AT commands, and in particular reacts to ADT123; (; is > > > important). > > > > Is that to dial a voice call? > > Yes. And it is ATD123; not ATD. Strange, no sem

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Pavel Machek
Hi! > > > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it seems > > > > to react to AT commands, and in particular reacts to ADT123; (; is > > > > important). > > > > > > Is that to dial a voice call? > > > > Yes. And it is ATD123; not ATD. > > Strange, no semicolon is needed w

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Tony Lindgren
* Pavel Machek [180325 22:57]: > Hi! > > > > > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it seems > > > > > to react to AT commands, and in particular reacts to ADT123; (; is > > > > > important). > > > > > > > > Is that to dial a voice call? > > > > > > Yes. And it is ATD12

Re: [PATCH v6 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-03-25 Thread Benjamin Herrenschmidt
On Sun, 2018-03-25 at 12:25 +1100, Benjamin Herrenschmidt wrote: > On Sat, 2018-03-24 at 12:19 +1100, Benjamin Herrenschmidt wrote: > > > In function ‘memcpy’, > > > inlined from ‘ast_vhub_rep_desc’ at > > > drivers/usb/gadget/udc/aspeed-vhub/hub.c:276:2: > > > ./include/linux/string.h:341:4:

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Tony Lindgren
* Tony Lindgren [180326 00:24]: > Looks like on /dev/ttyUSB4 doing AT+COPS? or AT+CREG? won't work > while on /dev/gsmtty1 they work. So /dev/ttyUSB4 seems to a subset of > what's available over n_gsm on ch1. Anyways, good to hear that > /dev/ttyUSB4 can be used to debug voice calls :) Hmm and no

[PATCH v7] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-03-25 Thread Benjamin Herrenschmidt
The Aspeed BMC SoCs support a "virtual hub" function. It provides some HW support for a top-level USB2 hub behind which sit 5 gadget "ports". This driver adds support for the full functionality, emulating the hub standard requests and exposing 5 UDC gadget drivers corresponding to the ports. The

Re: [PATCH] net/usb/qmi_wwan.c: Add USB id for lt4120 modem

2018-03-25 Thread David Miller
From: Torsten Hilbrich Date: Fri, 23 Mar 2018 14:26:18 +0100 > This is needed to support the modem found in HP EliteBook 820 G3. > > Signed-off-by: Torsten Hilbrich This patch was corrupted by your email client, it transformed TAB characters into sequence of spaces. Please email the patch to

Re: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-03-25 Thread Guenter Roeck
On 03/23/2018 03:12 AM, Adam Thomson wrote: This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson Acked-by: He

Re: [PATCH v7 5/6] typec: tcpm: Represent source supply through power_supply

2018-03-25 Thread Guenter Roeck
On 03/23/2018 03:12 AM, Adam Thomson wrote: This commit adds a power_supply class instance to represent a PD source's voltage and current properties. This provides an interface for reading these properties from user-space or other drivers. For PPS enabled Sources, this also provides write access

Re: [PATCH v7 6/6] typec: tcpm: Add support for sink PPS related messages

2018-03-25 Thread Guenter Roeck
On 03/23/2018 03:12 AM, Adam Thomson wrote: This commit adds sink side support for Get_Status, Status, Get_PPS_Status and PPS_Status handling. As there's the potential for a partner to respond with Not_Supported, handling of this message is also added. Sending of Not_Supported is added to handle

Re: [RFC usb-next v2 2/2] usb: core: use phy_exit during suspend if wake up is not supported

2018-03-25 Thread Chunfeng Yun
On Sat, 2018-03-24 at 15:21 +0100, Martin Blumenstingl wrote: > If the USB controller can wake up the system (which is the case for > example with the Mediatek USB3 IP) then we must not call phy_exit during > suspend to ensure that the USB controller doesn't have to re-enumerate > the devices durin

Re: [RFC usb-next v2 1/2] usb: core: split usb_phy_roothub_{init,alloc}

2018-03-25 Thread Chunfeng Yun
On Sat, 2018-03-24 at 15:21 +0100, Martin Blumenstingl wrote: > Before this patch usb_phy_roothub_init served two purposes (from a > caller's point of view - like hcd.c): > - parsing the PHYs and allocating the list entries > - calling phy_init on each list entry > > While this worked so far it ha

Re: [PATCH usb-next v1] usb: core: phy: fix return value of usb_phy_roothub_exit()

2018-03-25 Thread Chunfeng Yun
On Sat, 2018-03-24 at 14:56 +0100, Martin Blumenstingl wrote: > usb_phy_roothub_exit() should return the error code from the phy_exit() > call if exiting the PHY failed. > However, since a wrong variable is used usb_phy_roothub_exit() currently > always returns 0, even if one of the phy_exit calls

[PATCHv2] net/usb/qmi_wwan.c: Add USB id for lt4120 modem

2018-03-25 Thread Torsten Hilbrich
This is needed to support the modem found in HP EliteBook 820 G3. Signed-off-by: Torsten Hilbrich --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 76ac48095c29..e3ef0a0c715d 100644 --- a/drivers/net/u

[PATCH -next] usb: roles: Fix return value check in intel_xhci_usb_probe()

2018-03-25 Thread Wei Yongjun
In case of error, the function devm_ioremap_nocache() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: f6fb9ec02be1 ("usb: roles: Add Intel xHCI USB role switch driver") Signed-off-by: Wei Yongjun --- drivers/usb/roles/inte