Re: [PATCH v5 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-03-17 Thread Fengguang Wu
us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/usb-gadget-Add-an-EP-dispose-callback-for-EP-lifetime-tracking/20180317-004216 config: m32r-allyesconfig (attached as .config) compiler: m32r-linux-gcc (GCC) 7.2.0 Didn't we

[PATCH v1 0/3] usb: dwc2: gadget: Update ISOC DDMA flow.

2018-03-17 Thread Minas Harutyunyan
This series fully update existing ISOC DDMA flow which initially based on 2 descriptor chains. Switching between desc chains performing based on BNA interrupt. Because of BNA interrupt few packets can be lost. 1/3 patch unmask ISOC IN BNA interrupt only. 2/3 patch changing ISOC IN/OUT flow as desc

[PATCH v1 2/3] usb: dwc2: Change ISOC DDMA flow

2018-03-17 Thread Minas Harutyunyan
Changed existing two descriptor-chain flow to one chain. In two-chain implementation BNA interrupt used for switching between two chains. BNA interrupt asserted because of returning to beginning of the chain based on L-bit of last descriptor. Because of that we lose packets. This issue resolved b

[PATCH v1 3/3] usb: dwc2: Add High Bandwidth ISOC OUT support

2018-03-17 Thread Minas Harutyunyan
Updated checking of chain full condition based on mult count. For each packet in uframe (dpi) created new desc by setting size of transfer to mps. Buffer addresses in descs differ by mps in function dwc2_gadget_fill_isoc_desc(). In function dwc2_gadget_start_isoc_ddma() upadted loop boundaries ac

[PATCH v1 1/3] usb: dwc2: Enable BNA interrupt for IN endpoints

2018-03-17 Thread Minas Harutyunyan
In DDMA mode required to enable BNA interrupt for both directions. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/gadget.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 6c32bf26e48e..c231321656f9 100644 -

Re: [PATCH v2 1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-03-17 Thread Alan Stern
On Fri, 16 Mar 2018, Joe Moriarty wrote: > The Parfait (version 2.1.0) static code analysis tool found the > following NULL pointer dereference problem. > > dev_to_shost() in include/scsi/scsi_host.h has the ability to return > NULL if the scsi host device does not have the Scsi_host->parent > fi

Re: [PATCH v4 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-03-17 Thread Alan Stern
On Sat, 17 Mar 2018, Benjamin Herrenschmidt wrote: > On Fri, 2018-03-16 at 16:56 -0400, Alan Stern wrote: > > On Fri, 16 Mar 2018, Benjamin Herrenschmidt wrote: > > > > > On Thu, 2018-03-15 at 08:03 +1100, Benjamin Herrenschmidt wrote: > > > > > > Do you have more comments for the rest of the dri

Re: USB regression for Android phone and sound card in 4.14

2018-03-17 Thread Nazar Mokrynskyi
With kernel 4.16-rc5 it is still happening to USB sound card, Android phone issue was probably related to something else and is already fixed. Very annoying to unplug sound card after each reboot, any ideas why this might happen? Sincerely, Nazar Mokrynskyi github.com/nazar-pc 13.02.18 01:26,