>> Use three values directly for a condition check without assigning them
>> to intermediate variables.
>
> Hi,
>
> what is the benefit of this?
I proposed a small source code reduction.
Other software design directions might become more interesting for this use
case.
Regards,
Markus
--
To un
Trying quirks in usbcore needs to rebuild the driver or the entire
kernel if it's builtin. It can save a lot of time if usbcore has similar
ability like "usbhid.quirks=" and "usb-storage.quirks=".
Rename the original quirk detection function to "static" as we introduce
this new "dynamic" function.
Hi,
Thinh Nguyen writes:
> The maximum bytes per interval for USB SuperSpeed Plus can be set by
> isoc endpoint companion descriptor when it is above 48K. If the
> descriptor is provided, then use its value.
>
> USB 3.1 spec 9.6.8
>
> Signed-off-by: Thinh Nguyen
you should have Cc:ed Greg for
Hi,
Thinh Nguyen writes:
> In DWC_usb31 version 1.70a-ea06 and prior, for highspeed and fullspeed
> isochronous IN, BIT[15:14] of the 16-bit microframe number reported by
> the XferNotReady event are invalid. The driver uses this number to
> schedule the isochronous transfer and passes it to the
Am Montag, den 12.03.2018, 15:00 +0100 schrieb FRÉDÉRIC PARRENIN :
> ipu3
Hi,
sorry, I did not look closely enough. There is a failure report:
[8.995211] ipu3-cio2 :00:14.3: enabling device ( -> 0002)
[9.002030] ipu3-cio2 :00:14.3: device 0x9d32 (rev: 0x1)
[9.002238] ipu3
This patch adds 3 APIs to get the typec port power and data type,
and preferred power role.
Signed-off-by: Li Jun
---
change for v3:
- Use fwnode to get the node of usb connector.
- add one API to get data type
drivers/usb/typec/class.c | 85 +++
incl
Add bingdings supported by current typec driver, so user can pass
all those properties via dt.
Signed-off-by: Li Jun
---
Change for v3:
- port-type change to be power-type which only for power.
- add data-type for data capability.
- preferred-role change to try-power-role(bool property need 2, an
This patch set attempts to move the tcpci driver out of staging by fix
some tcpci driver issues and verified on NXP PTN5110, which is a standard
tcpci typec port controller device with power delivery support, tested
power source and sink with drp config.
Changes for v3:
- Use 2 properties to separ
TCPCI stands for typec port controller interface, its implementation
has full typec port control with power delivery support, it's a
standard i2c slave with GPIO input as irq interface, detail see spec
"Universal Serial Bus Type-C Port Controller Interface Specification
Revision 1.0, Version 1.1"
Add fwnode handle to get the fwnode so we can get typec configs
it contains.
Signed-off-by: Heikki Krogerus
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 14 +++---
drivers/usb/typec/tcpm.c | 1 +
include/linux/usb/tcpm.h | 2 ++
3 files changed, 10 insertions(+)
This patch add 2 APIs to get sink and source power config from firmware
description in case the port supports PD.
Signed-off-by: Li Jun
---
drivers/usb/typec/tcpm.c | 47 +++
include/linux/usb/tcpm.h | 8 +---
2 files changed, 52 insertions(+), 3
User can define the typec port properties in tcpci node to setup
the port config.
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 63 +++
1 file changed, 63 insertions(+)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
With that we can clear any pending events and the port is registered
so driver can be ready to handle typec events once we request irq.
Signed-off-by: Peter Chen
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff -
TCPCI implementation may need SW to enable VBUS detection to generate
power status events.
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index f5a3bf5..9a230c6 100644
As DRP port autonomously toggles the Rp/Rd need a start value to
begin with, so add one parameter for it in tcpm_start_drp_toggling.
Signed-off-by: Li Jun
---
drivers/usb/typec/tcpm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/typec/tcpm.c b/driver
While set polarity, we should keep the not connecting cc line to be
open when attached.
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 9a
We need regmap_update_bits to avoid touch any other bits when
enable or disable vconn.
Signed-off-by: Li Jun
---
drivers/staging/typec/tcpci.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 6fdb179.
Move TCPCI(Typec port controller interface) driver out of staging.
Signed-off-by: Li Jun
---
drivers/staging/Kconfig| 2 --
drivers/staging/Makefile | 1 -
drivers/staging/typec/Kconfig | 14 --
drivers/staging/typec/Makefile | 1 -
d
Hi Greg,
On 03/09/2018 06:19 PM, Greg KH wrote:
>> diff --git a/Documentation/ABI/testing/sysfs-bus-usb
>> b/Documentation/ABI/testing/sysfs-bus-usb
>> index 0bd731cbb50c..27020293c85b 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-usb
>> +++ b/Documentation/ABI/testing/sysfs-bus-usb
>> @@ -
Am Dienstag, den 13.03.2018, 08:24 +0100 schrieb SF Markus Elfring:
> >
> > >
> > > Use three values directly for a condition check without assigning them
> > > to intermediate variables.
> >
> > Hi,
> >
> > what is the benefit of this?
>
> I proposed a small source code reduction.
>
> Other
DWC3 controller on Qualcomm SOCs has a Qscratch wrapper.
Some of its uses are described below resulting in need to
have a separate glue driver instead of using dwc3-of-simple:
- It exposes register interface to override vbus-override
and lane0-pwr-present signals going to hardware. These
mus
Existing documentation has lot of incorrect information as it
was originally added for a driver that no longer exists.
Signed-off-by: Manu Gautam
---
.../devicetree/bindings/usb/qcom,dwc3.txt | 87 +++---
1 file changed, 59 insertions(+), 28 deletions(-)
diff --git a/Do
Hi,
+Andy
Manu Gautam writes:
> DWC3 controller on Qualcomm SOCs has a Qscratch wrapper.
> Some of its uses are described below resulting in need to
> have a separate glue driver instead of using dwc3-of-simple:
> - It exposes register interface to override vbus-override
>and lane0-pwr-pre
Hi Jun Li,
On Tue, Mar 13, 2018 at 05:34:29PM +0800, Li Jun wrote:
> Add fwnode handle to get the fwnode so we can get typec configs
> it contains.
>
> Signed-off-by: Heikki Krogerus
You should not sign-off patches for other people. If you check section
13 from Documentation/process/submitting-
Hi,
On 13-03-18 01:02, Li Jun wrote:
This patch tries to fix the problem describled on revert patch commit[1],
suppose any supported voltage ranges of sink should be describled by
variable pdo, so instead of revert the patch of only comparing source and
sink pdo to select one source pdo, this pa
On Tue, Mar 13, 2018 at 03:26:19PM +0800, Kai-Heng Feng wrote:
> + usbcore.quirks=
> + [USB] A list of quirks entries to supplement or
> + override the built-in usb core quirk list. List
> + entries are separated by commas. Each entr
HI,
On 13-03-18 12:36, Hans de Goede wrote:
Hi,
On 13-03-18 01:02, Li Jun wrote:
This patch tries to fix the problem describled on revert patch commit[1],
suppose any supported voltage ranges of sink should be describled by
variable pdo, so instead of revert the patch of only comparing source
[Cross-posted to 'linux-scsi' and 'linux-usb' lists; please keep me
Cced, as I'm not subscribed to either of them.)
I unboxed a brand new Samsung T5 SSD[*]. Then formatted it with EXT4
filesystem. I wanted to clean the disk of any existing software, so I
was reminded by a colleague to use `blkdi
On Tue, Mar 13, 2018 at 12:42:47PM +0100, Kashyap Chamarthy wrote:
> [Cross-posted to 'linux-scsi' and 'linux-usb' lists; please keep me
> Cced, as I'm not subscribed to either of them.)
[...]
> I was suggested to return this SSD. But the Interweb[%] claims Samsung
> T5 *does* have 'TRIM' (i.e.
Hi,
I ran "udevadm monitor -kup" (this command does not terminate) and then "rmmod
ipu3_cio2; modprobe ipu3_cio2", is that correct?
Below is the output of udevadm after rmmod/modprobe.
Thanks,
Frédéric
PS: maybe I should rather post to linux-media or linux-pci?
-
On 11/03/18 18:01, Fredrik Noring wrote:
Hi Christoph,
The point is that you should always use a pool, period.
dma_alloc*/dma_free* are fundamentally expensive operations on my
architectures, so if you call them from a fast path you are doing
something wrong.
The author's comment in commit b3
On Tue, Mar 13, 2018 at 12:11:49PM +, Robin Murphy wrote:
> Taking a step back, though, provided the original rationale about
> dma_declare_coherent_memory() is still valid, I wonder if we should simply
> permit the USB code to call dma_{alloc,free}_from_dev_coherent() directly
> here instea
From: Merlijn Wajer
This fixes an oops on unbind / module unload (on the musb omap2430
platform).
musb_remove function now calls musb_platform_exit before disabling
runtime pm.
Signed-off-by: Merlijn Wajer
Signed-off-by: Bin Liu
---
drivers/usb/musb/musb_core.c | 2 +-
1 file changed, 1 inse
Hi Greg,
Here is one musb fix for v4.16-rc6, which fixes the wrong teardown order in
musb_remove(). Please let me know if any change is needed.
Regards,
-Bin.
---
Merlijn Wajer (1):
usb: musb: Fix external abort in musb_remove on omap2430
drivers/usb/musb/musb_core.c | 2 +-
1 file changed,
Am Dienstag, den 13.03.2018, 13:11 +0100 schrieb FRÉDÉRIC PARRENIN :
> Hi,
>
> I ran "udevadm monitor -kup" (this command does not terminate) and then
> "rmmod ipu3_cio2; modprobe ipu3_cio2", is that correct?
Yes, it is correct and the command is not supposed to terminate.
It logs udev events.
If you look at udev events, the /dev/video* devices are added and then they are
removed.
I don't know exactly why.
If you don't know why this happens, I will email linux-media.
Thanks,
Frédéric
> De: "Oliver Neukum"
> À: "FRÉDÉRIC PARRENIN"
> Cc: "linux-usb"
> Envoyé: Mardi 13 Mars 2018 1
USB 3.2 specification adds Dual-lane support, doubling the maximum
SuperSpeedPlus data rate from 10Gbps to 20Gbps.
Dual-lane takes into use a second set of rx and tx wires/pins in the
Type-C cable and connector.
Add a "lanes" variable to struct usb_device to store the numer of lanes
in use. Numbe
The USB 3.2 specification adds support for Dual-lane, doubling the
maximum rate to 20Gbps by taking into use another set of rx and tx
wires and pins in the Type-C cable and connector.
The changes to support this in USB core and xhci driver seems to be minor.
USB 3.1 support already added the exten
USB 3.2 specification adds a Gen XxY notion for USB3 devices where
X is the signaling rate on the wire. Gen 1xY is 5Gbps Superspeed
and Gen 2xY is 10Gbps SuperSpeedPlus. Y is the lane count.
USB 3.2 supports dual lane Gen Xx2
Gen 1x1 5Gbps single lane
Gen 2x1 10Gbps single lane
Gen 1x2 10Gbps dua
Hi,
Mathias Nyman writes:
> The USB 3.2 specification adds support for Dual-lane, doubling the
> maximum rate to 20Gbps by taking into use another set of rx and tx
> wires and pins in the Type-C cable and connector.
>
> The changes to support this in USB core and xhci driver seems to be minor.
On 13.03.2018 17:29, Felipe Balbi wrote:
Hi,
Mathias Nyman writes:
USB 3.2 specification adds Dual-lane support, doubling the maximum
SuperSpeedPlus data rate from 10Gbps to 20Gbps.
Dual-lane takes into use a second set of rx and tx wires/pins in the
Type-C cable and connector.
Add a "lane
From: Colin Ian King
Trivial fix to spelling mistake in dev_warn warning message text.
Signed-off-by: Colin Ian King
---
drivers/usb/dwc2/hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index dcfda5eb4cac..190f95964000 1
On 13.03.2018 17:31, Felipe Balbi wrote:
Hi,
Mathias Nyman writes:
USB 3.2 specification adds a Gen XxY notion for USB3 devices where
X is the signaling rate on the wire. Gen 1xY is 5Gbps Superspeed
and Gen 2xY is 10Gbps SuperSpeedPlus. Y is the lane count.
USB 3.2 supports dual lane Gen Xx2
This is originally raised as Debian bug but the more I investigate
it seems to trace back to 4.14.x xhci.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892647 (see also
message #29)
Call trace:
xhci_giveback_urb_in_irq.isra.43+0x7f/0xe0 [xhci_hcd]
xhci_td_cleanup+0xe7/0x170 [xhci_hcd]
On Sun, Mar 11, 2018 at 2:38 PM, FRÉDÉRIC PARRENIN
wrote:
> Dear Oliver and all,
>
> So I was expecting linux-4.16 to recognize my webcams, thanks to this new PCI
> driver Oliver mentioned.
> Therefore I installed 4.16-rc4.
> Unfortunately, there is still no /dev/video* device
>
> Any idea what c
Hi,
Mathias Nyman writes:
> USB 3.2 specification adds a Gen XxY notion for USB3 devices where
> X is the signaling rate on the wire. Gen 1xY is 5Gbps Superspeed
> and Gen 2xY is 10Gbps SuperSpeedPlus. Y is the lane count.
> USB 3.2 supports dual lane Gen Xx2
>
> Gen 1x1 5Gbps single lane
> Gen
Hi,
Mathias Nyman writes:
> USB 3.2 specification adds Dual-lane support, doubling the maximum
> SuperSpeedPlus data rate from 10Gbps to 20Gbps.
>
> Dual-lane takes into use a second set of rx and tx wires/pins in the
> Type-C cable and connector.
>
> Add a "lanes" variable to struct usb_device
On 13.03.2018 17:27, Felipe Balbi wrote:
Hi,
Mathias Nyman writes:
The USB 3.2 specification adds support for Dual-lane, doubling the
maximum rate to 20Gbps by taking into use another set of rx and tx
wires and pins in the Type-C cable and connector.
The changes to support this in USB core
On Tue, 13 Mar 2018 17:27:21 +0200
Mathias Nyman wrote:
> Example for clarification:
> Gen 1x1 = 5Gbps, SuperSpeed, one lane, same as USB3.0, and USB 3.1 Gen1
> Gen 2x1 = 10Gbps, SuperSpeedPlus, one lane, same as USB 3.1 Gen2
> Gen 1x2 = 10Gbps, SuperSpeed, Dual-lane (2 x 5Gbps)
> Gen 2x2 = 20Gbp
Hi,
On Mon, Mar 12, 2018 at 11:30:39PM +0100, Merlijn Wajer wrote:
> Hi Bin,
>
> On 09/03/18 15:11, Bin Liu wrote:
> > Hi,
> >
> > On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote:
> >> This fixes an oops on unbind / module unload (on the musb omap2430
> >> platform).
> >>
> >> musb
Am Dienstag, den 13.03.2018, 16:14 +0100 schrieb FRÉDÉRIC PARRENIN :
> If you look at udev events, the /dev/video* devices are added and then they
> are removed.
> I don't know exactly why.
> If you don't know why this happens, I will email linux-media.
Sorry,
I assumed you unloaded the driver
On 03/12/2018 06:25 AM, Chunfeng Yun wrote:
> There are two parameters, ref_clk and coefficient, for U2 slew rate
> calibrate which may vary on different SoCs, here allow them to be
> configurable
>
> Signed-off-by: Chunfeng Yun
Reviewed-by: Matthias Brugger
> ---
> drivers/phy/mediatek/ph
On 03/12/2018 06:25 AM, Chunfeng Yun wrote:
> Add two properties of ref_clk and coefficient used by U2 slew rate
> calibrate which may vary on different SoCs
>
> Signed-off-by: Chunfeng Yun
Reviewed-by: Matthias Brugger
> ---
> Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 4
Hi Felipe,
On 3/13/2018 1:45 AM, Felipe Balbi wrote:
>
> Hi,
>
> Thinh Nguyen writes:
>> In DWC_usb31 version 1.70a-ea06 and prior, for highspeed and fullspeed
>> isochronous IN, BIT[15:14] of the 16-bit microframe number reported by
>> the XferNotReady event are invalid. The driver uses this n
Hi,
On 3/13/2018 1:31 AM, Felipe Balbi wrote:
>
> Hi,
>
> Thinh Nguyen writes:
>> The maximum bytes per interval for USB SuperSpeed Plus can be set by
>> isoc endpoint companion descriptor when it is above 48K. If the
>> descriptor is provided, then use its value.
>>
>> USB 3.1 spec 9.6.8
>>
>>
> -Original Message-
> From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com]
> Sent: 2018年3月13日 19:18
> To: Jun Li
> Cc: robh...@kernel.org; mark.rutl...@arm.com;
> gre...@linuxfoundation.org; a.ha...@samsung.com; li...@roeck-us.net;
> yue...@google.com; shufan_...@richtek.com; o
Matthew Wilcox wrote:
On Tue, Mar 13, 2018 at 03:26:19PM +0800, Kai-Heng Feng wrote:
+ usbcore.quirks=
+ [USB] A list of quirks entries to supplement or
+ override the built-in usb core quirk list. List
+ entries are sepa
On Tue, 2018-03-13 at 09:35 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2018-03-09 at 11:20 +0200, Felipe Balbi wrote:
> >
> > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c
> > > b/drivers/usb/gadget/udc/aspeed-vhub/core.c
> > > new file mode 100644
> > > index ..31ed2b6
Hi Manu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180313]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Manu
Hi,
On 3/13/2018 4:38 PM, Felipe Balbi wrote:
> Hi,
>
> +Andy
>
> Manu Gautam writes:
>> DWC3 controller on Qualcomm SOCs has a Qscratch wrapper.
>> Some of its uses are described below resulting in need to
>> have a separate glue driver instead of using dwc3-of-simple:
>> - It exposes register
The driver is used to support Apple carplay feature by a debugfs
interface which can force the driver to send a USB Vendor Request
of "Apple Device to Host Mode Switch" to switch Apple Device
into host mode.
Signed-off-by: Chunfeng Yun
---
drivers/usb/misc/Kconfig |9 ++
drivers/usb/misc/M
>From bf48dcd9cb254576cfea373c9a5d2ab996408895 Mon Sep 17 00:00:00 2001
From: Chunfeng Yun
Date: Tue, 13 Mar 2018 11:47:38 +0800
Subject: [PATCH] Add Apple Carplay driver
Some Apple devices which support Carplay can enter USB Host Mode from USB
Device Mode after receiving a specific USB Vendor Re
On Wed, 2018-03-14 at 00:21 +0100, Matthias Brugger wrote:
>
> On 03/12/2018 06:25 AM, Chunfeng Yun wrote:
> > There are two parameters, ref_clk and coefficient, for U2 slew rate
> > calibrate which may vary on different SoCs, here allow them to be
> > configurable
> >
> > Signed-off-by: Chunfeng
On Wed, 2018-03-14 at 00:21 +0100, Matthias Brugger wrote:
>
> On 03/12/2018 06:25 AM, Chunfeng Yun wrote:
> > Add two properties of ref_clk and coefficient used by U2 slew rate
> > calibrate which may vary on different SoCs
> >
> > Signed-off-by: Chunfeng Yun
>
> Reviewed-by: Matthias Brugger
Why is this a kernel-level driver, rather than a userspace application
that uses libusb to send the single vendor-specific command required?
Since this command would be applicable to many CarPlay devices, with
many different VID/PIDs, it would seem to make more sense as a
userspace app that took a
65 matches
Mail list logo
