Drop bogus call to usb_driver_release_interface() from an error path in
the usbnet bind() callback, which is called during interface probe. At
this point the interface is not bound and usb_driver_release_interface()
returns early.
Also remove the bogus call to clear the interface data, which is ow
Drop bogus call to usb_driver_release_interface() from an error path in
the usbnet bind() callback, which is called during interface probe. At
this point the interface is not bound and usb_driver_release_interface()
returns early.
Also remove the bogus call to clear the interface data, which is ow
Drop bogus call to usb_driver_release_interface() from the disconnect()
callback. As the interface is already being unbound at this point,
usb_driver_release_interface() simply returns early.
Signed-off-by: Johan Hovold
---
drivers/media/usb/cpia2/cpia2_usb.c | 3 ---
1 file changed, 3 deletions
Am Mittwoch, den 07.03.2018, 10:46 +0100 schrieb Johan Hovold:
> Drop bogus call to usb_driver_release_interface() from an error path in
> the usbnet bind() callback, which is called during interface probe. At
> this point the interface is not bound and usb_driver_release_interface()
> returns earl
Drop redundant interface-class test for Samsung GT-B3730 modems for
which we only match and probe the CDC data interface.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/option.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/optio
Use the USB class define rather than a magic number when refusing to
bind to mass-storage interfaces.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 96
Hi Chanwoo, Archit,
On 07.03.2018 05:48, Chanwoo Choi wrote:
> On 2018년 03월 07일 11:12, Chanwoo Choi wrote:
>> Hi Rob and Andrzej,
>>
>> On 2018년 03월 06일 21:53, Andrzej Hajda wrote:
>>> Hi Rob, Chanwoo, Krzysztof,
>>>
>>>
>>> On 27.02.2018 08:11, Andrzej Hajda wrote:
Hi,
Thanks for r
On Wed, Mar 7, 2018 at 12:13 PM, Andrzej Hajda wrote:
> Hi Chanwoo, Archit,
>
> On 07.03.2018 05:48, Chanwoo Choi wrote:
>> On 2018년 03월 07일 11:12, Chanwoo Choi wrote:
>>> Hi Rob and Andrzej,
>>>
>>> On 2018년 03월 06일 21:53, Andrzej Hajda wrote:
Hi Rob, Chanwoo, Krzysztof,
On 27
On 07.03.2018 12:22, Krzysztof Kozlowski wrote:
> On Wed, Mar 7, 2018 at 12:13 PM, Andrzej Hajda wrote:
>> Hi Chanwoo, Archit,
>>
>> On 07.03.2018 05:48, Chanwoo Choi wrote:
>>> On 2018년 03월 07일 11:12, Chanwoo Choi wrote:
Hi Rob and Andrzej,
On 2018년 03월 06일 21:53, Andrzej Hajda wro
Hi all,
are there any news regarding this issue?
I have a similar issue using a Lenovo ThinkPad T480s with Lenovo UltraDock
CS18. If I undock the CS18 dock I will get the following messages (kernel
4.14.24):
[ 64.127294] usb usb4-port1: Cannot enable. Maybe the USB cable is bad?
[ 64.12730
On 03/03/2018 22:43, Martin Blumenstingl wrote:
> The goal of this series is to initialize multiple PHYs on a USB host
> controller, which is needed on Amlogic Meson GXL and GXM SoCs.
> - Amlogic Meson GXL and GXM SoCs come with a dwc3 IP block which has two
> or three USB2 ports enabled on the i
On 11/02/2018 22:15, Martin Blumenstingl wrote:
> Amlogic Meson AXG and GXL SoCs can use the dwc3-of-simple with little
> modifications. These SoCs use:
> - a gate clock for the USB components (DWC3, USB PHYs)
> - a reset line which is shared across all USB components (DWC3, USB2 and
> USB3 PHYs,
On Wed, Mar 07, 2018 at 10:46:57AM +0100, Johan Hovold wrote:
> Drop bogus call to usb_driver_release_interface() from an error path in
> the usbnet bind() callback, which is called during interface probe. At
> this point the interface is not bound and usb_driver_release_interface()
> returns early
On Wed, Mar 07, 2018 at 10:46:58AM +0100, Johan Hovold wrote:
> Drop bogus call to usb_driver_release_interface() from an error path in
> the usbnet bind() callback, which is called during interface probe. At
> this point the interface is not bound and usb_driver_release_interface()
> returns early
On Wed, Mar 07, 2018 at 11:49:55AM +0100, Johan Hovold wrote:
> Drop redundant interface-class test for Samsung GT-B3730 modems for
> which we only match and probe the CDC data interface.
>
> Signed-off-by: Johan Hovold
Reviewed-by: Greg Kroah-Hartman
--
To unsubscribe from this list: send the
On Wed, Mar 07, 2018 at 11:49:56AM +0100, Johan Hovold wrote:
> Use the USB class define rather than a magic number when refusing to
> bind to mass-storage interfaces.
>
> Signed-off-by: Johan Hovold
Reviewed-by: Greg Kroah-Hartman
--
To unsubscribe from this list: send the line "unsubscribe li
On Wed, Mar 07, 2018 at 10:49:36AM +0100, Johan Hovold wrote:
> Drop bogus call to usb_driver_release_interface() from the disconnect()
> callback. As the interface is already being unbound at this point,
> usb_driver_release_interface() simply returns early.
>
> Signed-off-by: Johan Hovold
Revi
Let's add support for the GPIO controlled USB PHY on the MDM6600 modem.
It is used on some Motorola Mapphone series of phones and tablets such
as Droid 4.
The MDM6600 is hardwired to the first OHCI port in the Droid 4 case, and
is controlled by several GPIOs. The USB PHY is integrated into the MDM
On 06.03.2018 04:24, Cyril Roelandt wrote:
Hi,
On 02/28/18 15:55, Mathias Nyman wrote:
I have a series of even more custom debugging patches.
attached patches apply on 4.13, but seris for both 4.13 and 4.15 can be found
in the
streams-debug-4.13 and streams-debug-4.15 branches at
git://git.k
Reimplement interface masking using device flags stored directly in the
device-id table. This will make it easier to add and maintain device-id
entries by using a more compact and readable notation compared to the
current implementation (which manages pairs of masks in separate
blacklist structs).
From: Eric Dumazet
Date: Mon, 05 Mar 2018 11:41:13 -0800
> From: Eric Dumazet
>
> Marek reported a LOCKDEP issue occurring on 32bit host,
> that we tracked down to the fact that usbnet could either
> run from soft or hard irqs.
>
> This patch adds u64_stats_update_begin_irqsave() and
> u64_sta
Use kasprintf instead of combination of kmalloc and sprintf and
therefore avoid unnecessary computation of string length.
Signed-off-by: Himanshu Jha
---
drivers/usb/isp1760/isp1760-udc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/isp1760/isp1760-udc.c
b/
On Wed, Mar 7, 2018 at 8:08 PM, Himanshu Jha
wrote:
> Use kasprintf instead of combination of kmalloc and sprintf and
> therefore avoid unnecessary computation of string length.
> devname = dev_name(isp->dev);
Do you still need this temporary variable?
> - udc->irqname = kmalloc(s
On Wed, Mar 07, 2018 at 08:20:54PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 7, 2018 at 8:08 PM, Himanshu Jha
> wrote:
> > Use kasprintf instead of combination of kmalloc and sprintf and
> > therefore avoid unnecessary computation of string length.
>
> > devname = dev_name(isp->dev);
>
Use kasprintf instead of combination of kmalloc and sprintf and
therefore avoid unnecessary computation of string length.
Also, remove the useless local variable.
Signed-off-by: Himanshu Jha
---
drivers/usb/isp1760/isp1760-udc.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
v2:
On Wed, Mar 7, 2018 at 10:38 AM, Himanshu Jha
wrote:
> Use kasprintf instead of combination of kmalloc and sprintf and
> therefore avoid unnecessary computation of string length.
> Also, remove the useless local variable.
>
> Signed-off-by: Himanshu Jha
Reviewed-by: Kees Cook
-Kees
> ---
> d
On Wed, Mar 07, 2018 at 05:40:48PM +0100, Johan Hovold wrote:
> Reimplement interface masking using device flags stored directly in the
> device-id table. This will make it easier to add and maintain device-id
> entries by using a more compact and readable notation compared to the
> current impleme
From: Kuppuswamy Sathyanarayanan
In usb_serial_generic_submit_read_urb() function we are accessing the
port->read_urbs array without any boundry checks. This might lead to
kernel panic when index value goes above array length.
One posible call path for this issue is,
usb_serial_generic_read_bul
From: Johan Hovold
Date: Wed, 7 Mar 2018 10:46:58 +0100
> Drop bogus call to usb_driver_release_interface() from an error path in
> the usbnet bind() callback, which is called during interface probe. At
> this point the interface is not bound and usb_driver_release_interface()
> returns early.
>
From: Johan Hovold
Date: Wed, 7 Mar 2018 10:46:57 +0100
> Drop bogus call to usb_driver_release_interface() from an error path in
> the usbnet bind() callback, which is called during interface probe. At
> this point the interface is not bound and usb_driver_release_interface()
> returns early.
>
Changed usbip_network, usbip_attach, usbip_list, and usbipd to use
and propagate the new error codes in server reply messages.
usbip_net_recv_op_common() is changed to take a pointer to status
return the status returned in the op_common.status to callers.
usbip_attach and usbip_list use the commo
Currently ST_OK and ST_NA are the only values defined to communicate
status of a request from a client. Client doesn't know what failed
and prints a cryptic error message that something failed.
This patch series adds more error codes to clearly indicate what failed.
For example, when client sends
Currently ST_OK and ST_NA are the only values defined to communicate
status of a request from a client. Add more error codes to clearly
indicate what failed. For example, when client sends request to import
a device that isn't export-able, server can send a specific error code
to the client.
Exist
Currently ST_OK and ST_NA are the only values used to communicate
status of a request from a client. Use new error codes to clearly
indicate what failed. For example, when client sends request to
import a device that isn't export-able, send ST_DEV_BUSY to the client.
Signed-off-by: Shuah Khan
---
On Wed, Mar 07, 2018 at 12:23:56PM -0800,
sathyanarayanan.kuppusw...@linux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan
>
> In usb_serial_generic_submit_read_urb() function we are accessing the
> port->read_urbs array without any boundry checks. This might lead to
> kernel panic when inde
On 03/07/2018 12:58 PM, Greg KH wrote:
On Wed, Mar 07, 2018 at 12:23:56PM -0800,
sathyanarayanan.kuppusw...@linux.intel.com wrote:
From: Kuppuswamy Sathyanarayanan
In usb_serial_generic_submit_read_urb() function we are accessing the
port->read_urbs array without any boundry checks. This mi
Hi,
I am trying to unbind the musb driver on my Nokia N900, but I get the
following kernel oops [1].
This is the command that I issued:
root@n900devuan:/sys/bus/platform/drivers/musb-hdrc# echo
musb-hdrc.0.auto > unbind
This might be omap specific. I thought that as with the vbus issue,
calls t
On 03/06/2018 09:09 AM, Minas Harutyunyan wrote:
Hi,
On 3/6/2018 10:45 AM, Minas Harutyunyan wrote:
Hi,
On 3/5/2018 11:14 PM, Marek Vasut wrote:
On 02/20/2018 06:51 AM, Minas Harutyunyan wrote:
[...]
Is there a way to reduce that or is that the absolute minimum in HS mode?
We already discu
Hi,
I suspected that the issue was similar to the one fixed in this commit:
0c3aae9bd59978fb8c3557d7883380bef0f2cfa1 (USB: musb: fix late external
abort on suspend)
I've applied a similar fix to the musb_remove function (as well as
moving musb_platform_exit just before spin_unlock_irqrestore), an
On Tue, Mar 06, 2018 at 04:59:11PM +0800, Ran Wang wrote:
> Enable the undefined length INCR burst type and set INCRx.
> Different platform may has the different burst size type.
> In order to get best performance, we need to tune the burst size to
> one special value, instead of the default value.
On Tue, Mar 06, 2018 at 04:59:10PM +0800, Ran Wang wrote:
> Property "snps,incr-burst-type-adjustment = , ..." for USB3.0 DWC3.
> When only one value means INCRx mode with fix burst type.
> When more than one value, means undefined length burst mode, USB controller
> can use the length less than or
Hi
> -Original Message-
> From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com]
> Sent: 2018年3月6日 20:02
> To: Jun Li
> Cc: Andrzej Hajda ; gre...@linuxfoundation.org;
> robh...@kernel.org; li...@roeck-us.net; mark.rutl...@arm.com;
> yue...@google.com; Peter Chen ;
> garsi...@embed
Hi Andrzej, Archit,
On 2018년 03월 07일 20:13, Andrzej Hajda wrote:
> Hi Chanwoo, Archit,
>
> On 07.03.2018 05:48, Chanwoo Choi wrote:
>> On 2018년 03월 07일 11:12, Chanwoo Choi wrote:
>>> Hi Rob and Andrzej,
>>>
>>> On 2018년 03월 06일 21:53, Andrzej Hajda wrote:
Hi Rob, Chanwoo, Krzysztof,
>>>
Trying quirks in usbcore needs to rebuild the driver or the entire
kernel if it's builtin. It can save a lot of time if usbcore has similar
ability like "usbhid.quirks=" and "usb-storage.quirks=".
Rename the original quirk detection function to "static" as we introduce
this new "dynamic" function.
From: John Stultz
[ Upstream commit dad3f793f20fbb5c0c342f0f5a0bdf69a4d76089 ]
I had seen some odd behavior with HiKey's usb-gadget interface
that I finally seemed to have chased down. Basically every other
time I plugged in the OTG port, the gadget interface would
properly initialize. The other
From: John Stultz
[ Upstream commit dad3f793f20fbb5c0c342f0f5a0bdf69a4d76089 ]
I had seen some odd behavior with HiKey's usb-gadget interface
that I finally seemed to have chased down. Basically every other
time I plugged in the OTG port, the gadget interface would
properly initialize. The other
Attn: Beneficiary,
We have contacted the Federal Ministry of Finance on your Behalf and
they have brought a solution to your problem by coordinating your
payment in total (10,000,000.00) Ten Million Dollars in an atm card
which you can use to withdraw money from any ATM MACHINE CENTER
anywhere in
47 matches
Mail list logo
