Re: [PATCH V1 3/4] usb: serial: f81534: add output pin control

2018-01-02 Thread Johan Hovold
On Tue, Jan 02, 2018 at 11:24:26AM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Johan, > > >> In this code, I'm only read/write 3 registers of 0x2ae8, 0x2a90, 0x2a80, > >> but some register will read/write more than once. Should I change the > >> code from port_probe() to attach() and re-write it as

Re: [PATCH] USB: cp2101 Add new device ID ELV ALC 8xxx

2018-01-02 Thread Johan Hovold
On Wed, Dec 27, 2017 at 10:13:23PM +0100, Christian Holl wrote: > From: Christian Holl > Date: Wed, 27 Dec 2017 21:39:04 +0100 > Subject: [PATCH] USB: cp210x Add new device ID ELV ALC 8xxx > > This adds the ELV ALC 8xxx Battery Charging device > to the list of USB IDs of drivers/usb/serial/cp210x

Re: Second Try, as you will not accept not text mails: 4.14.10-gentoo-r1 breaks cups functionality

2018-01-02 Thread Greg KH
text emails work great, it's html emails that do not :) On Mon, Jan 01, 2018 at 11:12:24PM +0100, Roman Gruber wrote: > I send you  my bug because kernel.org bugzilla pointed me here. >   > https://bugzilla.kernel.org/show_bug.cgi?id=198329[https://deref-gmx.net/mail/client/HSud2NXiEWY/dereferrer/

Re: [PATCH v2] USB: serial: cp210x: add IDs for LifeScan OneTouch Verio IQ

2018-01-02 Thread Johan Hovold
On Fri, Dec 29, 2017 at 09:54:25AM +, Diego Elio Pettenò wrote: > Add IDs for the OneTouch Verio IQ that comes with an embedded > USB-to-serial converter. > > Signed-off-by: Diego Elio Pettenò Now applied. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

2018-01-02 Thread Kai Heng Feng
> On 21 Dec 2017, at 7:43 PM, Daniel Drake wrote: > > On Wed, Dec 20, 2017 at 6:53 PM, Brian Norris > wrote: >> >> On Wed, Dec 20, 2017 at 07:00:07PM +0800, Kai-Heng Feng wrote: >>> This commit causes a regression on some QCA ROME chips. The USB device >>> reset happens in btusb_open(), henc

Re: [PATCH v2] USB: host: Use zeroing memory allocator rather than allocator/memset

2018-01-02 Thread Mathias Nyman
On 30.12.2017 22:03, Himanshu Jha wrote: Use dma_zalloc_coherent for allocating zeroed memory and remove unnecessary memset function. Done using Coccinelle. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci 0-day tested with no failures. Suggested-by: Luis R. Rodriguez Signed-off

[PATCH] USB: usbip: remove useless call in usbip_recv

2018-01-02 Thread Gustavo A. R. Silva
Calling msg_data_left(&msg) is only useful for its return value, which in this particular case is ignored. Fix this by removing such call. Addresses-Coverity-ID: 1427080 Fixes: 90120d15f4c3 ("usbip: prevent leaking socket pointer address in messages") Signed-off-by: Gustavo A. R. Silva --- dri

Re: [PATCH 1/2] USB: serial: ark3116.c: Remove unused TIOCSSERIAL ioctl case.

2018-01-02 Thread Johan Hovold
On Wed, Dec 13, 2017 at 04:44:55PM +0300, Mikhail Zaytsev wrote: > The patch removes unused TIOCSSERIAL ioctl case and adds the default block > to the switch. > > Signed-off-by: Mikhail Zaytsev > --- > drivers/usb/serial/ark3116.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) >

Re: [PATCH 2/2] USB: serial: ark3116.c: Move TIOCGSERIAL ioctl case to function.

2018-01-02 Thread Johan Hovold
On Wed, Dec 13, 2017 at 04:45:06PM +0300, Mikhail Zaytsev wrote: > The patch moves TIOCGSERIAL ioctl case to get_serial_info function. > > Signed-off-by: Mikhail Zaytsev > --- > drivers/usb/serial/ark3116.c | 35 +-- > 1 file changed, 21 insertions(+), 14 deletion

[PATCH v4 7/7] typec: tcpm: Add support for sink PPS related messages

2018-01-02 Thread Adam Thomson
This commit adds sink side support for Get_Status, Status, Get_PPS_Status and PPS_Status handling. As there's the potential for a partner to respond with Not_Supported handling of this message is also added. Sending of Not_Supported is added is added to handle messages received but not yet handled.

[PATCH v4 6/7] typec: tcpm: Represent source supply through power_supply class

2018-01-02 Thread Adam Thomson
This commit adds a power_supply class instance to represent a PD source's voltage and current properties. This provides an interface for reading these properties from user-space or other drivers. For PPS enabled Sources, this also provides write access to set the current and voltage and allows for

[PATCH v4 5/7] power: supply: Add 'connected_type' property and supporting code

2018-01-02 Thread Adam Thomson
This commit adds the 'connected_type' property to represent supplies which can report a number of different types of supply based on a connection event. Examples of this already exist in drivers whereby the existing 'type' property is updated, based on an event, to represent what was connected (e.

[PATCH v4 2/7] typec: tcpm: Add ADO header for Alert message handling

2018-01-02 Thread Adam Thomson
This commit adds a header providing definitions for handling Alert messages. Currently the header only focuses on handling incoming alerts. Signed-off-by: Adam Thomson --- include/linux/usb/pd_ado.h | 42 ++ 1 file changed, 42 insertions(+) create mode 10

[PATCH v4 4/7] typec: tcpm: Add core support for sink side PPS

2018-01-02 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson --- drivers/usb/typec/tcpm.c | 533 ++

[PATCH v4 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2018-01-02 Thread Adam Thomson
This commit adds definitions for PD Rev 3.0 messages, including APDO PPS and extended message support for TCPM. Signed-off-by: Adam Thomson --- include/linux/usb/pd.h | 185 ++--- 1 file changed, 174 insertions(+), 11 deletions(-) diff --git a/include

[PATCH v4 3/7] typec: tcpm: Add SDB header for Status message handling

2018-01-02 Thread Adam Thomson
This commit adds a header providing definitions for handling Status messages. Currently the header only focuses on handling incoming Status messages. Signed-off-by: Adam Thomson --- include/linux/usb/pd_ext_sdb.h | 31 +++ 1 file changed, 31 insertions(+) create mode

[PATCH v4 0/7] typec: tcpm: Add sink side support for PPS

2018-01-02 Thread Adam Thomson
This patch set adds sink side support for the PPS feature introduced in the USB PD 3.0 specification. The source PPS supply is represented using the Power Supply framework to provide access and control APIs for dealing with it's operating voltage and current, and switching between a standard PDO a

Re: [PATCH] tools: usb: usbip: fix fd leak in case of 'fread' failure

2018-01-02 Thread Shuah Khan
On 12/30/2017 09:01 AM, Elad Wexler wrote: > Fix possible resource leak: fd > > Signed-off-by: Elad Wexler Thanks for the patch. Looks good to me. Acked-by: Shuah Khan Greg, please pick this patch up. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: [PATCH] tools: usb: usbip_device_driver: prefer 'unsigned int' to 'unsigned'

2018-01-02 Thread Shuah Khan
On 12/30/2017 09:11 AM, Elad Wexler wrote: > Fixup a coding style issue > > Signed-off-by: Elad Wexler Thanks for the patch. Looks good to me. Acked-by: Shuah Khan Greg, please pick this patch up. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in th

Re: [PATCH v5 03/78] xarray: Add the xa_lock to the radix_tree_root

2018-01-02 Thread Darrick J. Wong
On Tue, Dec 26, 2017 at 07:58:15PM -0800, Matthew Wilcox wrote: > On Tue, Dec 26, 2017 at 07:43:40PM -0800, Matthew Wilcox wrote: > > Also add the xa_lock() and xa_unlock() family of wrappers to make it > > easier to use the lock. If we could rely on -fplan9-extensions in > > the compi

4.14.10-gentoo-r1 breaks Heimdall + cups functionality

2018-01-02 Thread Roman Gruber
Hi Abstract: Heimdall does not work with 4.14.10-gentoo-r1. Heimdall is an open source SAMSUNG odin protocol software to write custom software to SAMSUNG ANDROID Tablets over USB. Going back to kernel 4.9.73-gentoo seems to have fixed it. A very small chance that the --no-reboot option of heimd

Re: [PATCH] NET: usb: qmi_wwan: add support for YUGA CLM920-NC5 PID 0x9625

2018-01-02 Thread David Miller
From: SZ Lin (林上智) Date: Fri, 29 Dec 2017 17:02:17 +0800 > This patch adds support for PID 0x9625 of YUGA CLM920-NC5. > > YUGA CLM920-NC5 needs to enable QMI_WWAN_QUIRK_DTR before QMI operation. > > qmicli -d /dev/cdc-wdm0 -p --dms-get-revision > [/dev/cdc-wdm0] Device revision retrieved: >

Re: 4.14.10-gentoo-r1 breaks Heimdall + cups functionality

2018-01-02 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, Jan 02, 2018 at 08:46

Re: [PATCH v5 03/78] xarray: Add the xa_lock to the radix_tree_root

2018-01-02 Thread Matthew Wilcox
On Tue, Jan 02, 2018 at 10:01:55AM -0800, Darrick J. Wong wrote: > On Tue, Dec 26, 2017 at 07:58:15PM -0800, Matthew Wilcox wrote: > > spin_lock_irqsave(&mapping->pages, flags); > > __delete_from_page_cache(page, NULL); > > spin_unlock_irqrestore(&mapping->pages, flags); > >

Re: [PATCH] USB: usbip: remove useless call in usbip_recv

2018-01-02 Thread Shuah Khan
On 01/02/2018 07:02 AM, Gustavo A. R. Silva wrote: > Calling msg_data_left(&msg) is only useful for its return value, > which in this particular case is ignored. > > Fix this by removing such call. > > Addresses-Coverity-ID: 1427080 > Fixes: 90120d15f4c3 ("usbip: prevent leaking socket pointer ad

Re: [PATCH v5 01/78] xfs: Rename xa_ elements to ail_

2018-01-02 Thread Darrick J. Wong
On Fri, Dec 15, 2017 at 02:03:33PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > This is a simple rename, except that xa_ail becomes ail_head. > > Signed-off-by: Matthew Wilcox That was an eyeful, Reviewed-by: Darrick J. Wong > --- > fs/xfs/xfs_buf_item.c| 10 ++-- > fs/xfs/x

Re: kernel BUG at ./include/linux/mm.h:LINE! (3)

2018-01-02 Thread Pete Zaitcev
On Fri, 29 Dec 2017 16:24:20 +0300 "Kirill A. Shutemov" wrote: > Looks like MON_IOCT_RING_SIZE reallocates ring buffer without any > serialization wrt mon_bin_vma_fault(). By the time of get_page() the page > may be freed. Okay. Who knew that you could fork while holding an open descriptor. :-)