[bug report] usbip: fix stub_rx: harden CMD_SUBMIT path to handle malicious input

2017-12-14 Thread Dan Carpenter
Hello Shuah Khan, The patch c6688ef9f297: "usbip: fix stub_rx: harden CMD_SUBMIT path to handle malicious input" from Dec 7, 2017, leads to the following static checker warning: drivers/usb/usbip/stub_rx.c:346 get_pipe() warn: impossible condition '(pdu->u.cmd_submit.transfer_buffer_lengt

[BUG] Kernel 4.14.3-300 breaks Roccat mouse drivers

2017-12-14 Thread Gianfranco Cecconi
Hi All, I was asked to send here a bug I originally posted at https://bugzilla.kernel.org/show_bug.cgi?id=198155 . I've been using for a couple of years these Roccat drivers https://sourceforge.net/projects/roccat/ with Fedora and a Nyth USB mouse https://www.roccat.org/en-GB/Products/Gaming-Mice/

Re: [BUG] Kernel 4.14.3-300 breaks Roccat mouse drivers

2017-12-14 Thread Felipe Balbi
Hi, Gianfranco Cecconi writes: > Hi All, I was asked to send here a bug I originally posted at > https://bugzilla.kernel.org/show_bug.cgi?id=198155 . > > I've been using for a couple of years these Roccat drivers > https://sourceforge.net/projects/roccat/ with Fedora and a Nyth USB out of tree

Re: [BUG] Kernel 4.14.3-300 breaks Roccat mouse drivers

2017-12-14 Thread Greg KH
On Thu, Dec 14, 2017 at 08:37:15AM +, Gianfranco Cecconi wrote: > Hi All, I was asked to send here a bug I originally posted at > https://bugzilla.kernel.org/show_bug.cgi?id=198155 . > > I've been using for a couple of years these Roccat drivers > https://sourceforge.net/projects/roccat/ with

Re: [PATCH] usb/io_edgeport: Fix a possible sleep-in-atomic bug in edge_bulk_in_callback

2017-12-14 Thread Johan Hovold
On Wed, Dec 13, 2017 at 08:34:36PM +0800, Jia-Ju Bai wrote: > According to drivers/usb/serial/io_edgeport.c, the driver may sleep > under a spinlock. > The function call path is: > edge_bulk_in_callback (acquire the spinlock) >process_rcvd_data > process_rcvd_status >change_port_s

Re: [PATCH] usbip: fix usbip bind writing random string after command in match_busid

2017-12-14 Thread Juan Zea
> Why not use the return value from snprintf() for length, instead of calling strlen(command)? Yes, that makes sense. Something like this? diff --git a/tools/usb/usbip/src/utils.c b/tools/usb/usbip/src/utils.c index 2b3d6d2..3d7b42e 100644 --- a/tools/usb/usbip/src/utils.c +++ b/tools/usb/usbip/s

Re: [PATCH] USB: serial: qcserial: add Sierra Wireless EM7565

2017-12-14 Thread Reinhard Speyerer
On Mon, Dec 11, 2017 at 09:48:00PM +0100, Bjørn Mork wrote: > Reinhard Speyerer writes: > > > Sierra Wireless EM7565 devices use the DEVICE_SWI layout for their > > serial ports > > > > T: Bus=01 Lev=03 Prnt=29 Port=01 Cnt=02 Dev#= 31 Spd=480 MxCh= 0 > > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=

[PATCH 1/1] usb: serial: option: add support for Telit ME910 PID 0x1101

2017-12-14 Thread Daniele Palmas
This patch adds support for PID 0x1101 of Telit ME910. Signed-off-by: Daniele Palmas --- Following lsusb output for 0x1101 composition tty, tty, tty, rmnet Bus 003 Device 015: ID 1bc7:1101 Telit Wireless Solutions Device Descriptor: bLength18 bDescriptorType 1 bcdU

[PATCH] usb: usbtest: Add TEST 29, toggle sync, Clear toggle between bulk writes

2017-12-14 Thread Mathias Nyman
Clear Feature Endpoint Halt should reset the data toggle even if the endpoint isn't halted. Host should manage to clear the host side data toggle to keep in sync with the device. Test by sending a "3 data packet URB" before and after clearing the halt. this should create a toggle sequence with two

Re: linux-next: Tree for Dec 14 (usb/dwc3)

2017-12-14 Thread Randy Dunlap
On 12/13/2017 11:06 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20171213: > on i386: ERROR: "__tracepoint_dwc3_writel" [drivers/usb/dwc3/dwc3.ko] undefined! ERROR: "__tracepoint_dwc3_readl" [drivers/usb/dwc3/dwc3.ko] undefined! I can send the randconfig file is you need it. --

Re: [bug report] usbip: fix stub_rx: harden CMD_SUBMIT path to handle malicious input

2017-12-14 Thread Shuah Khan
Hi Dan, On 12/14/2017 12:58 AM, Dan Carpenter wrote: > Hello Shuah Khan, > > The patch c6688ef9f297: "usbip: fix stub_rx: harden CMD_SUBMIT path > to handle malicious input" from Dec 7, 2017, leads to the following > static checker warning: > > drivers/usb/usbip/stub_rx.c:346 get_pipe() >

Re: [PATCH] usb: usbtest: Add TEST 29, toggle sync, Clear toggle between bulk writes

2017-12-14 Thread Alan Stern
On Thu, 14 Dec 2017, Mathias Nyman wrote: > Clear Feature Endpoint Halt should reset the data toggle even if the > endpoint isn't halted. Host should manage to clear the host side data > toggle to keep in sync with the device. > > Test by sending a "3 data packet URB" before and after clearing th

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-14 Thread Joe Perches
On Mon, 2017-12-11 at 14:43 -0800, Matthew Wilcox wrote: > - There's no warning for the first paragraph of section 6: > > 6) Functions > > > Functions should be short and sweet, and do just one thing. They should > fit on one or two screenfuls of text (the ISO/ANSI screen size is 8

[PATCH net-next] qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect

2017-12-14 Thread Bjørn Mork
It has been reported that the dummy byte we add to avoid ZLPs can be forwarded by the modem to the PGW/GGSN, and that some operators will drop the connection if this happens. In theory, QMI devices are based on CDC ECM and should as such both support ZLPs and silently ignore the dummy byte. The l

Re: [bug report] usbip: fix stub_rx: harden CMD_SUBMIT path to handle malicious input

2017-12-14 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2017 at 11:01:15AM -0700, Shuah Khan wrote: > Hi Dan, > > On 12/14/2017 12:58 AM, Dan Carpenter wrote: > > Hello Shuah Khan, > > > > The patch c6688ef9f297: "usbip: fix stub_rx: harden CMD_SUBMIT path > > to handle malicious input" from Dec 7, 2017, leads to the following > > stat

Re: [PATCH] usbip: fix usbip bind writing random string after command in match_busid

2017-12-14 Thread Shuah Khan
On 12/14/2017 03:23 AM, Juan Zea wrote: >> Why not use the return value from snprintf() for length, instead of calling > strlen(command)? > > Yes, that makes sense. Something like this? Yes > > diff --git a/tools/usb/usbip/src/utils.c b/tools/usb/usbip/src/utils.c > index 2b3d6d2..3d7b42e 10064

Re: [bug report] usbip: fix stub_rx: harden CMD_SUBMIT path to handle malicious input

2017-12-14 Thread Dan Carpenter
On Thu, Dec 14, 2017 at 11:01:15AM -0700, Shuah Khan wrote: > Hi Dan, > > On 12/14/2017 12:58 AM, Dan Carpenter wrote: > > Hello Shuah Khan, > > > > The patch c6688ef9f297: "usbip: fix stub_rx: harden CMD_SUBMIT path > > to handle malicious input" from Dec 7, 2017, leads to the following > > stat

Re: [PATCH net-next] qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect

2017-12-14 Thread Vamsi Samavedam
On Thu, Dec 14, 2017 at 07:55:50PM +0100, Bjørn Mork wrote: > It has been reported that the dummy byte we add to avoid > ZLPs can be forwarded by the modem to the PGW/GGSN, and that > some operators will drop the connection if this happens. > > In theory, QMI devices are based on CDC ECM and shoul

Re: [PATCH net-next] qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect

2017-12-14 Thread Bjørn Mork
Vamsi Samavedam writes: > On Thu, Dec 14, 2017 at 07:55:50PM +0100, Bjørn Mork wrote: >> It has been reported that the dummy byte we add to avoid >> ZLPs can be forwarded by the modem to the PGW/GGSN, and that >> some operators will drop the connection if this happens. >> >> In theory, QMI devic

[PATCH v2] USB: serial: qcserial: add Sierra Wireless EM7565

2017-12-14 Thread Reinhard Speyerer
Sierra Wireless EM7565 devices use the QCSERIAL_SWI layout for their serial ports T: Bus=01 Lev=03 Prnt=29 Port=01 Cnt=02 Dev#= 31 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=1199 ProdID=9091 Rev= 0.06 S: Manufacturer=Sierra Wireless, Incorporated S:

Re: [bug report] usbip: fix stub_rx: harden CMD_SUBMIT path to handle malicious input

2017-12-14 Thread Shuah Khan
On 12/14/2017 01:16 PM, Dan Carpenter wrote: > On Thu, Dec 14, 2017 at 11:01:15AM -0700, Shuah Khan wrote: >> Hi Dan, >> >> On 12/14/2017 12:58 AM, Dan Carpenter wrote: >>> Hello Shuah Khan, >>> >>> The patch c6688ef9f297: "usbip: fix stub_rx: harden CMD_SUBMIT path >>> to handle malicious input" f

Re: [PATCH v1 2/2] usb: tegra: Move UTMI-pads reset from ehci-tegra to tegra-phy

2017-12-14 Thread Dmitry Osipenko
On 11.12.2017 16:31, Dmitry Osipenko wrote: > On 11.12.2017 13:25, Thierry Reding wrote: >> On Mon, Dec 11, 2017 at 02:07:38AM +0300, Dmitry Osipenko wrote: >>> UTMI pads are shared by USB controllers and reset of UTMI pads is shared >>> with the reset of USB1 controller. Currently reset of UTMI pa

Re: [PATCH v4 08/73] xarray: Add documentation

2017-12-14 Thread Matthew Wilcox
On Mon, Dec 11, 2017 at 03:10:22PM -0800, Randy Dunlap wrote: > > +A freshly-initialised XArray contains a ``NULL`` pointer at every index. > > +Each non-``NULL`` entry in the array has three bits associated with > > +it called tags. Each tag may be flipped on or off independently of > > +the othe