Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-24 Thread Greg KH
On Fri, Nov 24, 2017 at 11:44:02AM +0800, Kai Heng Feng wrote: > > > > On 23 Nov 2017, at 5:24 PM, Greg KH wrote: > > > > On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: > >> > >> What I want to do here is to finding this connection: > >> Realtek r8153 <-> SMSC hub (USD ID: 0424

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-24 Thread Greg KH
On Fri, Nov 24, 2017 at 09:28:05AM +0100, Greg KH wrote: > On Fri, Nov 24, 2017 at 11:44:02AM +0800, Kai Heng Feng wrote: > > > > > > > On 23 Nov 2017, at 5:24 PM, Greg KH wrote: > > > > > > On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: > > >> > > >> What I want to do here is

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-24 Thread Kai Heng Feng
> On 24 Nov 2017, at 4:28 PM, Greg KH wrote: > > The bcdDevice is different between the dock device and the "real" > device, why not use that? Yea, I’ll poke around and see if bcdDevice alone can be a good predicate. > Then there is still a bug. Who as ASMedia is working on this, have they >

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-24 Thread Kai Heng Feng
> Also the MAC address is different, can you just trigger off of Dell's > MAC address space instead of the address space of the dongle device? A really good idea, never thought of this. Thanks for the hint :) Still, I need to ask Dell folks to get all the answers. Kai-Heng -- To unsubscribe fro

[PATCH] USB: gadget: udc: fix spelling mistake "unexpect" -> "unexpected"

2017-11-24 Thread Colin King
From: Colin Ian King Trival fix to spelling mistake in ERR message Signed-off-by: Colin Ian King --- drivers/usb/gadget/udc/fsl_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c index d6

Re: [PATCH v2] typec: fusb302: Use dev_err during probe

2017-11-24 Thread Heikki Krogerus
On Fri, Nov 24, 2017 at 12:03:16AM +0100, Mats Karrman wrote: > If probe fails, fusb302_debugfs_exit is called making it impossible > to view any logs so use normal dev_err for any error messages during > probe. > > Signed-off-by: Mats Karrman Acked-by: Heikki Krogerus Thanks, -- heikki -- T

Re: [PATCH v3] typec: tcpm: fusb302: Resolve out of order messaging events

2017-11-24 Thread Heikki Krogerus
On Tue, Nov 21, 2017 at 02:12:12PM +, Adam Thomson wrote: > The expectation in the FUSB302 driver is that a TX_SUCCESS event > should occur after a message has been sent, but before a GCRCSENT > event is raised to indicate successful receipt of a message from > the partner. However in some circ

Re: usbip port number limits

2017-11-24 Thread Juan Zea
> De: "Yuyang Du" > Para: "Juan Zea" > CC: "Shuah Khan" , sh...@kernel.org, "Bjørn Mork" > , linux-usb@vger.kernel.org, "Valentina Manea" > > Enviados: Viernes, 24 de Noviembre 2017 8:22:44 > Asunto: Re: usbip port number limits > > On Wed, Nov 22, 2017 at 09:38:27AM +0100, Juan Zea wrote: >

Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-24 Thread Heikki Krogerus
Hi, On Tue, Nov 14, 2017 at 11:44:47AM +, Adam Thomson wrote: > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index 78983e1..7c26c3d 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#incl

[PATCH] USB: atm: use setup_timer instead of init_timer

2017-11-24 Thread Colin King
From: Colin Ian King Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Colin Ian King --- drivers/usb/atm/usbatm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c

4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
Hello, I'm triggering a reproducible panic using a DWC3 in gadget mode (intel edison board). Built kernel is a 4.14 with all patches from Andy Shevchenko's tree for the edison (including ones to the dwc3 to skip EP1 & 8). It is available here: https://github.com/vpelletier/linux/tree/eds_4.14 T

RE: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-24 Thread Adam Thomson
On 24 November 2017 12:19, Heikki Krogerus wrote: > Hi, > > On Tue, Nov 14, 2017 at 11:44:47AM +, Adam Thomson wrote: > > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > > index 78983e1..7c26c3d 100644 > > --- a/drivers/usb/typec/tcpm.c > > +++ b/drivers/usb/typec/tcpm.c >

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Felipe Balbi
Hi, Vincent Pelletier writes: > Hello, > > I'm triggering a reproducible panic using a DWC3 in gadget mode > (intel edison board). Built kernel is a 4.14 with all patches from > Andy Shevchenko's tree for the edison (including ones to the dwc3 to > skip EP1 & 8). It is available here: > https:

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
On Fri, 24 Nov 2017 16:10:17 +0200, Felipe Balbi wrote: > $ gdb vmlinux > (gdb) l *(dwc3_gadget_ep_dequeue + 0x14c) > > > what does that give you? Note: this is a different debugging session, different traceback, but same kernel. $ gdb ./vmlinux [...] (gdb) target remote /dev/ttyUSB0 [...] (gd

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Felipe Balbi
Hi, Vincent Pelletier writes: > On Fri, 24 Nov 2017 16:10:17 +0200, Felipe Balbi > wrote: >> $ gdb vmlinux >> (gdb) l *(dwc3_gadget_ep_dequeue + 0x14c) >> >> >> what does that give you? > > Note: this is a different debugging session, different traceback, but > same kernel. > > $ gdb ./vmlinu

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
On Fri, 24 Nov 2017 16:45:53 +0200, Felipe Balbi wrote: > no, it's not. This is because of our call to wait_event_lock_irq() in > dwc3_gadget_ep_dequeue(). That call works fine in all other cases > because dequeue is never called with IRQs disabled, apart from this one > case in f_fs.c :-) > > Ca

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
On Fri, 24 Nov 2017 15:10:55 +, Vincent Pelletier wrote: > It sadly does not help, though it does something: now serial output > stops early (tried twice, happened twice): > > [ 103.274725] BUG: scheduling while atomic: swapper/1/0/0x0100 > [ 103.280990] 3 locks held by swapper/1/0: > [

Re: [PATCH] [stable only]USB: fix buffer overflows with parsing CDC headers

2017-11-24 Thread Greg KH
On Thu, Nov 23, 2017 at 04:20:05PM +0100, Oliver Neukum wrote: > Parsing CDC headers a buffer overflow cannot just be prevented > by checking that the remainder of the buffer is longer than minimum > length. The size of the fields to be parsed must be figured in, too. > > In newer kernels this iss

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
On Fri, 24 Nov 2017 15:55:02 +, Vincent Pelletier wrote: > write(6, "bla\n", 4)= -1 EINTR (Interrupted system call) > --- SIGQUIT {si_signo=SIGQUIT, si_code=SI_USER, si_pid=1931, si_uid=1000} --- I discovered this is not the whole truth: it is not the interruption itself w

Re: [RFC v2] Add support for Sony PS2 OHCI

2017-11-24 Thread Fredrik Noring
Thank you for your review, Alan Stern, > > With the patch above, the kernel successfully detects USB mass storage > > devices. However, it also causes another crash: > > > > [ cut here ] > > WARNING: CPU: 0 PID: 15 at ./include/linux/dma-mapping.h:530 > > hcd_buff

[PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

2017-11-24 Thread Dave Young
This mouse keep disconnecting in runleve 3 like below, add it needs the quirk to mute the anoying messages. [ 111.230555] usb 2-2: USB disconnect, device number 6 [ 112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd [ 112.941594] usb 2-2: New USB device found, idVendor=03f0,