Hi,
I am trying to support suspend to disk(hibernate) on Hikey with 4.4
kernel. During suspend, I could see the usb devices getting reset and I
can access them properly. Message can be seen as below:
usb 1-1: reset high-speed USB device number 2 using dwc2
usb 1-1.2: reset high-speed USB device n
Hi,
Ran Wang writes:
> Adds entry point at dwc3 core init function to enable
> USB 3.0 PHY driver.
>
> Signed-off-by: Ran Wang
> ---
> Change in v2:
> - New file
>
> drivers/usb/dwc3/core.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.c
From: Kuninori Morimoto
We already have renesas_usbhs_get_info() macro.
Let's use it.
Signed-off-by: Kuninori Morimoto
---
Shimoda-san
can you please check this patch ?
drivers/usb/renesas_usbhs/common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/ren
USB devices should work just fine when they don't support language id.
Lower the log level so user won't panic in the future.
BugLink: https://bugs.launchpad.net/bugs/1729618
Signed-off-by: Kai-Heng Feng
---
drivers/usb/core/message.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Tue, Nov 07, 2017 at 03:58:29AM -0500, Kai-Heng Feng wrote:
> USB devices should work just fine when they don't support language id.
They still work, but it's a "broken" device, and it should be fixed (I
thought it was part of the spec, but I can't find it right now...)
> Lower the log level s
Hi,
> From: Greg Kroah-Hartman, Sent: Monday, November 6, 2017 11:37 PM
>
> Now that the SPDX tag is in all USB files, that identifies the license
> in a specific and legally-defined manner. So the extra GPL text wording
> can be removed as it is no longer needed at all.
>
> This is done on a q
Hi,
> From: Greg Kroah-Hartman, Sent: Tuesday, November 7, 2017 12:34 AM
>
> These files somehow never got an SPDX tag added to them, maybe due to
> the small size. So provide the default identifier of the whole project:
> SPDX-License-Identifier: GPL-2.0
>
> The SPDX identifier is a lega
Hi Alan,
在 2017年11月07日 03:17, Alan Stern 写道:
On Mon, 6 Nov 2017, wlf wrote:
Hi Minas,
在 2017年11月06日 17:28, Minas Harutyunyan 写道:
Hi,
On 11/6/2017 12:46 PM, William Wu wrote:
The actual_length in dwc2_hcd_urb structure is used
to indicate the total data length transferred so far,
but in dwc
From: Colin Ian King
The variable temp is being set at the end of each loop iteration
but this value is never read, it is either being updated in just
the case 1 block or at the end of the loop. Thus the assignment
is redundant and can be removed. Cleans up clang warning:
drivers/usb/host/ehci
On Mon, Nov 06, 2017 at 04:34:11PM +0100, Greg Kroah-Hartman wrote:
> Due to these typec files being moved into the drivers/usb/ directory in
> this tree, they missed the larger "add SPDX tags to all files" work. So
> add the correct SPDX license tag, based on the license text in the file
> itself
On Mon, Nov 06, 2017 at 04:34:12PM +0100, Greg Kroah-Hartman wrote:
> Now that the SPDX tag is in all USB files, that identifies the license
> in a specific and legally-defined manner. So the extra GPL text wording
> can be removed as it is no longer needed at all.
>
> This is done on a quest to
This gets rid of the deprecated do_gettimeofday() function in usbip.
The comment above vgadget_get_frame() mentions that it suffers
from issues with the time jumps due to suspend and settimeofday,
so I'm changing it to use ktime_get_ts64() to use monotonic times
that don't have this problem.
I cou
Hi Morimoto-san,
> From: Kuninori Morimoto, Sent: Tuesday, November 7, 2017 5:26 PM
>
> From: Kuninori Morimoto
>
> We already have renesas_usbhs_get_info() macro.
> Let's use it.
>
> Signed-off-by: Kuninori Morimoto
> ---
> Shimoda-san
>
> can you please check this patch ?
Thank you for th
vgadget_get_frame returns a frame number from 0 to 2046, which
may require an expensive division operation to wrap at one lower
than the usual number.
I can't see any reason for this, and all other drivers wrap at
a power-of-two number. My best explanation is that it was a simple
typo, so I'm chan
On Mon, Nov 06, 2017 at 04:34:07PM +0100, Greg Kroah-Hartman wrote:
> It's good to have SPDX identifiers in all files to make it easier to
> audit the kernel tree for correct licenses.
>
> This updates the remaining drivers/usb/*Makefile* that were missing SPDX
> identifiers. They all get the fol
On Sat, Nov 04, 2017 at 12:22:12PM -0700, Badhri Jagan Sridharan wrote:
> The source and sink caps should follow the following rules.
> This patch validates whether the src_caps/snk_caps adheres
> to it.
>
> 6.4.1 Capabilities Message
> A Capabilities message (Source Capabilities message or Sink
>
Hi Mathias,
Does this patch look okay to you?
Regards,
Biju
> -Original Message-
> From: Yoshihiro Shimoda
> Sent: 17 October 2017 02:34
> To: Biju Das ; Greg Kroah-Hartman
> ; Felipe Balbi ; Rob Herring
> ; Mark Rutland ; Mathias
> Nyman
> Cc: Simon Horman ; Magnus Damm
> ; Chris Pater
On 11/07/2017 11:39 AM, Arnd Bergmann wrote:
vgadget_get_frame returns a frame number from 0 to 2046, which
may require an expensive division operation to wrap at one lower
than the usual number.
I can't see any reason for this, and all other drivers wrap at
a power-of-two number. My best expl
On 11/07/2017 11:39 AM, Arnd Bergmann wrote:
This gets rid of the deprecated do_gettimeofday() function in usbip.
The comment above vgadget_get_frame() mentions that it suffers
from issues with the time jumps due to suspend and settimeofday,
so I'm changing it to use ktime_get_ts64() to use mon
On 06.11.2017 16:37, Greg Kroah-Hartman wrote:
Now that the SPDX tag is in all USB files, that identifies the license
in a specific and legally-defined manner. So the extra GPL text wording
can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different way
On 06.11.2017 17:34, Greg Kroah-Hartman wrote:
The license text was removed from these files, yet they somehow missed
the big "add SPDX tags to all files" sweep due to them being new. So
add the proper SPDX license tag to them, based on the original license
text in the file.
Cc: Mathias Nyman
Hi,
On Mon 06 Nov 2017 at 15:34, Greg Kroah-Hartman
wrote:
> Due to these typec files being moved into the drivers/usb/ directory in
> this tree, they missed the larger "add SPDX tags to all files" work. So
> add the correct SPDX license tag, based on the license text in the file
> itself.
>
> Th
Hi,
On Mon 06 Nov 2017 at 15:34, Greg Kroah-Hartman
wrote:
> Now that the SPDX tag is in all USB files, that identifies the license
> in a specific and legally-defined manner. So the extra GPL text wording
> can be removed as it is no longer needed at all.
>
> This is done on a quest to remove th
Hi Ruslan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.14-rc8 next-20171107]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
From: Colin Ian King
Variable minor is being assigned but never read, hence it is redundant
and can be removed. Cleans up clang warning:
drivers/usb/misc/adutux.c:770:2: warning: Value stored to 'minor' is
never read
Signed-off-by: Colin Ian King
---
drivers/usb/misc/adutux.c | 2 --
1 file c
On Sat, Nov 04, 2017 at 12:22:13PM -0700, Badhri Jagan Sridharan wrote:
> At present, TCPM code assumes that local device supports
> variable/batt pdos and always selects the pdo with highest
> possible power within the board limit. This assumption
> might not hold good for all devices. To overcome
From: Colin Ian King
Variable index is being initialized and the value is never read,
it is being updated a few statements later, so remove the redundant
initialization. Variable total is being updated but the value is
never read, so this is also redundant and can be removed. Cleans
up two clang
When we receive a packet on a QMI device in raw IP mode, we should call
skb_reset_mac_header() to ensure that skb->mac_header contains a valid
offset in the packet. While it shouldn't really matter, the packets have
no MAC header and the interface is configured as-such, it seems certain
parts of th
Kristian Evensen writes:
> When we receive a packet on a QMI device in raw IP mode, we should call
> skb_reset_mac_header() to ensure that skb->mac_header contains a valid
> offset in the packet. While it shouldn't really matter, the packets have
> no MAC header and the interface is configured as
Hi Ruslan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.14-rc8 next-20171107]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
On 07.11.2017 13:00, Biju Das wrote:
Hi Mathias,
Does this patch look okay to you?
Yes, Adding to queue, Will send out after rc1
Thanks
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info
From: Colin Ian King
Variable is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed. Cleans up clang warning:
drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored
to 'dev' is never read
Sign
On 07/11/17 14:31, Colin King wrote:
> From: Colin Ian King
>
> Variable is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed. Cleans up clang warning:
>
> drivers/usb/gadget/udc/pxa27x_udc.c:1141:2:
Hei,
On Tue, Nov 7, 2017 at 2:02 PM, Bjørn Mork wrote:
> And his should probably go to stable as well? with a
>
> Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode")
Yes, I forgot to add the fixes-tag + comment about stable. Should I submit a v2?
-Kristian
--
To unsubscribe from this l
On 07.11.2017 04:01, Yu Chen wrote:
From: Yu Chen
Check vdev->real_port 0 to avoid panic
[9.261347] []
xhci_free_virt_devices_depth_first+0x58/0x108
[9.261352] [] xhci_mem_cleanup+0x1bc/0x570
[9.261355] [] xhci_stop+0x140/0x1c8
[9.261365] [] usb_remove_hcd+0xfc/0x1d0
[9.261
On Tue, Nov 07, 2017 at 01:31:52PM +0200, Mathias Nyman wrote:
> On 06.11.2017 16:37, Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as it is no long
On Tue, Nov 07, 2017 at 09:35:03AM +0800, Peter Chen wrote:
> On Mon, Nov 06, 2017 at 03:37:18PM +0100, Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be remove
On Mon, Nov 06, 2017 at 04:46:42PM +0200, Felipe Balbi wrote:
> Greg Kroah-Hartman writes:
>
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as it is no longer needed at all.
On Mon, Nov 06, 2017 at 01:36:15PM -0500, Alan Stern wrote:
> On Mon, 6 Nov 2017, Greg Kroah-Hartman wrote:
>
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as it is no longe
From: Colin Ian King
Variable is_short is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed. Pointer dev is assigned a value that
is not read and it is updated a few statements later, this too is
redunda
On Mon, Nov 06, 2017 at 04:51:48PM +0200, Heikki Krogerus wrote:
> On Mon, Nov 06, 2017 at 03:37:14PM +0100, Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be r
On Mon, Nov 06, 2017 at 04:55:06PM +0100, Michal Nazarewicz wrote:
> On Mon, Nov 06 2017, Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as it is no
On Tue, Nov 07, 2017 at 09:00:46AM +0200, Laurent Pinchart wrote:
> Hi Greg,
>
> Thank you for the patch.
>
> On Monday, 6 November 2017 16:37:30 EET Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner.
On Mon, Nov 06, 2017 at 08:41:20AM -0700, Shuah Khan wrote:
> On 11/06/2017 07:37 AM, Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as it is no long
On Mon, Nov 06, 2017 at 09:59:42AM -0600, Bin Liu wrote:
> On Mon, Nov 06, 2017 at 03:37:15PM +0100, Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed a
On Mon, Nov 06, 2017 at 11:05:44PM +, Vincent Pelletier wrote:
> On Mon, 6 Nov 2017 15:37:32 +0100, Greg Kroah-Hartman
> wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be re
On Tue, Nov 07, 2017 at 10:39:30AM +0800, Lu Baolu wrote:
> Hi,
>
> On 11/06/2017 10:37 PM, Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as it is
On Tue, Nov 07, 2017 at 09:55:03AM +0800, Chunfeng Yun wrote:
> On Mon, 2017-11-06 at 15:37 +0100, Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as
On Tue, Nov 07, 2017 at 09:19:25AM +, Yoshihiro Shimoda wrote:
> Hi,
>
> > From: Greg Kroah-Hartman, Sent: Monday, November 6, 2017 11:37 PM
> >
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text word
On Mon, Nov 06, 2017 at 03:50:31PM +0100, Nicolas Ferre wrote:
> On 06/11/2017 at 15:37, Greg Kroah-Hartman wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as it is no l
On Tue, Nov 07, 2017 at 08:15:50AM +0100, Robert Jarzmik wrote:
> Greg Kroah-Hartman writes:
>
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as it is no longer needed at al
On Mon, Nov 06, 2017 at 03:12:24PM -0600, Li Yang wrote:
> On Mon, Nov 6, 2017 at 8:37 AM, Greg Kroah-Hartman
> wrote:
> > Now that the SPDX tag is in all USB files, that identifies the license
> > in a specific and legally-defined manner. So the extra GPL text wording
> > can be removed as it is
On Thu, Nov 02, 2017 at 10:57:37AM +0200, Felipe Balbi wrote:
> Hi,
>
> Here's the new revision of PTM status support patches with the changes
> requested by Alan Stern.
>
> Changes since v1:
> - move code around to avoid two changes to all users of
> usb_get_status()
Now applied,
On Tue, Nov 07, 2017 at 11:32:07AM +, Rui Miguel Silva wrote:
> Hi,
> On Mon 06 Nov 2017 at 15:34, Greg Kroah-Hartman
> wrote:
> > Due to these typec files being moved into the drivers/usb/ directory in
> > this tree, they missed the larger "add SPDX tags to all files" work. So
> > add the co
On Tue, Nov 07, 2017 at 09:36:48AM +0800, Peter Chen wrote:
> On Mon, Nov 06, 2017 at 04:34:09PM +0100, Greg Kroah-Hartman wrote:
> > The license text was removed from this file, yet they somehow missed
> > the big "add SPDX tags to all files" sweep due to them being new. So
> > add the proper SPD
On Tue, 7 Nov 2017, wlf wrote:
> > That sounds like a good idea. Minas, does the following patch fix your
> > problem?
> >
> > In theory we could do this calculation for every isochronous URB, not
> > just those coming from usbfs. But I don't think there's any point,
> > since the USB class dri
On Tue, 7 Nov 2017, Greg KH wrote:
> On Tue, Nov 07, 2017 at 03:58:29AM -0500, Kai-Heng Feng wrote:
> > USB devices should work just fine when they don't support language id.
>
> They still work, but it's a "broken" device, and it should be fixed (I
> thought it was part of the spec, but I can't
On 06 November 2017 13:26, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Nov 01, 2017 at 05:03:13PM +, Adam Thomson wrote:
> > This adds a type to represent USB PPS chargers as defined in the
> > USB Power Delivery Specification Revision 3.0 V1.1
> >
> > Signed-off-by: Adam Thomson
>
> Reviewe
On Tue, 7 Nov 2017, Colin King wrote:
> From: Colin Ian King
>
> The variable temp is being set at the end of each loop iteration
> but this value is never read, it is either being updated in just
> the case 1 block or at the end of the loop. Thus the assignment
> is redundant and can be remove
On Mon, Nov 6, 2017 at 6:01 PM, Yu Chen wrote:
> From: Yu Chen
>
> Check vdev->real_port 0 to avoid panic
> [9.261347] []
> xhci_free_virt_devices_depth_first+0x58/0x108
> [9.261352] [] xhci_mem_cleanup+0x1bc/0x570
> [9.261355] [] xhci_stop+0x140/0x1c8
> [9.261365] [] usb_remove_
On Tue, 7 Nov 2017, Ivid Suvarna wrote:
> Hi,
>
> I am trying to support suspend to disk(hibernate) on Hikey with 4.4
> kernel. During suspend, I could see the usb devices getting reset and I
> can access them properly. Message can be seen as below:
>
> usb 1-1: reset high-speed USB device numbe
On Tue, Nov 07, 2017 at 08:11:13AM -0800, syzbot wrote:
> Hello,
>
> syzkaller hit the following crash on
> 36ef71cae353f88fd6e095e2aaa3e5953af1685d
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master
> compiler: gcc (GCC) 7.1.1 20170620
> .config is attached
> Raw console o
From: Colin Ian King
The variable temp is incorrectly being updated, instead it should
be offset otherwise the loop just reads the same capability value
and loops forever. Thanks to Alan Stern for pointing out the
correct fix to my original fix. Fix also cleans up clang warning:
drivers/usb/ho
On 07/11/17 15:42, Alan Stern wrote:
> On Tue, 7 Nov 2017, Colin King wrote:
>
>> From: Colin Ian King
>>
>> The variable temp is being set at the end of each loop iteration
>> but this value is never read, it is either being updated in just
>> the case 1 block or at the end of the loop. Thus th
On Tue, 7 Nov 2017, Colin King wrote:
> From: Colin Ian King
>
> The variable temp is incorrectly being updated, instead it should
> be offset otherwise the loop just reads the same capability value
> and loops forever. Thanks to Alan Stern for pointing out the
> correct fix to my original fix.
On Tue, 7 Nov 2017, Greg KH wrote:
> On Tue, Nov 07, 2017 at 08:11:13AM -0800, syzbot wrote:
> > Hello,
> >
> > syzkaller hit the following crash on
> > 36ef71cae353f88fd6e095e2aaa3e5953af1685d
> > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master
> > compiler: gcc (GCC) 7.
Colin King writes:
> From: Colin Ian King
>
> Variable is_short is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed. Pointer dev is assigned a value that
> is not read and it is updated a few state
On 11/07/2017 04:21 AM, Krzysztof Opasiak wrote:
>
>
> On 11/07/2017 11:39 AM, Arnd Bergmann wrote:
>> vgadget_get_frame returns a frame number from 0 to 2046, which
>> may require an expensive division operation to wrap at one lower
>> than the usual number.
>>
>> I can't see any reason for this
On 11/07/2017 04:22 AM, Krzysztof Opasiak wrote:
>
>
> On 11/07/2017 11:39 AM, Arnd Bergmann wrote:
>> This gets rid of the deprecated do_gettimeofday() function in usbip.
>> The comment above vgadget_get_frame() mentions that it suffers
>> from issues with the time jumps due to suspend and setti
Hi Alan,
在 2017年11月07日 23:18, Alan Stern 写道:
On Tue, 7 Nov 2017, wlf wrote:
That sounds like a good idea. Minas, does the following patch fix your
problem?
In theory we could do this calculation for every isochronous URB, not
just those coming from usbfs. But I don't think there's any point
From: Bjørn Mork
Date: Mon, 6 Nov 2017 15:37:22 +0100
> Setting dev->hard_mtu to 0 will cause a divide error in
> usbnet_probe. Protect against devices with bogus CDC Ethernet
> functional descriptors by ignoring a zero wMaxSegmentSize.
>
> Signed-off-by: Bjørn Mork
Applied and queued up for
From: Bjørn Mork
Date: Mon, 6 Nov 2017 15:32:18 +0100
> A CDC Ethernet functional descriptor with wMaxSegmentSize = 0 will
> cause a divide error in usbnet_probe:
>
> divide error: [#1] PREEMPT SMP KASAN
...
> Fix by simply ignoring the bogus descriptor, as it is optional
> for QMI device
From: Kristian Evensen
Date: Tue, 7 Nov 2017 13:47:56 +0100
> When we receive a packet on a QMI device in raw IP mode, we should call
> skb_reset_mac_header() to ensure that skb->mac_header contains a valid
> offset in the packet. While it shouldn't really matter, the packets have
> no MAC heade
73 matches
Mail list logo
