Re: [PATCH] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Greg KH
On Mon, Nov 06, 2017 at 11:28:55AM +0800, Yu Chen wrote: > From: Yu Chen > > Check vdev->real_port 0 to avoid panic > [9.261347] [] > xhci_free_virt_devices_depth_first+0x58/0x108 > [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 > [9.261355] [] xhci_stop+0x140/0x1c8 > [9.261365] [] u

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

2017-11-06 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 08:35:41AM +0800, Lu Baolu wrote: > Hi, > > On 11/03/2017 02:27 PM, Greg Kroah-Hartman wrote: > > On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: > >> Hi, > >> > >> On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: > >>> On Thu, Nov 02, 2017 at 12:38:57PM +0200, F

Re: [PATCH] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
On 2017/11/6 15:59, Greg KH wrote: >> >> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c >> index 2a82c927ded2..295789d993b0 100644 >> --- a/drivers/usb/host/xhci-mem.c >> +++ b/drivers/usb/host/xhci-mem.c >> @@ -947,6 +947,11 @@ void xhci_free_virt_devices_depth_first(stru

Re: [1/2] mm: drop migrate type checks from has_unmovable_pages

2017-11-06 Thread Michal Hocko
t; Since the patch wasn't accepted, i want to know is there another solution? The patch should be in next-20171106 -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-06 Thread Greg Kroah-Hartman
On Sun, Nov 05, 2017 at 04:39:22PM +0100, Philippe Ombredanne wrote: > On Sun, Nov 5, 2017 at 2:51 PM, Greg Kroah-Hartman > wrote: > > On Sun, Nov 05, 2017 at 01:53:54PM +0100, Philippe Ombredanne wrote: > >> On Sat, Nov 4, 2017 at 11:40 AM, Greg Kroah-Hartman > >> wrote: > >> > On Fri, Nov 03, 2

[PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Yu Chen
From: Yu Chen Check vdev->real_port 0 to avoid panic [9.261347] [] xhci_free_virt_devices_depth_first+0x58/0x108 [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 [9.261355] [] xhci_stop+0x140/0x1c8 [9.261365] [] usb_remove_hcd+0xfc/0x1d0 [9.261369] [] xhci_plat_remove+0x6c/0xa8 [

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Greg KH
On Mon, Nov 06, 2017 at 04:20:23PM +0800, Yu Chen wrote: > From: Yu Chen > > Check vdev->real_port 0 to avoid panic > [9.261347] [] > xhci_free_virt_devices_depth_first+0x58/0x108 > [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 > [9.261355] [] xhci_stop+0x140/0x1c8 > [9.261365] [] u

[PATCH] usb: dwc2: host: fix isoc urb actual length

2017-11-06 Thread William Wu
The actual_length in dwc2_hcd_urb structure is used to indicate the total data length transferred so far, but in dwc2_update_isoc_urb_state(), it just updates the actual_length of isoc frame, and don't update the urb actual_length at the same time, this will cause device drivers working error which

Re: [1/2] mm: drop migrate type checks from has_unmovable_pages

2017-11-06 Thread Stefan Wahren
issue. > Thanks for your testing. Can I assume your Tested-by? Yes > >> Since the patch wasn't accepted, i want to know is there another solution? > The patch should be in next-20171106 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

RE: stopping and starting a functionfs USB-device causes panic

2017-11-06 Thread Felipe Balbi
Hi, andy_purc...@keysight.com writes: > Hello Felipe, > >> > >> > I have a second issue with a functionfs USB-device implementation. >> > >> > The scenario is this: >> > 1) USB-device app starts up, runs fine >> > 2) ssh to the device, kill the app with CTRL-C >> > 3) try to start the USB-device

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

2017-11-06 Thread Minas Harutyunyan
Hi, On 11/6/2017 12:46 PM, William Wu wrote: > The actual_length in dwc2_hcd_urb structure is used > to indicate the total data length transferred so far, > but in dwc2_update_isoc_urb_state(), it just updates > the actual_length of isoc frame, and don't update the > urb actual_length at the same

RE: [PATCH] usb: gadget: udc: renesas_usb3: make const array max_packet_array static

2017-11-06 Thread Yoshihiro Shimoda
Hi Colin, > From: Colin King, Sent: Friday, November 3, 2017 12:53 AM > > From: Colin Ian King > > Don't populate the const array max_packet_array on the stack, instead make > it static. Makes the object code smaller by over 90 bytes: > > Before: >text data bss dec hex

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Oliver Neukum
Am Donnerstag, den 02.11.2017, 21:26 +0100 schrieb Andrey Konovalov: > When asix_suspend() is called dev->driver_priv might not have been > assigned a value, so we need to check that it's not NULL. > > Found by syzkaller. Hi, 1. if that happens on suspend, it will also happen on resume 2. Will a

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
Hi, On 2017/11/6 16:31, Greg KH wrote: > On Mon, Nov 06, 2017 at 04:20:23PM +0800, Yu Chen wrote: >> From: Yu Chen >> >> Check vdev->real_port 0 to avoid panic >> [9.261347] [] >> xhci_free_virt_devices_depth_first+0x58/0x108 >> [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 >> [9.261355

Lenovo Professional Keyboard not working

2017-11-06 Thread David Demelier
Hello, I have a Lenovo Professional Keyboard combo which is not working on Linux because it sends an extra byte (0x71) for each key. Some people explains the situation in the followings links: https://forums.lenovo.com/t5/Linux-Discussion/Professional-Wireless-Keyboard-not-working-on-Linux/td-p

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

2017-11-06 Thread wlf
Hi Minas, 在 2017年11月06日 17:28, Minas Harutyunyan 写道: Hi, On 11/6/2017 12:46 PM, William Wu wrote: The actual_length in dwc2_hcd_urb structure is used to indicate the total data length transferred so far, but in dwc2_update_isoc_urb_state(), it just updates the actual_length of isoc frame, and

Re: Lenovo Professional Keyboard not working

2017-11-06 Thread Oliver Neukum
Am Montag, den 06.11.2017, 11:07 +0100 schrieb David Demelier: > Hello, I have a Lenovo Professional Keyboard combo which is not working on > Linux because it sends an extra byte (0x71) for each key. Some people > explains the situation in the followings links: > > https://forums.lenovo.com/t5/

Re: RFC: AMD UDC Controller driver update

2017-11-06 Thread Felipe Balbi
(please, always Cc linux-usb) Raveendra Padasalagi writes: > Hi Felipe, > > The driver present at location: drivers/usb/gadget/udc/snps_udc_core.c > handles Synopsys UDC controller implementation and it's currently used by > AMD SoC's. > > In Broadcom SoC's we use same Synopsys UDC Controller on

Re: dwc2/dwc_otg drivers

2017-11-06 Thread Felipe Balbi
Hi, (please, always Cc linux-usb) Billy Araujo writes: > I saw your contact on Linkedin and it seems you are specialist USB drivers > for Linux. I I am having an issue dwc2 driver generating lots of interrupts > 8000 /sec and was wondering if you could give me with some advice on that. sounds

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Greg KH
On Mon, Nov 06, 2017 at 06:03:08PM +0800, Chen Yu wrote: > Hi, > > On 2017/11/6 16:31, Greg KH wrote: > > On Mon, Nov 06, 2017 at 04:20:23PM +0800, Yu Chen wrote: > >> From: Yu Chen > >> > >> Check vdev->real_port 0 to avoid panic > >> [9.261347] [] > >> xhci_free_virt_devices_depth_first+0x

[PATCH v2] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Andrey Konovalov
When asix_suspend() is called dev->driver_priv might not have been assigned a value, so we need to check that it's not NULL. Similar issue is present in asix_resume(), this patch fixes it as well. Found by syzkaller. kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

2017-11-06 Thread Minas Harutyunyan
Hi William, On 11/6/2017 2:08 PM, wlf wrote: > Hi Minas, > > 在 2017年11月06日 17:28, Minas Harutyunyan 写道: >> Hi, >> >> On 11/6/2017 12:46 PM, William Wu wrote: >>> The actual_length in dwc2_hcd_urb structure is used >>> to indicate the total data length transferred so far, >>> but in dwc2_update_is

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Andrey Konovalov
On Mon, Nov 6, 2017 at 10:49 AM, Oliver Neukum wrote: > Am Donnerstag, den 02.11.2017, 21:26 +0100 schrieb Andrey Konovalov: >> When asix_suspend() is called dev->driver_priv might not have been >> assigned a value, so we need to check that it's not NULL. >> >> Found by syzkaller. > > Hi, Hi Oliv

Re: dwc2/dwc_otg drivers

2017-11-06 Thread Minas Harutyunyan
Hi Billy, On 11/6/2017 2:45 PM, Felipe Balbi wrote: > > Hi, > > (please, always Cc linux-usb) > > Billy Araujo writes: >> I saw your contact on Linkedin and it seems you are specialist USB drivers >> for Linux. I I am having an issue dwc2 driver generating lots of interrupts >> 8000 /sec and w

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
On 2017/11/6 19:32, Greg KH wrote: >> A simple process is as below: >> xhci_plat_probe() >>| >> usb_add_hcd() xhci_plat_remove() >> || >> find some device

Re: [RFC PATCH 5/7] power: supply: Add type for USB PD PPS chargers

2017-11-06 Thread Sebastian Reichel
Hi, On Wed, Nov 01, 2017 at 05:03:13PM +, Adam Thomson wrote: > This adds a type to represent USB PPS chargers as defined in the > USB Power Delivery Specification Revision 3.0 V1.1 > > Signed-off-by: Adam Thomson Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/supply/power_

usb/net/qmi_wwan: divide error in qmi_wwan_probe/usbnet_probe

2017-11-06 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 39dae59d66acd86d1de24294bd2f343fd5e7a625 (4.14-rc8). qmi_wwan 1-1:0.4: cdc-wdm0: USB WDM device divide error: [#1] PREEMPT SMP KASAN Modules linked in: CPU: 0 PID: 24 Comm: kworker/0:1 Not tainted 4.14.0-rc

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Mathias Nyman
On 06.11.2017 14:36, Chen Yu wrote: On 2017/11/6 19:32, Greg KH wrote: A simple process is as below: xhci_plat_probe() | usb_add_hcd() xhci_plat_remove() ||

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Guenter Roeck
On Mon, Nov 6, 2017 at 6:00 AM, Mathias Nyman wrote: > On 06.11.2017 14:36, Chen Yu wrote: >> >> >> >> On 2017/11/6 19:32, Greg KH wrote: A simple process is as below: xhci_plat_probe() | usb_add_hcd() xhci_plat_remove()

Re: usb/net/qmi_wwan: divide error in qmi_wwan_probe/usbnet_probe

2017-11-06 Thread Bjørn Mork
Andrey Konovalov writes: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. Thanks. It would have helped a lot of you said *what* you were fuzzing, though But based on where the bug is, I assume it is USB descriptors? > On commit 39dae59d66acd86d1de24294bd2f3

[PATCH net,stable] net: qmi_wwan: fix divide by 0 on bad descriptors

2017-11-06 Thread Bjørn Mork
A CDC Ethernet functional descriptor with wMaxSegmentSize = 0 will cause a divide error in usbnet_probe: divide error: [#1] PREEMPT SMP KASAN Modules linked in: CPU: 0 PID: 24 Comm: kworker/0:1 Not tainted 4.14.0-rc8-44453-g1fdc1a82c34f #56 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996

[PATCH 02/24] USB: usbip: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH net,stable] net: cdc_ether: fix divide by 0 on bad descriptors

2017-11-06 Thread Bjørn Mork
Setting dev->hard_mtu to 0 will cause a divide error in usbnet_probe. Protect against devices with bogus CDC Ethernet functional descriptors by ignoring a zero wMaxSegmentSize. Signed-off-by: Bjørn Mork --- I believe the problem found by syzcaller in qmi_wwan also applies to cdc_ether. We cannot

[PATCH 11/24] USB: dwc2: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 01/24] USB: wusbcore: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 13/24] USB: early: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 14/24] USB: host: xhci: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 16/24] USB: host: ohci: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 12/24] USB: c67x00: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 20/24] USB: host: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 15/24] USB: host: whci: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 18/24] USB: host: fhci: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 17/24] USB: host: ehci: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 19/24] USB: host: imx21: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 04/24] USB: phy: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 07/24] USB: mtu3: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 05/24] USB: typec: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 08/24] USB: isp1760: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 06/24] USB: musb: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 09/24] USB: chipidea: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 24/24] USB: gadget: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 10/24] USB: dwc3: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 23/24] USB: gadget: function: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 22/24] USB: gadget: udc: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 21/24] USB: gadget: legacy: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 03/24] USB: renesas_usbhs: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

Re: [PATCH net,stable] net: cdc_ether: fix divide by 0 on bad descriptors

2017-11-06 Thread Oliver Neukum
Am Montag, den 06.11.2017, 15:37 +0100 schrieb Bjørn Mork : > Setting dev->hard_mtu to 0 will cause a divide error in > usbnet_probe. Protect against devices with bogus CDC Ethernet > functional descriptors by ignoring a zero wMaxSegmentSize. > > Signed-off-by: Bjørn Mork Acked-by: Oliver Neukum

Re: [PATCH 03/24] USB: renesas_usbhs: Remove redundant license text

2017-11-06 Thread Felipe Balbi
Greg Kroah-Hartman writes: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that file

Re: [PATCH 04/24] USB: phy: Remove redundant license text

2017-11-06 Thread Felipe Balbi
Greg Kroah-Hartman writes: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that file

Re: [PATCH 10/24] USB: dwc3: Remove redundant license text

2017-11-06 Thread Felipe Balbi
Greg Kroah-Hartman writes: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that file

Re: [PATCH 21/24] USB: gadget: legacy: Remove redundant license text

2017-11-06 Thread Felipe Balbi
Greg Kroah-Hartman writes: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that file

Re: [PATCH 22/24] USB: gadget: udc: Remove redundant license text

2017-11-06 Thread Felipe Balbi
Greg Kroah-Hartman writes: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that file

Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text

2017-11-06 Thread Felipe Balbi
Greg Kroah-Hartman writes: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that file

Re: [PATCH 22/24] USB: gadget: udc: Remove redundant license text

2017-11-06 Thread Nicolas Ferre
On 06/11/2017 at 15:37, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ di

Re: [PATCH 24/24] USB: gadget: Remove redundant license text

2017-11-06 Thread Felipe Balbi
Greg Kroah-Hartman writes: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that file

Re: [PATCH 05/24] USB: typec: Remove redundant license text

2017-11-06 Thread Heikki Krogerus
On Mon, Nov 06, 2017 at 03:37:14PM +0100, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to

Re: xhci bandwidth problem with isochronous endpoints

2017-11-06 Thread Mathias Nyman
On 03.11.2017 23:37, Curt Meyers wrote: On 09/19/2017 06:00 AM, Mathias Nyman wrote: On 08.09.2017 20:35, Curt Meyers wrote: On 09/05/2017 02:56 PM, Curt Meyers wrote: On 09/04/2017 04:13 AM, Mathias Nyman wrote: On 04.09.2017 13:46, Felipe Balbi wrote: Hi, Mathias Nyman writes: Unfortun

Re: [PATCH 03/24] USB: renesas_usbhs: Remove redundant license text

2017-11-06 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 04:46:04PM +0200, Felipe Balbi wrote: > Greg Kroah-Hartman writes: > > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is no longer needed at all.

Re: usb/net/qmi_wwan: divide error in qmi_wwan_probe/usbnet_probe

2017-11-06 Thread Andrey Konovalov
On Mon, Nov 6, 2017 at 3:06 PM, Bjørn Mork wrote: > Andrey Konovalov writes: > >> Hi! >> >> I've got the following report while fuzzing the kernel with syzkaller. > > Thanks. It would have helped a lot of you said *what* you were fuzzing, > though But based on where the bug is, I assume it i

Re: xhci_hcd WARN Event TRB for slot ep with no TDs queued?

2017-11-06 Thread Juan Simón
Hi, I have followed the guide https://wiki.archlinux.org/index.php/Bisecting_bugs : $ git clone https://github.com/torvalds/linux $ git bisect good v4.12 $ git bisect bad v4.13 Bisecting: 7028 revisions left to test after this (roughly 13 steps) [ac7b75966c9c86426b55fe1c50ae148aa4571075] Merge ta

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Oliver Neukum
Am Montag, den 06.11.2017, 13:30 +0100 schrieb Andrey Konovalov: > On Mon, Nov 6, 2017 at 10:49 AM, Oliver Neukum wrote: > > > > > > 2. Will a device work after that? The appropriate fix may be to wait > > until the device is properly initialized. > > This shouldn't affect real devices as far a

Re: xhci_hcd WARN Event TRB for slot ep with no TDs queued?

2017-11-06 Thread Felipe Balbi
Hi, (please avoid top-posting) Juan Simón writes: > I have followed the guide https://wiki.archlinux.org/index.php/Bisecting_bugs > : > > $ git clone https://github.com/torvalds/linux > $ git bisect good v4.12 > $ git bisect bad v4.13 > Bisecting: 7028 revisions left to test after this (roughl

[PATCH 3/6] USB: chipidea: ci_hdrc_tegra.c: add SPDX line

2017-11-06 Thread Greg Kroah-Hartman
The license text was removed from this file, yet they somehow missed the big "add SPDX tags to all files" sweep due to them being new. So add the proper SPDX license tag to them, based on the original license text in the file. Cc: Peter Chen Cc: Thierry Reding Cc: Jonathan Hunter Signed-off-by

[PATCH 2/6] USB: host: xhci-debugfs: add SPDX lines

2017-11-06 Thread Greg Kroah-Hartman
The license text was removed from these files, yet they somehow missed the big "add SPDX tags to all files" sweep due to them being new. So add the proper SPDX license tag to them, based on the original license text in the file. Cc: Mathias Nyman Signed-off-by: Greg Kroah-Hartman --- drivers/u

[PATCH 1/6] USB: add SPDX identifiers to all remaining Makefiles

2017-11-06 Thread Greg Kroah-Hartman
It's good to have SPDX identifiers in all files to make it easier to audit the kernel tree for correct licenses. This updates the remaining drivers/usb/*Makefile* that were missing SPDX identifiers. They all get the following identifier: SPDX-License-Identifier: GPL-2.0 The SPDX identifi

[PATCH 6/6] USB: typec: Remove remaining redundant license text

2017-11-06 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL licen

[PATCH 5/6] USB: typec: add SPDX identifiers to some files

2017-11-06 Thread Greg Kroah-Hartman
Due to these typec files being moved into the drivers/usb/ directory in this tree, they missed the larger "add SPDX tags to all files" work. So add the correct SPDX license tag, based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used ins

[PATCH 4/6] USB: renesas_usbhs: rcar?.h: add SPDX tags

2017-11-06 Thread Greg Kroah-Hartman
These files somehow never got an SPDX tag added to them, maybe due to the small size. So provide the default identifier of the whole project: SPDX-License-Identifier: GPL-2.0 The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Cc:

Re: [PATCH 4/6] USB: renesas_usbhs: rcar?.h: add SPDX tags

2017-11-06 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > These files somehow never got an SPDX tag added to them, maybe due to > the small size. So provide the default identifier of the whole project: > SPDX-License-Identifier: GPL-2.0 > > The SPDX identifier is a legally binding shorthand, which can be used > i

Re: [PATCH 02/24] USB: usbip: Remove redundant license text

2017-11-06 Thread Shuah Khan
On 11/06/2017 07:37 AM, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ di

Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text

2017-11-06 Thread Michal Nazarewicz
On Mon, Nov 06 2017, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ differ

Re: [PATCH 06/24] USB: musb: Remove redundant license text

2017-11-06 Thread Bin Liu
On Mon, Nov 06, 2017 at 03:37:15PM +0100, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Andrey Konovalov
On Mon, Nov 6, 2017 at 4:20 PM, Oliver Neukum wrote: > Am Montag, den 06.11.2017, 13:30 +0100 schrieb Andrey Konovalov: >> On Mon, Nov 6, 2017 at 10:49 AM, Oliver Neukum wrote: >> > >> > >> > 2. Will a device work after that? The appropriate fix may be to wait >> > until the device is properly in

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Oliver Neukum
Am Montag, den 06.11.2017, 17:05 +0100 schrieb Andrey Konovalov: > On Mon, Nov 6, 2017 at 4:20 PM, Oliver Neukum wrote: > > > I do have a way to reproduce this. > > As far as I understand, for this particular device ax88172_bind() is > called, which doesn't assign anything to dev->driver_priv,

Re: [PATCH 16/24] USB: host: ohci: Remove redundant license text

2017-11-06 Thread Alan Stern
On Mon, 6 Nov 2017, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ diffe

Re: [PATCH 17/24] USB: host: ehci: Remove redundant license text

2017-11-06 Thread Alan Stern
On Mon, 6 Nov 2017, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ diffe

Re: [PATCH][RFC] usb: hub: Cycle HUB power when initialization fails

2017-11-06 Thread Alan Stern
On Sun, 5 Nov 2017, Mike Looijmans wrote: > On 03-11-17 18:27, Alan Stern wrote: > > On Fri, 3 Nov 2017, Mike Looijmans wrote: > > > >> Sometimes the USB device gets confused about the state of the > >> initialization and > >> the connection fails. In particular, the device thinks that it's alr

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

2017-11-06 Thread Alan Stern
On Mon, 6 Nov 2017, wlf wrote: > Hi Minas, > > 在 2017年11月06日 17:28, Minas Harutyunyan 写道: > > Hi, > > > > On 11/6/2017 12:46 PM, William Wu wrote: > >> The actual_length in dwc2_hcd_urb structure is used > >> to indicate the total data length transferred so far, > >> but in dwc2_update_isoc_urb_s

Re: [PATCH 22/24] USB: gadget: udc: Remove redundant license text

2017-11-06 Thread Li Yang
On Mon, Nov 6, 2017 at 8:37 AM, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the

Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text

2017-11-06 Thread Vincent Pelletier
On Mon, 6 Nov 2017 15:37:32 +0100, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remov

[PATCH] Re: xhci bandwidth problem with isochronous endpoints

2017-11-06 Thread Curt Meyers
On 11/06/2017 06:57 AM, Mathias Nyman wrote: On 03.11.2017 23:37, Curt Meyers wrote: On 09/19/2017 06:00 AM, Mathias Nyman wrote: On 08.09.2017 20:35, Curt Meyers wrote: On 09/05/2017 02:56 PM, Curt Meyers wrote: On 09/04/2017 04:13 AM, Mathias Nyman wrote: On 04.09.2017 13:46, Felipe Balbi

Re: [PATCH 09/24] USB: chipidea: Remove redundant license text

2017-11-06 Thread Peter Chen
On Mon, Nov 06, 2017 at 03:37:18PM +0100, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to

Re: [PATCH 3/6] USB: chipidea: ci_hdrc_tegra.c: add SPDX line

2017-11-06 Thread Peter Chen
On Mon, Nov 06, 2017 at 04:34:09PM +0100, Greg Kroah-Hartman wrote: > The license text was removed from this file, yet they somehow missed > the big "add SPDX tags to all files" sweep due to them being new. So > add the proper SPDX license tag to them, based on the original license > text in the f

[PATCH 1/1] usb: gadget: add USB Audio Device Class 3.0 gadget support

2017-11-06 Thread Ruslan Bilovol
Recently released USB Audio Class 3.0 specification introduces many significant changes comparing to previous versions, like - new Power Domains, support for LPM/L1 - new Cluster descriptor - changed layout of all class-specific descriptors - new High Capability descriptors - New class-specifi

[PATCH 0/1] USB Audio Device Class 3.0 Gadget support

2017-11-06 Thread Ruslan Bilovol
Hi, This patch adds USB Audio Device Class 3.0 [1] function support to gadget subsystem. I didn't add UAC3 support to legacy gadget as it will make preprocessor configuration too complex (UAC3 device must have two configurations for backward compatibility, first is UAC1/2 and second is UAC3), yet

Re: [PATCH 07/24] USB: mtu3: Remove redundant license text

2017-11-06 Thread Chunfeng Yun
On Mon, 2017-11-06 at 15:37 +0100, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
On 2017/11/6 22:00, Mathias Nyman wrote: > On 06.11.2017 14:36, Chen Yu wrote: >> >> >> On 2017/11/6 19:32, Greg KH wrote: A simple process is as below: xhci_plat_probe() | usb_add_hcd()xhci_plat_remove() |

[PATCH v3] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Yu Chen
From: Yu Chen Check vdev->real_port 0 to avoid panic [9.261347] [] xhci_free_virt_devices_depth_first+0x58/0x108 [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 [9.261355] [] xhci_stop+0x140/0x1c8 [9.261365] [] usb_remove_hcd+0xfc/0x1d0 [9.261369] [] xhci_plat_remove+0x6c/0xa8 [

Re: [PATCH 0/1] USB Audio Device Class 3.0 Gadget support

2017-11-06 Thread Ruslan Bilovol
On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol wrote: > Hi, > > This patch adds USB Audio Device Class 3.0 [1] function > support to gadget subsystem. > I didn't add UAC3 support to legacy gadget as it will > make preprocessor configuration too complex (UAC3 device > must have two configurations f

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

2017-11-06 Thread Lu Baolu
Hi, On 11/06/2017 04:00 PM, Greg Kroah-Hartman wrote: > On Mon, Nov 06, 2017 at 08:35:41AM +0800, Lu Baolu wrote: >> Hi, >> >> On 11/03/2017 02:27 PM, Greg Kroah-Hartman wrote: >>> On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: Hi, On 11/03/2017 12:51 AM, Greg Kroah-Hartm

  1   2   >