Re: [PATCH] usb: max3421: unlock on error in max3421_hub_control()

Hi, > We can't return directly in max3421_hub_control(), we have to unlock > first. Yes you are right. I think testing if pdata is null is not necessary as driver_probe will fail if the device do not have a platform_data. Jules. > Fixes: 721fdc83b31b ("usb: max3421: Add devicetree support") > Si

Re: [PATCH] usb: max3421: unlock on error in max3421_hub_control()

On Fri, Oct 27, 2017 at 11:06:36AM +0200, Jules Maselbas wrote: > Hi, > > > We can't return directly in max3421_hub_control(), we have to unlock > > first. > Yes you are right. > I think testing if pdata is null is not necessary as driver_probe will fail if > the device do not have a platform_data

Re: [RFC/PATCH 0/4] usb: core: Add Support for getting PTM_STATUS

Hi, Alan Stern writes: >> >>> The following series was compile-tested only (so far, at least). I >> >>> wanted to get some comments from folks to see what you guys think >> >>> about this before running tests. >> >>> >> >>> I don't have any device available which would support PTM_STATUS so I >

Logitech Racing Wheel Driver

Hi, We are using Logitech GT 920 device on Ubuntu 16.04. Where we can find the driver for the same? Following is the output from the dmesg: [ 1676.016108] usb 1-5: new full-speed USB device number 7 using xhci_hcd [ 1676.157828] usb 1-5: New USB device found, idVendor=046d, idProduct=c261 [ 1676

Re: [PATCH] usb: max3421: unlock on error in max3421_hub_control()

> On Fri, Oct 27, 2017 at 11:06:36AM +0200, Jules Maselbas wrote: >> Hi, >> >> > We can't return directly in max3421_hub_control(), we have to unlock >> > first. >> Yes you are right. >> I think testing if pdata is null is not necessary as driver_probe will fail >> if >> the device do not have a

Re: [PATCH] usb: max3421: unlock on error in max3421_hub_control()

On Fri, Oct 27, 2017 at 02:08:38PM +0200, Jules Maselbas wrote: > > > On Fri, Oct 27, 2017 at 11:06:36AM +0200, Jules Maselbas wrote: > >> Hi, > >> > >> > We can't return directly in max3421_hub_control(), we have to unlock > >> > first. > >> Yes you are right. > >> I think testing if pdata is nu

Re: Logitech Racing Wheel Driver

Hi Pramod, On 27/10/17 14:19, Pramod Bhagwat wrote: > Hi, > > We are using Logitech GT 920 device on Ubuntu 16.04. Where we can find > the driver for the same? > > Following is the output from the dmesg: > > [ 1676.016108] usb 1-5: new full-speed USB device number 7 using xhci_hcd > [ 1676.1578

Re: dwc2: usb: Unable to clear channel error

On 10/24/2017 3:23 AM, Dinh Nguyen wrote: > > > On 10/23/2017 09:03 AM, Minas Harutyunyan wrote: >> On 10/19/2017 5:35 PM, Dinh Nguyen wrote: >>> >>> >>> On 10/19/2017 06:55 AM, Grigor Tovmasyan wrote: On 10/18/2017 6:07 PM, Marek Vasut wrote: > On 10/18/2017 04:05 PM, Dinh Nguyen wrote:

Re: Logitech Racing Wheel Driver

Thanks a lot Roger. Following link helped to switch the mode of the racing wheel and now events are seen in evtest. https://lkml.org/lkml/2016/1/26/763 Warm Regards, pramod On Fri, Oct 27, 2017 at 5:57 PM, Roger Quadros wrote: > Hi Pramod, > > On 27/10/17 14:19, Pramod Bhagwat wrote: >> Hi, >> >

ftdi_sio: no per-byte parity error detection possible?

Hi, I'm trying to communicate with an embedded device using a serial protocol which uses the parity bit to indicate the start of a frame (MARK/SPACE parity). Sending such frames works well, but when receiving them with a FT232RL USB adapter, the parity error detection is very unreliable. I

Re: [PATCH] usb: musb: Convert timers to use timer_setup()

Hi, On Tue, Oct 24, 2017 at 03:08:35AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Instead of a per-device static tim

Re: [PATCH] usb: musb_core: mark expected switch fall-through

Hi, On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1397608 > Signed-off-by: Gustavo A. R. Silva Applied with the above Coverity-ID me

Re: [PATCH] usb: musb_core: mark expected switch fall-through

On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote: > Hi, > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Addresses-Coverity-ID: 1397608 > > S

[PATCH 1/2] usb: musb: da8xx: Remove duplicated defines

From: Alexandre Bailon There is some registers defined in da8xx.c though they are not used. These registers are also defined and used in musb_cppi41.c Remove these defines from da8xx.c. Signed-off-by: Alexandre Bailon Signed-off-by: Bin Liu --- drivers/usb/musb/da8xx.c | 3 --- 1 file changed

[PATCH 0/2] musb patches for v4.15-rc1

Hi Greg, These are the two musb patches for next v4.15-rc1. One removes unused macro, the other adds fall-through comment. Please let me know if any change is needed. Regards, -Bin. --- Alexandre Bailon (1): usb: musb: da8xx: Remove duplicated defines Gustavo A. R. Silva (1): usb: musb_core

[PATCH 2/2] usb: musb_core: mark expected switch fall-through

From: "Gustavo A. R. Silva" In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/m

Re: [PATCH] usb: musb_core: mark expected switch fall-through

On Fri, Oct 27, 2017 at 06:49:49PM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote: > > Hi, > > > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where

Re: [PATCH v7 usb-next 4/4] dt-bindings: usb: xhci: include the roothub and a device in the example

Hi Rob, On Fri, Oct 27, 2017 at 5:29 AM, Rob Herring wrote: > On Mon, Oct 23, 2017 at 11:57:18PM +0200, Martin Blumenstingl wrote: >> This extends the existing example from the USB xHCI binding >> documentation so it includes the roothub and an actual device. >> The goal of this is to show that t

[PATCH] mmc: vub300: Use common code in __download_offload_pseudocode()

From: Markus Elfring Date: Fri, 27 Oct 2017 21:21:40 +0200 Add a jump target so that a specific string copy operation is stored only once at the end of this function implementation. Replace two calls of the function "strncpy" by goto statements. This issue was detected by using the Coccinelle so

Re: [PATCH v7 usb-next 4/4] dt-bindings: usb: xhci: include the roothub and a device in the example

On Fri, 27 Oct 2017, Martin Blumenstingl wrote: > Hi Rob, > > On Fri, Oct 27, 2017 at 5:29 AM, Rob Herring wrote: > > On Mon, Oct 23, 2017 at 11:57:18PM +0200, Martin Blumenstingl wrote: > >> This extends the existing example from the USB xHCI binding > >> documentation so it includes the roothu

[PATCH] usb: storage: sddr55: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/storage/sddr55.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c index 1

[PATCH] usb: typec: tps6598x: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/typec/tps6598x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c index 8