Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-22 Thread Uwe Kleine-König
Hello, On Sat, Oct 21, 2017 at 11:08:39AM -0400, Alan Stern wrote: > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-König wrote: > > On Fri, Oct 20, 2017 at 03:47:37PM -0400, Alan Stern wrote: > > > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-König wrote: > > > > On Fri, Oct 20, 2017 at 05:27:09PM

[PATCH 04/10 v3] usb: usb251xb: Add 5,6,7 ports mapping def setting

2017-10-22 Thread Serge Semin
USB2517 got three additionl downstream ports, which can as well be mapped to another logical ports. USB251xb driver currently doesn't fully support such setting configuration from dts file. This patch doesn't change this, but adds usb2517 spcific ports default liner mapping. Signed-off-by: Serge S

[PATCH 10/10 v3] usb: usb251xb: Use GPIO descriptor consumer interface

2017-10-22 Thread Serge Semin
The driver used to be developed with legacy GPIO API support. It's better to use descriptor-based interface for several reasons. First of all the legacy API doesn't support the ACTIVE_LOW/HIGH flag of dts nodes, which is essential since different hardware may have different GPIOs connectivity inclu

[PATCH 07/10 v3] usb: usb251xb: Add USB2517 LED settings

2017-10-22 Thread Serge Semin
USB2517 supports two LED modes: USB mode and speed (default) indication mode. The last one can be switched on by corresponding dts property. Since USB251xb hubs doesn't support LEDs settings, we need to ignore this setting. Signed-off-by: Serge Semin --- drivers/usb/misc/usb251xb.c | 12

[PATCH 08/10 v3] usb: usb251xb: Fix property_u32 NULL pointer dereference

2017-10-22 Thread Serge Semin
The methods like of_property_read_u32 utilizing the specified pointer permit only the pointer to a preallocated u32 storage as the third argument. As a result the driver crashes on NULL pointer dereference in case if "oc-delay-us" or "power-on-time-ms" declared in dts file. Signed-off-by: Serge Se

[PATCH 09/10 v3] usb: usb251xb: Add max power/current dts property support

2017-10-22 Thread Serge Semin
This parameters may be varied in accordance with hardware specifics. So lets add the corresponding settings to the usb251xb driver dts specification. Signed-off-by: Serge Semin --- drivers/usb/misc/usb251xb.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff -

[PATCH 06/10 v3] usb: usb251xb: Add battery enable setting flag

2017-10-22 Thread Serge Semin
Battery charging settings are supported by USB251xb hubs only. USB2517i isn't one of them. So we need to reflect it within the device-specific data structure. The driver doesn't support dts property changing this setting, but instead defaults it with zero. So the flag isn't used anywhere in the dri

[PATCH 05/10 v3] usb: usb251xb: Add 5,6,7 ports boost settings

2017-10-22 Thread Serge Semin
USB electrical signaling drive strength boost bit is also supported by USB2517 hub. Since it got three addition ports, the designers needed to add one more register for initialization. It turned out to be formerly reserved 0xF7. As before we just initialize it with default zeros. Signed-off-by: Se

[PATCH 02/10 v3] usb: usb251xb: Add USB2517i specific struct and IDs

2017-10-22 Thread Serge Semin
There are USB2517 and USB2517i hubs, which have almost the same registers space as already supported USB251xBi series. The difference it in DIDs and in a few functions. This patch adds the USB2517/i data structures to the driver, so it would have different setting depending on the device discovered

[PATCH 01/10 v3] usb: usb251xb: Update usb251xb bindings

2017-10-22 Thread Serge Semin
Since hub usb2517 is going to be supported by the usb251xb driver, the bindings need to be properly updated. Particularly: - add "microchip,usb2517" and "microchip,usb2517i" compatible strings. - add "boolean" description to all the properties, which really accept a boolean value including a new on

[PATCH 00/10 v3] usb: usb251xb: Add USB2517i hub support and fix some bugs

2017-10-22 Thread Serge Semin
Primarily it was intended to just add USB2517 hub support to the driver. But after tests a bug and inconistency were discovered. So it was decided to make the following changes: Changelog v1: - Add USB2517/i hub specifics support to the driver - Fix property_u32 NULL-pointer dereference - Add new

[PATCH 03/10 v3] usb: usb251xb: Add USB251x specific port count setting

2017-10-22 Thread Serge Semin
USB251xb as well as USB2517 datasheet states, that all these hubs differ by number of ports declared as the last digit in the model name. So USB2512 got two ports, USB2513 - three, and so on. Such setting must be reflected in the device specific data structure and corresponding dts property should

[PATCH v2 36/37] usb/gadget/NCM: Replace tasklet with softirq hrtimer

2017-10-22 Thread Anna-Maria Gleixner
From: Thomas Gleixner The tx_tasklet tasklet is used in invoke the hrtimer (task_timer) in softirq context. This can be also achieved without the tasklet but with HRTIMER_MODE_SOFT as hrtimer mode. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Cc: Felipe Balbi Cc: linux-us

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-22 Thread Alan Stern
On Sun, 22 Oct 2017, Uwe [iso-8859-1] Kleine-K�nig wrote: > Hello, > > On Sat, Oct 21, 2017 at 11:08:39AM -0400, Alan Stern wrote: > > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-K�nig wrote: > > > On Fri, Oct 20, 2017 at 03:47:37PM -0400, Alan Stern wrote: > > > > On Fri, 20 Oct 2017, Uwe [iso-

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

2017-10-22 Thread Kishon Vijay Abraham I
On Wednesday 18 October 2017 07:44 AM, Chanwoo Choi wrote: > Gently Ping. > > Dear Kishon, > > Could you please review this patch for 'drivers/phy/*'? sorry for the delay.. here it is Acked-by: Kishon Vijay Abraham I > > Regards, > Chanwoo Choi > > On 2017년 10월 12일 12:40, Chanwoo Choi wrot

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

2017-10-22 Thread Chanwoo Choi
Dear all, I got the reviews from all maintainers related to this patch. So, I make the immutable branch on extcon.git and then send the pull request in order to prevent the possible merge conflict. Best Regards, Chanwoo Choi Samsung Electronics The following changes since commit 2bd6bf03f4c1c59