[GIT PULL] USB-serial fixes for v4.14-rc6

2017-10-19 Thread Johan Hovold
Hi Greg, This should my last set of "fixes" for 4.14. Just a single device id this time. Thanks, Johan The following changes since commit 33d930e59a98fa10a0db9f56c7fa2f21a4aef9b9: Linux 4.14-rc5 (2017-10-15 21:01:12 -0400) are available in the git repository at: git://git.kernel.org/pub/

Re: [GIT PULL] USB-serial fixes for v4.14-rc6

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 09:08:39AM +0200, Johan Hovold wrote: > Hi Greg, > > This should my last set of "fixes" for 4.14. Just a single device id this > time. > > Thanks, > Johan > > > The following changes since commit 33d930e59a98fa10a0db9f56c7fa2f21a4aef9b9: > > Linux 4.14-rc5 (2017-10-1

Re: linux-next: manual merge of the usb-gadget tree with the usb tree

2017-10-19 Thread Felipe Balbi
Hi, Kees Cook writes: > On Wed, Oct 18, 2017 at 7:42 AM, Mark Brown wrote: >> Hi Felipe, >> >> Today's linux-next merge of the usb-gadget tree got a conflict in: >> >> drivers/usb/gadget/udc/snps_udc_core.c >> >> between commit: >> >> 29bce57723351f63d ("usb/gadget/snps_udc_core: Convert ti

Re: [iMX6Q][CI] EHCI Low-speed device problem

2017-10-19 Thread Lukasz Majewski
Hi Peter, > On Thu, Oct 19, 2017 at 07:47:01AM +0200, Lukasz Majewski wrote: > > > > I'm wondering if it is feasible to manually check the XactErr > > > > bit and then for example order the soft USB reset (from the > > > > root hub)? > > > > > > > > Or is there any other acceptable in upstream so

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Geert Uytterhoeven
Hi Greg, On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. This patch adds these > identifiers to all files in drivers/usb/ based on a script and data from > Thomas Glei

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 10:49:47AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman > wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. This patch adds these > > iden

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Thomas Gleixner
On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. This patch adds these > identifiers to all files in drivers/usb/ based on a script and data from > Thomas Gleixner, Philippe Ombredan

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. This patch adds these > > identifiers to all files in driver

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. This patch adds these > > identifiers to all files in driver

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Thomas Gleixner
On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > > The last discussion about this was to add the identifier as the first line > > of the file or as the second in case of files with a shebang in the first > > one. > > > > I think yo

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Geert Uytterhoeven
Hi Greg, On Thu, Oct 19, 2017 at 10:52 AM, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 10:49:47AM +0200, Geert Uytterhoeven wrote: >> On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman >> wrote: >> > It's good to have SPDX identifiers in all files to make it easier to >> > audit the ke

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 11:01:56AM +0200, Thomas Gleixner wrote: > On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > > On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > > > The last discussion about this was to add the identifier as the first line > > > of the file or as the second

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Thomas Gleixner
On Thu, 19 Oct 2017, Geert Uytterhoeven wrote: > On Thu, Oct 19, 2017 at 10:52 AM, Greg Kroah-Hartman > wrote: > > On Thu, Oct 19, 2017 at 10:49:47AM +0200, Geert Uytterhoeven wrote: > >> On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman > >> wrote: > >> > It's good to have SPDX identifiers in

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > On Thu, Oct 19, 2017 at 10:49:47AM +0200, Geert Uytterhoeven wrote: >> Hi Greg, >> >> On Thu, Oct 19, 2017 at 10:38 AM, Greg Kroah-Hartman >> wrote: >> > It's good to have SPDX identifiers in all files to make it easier to >> > audit the kernel tree for correct

Re: [PATCH v7 2/4] usb: dwc3: of-simple: Re-order resource handling in remove

2017-10-19 Thread Felipe Balbi
Hi, Philipp Zabel writes: > From: Vivek Gautam > > Move clock handling after of_platform_depopulate to achieve > a sequence that is reverse of the probe sequence. > > Cc: Felipe Balbi > Signed-off-by: Vivek Gautam does this depend on the rest of the series? Doesn't seem like it does. -- ba

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Felipe Balbi
Philipp Zabel writes: > From: Vivek Gautam > > Add support to get a list of resets available for the device. > These resets must be kept de-asserted until the device is > in use. > > Cc: Felipe Balbi > Signed-off-by: Vivek Gautam > [p.za...@pengutronix.de: switch to hidden reset control array]

Re: [RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub

2017-10-19 Thread Neil Armstrong
On 18/10/2017 11:05, Arnd Bergmann wrote: > On Tue, Oct 17, 2017 at 11:19 PM, Martin Blumenstingl > wrote: >>> Ok, very good! >>> is there anything else you want me to test? >>> >>> What about the same dtb when run on a kernel without your >>> patch series? Does that work as well, or are your

Re: [PATCH usb-next v6 0/3] initialize (multiple) PHYs on the roothub

2017-10-19 Thread Neil Armstrong
On 17/10/2017 23:20, Martin Blumenstingl wrote: > This series is the outcome of a discussion with Felipe Balbi, > see [0] and [1] as well as Mathias Nyman, see [7] and [8]. > The quick-summary of this is: > - dwc3 already takes one USB2 and one USB3 PHY and initializes these > correct > - some ot

Re: dwc2 - ChHltd set, but reason is unknown

2017-10-19 Thread Anders Montonen
On Thu, 19 Oct 2017, Minas Harutyunyan wrote: Could you please apply this patch. If you confirm that this patch fix your issue with "Transaction Error" and " ChHltd set, but reason is unknown" I'll submit to LKML as final patch. diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c ind

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Philipp Zabel
Hi Felipe, On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: > Philipp Zabel writes: > > > From: Vivek Gautam > > > > Add support to get a list of resets available for the device. > > These resets must be kept de-asserted until the device is > > in use. > > > > Cc: Felipe Balbi > > Sign

Re: [PATCH] usb: "USB Host halt failed, -110" error when rebooting system

2017-10-19 Thread Mathias Nyman
On 18.10.2017 17:50, Alan Stern wrote: On Tue, 17 Oct 2017 wenxi...@linux.vnet.ibm.com wrote: From: Wen Xiong We saw "Host halt failed, -110" error when rebooting system/ shutdowning system/kexec constantly. This patch called usb_disconnect() before calling xhci_halt(). usb_disconnect()disc

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-19 Thread Philippe Ombredanne
On Thu, Oct 19, 2017 at 11:10 AM, Greg Kroah-Hartman wrote: > And, to take it to the next conclusion, if we have the SPDX identifier, > we can get rid of the "boilerplate" GPL license crap as well, right? > > How about this example patch of just 2 files, we could drop so many > lines that we are

Re: usb/serial/visor: slab-out-of-bounds in palm_os_3_probe

2017-10-19 Thread Andrey Konovalov
On Wed, Oct 4, 2017 at 4:40 PM, Greg Kroah-Hartman wrote: > On Tue, Oct 03, 2017 at 11:29:40AM +0200, Johan Hovold wrote: >> On Fri, Sep 29, 2017 at 10:37:55AM +0200, Greg Kroah-Hartman wrote: >> > On Thu, Sep 28, 2017 at 07:57:46PM +0200, Andrey Konovalov wrote: >> > > Hi! >> > > >> > > I've got

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Felipe Balbi
Hi, Philipp Zabel writes: > Hi Felipe, > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: >> Philipp Zabel writes: >> >> > From: Vivek Gautam >> > >> > Add support to get a list of resets available for the device. >> > These resets must be kept de-asserted until the device is >> > in

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Felipe Balbi
Hi, Philipp Zabel writes: > Hi Felipe, > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: >> Philipp Zabel writes: >> >> > From: Vivek Gautam >> > >> > Add support to get a list of resets available for the device. >> > These resets must be kept de-asserted until the device is >> > in

Re: usb/serial/visor: slab-out-of-bounds in palm_os_3_probe

2017-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 01:19:13PM +0200, Andrey Konovalov wrote: > On Wed, Oct 4, 2017 at 4:40 PM, Greg Kroah-Hartman > wrote: > > On Tue, Oct 03, 2017 at 11:29:40AM +0200, Johan Hovold wrote: > >> On Fri, Sep 29, 2017 at 10:37:55AM +0200, Greg Kroah-Hartman wrote: > >> > On Thu, Sep 28, 2017 at

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Philipp Zabel
On Thu, 2017-10-19 at 14:31 +0300, Felipe Balbi wrote: > Hi, > > Philipp Zabel writes: > > Hi Felipe, > > > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: > > > Philipp Zabel writes: > > > > > > > From: Vivek Gautam > > > > > > > > Add support to get a list of resets available for

[PATCH v8] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Philipp Zabel
From: Vivek Gautam Add support to get a list of resets available for the device. These resets must be kept de-asserted until the device is in use. Signed-off-by: Vivek Gautam [p.za...@pengutronix.de: switch to hidden reset control array] Signed-off-by: Philipp Zabel --- v7: Rebased onto git://

Re: dwc2: usb: Unable to clear channel error

2017-10-19 Thread Grigor Tovmasyan
On 10/18/2017 6:07 PM, Marek Vasut wrote: > On 10/18/2017 04:05 PM, Dinh Nguyen wrote: >> Hi, >> >> I'm trying to bringup the DWC2 USB IP version 330A on a new Stratix10 >> SoC and have encountered this error in both Linux and U-Boot: >> >> U-Boot(version v2017.09) >> >> # usb start >> starting USB

Re: dwc2: usb: Unable to clear channel error

2017-10-19 Thread Dinh Nguyen
On 10/19/2017 06:55 AM, Grigor Tovmasyan wrote: > On 10/18/2017 6:07 PM, Marek Vasut wrote: >> On 10/18/2017 04:05 PM, Dinh Nguyen wrote: >>> Hi, >>> >>> I'm trying to bringup the DWC2 USB IP version 330A on a new Stratix10 >>> SoC and have encountered this error in both Linux and U-Boot: >>> >>>

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

2017-10-19 Thread Christoph Hellwig
> > Now we have 9 const instances of the config_item_type structure that are > identical, with only the .ct_owner field set. Should they be all merged into > a > single structure ? I think that's a good idea. But I'm about to slurp up this whole series into my tree, how about making that an i

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

2017-10-19 Thread Laurent Pinchart
Hi Christoph, On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote: > > Now we have 9 const instances of the config_item_type structure that are > > identical, with only the .ct_owner field set. Should they be all merged > > into a single structure ? > > I think that's a good idea.

Re: [PATCH v7 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-10-19 Thread Philipp Zabel
Hi Jon, Thierry, On Wed, 2017-07-19 at 17:59 +0200, Philipp Zabel wrote: > From: Vivek Gautam > > Make use of of_reset_control_array_get_exclusive() to manage > an array of reset controllers available with the device. > > Cc: Jon Hunter > Cc: Thierry Reding > Signed-off-by: Vivek Gautam > [p

Re: [iMX6Q][CI] EHCI Low-speed device problem

2017-10-19 Thread Alan Stern
On Thu, 19 Oct 2017, Lukasz Majewski wrote: > > > Problem: > > > > > > I do observe that the USB transfers are truncated - for example > > > "Get Configuration Descriptor", which length is 34B only gets 16B > > > from the device. > > > > > > I do get the "Invalid PID sequence" error and despit

Re: [PATCH] usb: "USB Host halt failed, -110" error when rebooting system

2017-10-19 Thread Alan Stern
On Thu, 19 Oct 2017, Mathias Nyman wrote: > Current shutdown routine just forces the host controller to stop, it clears > the > run bit and polls the "halted" status for 16ms. Apparently we don't see the > halted > bit within 16ms. > > Spec say that the correct way to stop is to first command a

Re: [PATCH v7 1/4] reset: Add APIs to manage array of resets

2017-10-19 Thread Bjorn Andersson
On Wed 19 Jul 08:59 PDT 2017, Philipp Zabel wrote: > From: Vivek Gautam > > Many devices may want to request a bunch of resets and control them. So > it's better to manage them as an array. Add APIs to _get() an array of > reset_control, reusing the _assert(), _deassert(), and _reset() APIs for

Re: [iMX6Q][CI] EHCI Low-speed device problem

2017-10-19 Thread Lukasz Majewski
Hi Alan, > On Thu, 19 Oct 2017, Lukasz Majewski wrote: > > > > > Problem: > > > > > > > > I do observe that the USB transfers are truncated - for example > > > > "Get Configuration Descriptor", which length is 34B only gets > > > > 16B from the device. > > > > > > > > I do get the "Invalid PI

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

2017-10-19 Thread John Stultz
On Tue, Oct 17, 2017 at 1:41 AM, Minas Harutyunyan wrote: > On 10/17/2017 1:34 AM, John Stultz wrote: >> On Mon, Oct 16, 2017 at 1:36 AM, Minas Harutyunyan >> wrote: >>> On b-plug disconnect should asserted GOTGINT.SesEndDet interrupt. >>> According previously sent by you register dump (GHWCFG2 =

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

2017-10-19 Thread John Stultz
On Wed, Oct 18, 2017 at 11:46 PM, Minas Harutyunyan wrote: > Could you please apply this patch. Please not apply your patch series > "[PATCH 0/3] dwc2 fixes for edge cases on hikey" to check only below patch. > If you confirm that this patch fix your issue with "Transaction Error" > and " ChHltd s

Re: [RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub

2017-10-19 Thread Martin Blumenstingl
Hi Arnd, On Wed, Oct 18, 2017 at 11:05 AM, Arnd Bergmann wrote: > On Tue, Oct 17, 2017 at 11:19 PM, Martin Blumenstingl > wrote: >>> Ok, very good! >>> is there anything else you want me to test? >>> >>> What about the same dtb when run on a kernel without your >>> patch series? Does that w

Re: [PATCH usb-next v6 0/3] initialize (multiple) PHYs on the roothub

2017-10-19 Thread Martin Blumenstingl
Hi Chunfeng Yun, many thanks for your efforts (testing and explaining the Mediatek SoC implementatino) on the earlier versions of this series! On Tue, Oct 17, 2017 at 11:20 PM, Martin Blumenstingl wrote: > This series is the outcome of a discussion with Felipe Balbi, > see [0] and [1] as well as

Re: [RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub

2017-10-19 Thread Arnd Bergmann
On Thu, Oct 19, 2017 at 11:25 PM, Martin Blumenstingl wrote: >> Does dwc2 also use separate nodes for the roothub? From your >> description it sounds like it would not be affected by your patch. > currently it doesn't use separate notes for the roothub - however, > with this patch it could (althou

Re: [iMX6Q][CI] EHCI Low-speed device problem

2017-10-19 Thread Peter Chen
On Thu, Oct 19, 2017 at 10:25:13AM +0200, Lukasz Majewski wrote: > Hi Peter, > > > On Thu, Oct 19, 2017 at 07:47:01AM +0200, Lukasz Majewski wrote: > > > > > I'm wondering if it is feasible to manually check the XactErr > > > > > bit and then for example order the soft USB reset (from the > > > >