Re: Issue with Gadget UVC and dummy_hcd

2017-10-06 Thread Felipe Balbi
Hi, Alan Stern writes: > On Thu, 5 Oct 2017, David Tulloh wrote: > >> Thanks Alan, >> >> I was facing a different problem but your suggestion put me on the right >> path. >> >> Sorry it took me so long to update the thread, it has taken me a while >> to get a basic understanding of the debugg

Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

2017-10-06 Thread Geert Uytterhoeven
Hi Biju, On Thu, Oct 5, 2017 at 5:12 PM, Biju Das wrote: > This patch adds support for r8a7743/5 SoC. The Renesas RZ/G1[ME] > (R8A7743/5) usbhs is identical to the R-Car Gen2 family. > > This doesn't change the driver, so it does nothing by itself. But it does Wording it like this may give the

Re: [PATCH] HID: usbhid: Convert timers to use timer_setup()

2017-10-06 Thread Benjamin Tissoires
On Oct 04 2017 or thereabouts, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Adds pointer back to hid_device for > multitouch. > >

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-10-06 Thread gre...@linuxfoundation.org
On Tue, Oct 03, 2017 at 06:41:54PM +, Thinh Nguyen wrote: > Hi, > > On 9/11/2017 12:42 AM, Felipe Balbi wrote: > > > > Hi, > > > > Thinh Nguyen writes: > >>> Felipe Balbi writes: > Thinh Nguyen writes: > > > Hi Felipe, > > > > On 9/7/2017 12:16 AM, Felipe Balbi wrote

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

2017-10-06 Thread Biju Das
> -Original Message- > From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] > On Behalf Of Geert Uytterhoeven > Sent: 06 October 2017 08:34 > To: Biju Das > Cc: Greg Kroah-Hartman ; Rob Herring > ; Mark Rutland ; Simon > Horman ; Chris Paterson > ; Fabrizio Castro > ;

Re: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper

2017-10-06 Thread Simon Horman
On Thu, Oct 05, 2017 at 01:12:01PM +0300, Mathias Nyman wrote: > On 05.10.2017 12:19, Simon Horman wrote: > >On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: > >>Use the of_device_get_match_data() helper instead of open coding. > >> > >>Signed-off-by: Geert Uytterhoeven > > > >R

Re: [PATCH 02/13] xhci: add port speed ID to portsc tracing

2017-10-06 Thread Mathias Nyman
On 05.10.2017 17:59, David Laight wrote: From: Mathias Nyman Sent: 05 October 2017 09:22 Shows the port speed protocol speed ID (PSID) in use. speed ID may map to custom speeds, but in most cases it uses default 1 = Full-Speed12 MB/s 2 = Low-Speed 1.5 Mb/s 3 = High-speed

Re: [PATCH] usb: xhci: Handle error condition in xhci_stop_device()

2017-10-06 Thread Mathias Nyman
On 05.10.2017 21:42, Jack Pham wrote: From: Mayank Rana xhci_stop_device() calls xhci_queue_stop_endpoint() multiple times without checking the return value. xhci_queue_stop_endpoint() can return error if the HC is already halted or unable to queue commands. This can cause a deadlock condition

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

2017-10-06 Thread Andrzej Hajda
Hi Rob, Thanks for review. On 06.10.2017 01:12, Rob Herring wrote: > On Thu, Sep 28, 2017 at 03:07:27PM +0200, Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be

Re: the imfamous asix ax88179 iommu error

2017-10-06 Thread Robin Murphy
Hi Will, On 06/10/17 01:19, Will Trives wrote: > Hello, > > Just reporting that it looks like this patch may fix the error (so > people having issues with VIA controller hosts may also want to try it): > > https://lists.linuxfoundation.org/pipermail/iommu/2017-September/024371.html > > It appea

Re: Issue with Gadget UVC and dummy_hcd

2017-10-06 Thread Alan Stern
On Fri, 6 Oct 2017, David Tulloh wrote: > On 6 October 2017 at 06:55, Alan Stern wrote: > > David, please try the patch below. It should fix this problem. And I > > have no idea why I didn't encounter exactly the same recursive locking > > error in my own testing... > > Thanks Alan, the patch

[PATCH] USB: dummy-hcd: Fix deadlock caused by disconnect detection

2017-10-06 Thread Alan Stern
The dummy-hcd driver calls the gadget driver's disconnect callback under the wrong conditions. It should invoke the callback when Vbus power is turned off, but instead it does so when the D+ pullup is turned off. This can cause a deadlock in the composite core when a gadget driver is unregistered

[PATCH 2/4] xhci: Cleanup current_cmd in xhci_cleanup_command_queue()

2017-10-06 Thread Mathias Nyman
From: Jeffy Chen KASAN reported use-after-free bug when xhci host controller died: [ 176.952537] BUG: KASAN: use-after-free in xhci_handle_command_timeout+0x68/0x224 [ 176.960846] Write of size 4 at addr ffc0cbb01608 by task kworker/3:3/1680 ... [ 177.180644] Freed by task 0: [ 177.18388

[PATCH 3/4] usb: xhci: Reset halted endpoint if trb is noop

2017-10-06 Thread Mathias Nyman
From: Lu Baolu When a URB is cancled, xhci driver turns the untransferred trbs into no-ops. If an endpoint stalls on a no-op trb that belongs to the cancelled URB, the event handler won't reset the endpoint. Hence, it will stay halted. Link: http://marc.info/?l=linux-usb&m=149582598330127&w=2

[PATCH 1/4] xhci: Identify USB 3.1 capable hosts by their port protocol capability

2017-10-06 Thread Mathias Nyman
Many USB 3.1 capable hosts never updated the Serial Bus Release Number (SBRN) register to USB 3.1 from USB 3.0 xhci driver identified USB 3.1 capable hosts based on this SBRN register, which according to specs "contains the release of the Universal Serial Bus Specification with which this Universa

[PATCH 0/4] xhci fixes for usb-linus

2017-10-06 Thread Mathias Nyman
Hi Greg A few more fixes for 4.14. Among other fixes, solves missing USB 3.1 host capability detection for many USB 3.1 hosts currently on the market -Mathias Jeffy Chen (1): xhci: Cleanup current_cmd in xhci_cleanup_command_queue() Lu Baolu (1): usb: xhci: Reset halted endpoint if trb is n

[PATCH 4/4] usb: xhci: Handle error condition in xhci_stop_device()

2017-10-06 Thread Mathias Nyman
From: Mayank Rana xhci_stop_device() calls xhci_queue_stop_endpoint() multiple times without checking the return value. xhci_queue_stop_endpoint() can return error if the HC is already halted or unable to queue commands. This can cause a deadlock condition as xhci_stop_device() would end up waiti

[PATCH v2] usb: wusbcore: Use put_unaligned_le32

2017-10-06 Thread Himanshu Jha
Use put_unaligned_le32 rather than using byte ordering function and memcpy which makes code clear. Also, add the header file where it is declared. Done using Coccinelle and semantic patch used is : @ rule1 @ identifier tmp; expression ptr,x; type T; @@ - tmp = cpu_to_le32(x); <+... when != tm

Re: the imfamous asix ax88179 iommu error

2017-10-06 Thread Robin Murphy
On 06/10/17 13:14, Robin Murphy wrote: > Hi Will, > > On 06/10/17 01:19, Will Trives wrote: >> Hello, >> >> Just reporting that it looks like this patch may fix the error (so >> people having issues with VIA controller hosts may also want to try it): >> >> https://lists.linuxfoundation.org/piperma

Re: [PATCH v2 0/2] USB: musb: PM fixes

2017-10-06 Thread Bin Liu
On Thu, Oct 05, 2017 at 05:14:24PM +0200, Johan Hovold wrote: > On Thu, Oct 05, 2017 at 08:11:55AM -0700, Tony Lindgren wrote: > > * Johan Hovold [171005 02:15]: > > > On Thu, Sep 07, 2017 at 03:37:46PM +0200, Johan Hovold wrote: > > > > These patches fix a couple of bugs introduced by the recent

RE: the imfamous asix ax88179 iommu error

2017-10-06 Thread David Laight
> >> It appears that my ax88179 is working just fine now with the vendor > >> driver. So perhaps it's possible to revert the old commit in the linux > >> kernel and allow the use of scatter gather ? (perhaps for non-intel > >> hosts ? I'm not sure if this device is effected by intel xhci errata) >

[PATCH v2] usb: renesas_usbhs: Add compatible string for r8a7743/5

2017-10-06 Thread Biju Das
This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME] (R8A7743/5) usbhs is identical to the R-Car Gen2 family. No driver change is needed due to the fallback compatible value "renesas,rcar-gen2-usbhs". Adding the SoC-specific compatible values here has two purposes: 1. Document which

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

2017-10-06 Thread Rob Herring
On Fri, Oct 6, 2017 at 6:10 AM, Andrzej Hajda wrote: > Hi Rob, > > Thanks for review. > > On 06.10.2017 01:12, Rob Herring wrote: >> On Thu, Sep 28, 2017 at 03:07:27PM +0200, Andrzej Hajda wrote: >>> These bindings allows to describe most known standard USB connectors >>> and it should be possible

Re: [PATCH 3/3] usb: gadget: udc: renesas_usb3: add support for generic phy

2017-10-06 Thread Rob Herring
On Fri, Sep 29, 2017 at 08:45:01PM +0900, Yoshihiro Shimoda wrote: > This patch adds support for generic phy as an optional. If you want > to use a generic phy (e.g. phy-rcar-gen3-usb3 driver) on this driver, > you have to do "insmod phy-rcar-gen3-usb3.ko" first for now. > > Signed-off-by: Yoshihi

[PATCH] rndis_host: remove unnecessary space

2017-10-06 Thread Alex Briskin
Remove single space before tab. --- drivers/net/usb/rndis_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c index b807c91abe1d..284d3bffc668 100644 --- a/drivers/net/usb/rndis_host.c +++ b/drivers/net/usb/rndis_ho

Re: [PATCH] rndis_host: remove unnecessary space

2017-10-06 Thread Greg KH
On Fri, Oct 06, 2017 at 08:54:50PM +0300, Alex Briskin wrote: > Remove single space before tab. > --- > drivers/net/usb/rndis_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Always use checkpatch.pl so you don't get grumpy emails from a maintainer telling you to use checkpatch.pl..

[PATCH] rndis_host: remove unnecessary space

2017-10-06 Thread Alex Briskin
Remove single space before tab. --- drivers/net/usb/rndis_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c index b807c91abe1d..284d3bffc668 100644 --- a/drivers/net/usb/rndis_host.c +++ b/drivers/net/usb/rndis_ho

[PATCH] rndis_host: remove unnecessary space

2017-10-06 Thread Alex Briskin
Remove single space before tab. Signed-off-by: Alex Briskin --- drivers/net/usb/rndis_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c index b807c91abe1d..284d3bffc668 100644 --- a/drivers/net/usb/rndis_host.c

Re: [PATCH] usb: wusbcore: Use put_unaligned_le32

2017-10-06 Thread kbuild test robot
Hi Himanshu, [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Jha/usb-wusbcore-Use-put_unalig