[GIT PULL] USB: fixes for v4.14-rc3

2017-09-29 Thread Felipe Balbi
Hi Greg, Here's the second set of fixes for this -rc cycle. Surprisingly, no fixes on dwc3, just a new device ID. I guess we can call dwc3 done :-p Anyway, let me know if you want anything to be changed. cheers The following changes since commit 8fec9355a968ad240f3a2e9ad55b823cf1cc52ff: US

Re: [PATCH] usb: dwc3: workaround: disable device-initiated U1/U2

2017-09-29 Thread Felipe Balbi
Hi, (first things first: use get-maintainer.pl. You should have Cc:ed linux-usb) > Issue: When the USB controller is configured as a USB device > mode, the device initiates low power when an ACK is pending for a > data packet (DP). When operating in SuperSpeed mode and when the > internal condit

Re: [PATCH] usb: dwc3: workaround: disable device-initiated U1/U2

2017-09-29 Thread Felipe Balbi
Hi, Felipe Balbi writes: > (first things first: use get-maintainer.pl. You should have Cc:ed linux-usb) apologies. Just now I noticed that you did Cc linux-usb. -- balbi signature.asc Description: PGP signature

Re: [GIT PULL] USB: fixes for v4.14-rc3

2017-09-29 Thread Greg Kroah-Hartman
On Fri, Sep 29, 2017 at 10:38:18AM +0300, Felipe Balbi wrote: > > Hi Greg, > > Here's the second set of fixes for this -rc cycle. > > Surprisingly, no fixes on dwc3, just a new device ID. I guess we can > call dwc3 done :-p > > Anyway, let me know if you want anything to be changed. Looks good

Re: usb/serial/visor: slab-out-of-bounds in palm_os_3_probe

2017-09-29 Thread Greg Kroah-Hartman
On Thu, Sep 28, 2017 at 07:57:46PM +0200, Andrey Konovalov wrote: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. > > On commit dc972a67cc54585bd83ad811c4e9b6ab3dcd427e (4.14-rc2+). > > There's no check on the connection_info->num_ports value when > iterating ove

[PATCH] xhci: Cancel cmd_timer before cleanup the command queue in xhci_hc_died()

2017-09-29 Thread Jeffy Chen
When the cmd_timer fired, it would try to access the command struct. So cancel it before cleanup the command queue in xhci_hc_died(), to avoid use-after-free reported by KASAN: [ 176.952537] BUG: KASAN: use-after-free in xhci_handle_command_timeout+0x68/0x224 [ 176.960846] Write of size 4 at add

RE: Type-C port on the Asmedia ASM1142

2017-09-29 Thread David Laight
From: Adrian Bocaniciu > Sent: 28 September 2017 20:25 .. > The correct names used in the new specification for the 4 speeds that can be > supported by a USB 3 > interface are: "Gen 1x1", "Gen 2x1", "Gen 1x2" and "Gen 2x2". I think I'd add the speed itself as well. David -- To unsubscri

[PATCH v2] xhci: Cleanup current_cmd in xhci_cleanup_command_queue()

2017-09-29 Thread Jeffy Chen
KASAN reported use-after-free bug when xhci host controller died: [ 176.952537] BUG: KASAN: use-after-free in xhci_handle_command_timeout+0x68/0x224 [ 176.960846] Write of size 4 at addr ffc0cbb01608 by task kworker/3:3/1680 ... [ 177.180644] Freed by task 0: [ 177.183882] kasan_slab_free

Re: usb/serial/visor: slab-out-of-bounds in palm_os_3_probe

2017-09-29 Thread Andrey Konovalov
On Fri, Sep 29, 2017 at 10:37 AM, Greg Kroah-Hartman wrote: > On Thu, Sep 28, 2017 at 07:57:46PM +0200, Andrey Konovalov wrote: >> Hi! >> >> I've got the following report while fuzzing the kernel with syzkaller. >> >> On commit dc972a67cc54585bd83ad811c4e9b6ab3dcd427e (4.14-rc2+). >> >> There's no

Re: usb/misc/usbtest: null-ptr-deref in usbtest_probe/get_endpoints

2017-09-29 Thread Andrey Konovalov
On Thu, Sep 28, 2017 at 7:01 PM, Alan Stern wrote: > On Thu, 28 Sep 2017, Andrey Konovalov wrote: > >> Hi! >> >> I've got the following report while fuzzing the kernel with syzkaller. >> >> On commit dc972a67cc54585bd83ad811c4e9b6ab3dcd427e (4.14-rc2+). >> >> It seems that out pointer ends up bein

[PATCH 2/3] usb: gadget: udc: renesas_usb3: Add suspend/resume functions

2017-09-29 Thread Yoshihiro Shimoda
This patch adds support suspend/resume functions Signed-off-by: Kazuya Mizuguchi [shimoda: add the commit log] Signed-off-by: Yoshihiro Shimoda --- drivers/usb/gadget/udc/renesas_usb3.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/usb/gadget/ud

[PATCH 0/3] usb: gadget: udc: renesas_usb3: add suspend/resume and generic phy

2017-09-29 Thread Yoshihiro Shimoda
This patch set is based on the latest Felipe's usb.git / testing/next branch (commit id = af846d7ab55c846af6d6f150e9af96295101e068) Kazuya Mizuguchi (1): usb: gadget: udc: renesas_usb3: move pm_runtime_{en,dis}able() Yoshihiro Shimoda (2): usb: gadget: udc: renesas_usb3: Add suspend/resume fu

[PATCH 1/3] usb: gadget: udc: renesas_usb3: move pm_runtime_{en,dis}able()

2017-09-29 Thread Yoshihiro Shimoda
From: Kazuya Mizuguchi This patch moves pm_runtime_{en,dis}able() call timing to renesas_usb3_{probe,remove}() for supporting PM_SLEEP feature in the future. Signed-off-by: Kazuya Mizuguchi [shimoda: Revise the commit log] Signed-off-by: Yoshihiro Shimoda --- drivers/usb/gadget/udc/renesas_us

[PATCH 3/3] usb: gadget: udc: renesas_usb3: add support for generic phy

2017-09-29 Thread Yoshihiro Shimoda
This patch adds support for generic phy as an optional. If you want to use a generic phy (e.g. phy-rcar-gen3-usb3 driver) on this driver, you have to do "insmod phy-rcar-gen3-usb3.ko" first for now. Signed-off-by: Yoshihiro Shimoda --- .../devicetree/bindings/usb/renesas_usb3.txt | 4

[PATCH] usb: phy: tegra: Fix phy suspend for UDC

2017-09-29 Thread Jon Hunter
Commit dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124") added UDC support for Tegra but with UDC support enabled, is was found that Tegra30, Tegra114 and Tegra124 would hang on entry to suspend. The hang occurred during the suspend of the USB PHY when the Tegra PHY driver attempt

Re: [PATCH] usb: phy: tegra: Fix phy suspend for UDC

2017-09-29 Thread Jon Hunter
Adding Dmitry ... Felipe, Thierry, this is needed for v4.14-rc because suspend is currently broken for some Tegra devices. Jon On 29/09/17 14:06, Jon Hunter wrote: > Commit dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124") > added UDC support for Tegra but with UDC support enabl

Re: [PATCH] extcon: Split out extcon header file for consumer and provider device

2017-09-29 Thread Sebastian Reichel
Hi, On Fri, Sep 29, 2017 at 09:01:45AM +0900, Chanwoo Choi wrote: > The extcon has two type of extcon devices as following. > - 'extcon provider deivce' adds new extcon device and detect the >state/properties of external connector. Also, it notifies the >state/properties to the extcon cons

Re: [PATCH 07/12] usb: mtu3: add support for usb3.1 IP

2017-09-29 Thread Chunfeng Yun
On Thu, 2017-09-28 at 08:17 +0800, Chunfeng Yun wrote: > Support SuperSpeedPlus for usb3.1 device IP > > Signed-off-by: Chunfeng Yun > --- > drivers/usb/mtu3/mtu3.h|1 + > drivers/usb/mtu3/mtu3_core.c | 14 +++--- > drivers/usb/mtu3/mtu3_gadget.c |3 ++- >

Re: [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS

2017-09-29 Thread Amelie DELAUNAY
Hi, Gentle ping for driver review submitted on August 28th. Thanks, Amelie On 08/28/2017 04:20 PM, Amelie Delaunay wrote: > This patch adds the dwc2_set_params function for STM32F7 USB OTG HS. > > Signed-off-by: Amelie Delaunay > --- > drivers/usb/dwc2/params.c | 11 +++ > 1 file ch

[PATCH] usb: usbtest: fix NULL pointer dereference

2017-09-29 Thread Alan Stern
If the usbtest driver encounters a device with an IN bulk endpoint but no OUT bulk endpoint, it will try to dereference a NULL pointer (out->desc.bEndpointAddress). The problem can be solved by adding a missing test. Signed-off-by: Alan Stern Reported-by: Andrey Konovalov Tested-by: Andrey Kono

Re: [PATCH] usb: phy: tegra: Fix phy suspend for UDC

2017-09-29 Thread Dmitry Osipenko
On 29.09.2017 16:10, Jon Hunter wrote: > Adding Dmitry ... > > Felipe, Thierry, this is needed for v4.14-rc because suspend is currently > broken for some Tegra devices. > > Jon > > On 29/09/17 14:06, Jon Hunter wrote: >> Commit dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124")

Re: [PATCH] usb: phy: tegra: Fix phy suspend for UDC

2017-09-29 Thread Dmitry Osipenko
On 29.09.2017 17:57, Dmitry Osipenko wrote: > On 29.09.2017 16:10, Jon Hunter wrote: >> Adding Dmitry ... >> >> Felipe, Thierry, this is needed for v4.14-rc because suspend is currently >> broken for some Tegra devices. >> >> Jon >> >> On 29/09/17 14:06, Jon Hunter wrote: >>> Commit dfebb5f43a78 ("

Re: [PATCH] usb: phy: tegra: Fix phy suspend for UDC

2017-09-29 Thread Jon Hunter
On 29/09/17 15:57, Dmitry Osipenko wrote: > On 29.09.2017 16:10, Jon Hunter wrote: >> Adding Dmitry ... >> >> Felipe, Thierry, this is needed for v4.14-rc because suspend is currently >> broken for some Tegra devices. >> >> Jon >> >> On 29/09/17 14:06, Jon Hunter wrote: >>> Commit dfebb5f43a78 ("u

[PATCH 2/2] usb: xhci: Reset halted endpoint if trb is noop

2017-09-29 Thread Lu Baolu
When a URB is cancled, xhci driver turns the untransferred trbs into no-ops. If an endpoint stalls on a no-op trb that belongs to the cancelled URB, the event handler won't reset the endpoint. Hence, it will stay halted. Link: http://marc.info/?l=linux-usb&m=149582598330127&w=2 Signed-off-by: Lu

[PATCH 1/2] usb: xhci: Remove ep_trb from xhci_cleanup_halted_endpoint()

2017-09-29 Thread Lu Baolu
Function argument ep_trb for xhci_cleanup_halted_endpoint() isn't needed anymore. Cleanup it. Signed-off-by: Lu Baolu --- drivers/usb/host/xhci-ring.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index a94