Re: [PATCH 1/2] usb: xhci: Support enabling of compliance mode for xhci 1.1

2017-08-24 Thread Mathias Nyman
On 23.08.2017 10:35, Jack Pham wrote: To perform SuperSpeed compliance testing the port should first be placed into compliance mode. For xHCI 1.0 and prior this transition happens automatically when the port is in Training and encounters an LFPS timeout. Thus running compliance tests against a te

Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C

2017-08-24 Thread Kai-Heng Feng
On Mon, Aug 21, 2017 at 6:03 PM, Dmitry Fleytman wrote: > Commit e0429362ab15 > ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") > introduced quirk to workaround an issue with some Logitech webcams. > > Apparently model C920-C has the same issue so applying > the same quirk as

[PATCH] USB: core: constify vm_operations_struct

2017-08-24 Thread Arvind Yadav
vm_operations_struct are not supposed to change at runtime. All functions working with const vm_operations_struct. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/usb/core/devio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core

ASM1153 detected as ASM1051 and breaking UAS

2017-08-24 Thread Massimo Burcheri
Hello, as reported on https://bugzilla.kernel.org/show_bug.cgi?id=196739 a Transcend 25M3 device with ASM1153 chipset is detected as ASM1051 and breaking UAS support as this one is blacklisted. But after contacting the manufacturer claimed this model has a ASM1153 and supported by UASP. So I doub

Re: [PATCH 08/15] PCI: make device_type const

2017-08-24 Thread Bjorn Helgaas
On Sat, Aug 19, 2017 at 01:52:19PM +0530, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Applied to pci/misc for v4.14, thanks! > --- > drivers/pci/endpoint/pci-epf

Re: [PATCH 03/15] [media] i2c: make device_type const

2017-08-24 Thread Guennadi Liakhovetski
On Sat, 19 Aug 2017, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Acked-by: Guennadi Liakhovetski Thanks Guennadi > --- > drivers/media/i2c/soc_camera/mt9t031.

[PATCH 2/6] usb: musb: print an error message when hwep alloc failed

2017-08-24 Thread Bin Liu
Print an error message with qh maxpacket size and hb_mult when hwep allocation failed, so we have a better idea why it is failed. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_host.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_h

[PATCH 0/6] musb patches for v4.14-rc1

2017-08-24 Thread Bin Liu
Hi Greg, These musb patches are for next v4.14-rc1. Two of them fix a bug in PM, and the rest of them improve the error logs and fix 4MB ep fifo buffer allocation. Please let me know if any change is needed. Regards, -Bin. --- Bin Liu (4): usb: musb: add helper function musb_ep_xfertype_string

[PATCH 3/6] usb: musb: print an error message when high bandwidth is unsupported

2017-08-24 Thread Bin Liu
There are multiple places in usb core or controller driver which returns -EMSGSIZE when a class driver queueing urb failed, so the "Message too long" log doesn't help much for understanding the error. Let the musb driver to specifically print a error message when musb_urb_enqueue() returns -EMSGSI

[PATCH 4/6] usb: musb: fix endpoint fifo allocation for 4KB fifo memory

2017-08-24 Thread Bin Liu
The fifo memory allocation in mode_2_cfg[] doesn't utilize all the 4KB memory. Increse some endpoint fifo buffers to fully use all the 4KB memory. Now we can support more webcam usecases on DA8xx. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH 6/6] USB: musb: dsps: add explicit runtime resume at suspend

2017-08-24 Thread Bin Liu
From: Johan Hovold The musb_dsps driver is special in that the parent (glue) device's driver is accessing registers mapped by the child. The clock is however shared and is managed by the grandparent device. Since commit 869c59782981 ("usb: musb: dsps: add support for suspend and resume") the dsp

[PATCH 5/6] USB: musb: fix external abort on suspend

2017-08-24 Thread Bin Liu
From: Johan Hovold Make sure that the controller is runtime resumed when system suspending to avoid an external abort when accessing the interrupt registers: Unhandled fault: external abort on non-linefetch (0x1008) at 0xd025840a ... [] (musb_default_readb) from [] (musb_disable_interrupt

[PATCH 1/6] usb: musb: add helper function musb_ep_xfertype_string

2017-08-24 Thread Bin Liu
Add helper function musb_ep_xfertype_string() to return the ep transfer type string. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.h | 24 drivers/usb/musb/musb_gadget.c | 6 +- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/drivers/usb/mu

Re: [PATCH 11/15] remoteproc: make device_type const

2017-08-24 Thread Bjorn Andersson
On Sat 19 Aug 01:22 PDT 2017, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Applied, thanks. Regards, Bjorn > --- > drivers/remoteproc/remoteproc_core.c | 2 +- >

[PATCH v2] usb: gadget: f_midi: Use snd_card_free_when_closed with refcount

2017-08-24 Thread Jerry Zhang
Currently, f_midi_free uses snd_card_free, which will wait until the user has released the sound card before returning. However, if the user doesn't release the sound card, then f_midi_free can block for an arbitrary amount of time, which also blocks any gadget operations on that thread. Instead,

[PATCH] usb: gadget: Add kerneldoc for some neglected structure fields

2017-08-24 Thread Jonathan Corbet
A couple of structures in have incomplete kerneldoc comments, leading to these warnings in the docs build: ./include/linux/usb/gadget.h:230: warning: No description found for parameter 'claimed' ./include/linux/usb/gadget.h:230: warning: No description found for parameter 'enabled' ./include/li

[PATCH] USB: serial: ti_usb_3410_5052: remove unnecessary brace

2017-08-24 Thread Himanshu Jha
Braces are not required for single statement blocks. Issue found using checkpatch.pl Signed-off-by: Himanshu Jha --- drivers/usb/serial/ti_usb_3410_5052.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410

Re: ASM1153 detected as ASM1051 and breaking UAS

2017-08-24 Thread Greg KH
On Thu, Aug 24, 2017 at 02:05:22PM +0200, Massimo Burcheri wrote: > Hello, > > as reported on > https://bugzilla.kernel.org/show_bug.cgi?id=196739 > > a Transcend 25M3 device with ASM1153 chipset is detected as ASM1051 and > breaking > UAS support as this one is blacklisted. But after contacting

Re: [PATCH v6 3/8] usb: chipidea: Add support for Tegra20/30/114/124

2017-08-24 Thread Peter Chen
On Wed, Aug 16, 2017 at 01:38:54PM +0300, Dmitry Osipenko wrote: > Peter, you've applied the v3 of this patch to your local tree and so it is > already in linux-next. Don't you mind to pick up a newer version of the patch? > Your patches are updated at my tree. -- Best Regards, Peter Chen -- T

[PATCH] usb: chipidea: usb2: check memory allocation failure

2017-08-24 Thread Christophe JAILLET
Check memory allocation failure and return -ENOMEM in such a case, as already done few lines below for another memory allocation. Signed-off-by: Christophe JAILLET --- drivers/usb/chipidea/ci_hdrc_usb2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b

Re: [PATCH v6 3/8] usb: chipidea: Add support for Tegra20/30/114/124

2017-08-24 Thread Dmitry Osipenko
On 25.08.2017 06:07, Peter Chen wrote: > On Wed, Aug 16, 2017 at 01:38:54PM +0300, Dmitry Osipenko wrote: >> Peter, you've applied the v3 of this patch to your local tree and so it is >> already in linux-next. Don't you mind to pick up a newer version of the >> patch? >> > > Your patches are upda