Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

2017-06-12 Thread Kai-Heng Feng
On Fri, Jun 9, 2017 at 10:43 PM, Alan Stern wrote: > On Fri, 9 Jun 2017, Kai-Heng Feng wrote: > >> As Alan Stern points out [1], the PME signal is not enabled when >> controller is in D3, therefore it's not being woken up when new deivces >> get plugged in. >> >> Workaround this bug by preventing

Re: Piping f_acm to real hardware

2017-06-12 Thread Greg KH
On Sun, Jun 11, 2017 at 11:41:02PM +0300, Tal Shorer wrote: > I'm currently working on a project where I'd like to have an omap board > running linux be a usb-to-uart converter (using f_acm). I have an > application that holds both the ttyGS* and the ttyO* port (the physical > uart port) open, poll

[PATCH v1] net/phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread Yuval Shaia
Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia Acked-by: Sergei Shtylyov --- Re-sending since last time forgot to add netdev-list v0 ->v1: * These files were missing in v0 * drivers/net/ethernet/renesas/ravb_main.c

[PATCH] phy: cpcap-usb: Fix missing return statement

2017-06-12 Thread Tony Lindgren
Commit 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") is missing return statement as noted by Colin Ian King . If the optional pins are not configured, we just want to return early and not attempt to configure the pins. Fixes: 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support"

Re: [PATCH v2] USB: qcserial: expose methods for modem control

2017-06-12 Thread Johan Hovold
On Sun, Jun 11, 2017 at 11:32:43PM -0700, mag...@gmail.com wrote: Thanks for resending. The eaten-tabs issue is gone, but there are still a few minor issues you should fix up. > This is v2, attempting to correct formatting problems with the patch. This type of meta information should not go in t

[PATCH net-next 1/2] r8152: split rtl8152_resume function

2017-06-12 Thread Hayes Wang
Split rtl8152_resume() into rtl8152_runtime_resume() and rtl8152_system_resume(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 99 ++--- 1 file changed, 61 insertions(+), 38 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/us

[PATCH net-next 2/2] r8152: move calling delay_autosuspend function

2017-06-12 Thread Hayes Wang
Move calling delay_autosuspend() in rtl8152_runtime_suspend(). Calling delay_autosuspend() as late as possible. The original flows are 1. check if the driver/device is busy now. 2. set wake events. 3. enter runtime suspend. If the wake event occurs between (1) and (2), the device may mis

[PATCH net-next 0/2] r8152: adjust runtime suspend/resume

2017-06-12 Thread Hayes Wang
Improve the flow about runtime suspend/resume and make the code easy to read. Hayes Wang (2): r8152: split rtl8152_resume function r8152: move calling delay_autosuspend function drivers/net/usb/r8152.c | 107 1 file changed, 62 insertions(+),

Re: usb/serial/option.c: Please add new vendor and product id 1c9e:9801

2017-06-12 Thread Johan Hovold
On Sun, Jun 11, 2017 at 07:50:46PM +0300, Teemu Likonen wrote: > Hello USB maintainers! > > I have a Telewell TW-3G HSPA+ USB modem which works with driver > usb/serial/option.c. However, the device is not automatically detected. Thanks for reporting this. > I'm a newbie in these driver things b

Re: usb/serial/option.c: Please add new vendor and product id 1c9e:9801

2017-06-12 Thread Teemu Likonen
Johan Hovold [2017-06-12 10:24:11+02] wrote: > What is the output of "lsusb -v" for this device? Thanks and here it comes: Bus 001 Device 009: ID 1c9e:9801 OMEGA TECHNOLOGY Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass

[PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Johan Hovold
Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the Longcheer vendor id. Reported-by: Teemu Likonen Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/option.c | 4 1 file changed, 4 insertions(+) Teemu, would you be able to test this patch? Thanks, Johan

Re: usb/serial/option.c: Please add new vendor and product id 1c9e:9801

2017-06-12 Thread Lars Melin
On 2017-06-12 15:46, Teemu Likonen wrote: Johan Hovold [2017-06-12 10:24:11+02] wrote: What is the output of "lsusb -v" for this device? Interface usage: MI_00 Wireless Diagnostics MI_01 Wireless Modem MI_02 Wireless Application MI_03 Wireless Data Device Ethernet Adapter (qmi_wwan) MI_04

Re: [PATCH] phy: cpcap-usb: Fix missing return statement

2017-06-12 Thread Sebastian Reichel
Hi, On Mon, Jun 12, 2017 at 01:12:23AM -0700, Tony Lindgren wrote: > Commit 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") > is missing return statement as noted by Colin Ian King > . If the optional pins are not configured, > we just want to return early and not attempt to configure

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Bjørn Mork
Johan Hovold writes: > Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the > Longcheer vendor id. > > Reported-by: Teemu Likonen > Cc: stable > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/option.c | 4 > 1 file changed, 4 insertions(+) > > Teemu, would you b

Re: usb/serial/option.c: Please add new vendor and product id 1c9e:9801

2017-06-12 Thread Johan Hovold
On Mon, Jun 12, 2017 at 04:34:56PM +0700, Lars Melin wrote: > On 2017-06-12 15:46, Teemu Likonen wrote: > > Johan Hovold [2017-06-12 10:24:11+02] wrote: > > > >> What is the output of "lsusb -v" for this device? > > > > Interface usage: > > MI_00 Wireless Diagnostics > MI_01 Wireless Modem > MI

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Teemu Likonen
Johan Hovold [2017-06-12 11:16:12+02] wrote: > Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the > Longcheer vendor id. > > Reported-by: Teemu Likonen > Cc: stable > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/option.c | 4 > 1 file changed, 4 insertions(+)

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Oliver Neukum
Am Montag, den 12.06.2017, 11:50 +0200 schrieb Bjørn Mork: > It's not clear what type of driver the 'cmntnet.sys' installed by this > is, but I wonder if it maybe is QMI based on the 'qc' prefix? QualCom I am afraid it says nothing about the protocol. Regards Oliver -- T

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

2017-06-12 Thread Kai-Heng Feng
On Mon, Jun 12, 2017 at 3:04 PM, Kai-Heng Feng wrote: > On Fri, Jun 9, 2017 at 10:43 PM, Alan Stern wrote: >> On Fri, 9 Jun 2017, Kai-Heng Feng wrote: >> >> Is this really the right solution? Maybe it would be better to allow >> the controller to go into D3 provided no wakeup signal is needed.

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Johan Hovold
[ +CC: Lars ] On Mon, Jun 12, 2017 at 11:50:13AM +0200, Bjørn Mork wrote: > Johan Hovold writes: > > > Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the > > Longcheer vendor id. > > > > Reported-by: Teemu Likonen > > Cc: stable > > Signed-off-by: Johan Hovold > > --- > >

Re: ASIX AX88772 USB 2.0 Ethernet stops working after kernel 4.8

2017-06-12 Thread Oliver Neukum
Am Montag, den 15.05.2017, 18:26 +0300 schrieb Andrey Aleksandrovich: > > > > Please try to revert > > 535baf8588d04b177cb33700f81499f2b5203c2d > > Sorry, not understood what to try? > I've checked today snapshot of 4.11.1 and 4.12 > Both have the bug. > -- > To unsubscribe from this list: send t

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Johan Hovold
[ +CC: Lars, resend with Lars actually on CC ] On Mon, Jun 12, 2017 at 11:50:13AM +0200, Bjørn Mork wrote: > Johan Hovold writes: > > > Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the > > Longcheer vendor id. > > > > Reported-by: Teemu Likonen > > Cc: stable > > Signed-o

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Johan Hovold
On Mon, Jun 12, 2017 at 01:11:18PM +0300, Teemu Likonen wrote: > Johan Hovold [2017-06-12 11:16:12+02] wrote: > > > Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the > > Longcheer vendor id. > > > > Reported-by: Teemu Likonen > > Cc: stable > > Signed-off-by: Johan Hovold >

Re: Piping f_acm to real hardware

2017-06-12 Thread Tal Shorer
On Mon, Jun 12, 2017 at 9:48 AM, Greg KH wrote: > On Sun, Jun 11, 2017 at 11:41:02PM +0300, Tal Shorer wrote: >> I'm currently working on a project where I'd like to have an omap board >> running linux be a usb-to-uart converter (using f_acm). I have an >> application that holds both the ttyGS* an

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Lars Melin
On 2017-06-12 16:50, Bjørn Mork wrote: Johan Hovold writes: Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the Longcheer vendor id. Reported-by: Teemu Likonen Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/option.c | 4 1 file changed, 4 insertion

Re: [PATCH v2 0/3] New driver for UCSI (USB Type-C)

2017-06-12 Thread Heikki Krogerus
On Fri, Jun 09, 2017 at 06:30:30AM -0700, Guenter Roeck wrote: > On 06/09/2017 04:03 AM, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Mon, Jun 05, 2017 at 05:30:22PM +0300, Heikki Krogerus wrote: > > > Hi, > > > > > > This moves the current ucsi driver from drivers/usb/misc/ucsi.c to the > >

Re: [PATCH v1] usb: dwc3: gadget: increase readability of dwc3_gadget_init_endpoints()

2017-06-12 Thread Felipe Balbi
Hi, Andy Shevchenko writes: > The commit 47d3946ea220 > usb: dwc3: refactor gadget endpoint count calculation > refactored dwc3_gadget_init_endpoints() and in particular changed in our > out endpoint numbering to be through. It's not always convenient and > makes code a slightly harder to

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Bjørn Mork
Lars Melin writes: > 1c9e:9803 can be added, the other ones may be reserved id's for > products that never reached the market. Out of curiosity: How do you know these things? Thanks for very valuable information. Our lists of supported devices are long enough without lots of dead entries...

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-06-12 Thread Felipe Balbi
Hi, kbuild test robot writes: > Hi Felipe, > > [auto build test ERROR on balbi-usb/next] > [also build test ERROR on v4.12-rc4 next-20170609] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] this patch depends on another patch [1] in order

[PATCH] usb: dwc3: exynos: Handle return value of clk_prepare_enable

2017-06-12 Thread Arvind Yadav
clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/usb/dwc3/dwc3-exynos.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c index 98f74ff..

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Lars Melin
On 2017-06-12 17:37, Bjørn Mork wrote: Lars Melin writes: 1c9e:9803 can be added, the other ones may be reserved id's for products that never reached the market. Out of curiosity: How do you know these things? Thanks for very valuable information. Our lists of supported devices are long en

[PATCH] usb: host: ehci-exynos: Handle return value of clk_prepare_enable

2017-06-12 Thread Arvind Yadav
clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/usb/host/ehci-exynos.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 7a603f6..26b6411 1006

Re: Continuous, infinite warm reset attempts in Chipidea HDRC on multiple connect-disconects

2017-06-12 Thread lingareddy praneethreddy
On Fri, Jun 9, 2017 at 8:01 PM, Alan Stern wrote: > On Fri, 9 Jun 2017, lingareddy praneethreddy wrote: > >> Thanks Alan. I understand and agree. >> >> It is a legacy platform that we are supporting and I needed to address >> this issue on 3.10.17. We are in the process of migrating to 4.1.x >> th

Re: Piping f_acm to real hardware

2017-06-12 Thread Greg KH
On Mon, Jun 12, 2017 at 01:17:18PM +0300, Tal Shorer wrote: > On Mon, Jun 12, 2017 at 9:48 AM, Greg KH wrote: > > On Sun, Jun 11, 2017 at 11:41:02PM +0300, Tal Shorer wrote: > >> I'm currently working on a project where I'd like to have an omap board > >> running linux be a usb-to-uart converter (

Re: [PATCH v2 1/2] usb: typec: Add support for UCSI interface

2017-06-12 Thread Heikki Krogerus
Hi, On Fri, Jun 09, 2017 at 07:52:56PM -0700, Guenter Roeck wrote: > > diff --git a/drivers/usb/typec/ucsi/debug.h b/drivers/usb/typec/ucsi/debug.h > > new file mode 100644 > > index ..87d0cd20597a > > --- /dev/null > > +++ b/drivers/usb/typec/ucsi/debug.h > > @@ -0,0 +1,64 @@ > > +#if

Re: [PATCH] usb: host: ehci-exynos: Handle return value of clk_prepare_enable

2017-06-12 Thread Krzysztof Kozlowski
On Mon, Jun 12, 2017 at 04:45:14PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/host/ehci-exynos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozl

Re: [PATCH] usb: dwc3: exynos: Handle return value of clk_prepare_enable

2017-06-12 Thread Krzysztof Kozlowski
On Mon, Jun 12, 2017 at 04:23:31PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/dwc3/dwc3-exynos.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > Reviewed-by: Kr

[GIT PULL] USB fixes for v4.12-rc5

2017-06-12 Thread Felipe Balbi
Hi Greg, here's what I hope to be my last pull request for the current -rc cycle. Let me know if you want anything to be changed. cheers The following changes since commit afbbc7913a288c29616bd31ae612548f6475151a: usb: gadget: udc: renesas_usb3: Fix PN_INT_ENA disabling timing (2017-06-02

Re: resolving issue by: USB_AUTOSUSPEND=0

2017-06-12 Thread Oliver Neukum
Am Dienstag, den 23.05.2017, 11:23 +0200 schrieb Daniel Duris: > Sorry about that, -v output here: > Hi, sorry about the delay. Could you apply the attached debugging patch, raise logging level and report the result? Regards Oliver From 96ab31dc4870f9104b77a40e26052d062b

[PATCH v2] usb: dwc3: gadget: increase readability of dwc3_gadget_init_endpoints()

2017-06-12 Thread Andy Shevchenko
The commit 47d3946ea220 usb: dwc3: refactor gadget endpoint count calculation refactored dwc3_gadget_init_endpoints() and in particular changed in or out endpoint numbering to be through. It's not always convenient and makes code a slightly harder to read. Introduce a new temporary varia

Re: resolving issue by: USB_AUTOSUSPEND=0

2017-06-12 Thread Daniel Duris
Hi, If you please provide a way how to do it, then yes of course. Thanks, D. On 12.06.2017 14:06, Oliver Neukum wrote: > Am Dienstag, den 23.05.2017, 11:23 +0200 schrieb Daniel Duris: >> Sorry about that, -v output here: >> > Hi, > > sorry about the delay. Could you apply the attached debugging

Re: [PATCH v2] usb: dwc3: gadget: increase readability of dwc3_gadget_init_endpoints()

2017-06-12 Thread Felipe Balbi
Hi, Andy Shevchenko writes: > The commit 47d3946ea220 > > usb: dwc3: refactor gadget endpoint count calculation > > refactored dwc3_gadget_init_endpoints() and in particular changed in or > out endpoint numbering to be through. It's not always convenient and > makes code a slightly harder

Re: [PATCH v2] usb: dwc3: gadget: increase readability of dwc3_gadget_init_endpoints()

2017-06-12 Thread Felipe Balbi
Hi, Felipe Balbi writes: >> The commit 47d3946ea220 >> >> usb: dwc3: refactor gadget endpoint count calculation >> >> refactored dwc3_gadget_init_endpoints() and in particular changed in or >> out endpoint numbering to be through. It's not always convenient and >> makes code a slightly hard

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

2017-06-12 Thread Baxter, Jim
From: Oliver Neukum (oneu...@suse.com) Sent: Mon, 12 Jun 2017 12:24:07 +0200 > Am Dienstag, den 23.05.2017, 20:06 +0100 schrieb Jim Baxter: >> From: David S. Miller (da...@davemloft.net) >> Sent: Tue, 23 May 2017 11:26:25 -0400 >>> >>> From: Oliver Neukum >>> Date: Tue, 23 May 2017 10:42:48 +020

Re: [PATCH net-next 1/2] r8152: split rtl8152_resume function

2017-06-12 Thread Oliver Neukum
Am Montag, den 12.06.2017, 16:21 +0800 schrieb Hayes Wang: > Split rtl8152_resume() into rtl8152_runtime_resume() and > rtl8152_system_resume(). > > Signed-off-by: Hayes Wang > --- >  drivers/net/usb/r8152.c | 99 > ++--- >  1 file changed, 61 insertion

Re: [PATCH v2 1/2] usb: typec: Add support for UCSI interface

2017-06-12 Thread Heikki Krogerus
Hi Guenter, On Mon, Jun 12, 2017 at 02:55:49PM +0300, Heikki Krogerus wrote: > > > +/* Command Status and Connector Change Indication (CCI) data structure */ > > > +struct ucsi_cci { > > > + u8:1; /* reserved */ > > > + u8 connector_change:7; > > > + u8 data_length; > > > + u16:9; /* reserved */ >

Re: FW: Unable to perform remote wakeup of host with USB HID Composite Device

2017-06-12 Thread Oliver Neukum
Am Dienstag, den 06.06.2017, 12:30 + schrieb Abdulhadi Mohamed: > Hi > > I apologize in advance for this is my first email using this mailing list but > I could really use some help. I have connected a composite USB device running > the 4.0 Linux kernel to a PC running Ubuntu. One of its fu

Re: Piping f_acm to real hardware

2017-06-12 Thread Tal Shorer
On Mon, Jun 12, 2017 at 2:42 PM, Greg KH wrote: > On Mon, Jun 12, 2017 at 01:17:18PM +0300, Tal Shorer wrote: >> On Mon, Jun 12, 2017 at 9:48 AM, Greg KH wrote: >> > On Sun, Jun 11, 2017 at 11:41:02PM +0300, Tal Shorer wrote: >> >> I'm currently working on a project where I'd like to have an omap

Re: [PATCH v2 1/2] usb: typec: Add support for UCSI interface

2017-06-12 Thread Guenter Roeck
On 06/12/2017 05:41 AM, Heikki Krogerus wrote: Hi Guenter, On Mon, Jun 12, 2017 at 02:55:49PM +0300, Heikki Krogerus wrote: +/* Command Status and Connector Change Indication (CCI) data structure */ +struct ucsi_cci { + u8:1; /* reserved */ + u8 connector_change:7; + u8 data_l

Re: Piping f_acm to real hardware

2017-06-12 Thread Greg KH
On Mon, Jun 12, 2017 at 04:00:56PM +0300, Tal Shorer wrote: > On Mon, Jun 12, 2017 at 2:42 PM, Greg KH wrote: > > On Mon, Jun 12, 2017 at 01:17:18PM +0300, Tal Shorer wrote: > >> On Mon, Jun 12, 2017 at 9:48 AM, Greg KH > >> wrote: > >> > On Sun, Jun 11, 2017 at 11:41:02PM +0300, Tal Shorer wrot

RE: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-12 Thread Mario.Limonciello
> -Original Message- > From: Lars Chang(張家豪) [mailto:lars_ch...@asmedia.com.tw] > Sent: Friday, June 9, 2017 1:34 AM > To: 'Felipe Balbi' ; Jiahau Chang > ; linux-usb@vger.kernel.org; mathias.ny...@intel.com > Cc: Brain Lee(李魁中) ; Limonciello, Mario > ; Justin_CY Chen(陳志勇) > ; Wang, Keith ;

Re: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-12 Thread Greg KH
On Mon, Jun 12, 2017 at 01:28:57PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Lars Chang(張家豪) [mailto:lars_ch...@asmedia.com.tw] > > Sent: Friday, June 9, 2017 1:34 AM > > To: 'Felipe Balbi' ; Jiahau Chang > > ; linux-usb@vger.kernel.org; mathias.ny...@intel.c

Re: [PATCH v1] net/phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: Yuval Shaia Date: Mon, 12 Jun 2017 10:42:33 +0300 > Make return value void since function never return meaningfull value > > Signed-off-by: Yuval Shaia > Acked-by: Sergei Shtylyov > --- > Re-sending since last time forgot to add netdev-list > v0 ->v1: > * These files were missing i

RE: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-12 Thread Mario.Limonciello
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, June 12, 2017 8:42 AM > To: Limonciello, Mario > Cc: lars_ch...@asmedia.com.tw; felipe.ba...@linux.intel.com; > jia...@gmail.com; linux-usb@vger.kernel.org; mathias.ny...@intel.com; > brain_...@asmedia

Re: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-12 Thread Greg KH
On Mon, Jun 12, 2017 at 01:52:36PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Monday, June 12, 2017 8:42 AM > > To: Limonciello, Mario > > Cc: lars_ch...@asmedia.com.tw; felipe.ba...@linux.intel.com; > > j

Re: [GIT PULL] USB fixes for v4.12-rc5

2017-06-12 Thread Greg KH
On Mon, Jun 12, 2017 at 03:06:37PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's what I hope to be my last pull request for the current -rc > cycle. > > Let me know if you want anything to be changed. > > cheers > > The following changes since commit afbbc7913a288c29616bd31ae612548f647515

Re: [PATCH] usb: host: ehci-exynos: Handle return value of clk_prepare_enable

2017-06-12 Thread Alan Stern
On Mon, 12 Jun 2017, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/host/ehci-exynos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-exynos.c b/

RE: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-12 Thread Mario.Limonciello
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, June 12, 2017 9:02 AM > To: Limonciello, Mario > Cc: lars_ch...@asmedia.com.tw; felipe.ba...@linux.intel.com; > jia...@gmail.com; linux-usb@vger.kernel.org; mathias.ny...@intel.com; > brain_...@asmedia

patch "USB: usbip: convert to use DRIVER_ATTR_RW" added to driver-core-testing

2017-06-12 Thread gregkh
This is a note to let you know that I've just added the patch titled USB: usbip: convert to use DRIVER_ATTR_RW to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-testing branch. The patch will show up

[PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread Yuval Shaia
Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia Acked-by: Sergei Shtylyov --- v0 ->v1: * These files were missing in v0 * drivers/net/ethernet/renesas/ravb_main.c * drivers/net/ethernet/renesas/sh_eth.c

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

2017-06-12 Thread Alan Stern
Let's get some help from people who understand PCI well. Here's the general problem: Kai-Heng has a PCI-based USB host controller that advertises wakeup capability from D3, but it doesn't assert PME# from D3 when it should. For "lspci -vv" output, see http://marc.info/?l=linux-usb&m=14

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: Yuval Shaia Date: Mon, 12 Jun 2017 17:15:08 +0300 > Make return value void since function never return meaningfull value > > Signed-off-by: Yuval Shaia > Acked-by: Sergei Shtylyov > --- > v0 ->v1: > * These files were missing in v0 > * drivers/net/ethernet/renesas/rav

Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

2017-06-12 Thread Johan Hovold
On Mon, Jun 12, 2017 at 06:02:16PM +0700, Lars Melin wrote: > On 2017-06-12 17:37, Bjørn Mork wrote: > > Lars Melin writes: > > > >> 1c9e:9803 can be added, the other ones may be reserved id's for > >> products that never reached the market. > > > > Out of curiosity: How do you know these things

[PATCH v2] USB: serial: option: add two Longcheer device ids

2017-06-12 Thread Johan Hovold
Add two Longcheer device-id entries which specifically enables the Telewell TW-3G HSPA+ branded modem. Reported-by: Teemu Likonen Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/option.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers

[PATCH v3 1/2] usb: typec: Add support for UCSI interface

2017-06-12 Thread Heikki Krogerus
UCSI - USB Type-C Connector System Software Interface - is a specification that defines set of registers and data structures for controlling the USB Type-C ports. It's designed for systems where an embedded controller (EC) is in charge of the USB Type-C PHY or USB Power Delivery controller. It is d

[PATCH v3 0/2] New driver for UCSI (USB Type-C)

2017-06-12 Thread Heikki Krogerus
Hi, This moves the current ucsi driver from drivers/usb/misc/ucsi.c to the new USB Type-C class (drivers/usb/typec/). That allows us to finally do role swapping. The driver is now split into core library part, and ACPI driver. That should make it easy to add support for other interface methods (f

[PATCH v3 2/2] usb: typec: ucsi: Add ACPI driver

2017-06-12 Thread Heikki Krogerus
Driver for ACPI UCSI interface method. This driver replaces the previous UCSI driver drivers/usb/misc/ucsi.c. Signed-off-by: Heikki Krogerus Reviewed-by: Guenter Roeck --- drivers/usb/misc/Kconfig | 26 -- drivers/usb/misc/Makefile | 1 - drivers/usb/misc/ucsi.c

Re: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-12 Thread Mathias Nyman
Hi In addition to Felipes comments I have a few ones myself. On 09.06.2017 05:33, Jiahau Chang wrote: v2 : fix coding format When USB Ethernet is plugged in ASMEDIA ASM1042A xHCI host, bad performance was manifesting in Web browser use (like download large file such as ISO image). It is known

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: David Miller Date: Mon, 12 Jun 2017 10:25:25 -0400 (EDT) > From: Yuval Shaia > Date: Mon, 12 Jun 2017 17:15:08 +0300 > >> Make return value void since function never return meaningfull value >> >> Signed-off-by: Yuval Shaia >> Acked-by: Sergei Shtylyov >> --- >> v0 ->v1: >> * Thes

Re: Piping f_acm to real hardware

2017-06-12 Thread Tal Shorer
On Mon, Jun 12, 2017 at 4:34 PM, Greg KH wrote: > On Mon, Jun 12, 2017 at 04:00:56PM +0300, Tal Shorer wrote: >> On Mon, Jun 12, 2017 at 2:42 PM, Greg KH wrote: >> > On Mon, Jun 12, 2017 at 01:17:18PM +0300, Tal Shorer wrote: >> >> On Mon, Jun 12, 2017 at 9:48 AM, Greg KH >> >> wrote: >> >> > O

RE: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-12 Thread David Laight
From: Mathias Nyman > Sent: 12 June 2017 15:49 Commenting on this copy because it is handy... > On 09.06.2017 05:33, Jiahau Chang wrote: > > v2 : fix coding format > > > > When USB Ethernet is plugged in ASMEDIA ASM1042A xHCI host, bad > > performance was manifesting in Web browser use (like downl

Re: [PATCH v2] USB: serial: option: add two Longcheer device ids

2017-06-12 Thread Teemu Likonen
Johan Hovold [2017-06-12 16:30:16+02] wrote: > Add two Longcheer device-id entries which specifically enables the > Telewell TW-3G HSPA+ branded modem. > > Reported-by: Teemu Likonen > Cc: stable > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/option.c | 4 > 1 file changed, 4 in

Re: usb/gadget: potential deadlock in gadgetfs_suspend

2017-06-12 Thread Andrey Konovalov
On Fri, Jun 9, 2017 at 9:14 PM, Alan Stern wrote: > On Fri, 9 Jun 2017, Andrey Konovalov wrote: > >> On Fri, Jun 9, 2017 at 2:41 PM, Andrey Konovalov >> wrote: >> > Hi, >> > >> > I'm getting some hangs while fuzzing the kernel with syzkaller. >> > >> > Possibly it happens during the execution of

[PATCH 03/11] Creation of "usb_device_auth" LSM hook

2017-06-12 Thread Salvatore Mesoraca
Creation of a new LSM hook that can be used to authorize or deauthorize new USB devices via the usb authorization interface. The same hook can also prevent the authorization of a USB device via "/sys/bus/usb/devices/DEVICE/authorized". Using this hook an LSM could provide an higher level of granula

[PATCH 4.11 078/150] usb: chipidea: imx: Do not access CLKONOFF on i.MX51

2017-06-12 Thread Greg Kroah-Hartman
4.11-stable review patch. If anyone has any objections, please let me know. -- From: Andrey Smirnov commit 62b97d502bb76c6e8d589e42e02bfcb7bdff0453 upstream. Unlike i.MX53, i.MX51's USBOH3 register file does not implemenent registers past offset 0x018, which includes MX53_USB_

Re: usb/gadget: potential deadlock in gadgetfs_suspend

2017-06-12 Thread Andrey Konovalov
On Mon, Jun 12, 2017 at 6:11 PM, Andrey Konovalov wrote: > On Fri, Jun 9, 2017 at 9:14 PM, Alan Stern wrote: >> On Fri, 9 Jun 2017, Andrey Konovalov wrote: >> >>> On Fri, Jun 9, 2017 at 2:41 PM, Andrey Konovalov >>> wrote: >>> > Hi, >>> > >>> > I'm getting some hangs while fuzzing the kernel wi

[PATCH 0/8] Allow f_acm gadgets to notify the user about SetLineCoding requests

2017-06-12 Thread Tal Shorer
I'm currently working on a project where I'd like to have an omap board running linux be a usb-to-uart converter (using f_acm), and I've ran into an issue: there's no way for the application to know if the host has issued a SetLineCoding requests (after which parity/baudrate should be changed to ma

[PATCH 8/8] usb: gadget: u_serial: remove port_line_config from struct gserial

2017-06-12 Thread Tal Shorer
GetLineCoding and SetLineCoding are a cdc-acm thing. It doesn't make sense to have that in the generic u_serial layer. Moreso, f_acm has its own port_line_coding in its own struct and it uses that, while the one in struct gserial is set once upon initialization and then never used. Also, the initia

[PATCH 4/8] usb: gadget: u_serial: propagate ioctl() to the next layer

2017-06-12 Thread Tal Shorer
In order for a serial function to implement its own ioctl() calls, propagate the ioctl() callback to the next layer so it can handle it if it sees fit to do so. Signed-off-by: Tal Shorer --- drivers/usb/gadget/function/u_serial.c | 15 +++ drivers/usb/gadget/function/u_serial.h | 1

[PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-12 Thread Tal Shorer
The user can issue USB_F_GET_LINE_CODING to get the current line coding as set by the host (or the default if unset yet). Signed-off-by: Tal Shorer --- Documentation/ioctl/ioctl-number.txt | 1 + drivers/usb/gadget/function/f_acm.c | 27 +++ include/uapi/linux/usb/f_acm

[PATCH 3/8] usb: gadget: f_acm: validate set_line_coding requests

2017-06-12 Thread Tal Shorer
We shouldn't accept malformed set_line_coding requests. All values were taken from table 17 (section 6.3.11) of the cdc1.2 spec available at http://www.usb.org/developers/docs/devclass_docs/ The table is in the file PTSN120.pdf. Signed-off-by: Tal Shorer --- drivers/usb/gadget/function/f_acm.c |

[PATCH 5/8] usb: gadget: f_acm: initialize port_line_coding when creating an instance

2017-06-12 Thread Tal Shorer
Initialize acm->port_line_coding with something that makes sense so that we can return a valid line coding if the host requests GetLineCoding before requesting SetLineCoding Signed-off-by: Tal Shorer --- drivers/usb/gadget/function/f_acm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 7/8] usb: gadget: f_acm: notify the user on SetLineCoding

2017-06-12 Thread Tal Shorer
Notify the user with a POLLPRI event when the host issues a SetLineCoding request so that they can act upon it, for example by configuring the line coding on a real serial port. The event is cleared when the user reads the line coding using USB_F_ACM_GET_LINE_CODING ioctl() Signed-off-by: Tal Sho

[PATCH 2/8] usb: gadget: u_serial: propagate poll() to the next layer

2017-06-12 Thread Tal Shorer
In order for a serial function to add flags to the poll() mask of their tty files, propagate the poll() callback to the next layer so it can return a mask if it sees fit to do so. Signed-off-by: Tal Shorer --- drivers/usb/gadget/function/u_serial.c | 16 drivers/usb/gadget/funct

[PATCH 1/8] tty: add a poll() callback in struct tty_operations

2017-06-12 Thread Tal Shorer
If a tty driver wants to notify the user of some exceptional event, such as a usb cdc acm device set_line_coding event, it needs a way to modify the mask returned by poll() and possible also add wait queues. In order to do that, we allow the driver to supply a poll() callback of its own, which will

Re: [PATCH 03/11] Creation of "usb_device_auth" LSM hook

2017-06-12 Thread Krzysztof Opasiak
Hi, On 06/12/2017 06:56 PM, Salvatore Mesoraca wrote: Creation of a new LSM hook that can be used to authorize or deauthorize new USB devices via the usb authorization interface. The same hook can also prevent the authorization of a USB device via "/sys/bus/usb/devices/DEVICE/authorized". Using

Re: [PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-12 Thread Tal Shorer
On Mon, Jun 12, 2017 at 8:26 PM, Tal Shorer wrote: > The user can issue USB_F_GET_LINE_CODING to get the current line coding > as set by the host (or the default if unset yet). > > Signed-off-by: Tal Shorer > --- > @@ -764,10 +783,10 @@ static struct usb_function *acm_alloc_func(struct > usb_fu

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread kbuild test robot
Hi Yuval, [auto build test ERROR on net-next/master] [also build test ERROR on next-20170609] [cannot apply to v4.12-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yuval-Shaia/net-phy-Make-

Re: [PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-12 Thread Tal Shorer
On Mon, Jun 12, 2017 at 9:02 PM, Tal Shorer wrote: > On Mon, Jun 12, 2017 at 8:26 PM, Tal Shorer wrote: >> The user can issue USB_F_GET_LINE_CODING to get the current line coding >> as set by the host (or the default if unset yet). >> >> Signed-off-by: Tal Shorer >> --- > >> @@ -764,10 +783,10

[PATCH v3] USB: qcserial: expose methods for modem control

2017-06-12 Thread Magnus Lynch
The qcserial driver fails to expose the .tiocmget and .tiocmset methods available from usb_wwan. These methods are required by ioctl commands dealing with the modem control signals DTR, RTS, etc. With these methods not set ioctl calls intended to control the DTR state will fail. For example, pppd

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-12 Thread Thinh Nguyen
Hi Felipe, On 6/6/2017 11:52 AM, Thinh Nguyen wrote: > On 6/4/2017 11:08 PM, Felipe Balbi wrote: >> Paul Zimmerman writes: >>> Forgot to CC linux-usb, doing that now >>> >>> On Fri, 2 Jun 2017 16:27:56 -0700, Paul Zimmerman >>> wrote: >>> Felipe Balbi writes: > Thinh Nguyen writes: >

Re: [PATCH 03/11] Creation of "usb_device_auth" LSM hook

2017-06-12 Thread Greg Kroah-Hartman
On Mon, Jun 12, 2017 at 06:56:52PM +0200, Salvatore Mesoraca wrote: > Creation of a new LSM hook that can be used to authorize or deauthorize > new USB devices via the usb authorization interface. > The same hook can also prevent the authorization of a USB device via > "/sys/bus/usb/devices/DEVICE/

Gadget driver ->disconnect callback during unbinding

2017-06-12 Thread Alan Stern
Felipe: A UDC driver will invoke the gadget driver's ->disconnect callback whenever the D+ pullup is turned off. During gadget driver unbinding, this happens automatically when usb_gadget_remove_driver() calls usb_gadget_disconnect(). But immediately thereafter, usb_gadget_remove_driver() calls

Re: usb/gadget: potential deadlock in gadgetfs_suspend

2017-06-12 Thread Alan Stern
On Mon, 12 Jun 2017, Andrey Konovalov wrote: > Aha, got KASAN report: > > == > BUG: KASAN: use-after-free in __lock_acquire+0x3069/0x3690 > kernel/locking/lockdep.c:3246 > Read of size 8 at addr 88003a2bdaf8 by task kworker/3:1/9

[PATCH v2 1/8] ACPI / PM: Run wakeup notify handlers synchronously

2017-06-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The work functions provided by the users of acpi_add_pm_notifier() should be run synchronously before re-enabling the wakeup GPE in case they are used to clear the status and/or disable the wakeup signaling at the source. Otherwise, which is the case currently in the PCI

[PATCH v2 5/8] PM / sleep: Print timing information if debug is enabled

2017-06-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Avoid printing the device suspend/resume timing information if CONFIG_PM_DEBUG is not set to reduce the log noise level. Signed-off-by: Rafael J. Wysocki --- drivers/base/power/main.c |4 1 file changed, 4 insertions(+) Index: linux-pm/drivers/base/power/main.

[PATCH v2 0/8] ACPI / PM: Suspend-to-idle rework to deal with spurious ACPI wakeups

2017-06-12 Thread Rafael J. Wysocki
Hi All, On Thursday, June 08, 2017 02:00:40 AM Rafael J. Wysocki wrote: > Hi All, > > This series is a replacement for commit eed4d47efe95 (ACPI / sleep: Ignore > spurious SCI wakeups from suspend-to-idle) which is still there in 4.12-rc4 > but > will be reverted shortly, because it triggered is

[PATCH v2 7/8] platform/x86: Add driver for ACPI INT0002 Virtual GPIO device

2017-06-12 Thread Rafael J. Wysocki
From: Hans de Goede Some peripherals on Bay Trail and Cherry Trail platforms signal a Power Management Event (PME) to the Power Management Controller (PMC) to wakeup the system. When this happens software needs to explicitly clear the PME bus 0 status bit in the GPE0a_STS register to avoid an IRQ

[PATCH v2 6/8] PCI / PM: Restore PME Enable if skipping wakeup setup

2017-06-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The wakeup_prepared PCI device flag is used for preventing subsequent changes of PCI device wakeup settings in the same way (e.g. enabling device wakeup twice in a row). However, in some cases PME Enable may be updated by things like PCI configuration space restoration in

[PATCH v2 8/8] ACPI / PM: Ignore spurious SCI wakeups from suspend-to-idle

2017-06-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The ACPI SCI (System Control Interrupt) is set up as a wakeup IRQ during suspend-to-idle transitions and, consequently, any events signaled through it wake up the system from that state. However, on some systems some of the events signaled via the ACPI SCI while suspended

[PATCH v2 2/8] USB / PCI / PM: Allow the PCI core to do the resume cleanup

2017-06-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki hcd_pci_resume_noirq() used as a universal _resume_noirq handler for PCI USB controllers calls pci_back_from_sleep() which is unnecessary and may become problematic. It is unnecessary, because the PCI bus type carries out post-suspend cleanup of all PCI devices during res

  1   2   >