[ +CC: media list ]
On Wed, May 31, 2017 at 08:25:42PM +0200, Sebastian wrote:
> Hi list,
>
> as kindly suggested by gregkh
> (https://bugzilla.kernel.org/show_bug.cgi?id=195943), I am now sending
> the mail to this mailing list.
> I have set up the latest Ubuntu 17.04 server within a qemu/kvm vi
Drop a since commit e1159cb35712 ("[media] mceusb: remove pointless
mce_flush_rx_buffer function") redundant reinitialisation of two urb
fields immediately after they have been initialised.
Signed-off-by: Johan Hovold
---
drivers/media/rc/mceusb.c | 3 ---
1 file changed, 3 deletions(-)
diff --
Fix urb and transfer-buffer leaks in an urb-submission error path which
may be hit when a device is disconnected.
Fixes: 66e89522aff7 ("V4L/DVB: IR: add mceusb IR receiver driver")
Cc: stable # 2.6.36
Cc: Jarod Wilson
Signed-off-by: Johan Hovold
---
drivers/media/rc/mceusb.c | 2 ++
1 file
On 06/01/2017 05:37 AM, Lu Baolu wrote:
> Hi,
>
> On 05/31/2017 05:38 PM, Vlastimil Babka wrote:
>> On 05/31/2017 05:27 AM, Lu Baolu wrote:
>>> Hi,
>>>
>>> On 05/30/2017 09:46 PM, Vlastimil Babka wrote:
On 03/21/2017 09:01 AM, Lu Baolu wrote:
Did you forget to remove the #define XDBC_TRA
On Mon, Apr 24, 2017 at 12:59:53PM +0300, Maksim Salau wrote:
> Some local constants don't change from call to call and are good
> candidates to become static. This will prevent copying of these
> constants to stack during runtime.
>
> Signed-off-by: Maksim Salau
Now applied, thanks.
Johan
--
T
On Thu, Jun 01, 2017 at 10:15:24AM +0200, Vlastimil Babka wrote:
> Thanks. I didn't make it clear that the trace_printk() warning is there
> even if the code using it doesn't actually execute (i.e. I didn't
> specify any early_printk bootparam). There are some roastedy tricks to
> detect the potent
Add soft reset support to cleanup_halted_endpoint().
using soft reset will prevent it from setting a new dequeue pointer to
start the transfer from. Let it continue where it halted.
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 16 ++--
1 file changed, 10 insertions
Most transfer events have a TRB pointer indicating which TRB caused
the event.
In the case of streams, transfer events such as
USB Transaction error may have its TRB pointer set to zero.
driver won't know which stream or what TRB on that stream caused
the error, but it can issue a soft reset to re
Hi
This series address a transfer error seen with UAS devices:
"xhci_hcd :00:14.0: ERROR Transfer event for disabled endpoint
or incorrect stream ring"
If anybody who has seen this error, or otherwise extensively
use UAS (USB attached SCSI) devices coud try it out and give some
feedback it w
xhci supports soft retry recovery when the host halted the host side of an
endopint but the connected USB device is not aware of the halt.
In this case xhci needs to issue a reset endopint command with a TSP
(Transfer State Preserve) flag set which preserves the Data toggle
and Sequence number of
On 31.05.2017 16:41, Anurag Kumar Vulisha wrote:
At present USB 2.0 cameras fail to play when run for 2nd time or greater.
This issue occurs only when previous endpoint cached ring is used instead
of allocating a new endpoint ring. The root cause of the problem narrows
down to the Toggle bit, whi
Parse the transfer event first, and remove duplicate debugging
code.
Reorder completion codes according to endpoint state.
No functional changes
We are not handling some transfer events correcly and need to
clean up this before fixing it
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-
On Tuesday 23 May 2017 06:07 AM, Tony Lindgren wrote:
> Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a
> multiplexing USB PHY.
>
> This USB PHY can operate at least in four modes using pin multiplexing
> and two control GPIOS:
>
> - Pass through companion PHY for the SoC U
On Thu, 1 Jun 2017, Reinhard Huck wrote:
> Hi,
>
> Currently, in an usbdevfs-based application it is not possible to know
> the speed the device is operating at. But this information is sometime
> required, for example to interpret the bInterval and wMaxPacketSize
> fields of interrupt/isochro
HI Mathias,
>-Original Message-
>From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com]
>Sent: Thursday, June 01, 2017 6:51 PM
>To: Anurag Kumar Vulisha ; mathias.ny...@intel.com;
>gre...@linuxfoundation.org
>Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Anirudha Sarangi
Hi,
On Wed, 2017-05-31 at 15:23 +0100, Jon Hunter wrote:
> On 22/05/17 12:23, Vivek Gautam wrote:
> > Make use of reset_control_array_*() set of APIs to manage
> > an array of reset controllers available with the device.
> >
> > Cc: Jon Hunter
> > Cc: Thierry Reding
> > Cc: Philipp Zabel
> > S
A set of patches to allow consumers to get and de/assert or trigger
a number of resets at the same time. A patch on top of Vivek's original
API extension is added to hide the reset_control_array behind a struct
reset_control so that the consumer doesn't have care about the difference
between a sing
Use kref for reference counting and enjoy the advantages of refcount_t.
Signed-off-by: Philipp Zabel
---
drivers/reset/core.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index cd739d2fa1603..0090784ff410
Reset controls already may control multiple reset lines with a single
hardware bit. So from the user perspective, reset control arrays are not
at all different from single reset controls.
Therefore, hide reset control arrays behind struct reset_control to
avoid having to introduce new API functions
From: Vivek Gautam
Move clock handling after of_platform_depopulate to achieve
a sequence that is reverse of the probe sequence.
Cc: Felipe Balbi
Signed-off-by: Vivek Gautam
---
drivers/usb/dwc3/dwc3-of-simple.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/u
From: Vivek Gautam
Many devices may want to request a bunch of resets
and control them. So it's better to manage them as an
array. Add APIs to _get(), _assert(), and _deassert()
an array of reset_control.
Note that, these APIs don't guarantee that the reset lines
managed in the array are handled
From: Vivek Gautam
Make use of reset_control_array_*() set of APIs to manage
an array of reset controllers available with the device.
Cc: Jon Hunter
Cc: Thierry Reding
Cc: Philipp Zabel
Signed-off-by: Vivek Gautam
---
drivers/soc/tegra/pmc.c | 82
From: Vivek Gautam
Add support to get a list of resets available for the device.
These resets must be kept de-asserted until the device is
in use.
Cc: Felipe Balbi
Signed-off-by: Vivek Gautam
[p.za...@pengutronix.de: switch to hidden reset control array]
Signed-off-by: Philipp Zabel
---
driv
Both __snd_pcm_lib_read() and __snd_pcm_write() functions have almost
the same code to loop over samples. For simplification, this patch
unifies both as the single helper, __snd_pcm_lib_xfer().
Other than that, there should be no functional change by this patch.
Signed-off-by: Takashi Iwai
---
Hi,
this is a full patchset of what I sent previously, containing the all
changes instead of the snippet. The main purpose of this patchset is
to eliminate the remaining usages of set_fs(). They are basically
used for in-kernel PCM data transfer, and this patch provides the new
API functions and
Replace the copy and the silence ops with the new PCM ops.
Although we can refactor this messy code, at this time, the changes
are kept as small as possible. Let's clean up later.
Signed-off-by: Takashi Iwai
---
sound/pci/korg1212/korg1212.c | 112 --
1 f
Just shuffle the codes, without any change otherwise.
Signed-off-by: Takashi Iwai
---
sound/core/pcm_lib.c | 212 +--
1 file changed, 106 insertions(+), 106 deletions(-)
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index e4f5c43b6448..
The snd_pcm_oss_writev3() and snd_pcm_oss_readv3() are used only in
io.c with CONFIG_SND_PCM_OSS_PLUGINS=y. Add an ifdef to reduce the
build of these functions.
Along with it, since they are called always for in-kernel copy, reduce
the argument and call snd_pcm_kernel_writev() and *_readv() direc
Replace the copy and the silence ops with the new PCM ops.
The conversion is straightforward with standard helper functions.
Signed-off-by: Takashi Iwai
---
sound/pci/rme9652/rme9652.c | 71 ++---
1 file changed, 54 insertions(+), 17 deletions(-)
diff --g
Use the existing silence helper codes for simplification.
Signed-off-by: Takashi Iwai
---
sound/core/pcm_lib.c | 50 --
1 file changed, 20 insertions(+), 30 deletions(-)
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index f15460eaf8b5..
Replace the copy and the silence ops with the new ops.
The conversion is straightforward with standard helper functions, and
now we can drop the bytes <-> frames conversions in callbacks.
Signed-off-by: Takashi Iwai
---
sound/pci/rme32.c | 65 -
Signed-off-by: Takashi Iwai
---
.../sound/kernel-api/writing-an-alsa-driver.rst| 111 ++---
1 file changed, 76 insertions(+), 35 deletions(-)
diff --git a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst
b/Documentation/sound/kernel-api/writing-an-alsa-driver.rst
in
Now that all users of old copy and silence ops have been converted to
the new PCM ops, the old stuff can be retired and go away.
Signed-off-by: Takashi Iwai
---
include/sound/pcm.h | 5 -
sound/core/pcm_lib.c | 38 +-
sound/soc/soc-pcm.c | 2 --
3 file
This is the last-standing one: kill the set_fs() usage in PCM OSS
layer by replacing with the new API functions to deal with the direct
in-kernel buffer copying.
The code to fill the silence can be replaced even to a one-liner to
pass NULL buffer instead of the manual copying.
Signed-off-by: Taka
With the new API to perform the in-kernel buffer copy, we can get rid
of set_fs() usage in this driver, finally.
Signed-off-by: Takashi Iwai
---
drivers/usb/gadget/function/u_uac1.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/function/u_uac1.c
b/
Now all materials are ready, let's allow the direct in-kernel
read/write, i.e. a kernel-space buffer is passed for read or write,
instead of the normal user-space buffer. This feature is used by OSS
layer and UAC1 driver, for example.
The __snd_pcm_lib_xfer() takes in_kernel argument that indicat
Signed-off-by: Takashi Iwai
---
sound/core/pcm_lib.c | 81 +++-
1 file changed, 29 insertions(+), 52 deletions(-)
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index 0db8d4e0fca2..e4f5c43b6448 100644
--- a/sound/core/pcm_lib.c
+++ b/soun
Replace the copy and the silence ops with the new ops.
The conversion is straightforward with standard helper functions, and
now we can drop the bytes <-> frames conversions in callbacks.
Signed-off-by: Takashi Iwai
---
sound/pci/nm256/nm256.c | 57 ---
Make snd_pcm_lib_read() and *_write() static inline functions that
call the common helper functions directly. This reduces a slight
amount of codes, and at the same time, it's a preparation for the
further cleanups / fixes.
Signed-off-by: Takashi Iwai
---
include/sound/pcm.h | 43 +++-
This patch proceeds more abstraction of PCM read/write loop codes.
For both interleaved and non-interleaved transfers, the same copy or
silence transfer code (which is defined as pcm_transfer_f) is used
now. This became possible since we switched to byte size to copy_*
and fill_silence ops argume
Replace the copy and the silence ops with the new PCM ops.
Fixed also the user-space buffer copy with the proper
copy_from_user*() variant.
Signed-off-by: Takashi Iwai
---
sound/sh/sh_dac_audio.c | 54 +++--
1 file changed, 30 insertions(+), 24 deletio
Replace the copy and the silence ops with the new PCM ops.
For simplifying the code a bit, two local helpers are introduced here:
get_bpos() and playback_copy_ack().
Signed-off-by: Takashi Iwai
---
sound/isa/gus/gus_pcm.c | 97 ++---
1 file changed, 59
Replace the copy and the silence ops with the new PCM ops.
The conversion is straightforward with standard helper functions, and
now we can drop the bytes <-> frames conversions in callbacks.
Signed-off-by: Takashi Iwai
---
sound/pci/rme96.c | 70 ++---
Replace the copy and the silence ops with the new PCM ops.
The conversion is straightforward with standard helper functions.
Signed-off-by: Takashi Iwai
---
sound/pci/rme9652/hdsp.c | 67
1 file changed, 50 insertions(+), 17 deletions(-)
diff --g
Replace the copy and the silence ops with the new PCM ops.
In AC97 and I2S-TDM mode, we need to convert back to frames, but
otherwise the conversion is pretty straightforward.
Signed-off-by: Takashi Iwai
---
sound/soc/blackfin/bf5xx-ac97-pcm.c | 27 +++
sound/soc/blackfin
Replace the copy ops with the new copy_user and copy_kernel ops.
It's used only for a capture stream (for some hardware workaround),
thus we need no silence operation.
Signed-off-by: Takashi Iwai
---
sound/pci/es1938.c | 33 +
1 file changed, 25 insertions(+), 8 d
Replace the copy and the silence ops with the new PCM ops.
The device supports only 1 channel and 8bit sample, so it's always
bytes=frames, and we need no conversion of unit in the callback.
Also, it's a capture stream, thus no silence is needed.
Signed-off-by: Takashi Iwai
---
drivers/media/pci
For supporting the explicit in-kernel copy of PCM buffer data, and
also for further code refactoring, three new PCM ops, copy_user,
copy_kernel and fill_silence, are introduced. The old copy and
silence ops will be deprecated and removed later once when all callers
are converted.
The copy_kernel
Replace the copy and the silence ops with the new PCM ops.
For avoiding the code redundancy, slightly hackish macros are
introduced.
Signed-off-by: Takashi Iwai
---
sound/isa/sb/emu8000_pcm.c | 190 ++---
1 file changed, 109 insertions(+), 81 deletions(-)
It's a dummy ops, so just replacing it.
Signed-off-by: Takashi Iwai
---
sound/drivers/dummy.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c
index 172dacd925f5..dd5ed037adf2 100644
--- a/sound/drivers/dummy.
The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk
for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec
quirk for a MSI mobo. But it turned out that this isn't applied
properly due to the MSI-vendor quirk before this entry. I overlooked
such two MSI entries just
On 06/01/2017 10:58 PM, Takashi Iwai wrote:
Replace the copy and the silence ops with the new PCM ops.
The device supports only 1 channel and 8bit sample, so it's always
bytes=frames, and we need no conversion of unit in the callback.
Also, it's a capture stream, thus no silence is needed.
Signe
Hi Philipp,
[auto build test ERROR on pza/reset/next]
[also build test ERROR on v4.12-rc3 next-20170601]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Philipp-Zabel/reset-APIs-to-manage-a-list
On Thu, Jun 01, 2017 at 10:58:47PM +0200, Takashi Iwai wrote:
> With the new API to perform the in-kernel buffer copy, we can get rid
> of set_fs() usage in this driver, finally.
>
> Signed-off-by: Takashi Iwai
> ---
Acked-by: Greg Kroah-Hartman
--
To unsubscribe from this list: send the line "
Hi Philipp,
[auto build test WARNING on pza/reset/next]
[also build test WARNING on v4.12-rc3 next-20170601]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Philipp-Zabel/reset-APIs-to-manage-a
On Thu, 1 Jun 2017 14:25:51 +0200
Peter Zijlstra wrote:
> On Thu, Jun 01, 2017 at 10:15:24AM +0200, Vlastimil Babka wrote:
> > Thanks. I didn't make it clear that the trace_printk() warning is
> > there even if the code using it doesn't actually execute (i.e. I
> > didn't specify any early_printk
On Sat, 2017-05-27 at 21:58 -0400, Alan Stern wrote:
> The interfaces required for a UDC driver are explained to some extent
> by the kerneldoc in include/linux/usb/gadget.h. For anything you still
> don't understand, feel free to ask on this mailing list.
It's missing docs for the udc callback
On Thu, 01 Jun 2017 22:58:24 +0200,
Takashi Iwai wrote:
>
> The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk
> for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec
> quirk for a MSI mobo. But it turned out that this isn't applied
> properly due to the MSI-vend
on AMD platforms with SNPS 3.1 USB controller if stop endpoint command is
issued the controller does not respond, when the EP is not in running
state. HW completes the command execution and reports
"Context State Error" completion code. This is as per the spec. However
HW on receiving the second co
On Fri, 2017-06-02 at 15:13 +1000, Benjamin Herrenschmidt wrote:
> On Sat, 2017-05-27 at 21:58 -0400, Alan Stern wrote:
> > The interfaces required for a UDC driver are explained to some extent
> > by the kerneldoc in include/linux/usb/gadget.h. For anything you still
> > don't understand, feel
60 matches
Mail list logo
