Re: [PATCH] usbtmc: don't return zero on failure path in usbtmc_probe()

On Sat, Mar 18, 2017 at 02:38:00AM +0300, Alexey Khoroshilov wrote: > usbtmc_probe() returns zero in case of allocation failures. > > The patch fixes that. By the way it rearranges error lables just to improve > readability of quite complex dependencies in error handling code. This was in fact fi

Re: [PATCH] USB: qcserial: add Dell DW5811e

On Fri, Mar 17, 2017 at 05:21:28PM +0100, Bjørn Mork wrote: > This is a Dell branded Sierra Wireless EM7455. > > Cc: > Signed-off-by: Bjørn Mork Applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 0/7] Input: fix NULL-derefs at probe

On Fri, Mar 17, 2017 at 02:03:15PM -0700, Dmitry Torokhov wrote: > On Fri, Mar 17, 2017 at 11:53:37AM +0100, Johan Hovold wrote: > > On Thu, Mar 16, 2017 at 03:37:28PM -0700, Dmitry Torokhov wrote: > > > On Mon, Mar 13, 2017 at 04:45:52PM +0100, Johan Hovold wrote: > > > > On Mon, Mar 13, 2017 at 0

Re: [PATCH] net: usb: pegasus: use new api ethtool_{get|set}_link_ksettings

On 17-03-17 23:34:04, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if someone may test this > patch. Yep, the patch seems to be working fine on real hard

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

On Thu, Feb 23, 2017 at 07:40:13PM +0100, Pavel Machek wrote: > On Thu 2017-02-23 17:28:26, Frederic Weisbecker wrote: > > On Tue, Feb 14, 2017 at 08:27:43PM +0100, Pavel Machek wrote: > > > On Tue 2017-02-14 18:59:56, Pavel Machek wrote: > > > > Hi! > > > > > > > > > > > > Hmm. I moved keyboard b

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

On Fri, 17 Mar 2017, Michael Zoran wrote: > On Fri, 2017-03-17 at 10:24 +0900, Greg Kroah-Hartman wrote: > > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab > > wrote: > > > The dwc2 hardware doesn't like to do DMA transfers without > > > aligning data in DWORD. The driver also ass

Re: [PATCH 1/4] cdc-acm: reassemble fragmented notifications

Hi, thank you for your feedback. I tried to fix all issues with v2. I was just unsure with one point (see comment). /tobias > Am Dienstag, den 14.03.2017, 21:14 +0100 schrieb Tobias Herzog: > > > > USB devices may have very limitited endpoint packet sizes, so that > > notifications can not be

[PATCH v2 0/4] cdc-acm: reassemble fragmented notifications

USB devices may have very limitited endpoint packet sizes, so that notifications can not be transferred within one single usb packet. This patchset adds the ability to reassemble notifications that are transmitted fragmented. v2: * reuse an allocated buffer for further notifications * fixed issu

[PATCH v2 2/4] cdc-acm: fix possible invalid access when processing notification

Notifications may only be 8 bytes so long. Accessing the 9th and 10th byte of unimplemented/unknown notifications may be insecure. Also check the length of known notifications before accessing anything behind the 8th byte. Signed-off-by: Tobias Herzog --- drivers/usb/class/cdc-acm.c | 11 +++

[PATCH v2 3/4] cdc-acm: log message for serial state notification

Adds a similar log message to USB_CDC_NOTIFY_SERIAL_STATE as it is already done with USB_CDC_NOTIFY_NETWORK_CONNECTION. Signed-off-by: Tobias Herzog --- drivers/usb/class/cdc-acm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c ind

[PATCH v2 4/4] cdc-acm: remove unused element of struct acm

write_used was introduced with commit 884b600f63dc ("[PATCH] USB: fix acm trouble with terminals") but never used since. Signed-off-by: Tobias Herzog --- drivers/usb/class/cdc-acm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.h b/drivers/usb/class/cdc-acm.h index

[PATCH v2 1/4] cdc-acm: reassemble fragmented notifications

USB devices may have very limitited endpoint packet sizes, so that notifications can not be transferred within one single usb packet. Reassembling of multiple packages may be necessary. Signed-off-by: Tobias Herzog --- drivers/usb/class/cdc-acm.c | 106 ---