Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

2017-02-13 Thread Alexander Sverdlin
Hi! On 11/02/17 02:27, Peter Chen wrote: > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. So, set > the dma for xhci from sysdev. sysdev is pointing to device that > is known to the system firmware or hardware. > > Cc: Baolin

[PATCH 1/1] extcon: ext-usb-gpio: do not enable USB as wakeup source by default

2017-02-13 Thread Peter Chen
Whether the USB port as a wakeup source should be determined by user, but not enabled by default. Signed-off-by: Peter Chen --- drivers/extcon/extcon-usb-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c

Re: [PATCH] USB: serial: ftdi_sio: add device ID for Microsemi/Arrow SF2PLUS Dev Kit

2017-02-13 Thread Johan Hovold
[+CC: linux-usb] Always make sure to CC linux-usb for USB patches. On Fri, Feb 10, 2017 at 05:16:12PM +0100, Marek Vasut wrote: > This development kit has an FT4232 on it with a custom USB VID/PID. > The FT4232 provides four UARTs, but only two are used. The UART 0 > is used by the FlashPro5 prog

RE: How to resolve "Waited 2000ms for CONNECT" in system resuming?

2017-02-13 Thread Yoshihiro Shimoda
Hi Alan, > From: Alan Stern > Sent: Friday, February 10, 2017 12:28 AM > > On Thu, 9 Feb 2017, Yoshihiro Shimoda wrote: > > > > > > From: Alan Stern > > > Sent: Thursday, February 09, 2017 12:39 AM > > > On Wed, 8 Feb 2017, Yoshihiro Shimoda wrote: < snip > > > I checked the ehci_handover_comp

Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0

2017-02-13 Thread Peter Chen
On Sun, Feb 12, 2017 at 06:35:18PM +, Colin King wrote: > From: Colin Ian King > > The check for retval being less than zero is always true since > retval equal to -EPIPE at that point. Replace the existing > conditional with just return retval. > > Detected with CoverityScan, CID#114349 ("

Re: [PATCH] USB: serial: upd78f0730: Add ID for EVAL-ADXL362Z

2017-02-13 Thread Johan Hovold
On Fri, Feb 10, 2017 at 02:53:42PM +0300, Maksim Salau wrote: > The adaptor on Analog Devices EVAL-ADXL362Z development board is used > to flash and debug firmware of on-board Renesas RL78/G13 MCU. > > Signed-off-by: Maksim Salau > --- > > I have no access to such board to test the change, but t

Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0

2017-02-13 Thread Felipe Balbi
Hi, Colin King writes: > From: Colin Ian King > > The check for retval being less than zero is always true since > retval equal to -EPIPE at that point. Replace the existing > conditional with just return retval. > > Detected with CoverityScan, CID#114349 ("Logically dead code") > > Signed-off

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

2017-02-13 Thread Felipe Balbi
Hi, Stefan Agner writes: >>> On Thu, Feb 09, 2017 at 10:04:43AM -0800, Stefan Agner wrote: On 2017-02-01 08:59, Stefan Agner wrote: > On 2017-02-01 00:06, Greg KH wrote: >> On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote: >>> Currently qw_sign requires UTF-8 char

[PATCH v2] USB: serial: upd78f0730: Add ID for EVAL-ADXL362Z

2017-02-13 Thread Maksim Salau
The adaptor on Analog Devices EVAL-ADXL362Z development board is used to flash and debug firmware of on-board Renesas RL78/G13 MCU. Also added support of the 153600 baud rate, since the stock firmware uses it. Signed-off-by: Maksim Salau --- Changes in v2: * mentioned additional baudrate in the c

Re: [PATCH v13 00/12] power: add power sequence library

2017-02-13 Thread Rafael J. Wysocki
On Saturday, February 11, 2017 09:27:11 AM Peter Chen wrote: > Hi all, > > This is a follow-up for my last power sequence framework patch set [1]. > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of > power sequence instances will be added at postcore_initcall, the match > crite

Re: [PATCH v2] USB: serial: upd78f0730: Add ID for EVAL-ADXL362Z

2017-02-13 Thread Johan Hovold
On Mon, Feb 13, 2017 at 03:14:34PM +0300, Maksim Salau wrote: > The adaptor on Analog Devices EVAL-ADXL362Z development board is used > to flash and debug firmware of on-board Renesas RL78/G13 MCU. > Also added support of the 153600 baud rate, since the stock firmware > uses it. > > Signed-off-by:

[PATCH] USB: serial: upd78f0730: sort device ids

2017-02-13 Thread Johan Hovold
Sort the device ids by vendor id. Signed-off-by: Johan Hovold --- drivers/usb/serial/upd78f0730.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/upd78f0730.c b/drivers/usb/serial/upd78f0730.c index f1e6c07ffc81..a028dd2310c9 100644 --- a/drivers/usb/serial

Re: [PATCH -next] usb: dwc2: Fix the error handling of dwc2_pci_probe()

2017-02-13 Thread Vardan Mikayelyan
On 2/7/2017 7:54 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix the error handling of dwc2_pci_probe() to avoid resources leak. > > Signed-off-by: Wei Yongjun > --- > drivers/usb/dwc2/pci.c | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/driver

Re: [PATCH] USB: serial: upd78f0730: sort device ids

2017-02-13 Thread Maksim Salau
> Sort the device ids by vendor id. > > Signed-off-by: Johan Hovold Thanks for taking care of that. I didn't bothered about order before your comment about ftd_sio driver. Maksim. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.

[PATCH] usb: gadget: legacy gadgets are optional

2017-02-13 Thread Romain Izard
When building without modules, it makes sense to configure the kernel to only use configfs for USB Gadget drivers. Mark the choice for legacy gadget drivers as optional. Signed-off-by: Romain Izard cc: # 4.9 --- drivers/usb/gadget/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/dri

Re: [PATCH] USB: serial: upd78f0730: sort device ids

2017-02-13 Thread Johan Hovold
On Mon, Feb 13, 2017 at 05:44:17PM +0300, Maksim Salau wrote: > > Sort the device ids by vendor id. > > > > Signed-off-by: Johan Hovold > > Thanks for taking care of that. I didn't bothered about order > before your comment about ftd_sio driver. Yeah, I didn't even notice it before either, but

[PATCH 0/2] avoid use of freed pointer

2017-02-13 Thread Gustavo A. R. Silva
Hello, This patch series addesses Coverity ID 1091172, which reports the use of a freed pointer. udc_free_dma_chain() function was rewritten in order to fix this issue. Unnecessary 'ret_val' variable was removed and the function prototype was modified. Thanks Gustavo A. R. Silva (2): usb: gad

[PATCH 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype

2017-02-13 Thread Gustavo A. R. Silva
Remove unnecessary variable and update function prototype. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/udc/amd5536udc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/amd5536udc.c b/drivers/usb/gadget

Re: [PATCH v2] usb: gadget: udc: remove pointer dereference after free

2017-02-13 Thread Michal Nazarewicz
On Sat, Feb 11 2017, Gustavo A. R. Silva wrote: > Remove pointer dereference after free and set pointer to NULL after free. > > Addresses-Coverity-ID: 1091173 > Signed-off-by: Gustavo A. R. Silva Acked-by: Michal Nazarewicz > --- > Changes in v2: > Move pointer dereference before pci_pool_fre

Re: [PATCH 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype

2017-02-13 Thread Michal Nazarewicz
On Mon, Feb 13 2017, Gustavo A. R. Silva wrote: > Remove unnecessary variable and update function prototype. > > Reviewed-by: Greg Kroah-Hartman > Signed-off-by: Gustavo A. R. Silva Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/udc/amd5536udc.c | 5 + > 1 file changed, 1 insertio

Re: [PATCH 1/2] usb: gadget: udc: avoid use of freed pointer

2017-02-13 Thread Michal Nazarewicz
On Mon, Feb 13 2017, Gustavo A. R. Silva wrote: > Rewrite udc_free_dma_chain() function to avoid use of pointer after free. > > Addresses-Coverity-ID: 1091172 > Reviewed-by: Greg Kroah-Hartman > Signed-off-by: Gustavo A. R. Silva Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/udc/amd5

[PATCH 1/2] usb: gadget: udc: avoid use of freed pointer

2017-02-13 Thread Gustavo A. R. Silva
Rewrite udc_free_dma_chain() function to avoid use of pointer after free. Addresses-Coverity-ID: 1091172 Reviewed-by: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/udc/amd5536udc.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff -

RE: How to resolve "Waited 2000ms for CONNECT" in system resuming?

2017-02-13 Thread Alan Stern
On Mon, 13 Feb 2017, Yoshihiro Shimoda wrote: > > Hmmm. You're using platform drivers for OHCI and EHCI, not PCI, > > Yes, I'm using platform drivers for OHCI and EHCI. > > > right? The resume_common() routine in drivers/usb/core/hcd-pci.c is > > careful to resume things in the correct order.

Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0

2017-02-13 Thread Alan Stern
On Mon, 13 Feb 2017, Felipe Balbi wrote: > Hi, > > Colin King writes: > > From: Colin Ian King > > > > The check for retval being less than zero is always true since > > retval equal to -EPIPE at that point. Replace the existing > > conditional with just return retval. > > > > Detected with Co

Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0

2017-02-13 Thread Colin Ian King
On 13/02/17 10:45, Felipe Balbi wrote: > > Hi, > > Colin King writes: >> From: Colin Ian King >> >> The check for retval being less than zero is always true since >> retval equal to -EPIPE at that point. Replace the existing >> conditional with just return retval. >> >> Detected with CoverityS

USB- Kernel 4.4.0.-59 / -62 - Hardware (Sense) Errors without a reason

2017-02-13 Thread Mike
Hi, with the Kernel 4.4.0-59 i got after the startup, Hardware Error Messages for my external USB-HDDs. The internal HDD ist not affected. I checked all external HDDs via smartctl and did a short selftest which finished without error. The error came up after i switched from XUbuntu 14.04 to 16.

Re: USB- Kernel 4.4.0.-59 / -62 - Hardware (Sense) Errors without a reason

2017-02-13 Thread Greg KH
On Mon, Feb 13, 2017 at 06:18:30PM +0100, Mike wrote: > Hi, with the Kernel 4.4.0-59 i got after the startup, Hardware Error Messages > for my external USB-HDDs. > The internal HDD ist not affected. I checked all external HDDs via smartctl > and did a short selftest which finished without error.

Re: [BUG] usb: gadget: Kernel oops with UVC USB gadget and configfs

2017-02-13 Thread Robert Jarzmik
Petr Cvek writes: > Dne 12.2.2017 v 13:02 Robert Jarzmik napsal(a): > That's weird I even removed pxa_set_udc_info() from magician machine init and > it still fails. > Host cable and/or actual camera is not required. It fails without them. > > So you binded pxa27x-udc as UDC controller (= activa

Re: USB- Kernel 4.4.0.-59 / -62 - Hardware (Sense) Errors without a reason

2017-02-13 Thread Alan Stern
On Mon, 13 Feb 2017, Greg KH wrote: > On Mon, Feb 13, 2017 at 06:18:30PM +0100, Mike wrote: > > Hi, with the Kernel 4.4.0-59 i got after the startup, Hardware Error > > Messages for my external USB-HDDs. > > The internal HDD ist not affected. I checked all external HDDs via smartctl > > and did

[PATCH v7 4/5] usb: serial: add dbc debug device support to usb_debug

2017-02-13 Thread Lu Baolu
This patch adds dbc debug device support to the usb_debug driver. Signed-off-by: Lu Baolu Acked-by: Johan Hovold --- drivers/usb/serial/usb_debug.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/usb_debug.c b/drivers/usb/seri

[PATCH v7 5/5] usb: doc: add document for USB3 debug port usage

2017-02-13 Thread Lu Baolu
Add Documentation/usb/usb3-debug-port.rst. This document includes the user guide for USB3 debug port. Cc: linux-...@vger.kernel.org Signed-off-by: Lu Baolu --- Documentation/usb/usb3-debug-port.rst | 98 +++ 1 file changed, 98 insertions(+) create mode 100644 Doc

[PATCH v7 3/5] x86: add support for earlyprintk via USB3 debug port

2017-02-13 Thread Lu Baolu
Add support for early printk by writing debug messages to the USB3 debug port. Users can use this type of early printk by specifying kernel parameter of "earlyprintk=xdbc". This gives users a chance of providing debug output. The hardware for USB3 debug port requires DMA memory blocks. This requ

[PATCH v7 0/5] usb: early: add support for early printk through USB3 debug port

2017-02-13 Thread Lu Baolu
xHCI debug capability (DbC) is an optional but standalone functionality provided by an xHCI host controller. With DbC hardware initialized, the system will present a debug device through the USB3 debug port (normally the first USB3 port). The debug device is fully compliant with the USB framework a

[PATCH v7 1/5] x86: add simple udelay calibration

2017-02-13 Thread Lu Baolu
Add a simple udelay calibration in x86 architecture-specific boot-time initializations. This will get a workable estimate for loops_per_jiffy. Hence, udelay() could be used after this initialization. Cc: Ingo Molnar Cc: x...@kernel.org Signed-off-by: Lu Baolu --- arch/x86/kernel/setup.c | 22 ++

[PATCH v7 2/5] usb: dbc: early driver for xhci debug capability

2017-02-13 Thread Lu Baolu
xHCI debug capability (DbC) is an optional but standalone functionality provided by an xHCI host controller. Software learns this capability by walking through the extended capability list of the host. xHCI specification describes DbC in section 7.6. This patch introduces the code to probe and ini

RE: [PATCH -next] usb: dwc2: Fix the error handling of dwc2_pci_probe()

2017-02-13 Thread weiyongjun (A)
Hi Vardan, > > We have patch doing the same in our internal branch, please review it > below. We will send it out after internal review/testing process. > > usb: dwc2: pci: Fix error handling in dwc2_pci_probe > > Move usb_phy_generic_register() function call to the top, to simplify > error han

[RFC][PATCH] usb: dwc2: Make sure we disconnect the gadget state

2017-02-13 Thread John Stultz
Just wanted to get some early feedback on this before I submit it for real for the 4.12 timeframe. This is the last patch, that isn't already queued, which I need to get hikey's USB working properly. Feedback would be greatly appreciated! thanks -john I had seen some odd behavior with HiKey's u

Re: [PATCH v7 5/5] usb: doc: add document for USB3 debug port usage

2017-02-13 Thread Lu Baolu
Hi, On 02/14/2017 11:45 AM, Peter Chen wrote: > On Tue, Feb 14, 2017 at 10:27 AM, Lu Baolu wrote: > >> Add Documentation/usb/usb3-debug-port.rst. This document includes >> the user guide for USB3 debug port. >> >> Cc: linux-...@vger.kernel.org >> Signed-off-by: Lu Baolu >> --- >> Documentation/

Re: [PATCH] USB: serial: ftdi_sio: add device ID for Microsemi/Arrow SF2PLUS Dev Kit

2017-02-13 Thread Marek Vasut
On 02/13/2017 10:29 AM, Johan Hovold wrote: > [+CC: linux-usb] > > Always make sure to CC linux-usb for USB patches. Got it > On Fri, Feb 10, 2017 at 05:16:12PM +0100, Marek Vasut wrote: >> This development kit has an FT4232 on it with a custom USB VID/PID. >> The FT4232 provides four UARTs, but

Re: [PATCH v2] usb: gadget: udc: remove pointer dereference after free

2017-02-13 Thread Gustavo A. R. Silva
Hi Michal, Quoting Michal Nazarewicz : On Sat, Feb 11 2017, Gustavo A. R. Silva wrote: Remove pointer dereference after free and set pointer to NULL after free. Addresses-Coverity-ID: 1091173 Signed-off-by: Gustavo A. R. Silva Acked-by: Michal Nazarewicz --- Changes in v2: Move pointe

[PATCH v3] usb: gadget: udc: remove pointer dereference after free

2017-02-13 Thread Gustavo A. R. Silva
Remove pointer dereference after free. Addresses-Coverity-ID: 1091173 Acked-by: Michal Nazarewicz Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Move pointer dereference before pci_pool_free() Set pointer to NULL after free Changes in v3: Remove 'td->next = 0x00' inside for loop. Re

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

2017-02-13 Thread Vivek Gautam
On 02/11/2017 06:57 AM, Peter Chen wrote: From: Arnd Bergmann For xhci-hcd platform device, all the DMA parameters are not configured properly, notably dma ops for dwc3 devices. So, set the dma for xhci from sysdev. sysdev is pointing to device that is known to the system firmware or hardware

UAS not working with JMS567 based disk enclosure

2017-02-13 Thread Jack Coulter
Hi, I'm using an external multiple-disk enclosure (specifically a Hotway H82-SU3S2), which from lsusb appears to use a JMS567 SATA-USB bridge: > Bus 002 Device 002: ID 152d:0567 JMicron Technology Corp. / JMicron > USA Technology Corp. JMS567 SATA 6Gb/s bridge According to the manufacturer's pr

RE: [PATCH v7 5/5] usb: doc: add document for USB3 debug port usage

2017-02-13 Thread Peter Chen
> >On 02/14/2017 11:45 AM, Peter Chen wrote: >> On Tue, Feb 14, 2017 at 10:27 AM, Lu Baolu wrote: >> >>> Add Documentation/usb/usb3-debug-port.rst. This document includes the >>> user guide for USB3 debug port. >>> >>> Cc: linux-...@vger.kernel.org >>> Signed-off-by: Lu Baolu >>> --- >>> Docum

Re: [PATCH v7 5/5] usb: doc: add document for USB3 debug port usage

2017-02-13 Thread Lu Baolu
Hi, On 02/14/2017 02:13 PM, Peter Chen wrote: > >> On 02/14/2017 11:45 AM, Peter Chen wrote: >>> On Tue, Feb 14, 2017 at 10:27 AM, Lu Baolu wrote: >>> Add Documentation/usb/usb3-debug-port.rst. This document includes the user guide for USB3 debug port. Cc: linux-...@vger.ker