On 20.01.2017 20:18, Felipe Balbi wrote:
Mathias Nyman writes:
Remove duplicate code by using trb_to_noop() when
handling Aborted commads
Signed-off-by: Mathias Nyman
isn't this just [1]
https://marc.info/?i=20161229110109.26372-25-felipe.ba...@linux.intel.com
A simplified versio
On Mon, Jan 23, 2017 at 03:05:45PM +0800, Jisheng Zhang wrote:
> is for net phy drivers, we don't need it.
>
> Signed-off-by: Jisheng Zhang
> ---
> drivers/usb/chipidea/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> in
On Mon, Jan 23, 2017 at 03:09:23PM +0800, Jisheng Zhang wrote:
> Similar as commit 2b2fe36def08 ("usb: chipidea: imx: delete the
> redundant setting default DMA mask code"), the ci_hdrc_usb2 platform
> device is also created by device tree, the default DMA mask should be
> already set by of_dma_con
On 23.01.2017 10:12, Mathias Nyman wrote:
On 20.01.2017 20:18, Felipe Balbi wrote:
Mathias Nyman writes:
Remove duplicate code by using trb_to_noop() when
handling Aborted commads
Signed-off-by: Mathias Nyman
isn't this just [1]
https://marc.info/?i=20161229110109.26372-25-felipe.b
Hi,
Mathias Nyman writes:
> On 20.01.2017 20:18, Felipe Balbi wrote:
>>
>> Mathias Nyman writes:
>>
>>> Remove duplicate code by using trb_to_noop() when
>>> handling Aborted commads
>>>
>>> Signed-off-by: Mathias Nyman
>>
>> isn't this just [1]
>>
>> https://marc.info/?i=20161229110109.2
Hi,
Mathias Nyman writes:
> On 23.01.2017 10:12, Mathias Nyman wrote:
>> On 20.01.2017 20:18, Felipe Balbi wrote:
>>>
>>> Mathias Nyman writes:
>>>
Remove duplicate code by using trb_to_noop() when
handling Aborted commads
Signed-off-by: Mathias Nyman
>>>
>>> isn't this jus
On 23.01.2017 11:21, Felipe Balbi wrote:
Hi,
Mathias Nyman writes:
On 20.01.2017 20:18, Felipe Balbi wrote:
Mathias Nyman writes:
Remove duplicate code by using trb_to_noop() when
handling Aborted commads
Signed-off-by: Mathias Nyman
isn't this just [1]
https://marc.info/?i=201
On 01/20/2017 09:17 PM, Bin Liu wrote:
> On Thu, Jan 19, 2017 at 11:06:59AM +0100, Alexandre Bailon wrote:
>> Despite the CPPI 4.1 is a generic DMA, it is tied to USB.
>> On the dsps, CPPI 4.1 interrupt's registers are in USBSS (the MUSB glue).
>> Currently, to enable / disable and clear interrupts
Hello,
It seems the USB product ID for g_webcam usb device gadget is incorrectly used
from EEM gadget "Ethernet Emulation Model". So "webcam" device has a confusing
description in lsusb:
1d6b:0102 Linux Foundation EEM Gadget
I would change it to 0x0106, which is a next unassigned value
Hi,
Petr Cvek writes:
> It seems the USB product ID for g_webcam usb device gadget is
> incorrectly used from EEM gadget "Ethernet Emulation Model". So
> "webcam" device has a confusing description in lsusb:
>
> 1d6b:0102 Linux Foundation EEM Gadget
>
> I would change it to 0x0106, which i
On Mon, Jan 23, 2017 at 12:59:33PM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Petr Cvek writes:
> > It seems the USB product ID for g_webcam usb device gadget is
> > incorrectly used from EEM gadget "Ethernet Emulation Model". So
> > "webcam" device has a confusing description in lsusb:
> >
> >
We need to break from all cases if we want to treat
each one of them separately.
Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently")
Signed-off-by: Roger Quadros
---
drivers/usb/dwc3/dwc3-omap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/dwc3-
USB1 port is micro-AB type and can function as peripheral
as well as host. Enable dual-role mode for USB1.
Signed-off-by: Roger Quadros
---
arch/arm/boot/dts/dra7-evm.dts | 2 +-
arch/arm/boot/dts/dra72-evm-common.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
If dr_mode is "otg" then support dual role mode of operation.
Get ID and VBUS information from the OTG controller
and put the controller in the appropriate state.
This is our dual-role state table.
ID VBUSdual-role state
-- ---
0 x A_HOST - Host cont
To avoid checkpatch warnings with new patches let's
start using the BIT() macro wherever possible.
Signed-off-by: Roger Quadros
---
drivers/usb/dwc3/core.h | 192 +--
drivers/usb/dwc3/dwc3-omap.c | 48 +--
drivers/usb/dwc3/gadget.h| 20 +
Hi,
We rely on the OTG controller block to provide us with
VBUS and ID line status via an interrupt.
This is then used to switch the controller between host, peripheral
and idle roles based on the following table.
ID VBUSdual-role state
-- ---
0 x A_
On Mon, Jan 23, 2017 at 12:20:03PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 23, 2017 at 12:59:33PM +0200, Felipe Balbi wrote:
> >
> > Hi,
> >
> > Petr Cvek writes:
> > > It seems the USB product ID for g_webcam usb device gadget is
> > > incorrectly used from EEM gadget "Ethernet Emulation
If usb/otg-fsm.h and usb/composite.h are included together
then it results in the build warning [1].
Prevent that by defining VDBG locally.
Also get rid of MPC_LOC which doesn't seem to be used
by anyone.
[1] - warning fixed by this patch:
In file included from drivers/usb/dwc3/core.h:33,
fr
USB1 port is micro-AB type and can function as peripheral
as well as host. Enable dual-role mode for USB1.
Signed-off-by: Roger Quadros
---
arch/arm/boot/dts/am437x-gp-evm.dts | 2 +-
arch/arm/boot/dts/am437x-sk-evm.dts | 2 +-
arch/arm/boot/dts/am43x-epos-evm.dts | 2 +-
3 files changed, 3 in
Add OTG and GHWPARAMS6 register definitions
Signed-off-by: Roger Quadros
---
drivers/usb/dwc3/core.h | 82 +
1 file changed, 82 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index d514dca..fc82d2e 100644
--- a/driver
USB port is micro-AB type and can function as peripheral
as well as host. Enable dual-role mode for USB2.
Signed-off-by: Roger Quadros
---
arch/arm/boot/dts/am57xx-idk-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am57xx-idk-common.dtsi
b/arch
On Mon, Jan 23, 2017 at 11:30:01AM +0100, Petr Cvek wrote:
> Hello,
>
> It seems the USB product ID for g_webcam usb device gadget is incorrectly
> used from EEM gadget "Ethernet Emulation Model". So "webcam" device has a
> confusing description in lsusb:
>
> 1d6b:0102 Linux Foundation EE
Hi,
Greg KH writes:
> On Mon, Jan 23, 2017 at 11:30:01AM +0100, Petr Cvek wrote:
>> Hello,
>>
>> It seems the USB product ID for g_webcam usb device gadget is incorrectly
>> used from EEM gadget "Ethernet Emulation Model". So "webcam" device has a
>> confusing description in lsusb:
>>
>>
On Mon, Jan 23, 2017 at 01:27:59PM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Greg KH writes:
> > On Mon, Jan 23, 2017 at 11:30:01AM +0100, Petr Cvek wrote:
> >> Hello,
> >>
> >> It seems the USB product ID for g_webcam usb device gadget is incorrectly
> >> used from EEM gadget "Ethernet Emulation
Krzysztof Opasiak writes:
> Since commit ba1582f22231 ("usb: gadget: f_hid: use alloc_ep_req()")
> we cannot allocate any requests in bind() as we check if we should
> align request buffer based on endpoint descriptor which is assigned
> in set_alt().
>
> Allocating request in bind() function cau
Hi Roger,
On 2017년 01월 23일 20:19, Roger Quadros wrote:
> - Some SoC's (e.g. Qualcomm MSM) do not have the OTG controller block
> but do have both host and peripheral controllers and so can operate
> in dual role mode. Current series does not address this case.
> We can get dual-role to work with s
John Youn writes:
> The otg_ver parameter only controls the SRP pulsing method and defaults
> to the 1.3 behavior. It is unused and can be removed.
>
> Signed-off-by: John Youn
this patch fails to apply:
checking file drivers/usb/dwc2/core.c
checking file drivers/usb/dwc2/core.h
Hunk #2 succee
Hi,
Peter Chen writes:
> On Tue, Jan 17, 2017 at 05:57:50PM +0800, Peter Chen wrote:
>> On Tue, Jan 17, 2017 at 11:23:55AM +0200, Felipe Balbi wrote:
>> >
>> > Hi,
>> >
>> > Peter Chen writes:
>> > > On Mon, Jan 16, 2017 at 12:40:06PM +0200, Felipe Balbi wrote:
>> > >>
>> > >> Hi,
>> > >>
>
Hi,
Richard Genoud writes:
> On 19/01/2017 09:03, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Richard Genoud writes:
>>> Hi,
>>> Since commit c499ff71ff2a2 ("usb: dwc3: core: re-factor init and exit
>>> paths")
>>> (merged in 4.8), the usb ports on odroid-XU4 don't work anymore.
>>>
>>> [ Actually,
Dne 23.1.2017 v 12:32 Greg KH napsal(a):
I know it is only a cosmetic change on a legacy driver, but I assume
it would be better to have some default value for configfs API than to
borrow a PID from a whole different gadget.
>>>
>>> For class devices, they really don't need a new id,
John Youn writes:
> From: Sevak Arakelyan
>
> GDFIFOCFG is available from IP version 2.91a. Fix the code to reflect
> this.
>
> Signed-off-by: Sevak Arakelyan
> Signed-off-by: John Youn
doesn't apply :-( please rebase
--
balbi
signature.asc
Description: PGP signature
2017-01-23 12:45 GMT+01:00 Felipe Balbi :
>
> Hi,
>
> Richard Genoud writes:
>> On 19/01/2017 09:03, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Richard Genoud writes:
Hi,
Since commit c499ff71ff2a2 ("usb: dwc3: core: re-factor init and exit
paths")
(merged in 4.8), the usb ports
Hi,
John Youn writes:
> @@ -1229,7 +1229,8 @@ static inline void dwc2_hcd_connect(struct
> dwc2_hsotg *hsotg) {}
> static inline void dwc2_hcd_disconnect(struct dwc2_hsotg *hsotg, bool
> force) {}
> static inline void dwc2_hcd_start(struct dwc2_hsotg *hsotg) {}
> sta
Hi,
Magnus Lilja writes:
> Hi
>
> I tried the fsl_udc_core gadget driver on the i.MX31 PDK board and got a
> kernel panic (NULL pointer dereference) when connecting the USB cable. I
> had the g_serial module loaded as well.
>
> The NULL pointer panic comes from gadget/udc/core.c
> usb_gadget_
Hi,
Alan Stern writes:
> On Mon, 16 Jan 2017, Felipe Balbi wrote:
>
>> > The gadget driver never calls usb_ep_queue in order to receive the next
>> > SETUP packet; the UDC driver takes care of SETUP handling
>> > automatically.
>>
>> yeah, that's another thing I'd like to change. Currently, we
Hi,
Vincent Pelletier writes:
> On Mon, 16 Jan 2017 14:48:31 +, Vincent Pelletier
> wrote:
>> 3) I declared 4 endpoints (2 IN, 2 OUT). And I went one level deeper
>>down the rabbit hole: now enumeration fails with this message on
>>host:
>
> Aaand... I dug this part of the hole myse
Hi,
Bryan O'Donoghue writes:
> - DWC_USB3_NUM indicates the number of Device mode single directional
> endpoints, including OUT and IN endpoint 0.
>
> - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN
> endpoints active at any time, including control endpoint 0.
>
> It's p
On 23.01.2017 13:57, David Laight wrote:
From: Mathias Nyman
Sent: 20 January 2017 14:47
Instead of storing a zero length array of td pointers, and then
allocate memory both for the td pointer array and the td's, just
use a zero length array of actual td's in urb private data.
This reminds
We don't want to confuse halted and stalled endpoint states with
a flag indicating we are waiting for a stop endpoint command to
finish or timeout
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 6 +++---
drivers/usb/host/xhci.c | 6 +++---
drivers/usb/host/xhci.h | 2 +
From: Lu Baolu
The second try was a workaround for (what we thought was) command
ring failing to stop in the first place. But this turns out to be
due to the race that we have fixed(see "xhci: Fix race related to
abort operation"). With that fix, it is time to remove the second
try.
Signed-off-b
No functional change, De Morgan !(A && B) = (!A || !B)
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index e32029a..46df89e 100644
--- a/drivers/usb/h
Hi Greg
version 2.
A lot of xhci cleanups, refactoring and changes for 4.11
Including major tracing rework by Felipe
Changes since v1:
Removed extra empty lines in patch 25/37
Added "based on" entry to patch 25/37 and 26/37 commit messages
fixed typo in patch 32/37 commit message
-Mathias
Checking if the command timeout timer is pending when queueing the
first command to the command ring is not really useful, remove it.
Suggested-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/driver
A counter was used to find out if the stop endpoint completion raced with
the stop endpoint timeout timer. This was needed in case the stop ep
completion failed to delete the timer as it was running on anoter cpu.
The EP_STOP_CMD_PENDING flag was not enough as a new stop endpoint command
may be qu
From: Alexander Stein
This allows someone to grep for the complete warning message as in;
xhci-hcd xhci-hcd.0.auto: USB core suspending device not in U0/U1/U2.
Signed-off-by: Alexander Stein
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-hub.c | 3 +--
1 file changed, 1 insertion(+),
From: Lu Baolu
No need to calculate remainder and length_field, if there is
no data phase of a control transfer.
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/dri
From: Lu Baolu
Use list_is_singular() to check if cmd_list has only one entry.
[use list_empty() in queue command instead -Mathias]
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/
From: Baolin Wang
Since the 'addr_64' variable as legacy is unused now, then remove it from
xhci_hcd structure.
Signed-off-by: Baolin Wang
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhc
From: Felipe Balbi
Some devices from Texas Instruments [1] suffer from
a silicon bug where Port Enabled/Disabled bit
should not be used to silence an erroneous device.
The bug is so that if port is disabled with PED
bit, an IRQ for device removal (or attachment)
will never fire.
Just for the sa
From: Felipe Balbi
When calling xhci_dbg_regs() we actually _do_ want to know XHCI's
version. This might help figure out why certain problems only happen
in some cases.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-dbg.c | 2 --
1 file changed, 2 deletions
From: Lu Baolu
Remove the unnecessary return line in xhci_pci_setup().
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-pci.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index
From: Felipe Balbi
Cleanup only. This patch is a mechaninal rename to make sure our macros
for TRB completion codes match what the specification uses to refer to
such errors. The idea behind this is that it makes it far easier to grep
the specification and match it with implementation.
Signed-of
Useful for turning both transfer and command trbs
into no-ops.
Based on earlier code by Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 29 +
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/
From: Felipe Balbi
it does no good, let's remove it.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ext-caps.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ext-caps.h b/drivers/usb/host/xhci-ext-caps.h
index e024
Use switch instead of several if statements
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.c | 93 -
1 file changed, 37 insertions(+), 56 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index dde5c2d..6d6c460 10
From: Felipe Balbi
These three new tracers will help us tie TRBs into URBs by *also*
looking into URB lifetime.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 1 +
drivers/usb/host/xhci-trace.h | 70 +++
dr
From: Felipe Balbi
In case 'quirk-broken-port-ped' property is passed in via device property,
we should enable the corresponding BROKEN_PED quirk flag for XHCI core.
[rog...@ti.com] Updated code from platform data to device property
and added DT binding.
Signed-off-by: Felipe Balbi
Signed-off-
From: Lu Baolu
Drop an unnecessary assignment in prepare_transfer().
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index bcc0894..61b5fea 10
From: Felipe Balbi
This is a cleanup patch only, no functional changes. The idea is just to
make sure for loops look the same all over the driver.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-dbg.c | 20 ++--
drivers/usb/host/xhci-mem.c |
From: Felipe Balbi
Instead of having several return points, let's use a local variable and
a single place to return. This makes the code slightly easier to read.
[set ret = IRQ_HANDLED in default working case -Mathias]
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/
From: Felipe Balbi
xhci_unmap_td_bounce_buffer() already checks for a valid td->bounce_seg
and bails out early if that's invalid. There's no need to check for this
twice.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 9 +++--
1 file changed, 3
From: Felipe Balbi
no functional changes. Simple cleanup to make sure variables are ordered
in a 'reverse christmas tree' fashion. While at that, also remove an
obsolete comment which doesn't apply anymore.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-rin
From: Felipe Balbi
If we just provide a helper to convert completion code to string, we can
combine all debugging messages into a single print.
[keep the old debug messages, for warn and grep -Mathias]
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.h | 80 +
From: Felipe Balbi
If we add that newline, the output will look like the following:
kworker/2:1-42[002] 169.811435: xhci_address_ctx:
ctx_64=0, ctx_type=2, ctx_dma=@153fbd000, ctx_va=@880153fbd000
We would rather have that in a single line.
Signed-off-by: Felipe Balbi
Sign
From: Felipe Balbi
instead of having a tracer that can only trace command completions,
let's promote this tracer so it can trace and decode any TRB.
With that, it will be easier to extrapolate the lifetime of any TRB
which might help debugging certain issues.
Signed-off-by: Felipe Balbi
Signed
From: Felipe Balbi
Replace list_entry() with list_first_entry() and list_for_each() with
list_for_each_entry(). This makes the code slightly more readable.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 19 ++-
1 file changed, 10 in
Remove duplicate code by using trb_to_noop() when
handling Aborted commads
Based on earlier code by Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/driver
From: Felipe Balbi
This way we can remove checks for valid ring from call sites of
xhci_unmap_td_bounce_buffer()
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-
From: Felipe Balbi
handle_tx_event() is not releasing xhci->lock nor reacquiring it, remove
the bogus annotation.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drive
From: Felipe Balbi
Let's start tracing at least part of an xhci_virt_device lifetime. We
might want to extend this tracepoint class later, but for now it already
exposes quite a bit of valuable information.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-hub
From: Felipe Balbi
By extracting xhci_td_cleanup() from finish_td(), code before clearer
and easier to follow.
There are no functional changes with this patch. It's merely a cleanup.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 92 ++
Instead of storing a zero length array of td pointers, and then
allocate memory both for the td pointer array and the td's, just
use a zero length array of actual td's in urb private data.
old:
struct urb_priv {
struct xhci_td *td[0]
}
new:
struct urb_priv {
struct xhci_td td[0]
urb_priv structure has a count on how many TDs the
URB contains, and how many of those TD's we have handled.
rename:
length -> num_tds
td_cnt -> num_tds_done
No functional changes
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 10 +-
drivers/usb/host/xhci.c | 14 +
From: Mathias Nyman
> Sent: 20 January 2017 14:47
> Instead of storing a zero length array of td pointers, and then
> allocate memory both for the td pointer array and the td's, just
> use a zero length array of actual td's in urb private data.
This reminds me of an old patch that got reverted be
From: Felipe Balbi
when getting endpoint type, a switch statement looks
better than a series of if () branches. There are no
functional changes with this patch, cleanup only.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-mem.c | 10 ++
1 file chang
No functinal changes.
num_tds describes the number of transfer descriptor better than "size"
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 4968e
From: Felipe Balbi
instead of using while(!list_empty()) followed by list_first_entry(), we
can actually use list_for_each_entry_safe().
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions
Hi,
David Laight writes:
> From: Mathias Nyman
>> Sent: 20 January 2017 14:47
>> From: Felipe Balbi
>>
>> If we add that newline, the output will like like the following:
>>
>> kworker/2:1-42[002] 169.811435: xhci_address_ctx:
>> ctx_64=0, ctx_type=2, ctx_dma=@153fbd000, ctx_v
From: Mathias Nyman
> Sent: 20 January 2017 14:47
> From: Felipe Balbi
>
> If we add that newline, the output will like like the following:
>
> kworker/2:1-42[002] 169.811435: xhci_address_ctx:
> ctx_64=0, ctx_type=2, ctx_dma=@153fbd000, ctx_va=@880153fbd000
>
> We would rat
Hi Florian,
On Fri, Jan 20, 2017 at 12:58 AM, Florian Fainelli wrote:
> On 01/19/2017 02:44 AM, Raviteja Garimella wrote:
>> Hi,
>>
>> On Thu, Jan 19, 2017 at 12:15 AM, Florian Fainelli
>> wrote:
>>> On 01/17/2017 12:05 AM, Raviteja Garimella wrote:
This patch splits the amd5536udc driver
On 23/01/17 12:08, Felipe Balbi wrote:
>
> Hi,
>
> Bryan O'Donoghue writes:
>> - DWC_USB3_NUM indicates the number of Device mode single directional
>> endpoints, including OUT and IN endpoint 0.
>>
>> - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN
>> endpoints active a
On 01/20/2017 09:00 PM, Bin Liu wrote:
> On Thu, Jan 19, 2017 at 11:06:57AM +0100, Alexandre Bailon wrote:
>> Currently, the CPPI 4.1 driver is not completely generic and
>> only work on dsps. This is because of IRQ management.
>> Add a callback to dma_controller that could be invoked on DMA comple
On Sat, Jan 21, 2017 at 7:49 PM, Chunfeng Yun wrote:
> Hi,
>
> On Sat, 2017-01-21 at 14:11 -0600, Rob Herring wrote:
>> On Wed, Jan 18, 2017 at 02:08:27PM +0800, Chunfeng Yun wrote:
>> > add a reference clock for compatibility
>>
>> Why? This block suddenly has 2 clocks instead of 1?
> In fact, th
On Sat, Jan 21, 2017 at 8:50 PM, Chunfeng Yun wrote:
> On Sat, 2017-01-21 at 14:08 -0600, Rob Herring wrote:
>> On Wed, Jan 18, 2017 at 02:00:14PM +0800, Chunfeng Yun wrote:
>> > add a new compatible string for "mt2712", and a new reference clock
>> > for SuperSpeed analog phy;
>> >
>> > Signed-of
On Thu, 5 Jan 2017, Benjamin Tissoires wrote:
> I don't know what to do about hiddev too. I don't know if we have actual
> users besides some debugging tools. And hidraw is much better than
> hiddev, so ideally, I'd like to remove it some way.
First, I'd love to get rid of HID_QUIRK_NO_INIT_REP
On Mon, Jan 23, 2017 at 12:47:31PM +0100, Petr Cvek wrote:
> Dne 23.1.2017 v 12:32 Greg KH napsal(a):
> I know it is only a cosmetic change on a legacy driver, but I assume
> it would be better to have some default value for configfs API than to
> borrow a PID from a whole different
Hi,
Heikki Krogerus writes:
> +static int wcove_typec_probe(struct platform_device *pdev)
> +{
[snip]
> + wcove->cap.prefer_role = TYPEC_NO_PREFERRED_ROLE;
we have a slight problem here that affects users of this particular
driver. Well, more specifically, it affects Intel Joule.
Because
Hello,
On Mon, 23 Jan 2017 14:00:40 +0200, Felipe Balbi
wrote:
> it could be that we're ran out of IN endpoints. There's a maximum number
> to how many IN endpoints we can have enabled at one time and, currently,
> dwc3 is not enforcing that in any way (I'll get that sorted out for
> v4.12, v4.11
Hi,
Greg KH writes:
>> >> fine by me. Just lsusb will look funky ;-)
>> >
>> > Heh, true, but I thought lsusb would use a string if the device provided
>> > it. Haven't looked at that portion of the code in a very long time...
>> >
>>
>> My lsusb shows separate strings (using usbutils from s
On 01/19/2017 07:15 PM, Sergei Shtylyov wrote:
> On 01/19/2017 02:13 PM, Alexandre Bailon wrote:
>
> > The DA8xx has a CPPI 4.1 DMA controller.
> > This is add the glue layer required to make it work on DA8xx.
> >
> > Signed-off-by: Alexandre Bailon
> > ---
> > drivers/dma/Kconfig | 6 +++---
>
Hi,
Vincent Pelletier writes:
> On Mon, 23 Jan 2017 14:00:40 +0200, Felipe Balbi
> wrote:
>> it could be that we're ran out of IN endpoints. There's a maximum number
>> to how many IN endpoints we can have enabled at one time and, currently,
>> dwc3 is not enforcing that in any way (I'll get th
On 23.01.2017 14:15, Mathias Nyman wrote:
On 23.01.2017 13:57, David Laight wrote:
From: Mathias Nyman
Sent: 20 January 2017 14:47
Instead of storing a zero length array of td pointers, and then
allocate memory both for the td pointer array and the td's, just
use a zero length array of actua
On Mon, 23 Jan 2017 16:30:57 +0200, Felipe Balbi
wrote:
> hmmm, what does the following show?
>
> # mkdir -p /d
> # mount -t debugfs none /d
> # grep HWPARAMS3 /d/*dwc3*/regdump
# grep HWPARAMS3 /sys/kernel/debug/*dwc3*/regdump
GHWPARAMS3 = 0x10420089
Regards,
--
Vincent Pelletier
pgp9ZJv9GN
It is allowed by the USB specification to enabled same-address, opposite-
direction endpoints simultaneously, which means 30 non-zero endpoints
are allowed. So double eps_addrmap length to 30.
The original code only accepted 14 descriptors out of a likely intended 15
(as there are 15 endpoint addre
Changes since try 1:
- impove commit message a bit
- #declare array size to avoid duplication
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Cristian Birsan
Update atmel udc driver with a new enpoint allocation scheme. The data
sheet requires that all endpoints are allocated in order.
Signed-off-by: Cristian Birsan
---
drivers/usb/gadget/udc/Kconfig | 14 ++
drivers/usb/gadget/udc/atmel_usba_udc.c | 236
On Sun, Jan 22, 2017 at 12:32:16AM +0300, Maksim Salau wrote:
> The adaptor can be found on development boards for 78k, RL78 and V850
> microcontrollers produced by Renesas Electronics Corporation.
>
> This is not a full-featured USB to serial converter, however it allows
> basic communication and
Hi,
Vincent Pelletier writes:
> On Mon, 23 Jan 2017 16:30:57 +0200, Felipe Balbi
> wrote:
>> hmmm, what does the following show?
>>
>> # mkdir -p /d
>> # mount -t debugfs none /d
>> # grep HWPARAMS3 /d/*dwc3*/regdump
>
> # grep HWPARAMS3 /sys/kernel/debug/*dwc3*/regdump
> GHWPARAMS3 = 0x104200
Hi,
Heikki Krogerus writes:
> +static void typec_report_identity(struct device *dev)
> +{
> + sysfs_notify(&dev->kobj, "identity", "id_header");
> + sysfs_notify(&dev->kobj, "identity", "cert_stat");
> + sysfs_notify(&dev->kobj, "identity", "product");
if you sysfs_notify() all thre
From: Cristian Birsan
Hi,
This patch updates the usb endpoint allocation scheme for atmel usba
driver to make sure all endpoints are allocated in order. This requirement
comes from the datasheet of the controller.
The allocation scheme is decided by fifo_mode parameter. For fifo_mode = 0
the dr
1 - 100 of 159 matches
Mail list logo
