Re: [PATCH v2 1/5] usb: dwc2: gadget: use ep->fifo_index in context of FIFO registers

2017-01-09 Thread Morgan Chang
Hi, John On Thu, Feb 4, 2016 at 8:25 PM, Vahram Aharonyan wrote: > On 2/3/2016 3:40 PM, Robert Baldyga wrote: > > Hi Robert, > > DTXFSTS register is linked with endpoint, not FIFO - it contains information > about how much space is used in the FIFO assigned to the endpoint. Changing > ep->index

Re: [PATCH v5 1/2] USB: add switch to turn off padding of resume time delays

2017-01-09 Thread Oliver Neukum
On Fri, 2017-01-06 at 16:45 -0800, Todd Brandt wrote: > Add a kernel parameter that replaces the USB_RESUME_TIMEOUT > and other hardcoded delay numbers with the USB spec minimums. Hi, the problem with that is that distros cannot use it. It is obviously better than nothing but it seems to me that

XHCI regression on v4.10-rc1

2017-01-09 Thread Patrice Chotard
Hi Mathias, Greg I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or B2120 STi boards platform with nothing plugged on USB3 connector, i observed the following kernel logs : [ 801.953836] usb usb6-port1: Cannot enable. Maybe the USB cable is bad? [ 801.960455] xhci-h

Re: XHCI regression on v4.10-rc1

2017-01-09 Thread Greg Kroah-Hartman
On Mon, Jan 09, 2017 at 11:08:39AM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 09, 2017 at 10:51:34AM +0100, Patrice Chotard wrote: > > Hi Mathias, Greg > > > > I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or > > B2120 STi boards platform > > with nothing plugged on U

Re: XHCI regression on v4.10-rc1

2017-01-09 Thread Greg Kroah-Hartman
On Mon, Jan 09, 2017 at 10:51:34AM +0100, Patrice Chotard wrote: > Hi Mathias, Greg > > I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or > B2120 STi boards platform > with nothing plugged on USB3 connector, i observed the following kernel logs : > > > [ 801.953836]

Re: XHCI regression on v4.10-rc1

2017-01-09 Thread Patrice Chotard
On 01/09/2017 11:08 AM, Greg Kroah-Hartman wrote: > On Mon, Jan 09, 2017 at 10:51:34AM +0100, Patrice Chotard wrote: >> Hi Mathias, Greg >> >> I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or >> B2120 STi boards platform >> with nothing plugged on USB3 connector, i obser

Re: usb:xhci: support disable usb2 LPM Remote Wakeup

2017-01-09 Thread Thang Q. Nguyen
On Mon, Dec 12, 2016 at 8:00 PM, Mathias Nyman wrote: > On 12.12.2016 06:00, Thang Q. Nguyen wrote: >> >> On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring wrote: >>> >>> On Sun, Dec 04, 2016 at 07:42:01PM +0700, Thang Q. Nguyen wrote: From: Thang Nguyen As per USB 2.0 link power

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Felipe Balbi
Hi, Martin Blumenstingl writes: > while adding USB support on the Amlogic Meson GXL / GXM SoCs I have > come across something I did not know yet: > dwc3 has an internal USB2 hub (from what I can read in the code there > seem to be multiple USB3 ports supported as well). no, that's not true. It

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Martin Blumenstingl
Hi Felipe, On Mon, Jan 9, 2017 at 11:37 AM, Felipe Balbi wrote: > > Hi, > > Martin Blumenstingl writes: >> while adding USB support on the Amlogic Meson GXL / GXM SoCs I have >> come across something I did not know yet: >> dwc3 has an internal USB2 hub (from what I can read in the code there >>

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Felipe Balbi
Hi, Martin Blumenstingl writes: >> Martin Blumenstingl writes: >>> while adding USB support on the Amlogic Meson GXL / GXM SoCs I have >>> come across something I did not know yet: >>> dwc3 has an internal USB2 hub (from what I can read in the code there >>> seem to be multiple USB3 ports suppo

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Martin Blumenstingl
On Mon, Jan 9, 2017 at 12:18 PM, Felipe Balbi wrote: > > Hi, > > Martin Blumenstingl writes: >>> Martin Blumenstingl writes: while adding USB support on the Amlogic Meson GXL / GXM SoCs I have come across something I did not know yet: dwc3 has an internal USB2 hub (from what I can

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Felipe Balbi
Hi, Martin Blumenstingl writes: > On Mon, Jan 9, 2017 at 12:18 PM, Felipe Balbi > wrote: >> >> Hi, >> >> Martin Blumenstingl writes: Martin Blumenstingl writes: > while adding USB support on the Amlogic Meson GXL / GXM SoCs I have > come across something I did not know yet: >

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Martin Blumenstingl
On Mon, Jan 9, 2017 at 12:55 PM, Felipe Balbi wrote: > > Hi, > > Martin Blumenstingl writes: >> On Mon, Jan 9, 2017 at 12:18 PM, Felipe Balbi >> wrote: >>> >>> Hi, >>> >>> Martin Blumenstingl writes: > Martin Blumenstingl writes: >> while adding USB support on the Amlogic Meson GXL / G

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Felipe Balbi
Hi, Martin Blumenstingl writes: >>> When searching the web I did not come across any SoC that uses a >>> configuration with more than one port enabled. >>> >>> On my Amlogic Meson GXM device (consumer device, no development board) >>> I see the following USB2 PHY register con

Re: XHCI regression on v4.10-rc1

2017-01-09 Thread Mathias Nyman
On 09.01.2017 11:51, Patrice Chotard wrote: Hi Mathias, Greg Hi I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or B2120 STi boards platform with nothing plugged on USB3 connector, i observed the following kernel logs : [ 801.953836] usb usb6-port1: Cannot enab

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Martin Blumenstingl
On Mon, Jan 9, 2017 at 1:16 PM, Felipe Balbi wrote: > > Hi, > > Martin Blumenstingl writes: When searching the web I did not come across any SoC that uses a configuration with more than one port enabled. On my Amlogic Meson GXM device (consumer device, no devel

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Felipe Balbi
Hi, Martin Blumenstingl writes: [snip] true. But even so, that PHY handle is only needed for devices which weren't properly configured at coreConsultant time. >>> I don't understand that - there are two separate modules involved >>> here: 1. the dwc3 IP block 2. Amlogic's own USB2 PH

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Martin Blumenstingl
On Mon, Jan 9, 2017 at 1:39 PM, Felipe Balbi wrote: > > Hi, > > Martin Blumenstingl writes: > > [snip] > > true. But even so, that PHY handle is only needed for devices which > weren't properly configured at coreConsultant time. I don't understand that - there are two separate module

Re: dwc3: add support for hardware with multiple ports on USB2 hub enabled

2017-01-09 Thread Felipe Balbi
Hi, Martin Blumenstingl writes: > On Mon, Jan 9, 2017 at 1:39 PM, Felipe Balbi > wrote: >> >> Hi, >> >> Martin Blumenstingl writes: >> >> [snip] >> >> true. But even so, that PHY handle is only needed for devices which >> weren't properly configured at coreConsultant time. > I don'

Re: [PATCH v2 6/7] usb: musb: fix runtime PM in debugfs

2017-01-09 Thread Bin Liu
Greg, On Thu, Jan 05, 2017 at 12:33:02PM -0600, Bin Liu wrote: > On Thu, Jan 05, 2017 at 07:17:51PM +0100, Greg KH wrote: > > On Tue, Jan 03, 2017 at 06:13:51PM -0600, Bin Liu wrote: > > > MUSB driver now has runtime PM support, but the debugfs driver misses > > > the PM _get/_put() calls, which c

[try2] usb: gadget: f_fs: Fix iterations on endpoints.

2017-01-09 Thread Vincent Pelletier
Changes since first submission: - use my personal address for author & sign-off (no code change) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

2017-01-09 Thread Johan Hovold
On Tue, Dec 20, 2016 at 09:49:00PM +0100, Johan Hovold wrote: > On Tue, Dec 20, 2016 at 12:09:55PM -0800, Russell Senior wrote: > > On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold wrote: > > > > > Perhaps we should determine what else is working or broken first, > > > though. > > > > > > Russel, co

usb: gadget: f_fs: Fix iterations on endpoints.

2017-01-09 Thread Vincent Pelletier
When zero endpoints are declared for a function, there is no endpoint to disable, enable or free, so replace do...while loops with while loops. Change pre-decrement to post-decrement to iterate the same number of times when there are endpoints to process. Signed-off-by: Vincent Pelletier --- dri

Re: XHCI regression on v4.10-rc1

2017-01-09 Thread Patrice Chotard
On 01/09/2017 01:30 PM, Mathias Nyman wrote: > > On 09.01.2017 11:51, Patrice Chotard wrote: >> Hi Mathias, Greg > > Hi > >> >> I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or >> B2120 STi boards platform >> with nothing plugged on USB3 connector, i observed the followi

Re: [PATCH v2 6/7] usb: musb: fix runtime PM in debugfs

2017-01-09 Thread Greg KH
On Mon, Jan 09, 2017 at 07:21:03AM -0600, Bin Liu wrote: > Greg, > > On Thu, Jan 05, 2017 at 12:33:02PM -0600, Bin Liu wrote: > > On Thu, Jan 05, 2017 at 07:17:51PM +0100, Greg KH wrote: > > > On Tue, Jan 03, 2017 at 06:13:51PM -0600, Bin Liu wrote: > > > > MUSB driver now has runtime PM support,

Re: [PATCH V1 1/2] usb:serial: Implement Fintek F81232 break on/off

2017-01-09 Thread Johan Hovold
On Fri, Dec 09, 2016 at 01:39:33PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Implement Fintek F81232 break on/off with LCR register, > it's the same with 16550A LCR register layout. > > Signed-off-by: Ji-Ze Hong (Peter Hong) > --- > drivers/usb/serial/f81232.c | 40

Re: [PATCH V1 2/2] usb:serial: Implement Fintek f81534 break on/off

2017-01-09 Thread Johan Hovold
On Fri, Dec 09, 2016 at 01:39:34PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Implement Fintek f81534 break on/off with LCR register > It's the same with 16550A LCR register layout > > We'll add a shadow LCR variable to save the final LCR we > had set due to the "read ep0" operations maybe slow down

Re: Raw hid gadget

2017-01-09 Thread Alan Stern
On Mon, 9 Jan 2017, Rogan Dawes wrote: > > This raises the question of how many of the values in the report are > > real. In your first example, for instance, there must have been 64 > > values but only 4 of them were real. How are you going to tell where > > the real data ends in each report? >

Re: [PATCH 2/2] usb: host: ohci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths

2017-01-09 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/07/2017 05:41 AM, Krzysztof Kozlowski wrote: > Returning from for_each_available_child_of_node() loop requires cleaning > up node refcount. Error paths lacked it so for example in case of > deferred probe, the refcount of phy node was left increased. > > Fixes: 6d40500ac9b

Re: [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths

2017-01-09 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/07/2017 05:41 AM, Krzysztof Kozlowski wrote: > Returning from for_each_available_child_of_node() loop requires cleaning > up node refcount. Error paths lacked it so for example in case of > deferred probe, the refcount of phy node was left increased. > > Fixes: 6d40500ac9b

Re: [PATCH 1/4] ARM: dts: exynos: Fix indentation of EHCI and OHCI ports

2017-01-09 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/07/2017 05:52 AM, Krzysztof Kozlowski wrote: > Replace spaces with tabs in EHCI and OHCI ports indentation. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research A

Re: [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths

2017-01-09 Thread Alan Stern
On Sat, 7 Jan 2017, Krzysztof Kozlowski wrote: > Returning from for_each_available_child_of_node() loop requires cleaning > up node refcount. Error paths lacked it so for example in case of > deferred probe, the refcount of phy node was left increased. > > Fixes: 6d40500ac9b6 ("usb: ehci/ohci-ex

Re: [PATCH 2/2] usb: host: ohci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths

2017-01-09 Thread Alan Stern
On Sat, 7 Jan 2017, Krzysztof Kozlowski wrote: > Returning from for_each_available_child_of_node() loop requires cleaning > up node refcount. Error paths lacked it so for example in case of > deferred probe, the refcount of phy node was left increased. > > Fixes: 6d40500ac9b6 ("usb: ehci/ohci-ex

[PATCH 02/11] dmaengine: cppi41: Split out the interrupt handler

2017-01-09 Thread Alexandre Bailon
The current interrupt handler do some actions specifics to am335x. These actions should be made by the platform interrupt handler. Split out the interrupt handler in two: one for the am335x platform and a generic one. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 24 +++-

[PATCH 01/11] dmaengine: cppi41: rename platform variables

2017-01-09 Thread Alexandre Bailon
Currently, only the am335x is supported by the driver. Though the driver has a glue layer to support different platforms, some platform variable names are not prefixed with the platform name. To facilitate the addition of a new platform, rename some variables owned by the am335x glue. Currently, o

[PATCH 04/11] dmaengine: cppi41: init_sched(): Get number of channels from DT

2017-01-09 Thread Alexandre Bailon
Despite the driver is already using DT to get the number of channels, init_sched() is using an hardcoded value to get it. Use DT to get the number of channels. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 33 - 1 file changed, 20 insertions(+), 13 de

[PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

2017-01-09 Thread Alexandre Bailon
The da8xx has a cppi41 dma controller. This is add the glue layer required to make it work on da8xx, as well some changes in driver (e.g to manage clock). Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 95 1 file changed, 95 insert

[PATCH 06/11] dmaengine: cppi41: Only configure am335x's registers on amm335x platform

2017-01-09 Thread Alexandre Bailon
Currently, the driver configure some am335x's usb registers. Test if the driver is running on am335x before to configure these registers. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/dma/cp

[PATCH 07/11] dt/bindings: da8xx-usb: Add binding for the cppi41 dma controller

2017-01-09 Thread Alexandre Bailon
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx cppi41 dma controller. Signed-off-by: Alexandre Bailon --- .../devicetree/bindings/usb/da8xx-usb.txt | 39 ++ 1 file changed, 39 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Docu

[PATCH 03/11] dmaengine: cppi41: Move some constants to glue layer

2017-01-09 Thread Alexandre Bailon
Some constants are defined and use by the driver whereas they are specifics to am335x. Add new variables to the glue layer, initialize them with the constants, and use them in the driver. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 20 ++-- 1 file changed, 14 inser

[PATCH 05/11] dmaengine: cppi41: Add a way to test if the driver is running on am335x

2017-01-09 Thread Alexandre Bailon
As the cppi41 is present in different platform, the driver needs to determine on which platform it is running to execute instructions specific to this platform (such as configure IRQ on am335x). Add a way to test if we are running on am335x. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41

[PATCH 09/11] dmaengine: cppi41: Fix a race between PM runtime and channel abort

2017-01-09 Thread Alexandre Bailon
cppi41_dma_issue_pending() may be called while the device is runtime suspended. In that case, the descritpor will be push to the pending list and then be queued to hardware queue. But if cppi41_stop_chan() is called before the device got time to resume, then the descriptor will remain in the pendin

[PATCH 11/11] dmaengine: cppi41: Fix teardown warnings

2017-01-09 Thread Alexandre Bailon
During the teardown of a RX channel, because there is only one completion queue available for RX channel, descriptor of another channel may be popped which will cause 2 warnings: - the first one because we popped a wrong descriptor (neither the channel's descriptor, neither the teardown descripto

[PATCH 10/11] dmaengine: cppi41: Fix da8xx interrupt issue

2017-01-09 Thread Alexandre Bailon
Sometime, after a teardown, interrupts are not fired anymore. This happen because the interrupt handler doesn't re-assert IRQ. Once the teardown complete, the teardown descriptor is moved to completion queue, which is causing an interrupt. But cppi41_tear_down_chan() is called from atomic section,

[PATCH 00/11] dmaengine: cppi41: Add dma support to da8xx

2017-01-09 Thread Alexandre Bailon
This series adds support of da8xx to cppi41 dma controller driver. This update the cppi41 driver to make it more generic (was only supporting the am335x), and implement the support for the da8xx. Some other changes are required in platform and musb drivers to make the dma work on da8xx (though, it

[PATCH] ARM: davinci: da850: Share the usb20 clock

2017-01-09 Thread Alexandre Bailon
On da850, the cppi41 dma controller and usb core are the usb20 clock. Currently, this clock can only be used by the da8xx musb glue driver. Update the usb20 clock to be requested by more than one user. Signed-off-by: Alexandre Bailon --- arch/arm/mach-davinci/da850.c | 2 +- 1 file changed, 1 in

[PATCH] ARM: davinci: da850: Share the usb20 clock

2017-01-09 Thread Alexandre Bailon
On da850, the cppi41 dma controller and usb core are the usb20 clock. Currently, this clock can only be used by the da8xx musb glue driver. Update the usb20 clock to be requested by more than one user. Signed-off-by: Alexandre Bailon --- arch/arm/mach-davinci/da850.c | 2 +- 1 file changed, 1 in

Re: [PATCH 3/4] ARM: exynos_defconfig: Enable power sequence for Odroid U3

2017-01-09 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/07/2017 05:52 AM, Krzysztof Kozlowski wrote: > Odroid U3 needs a power sequence for lan9730, if it was enabled by > bootloader. Enable also GPIO_SYSFS which is useful for playing with > GPIO during debug process. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by:

Re: usb/gadget: warning in dummy_free_request

2017-01-09 Thread Andrey Konovalov
On Tue, Dec 27, 2016 at 12:40 PM, Felipe Balbi wrote: > > Hi, > > Andrey Konovalov writes: >> Hi! >> >> I've got the following error report while running the syzkaller fuzzer. >> >> On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). >> >> WARNING: CPU: 0 PID: 5257 at drivers/usb/gadget/u

Re: [PATCH 2/4] ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot

2017-01-09 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/07/2017 05:52 AM, Krzysztof Kozlowski wrote: > The ethernet adapter LAN9730, after enabling in bootloader (e.g. for > tftpboot) requires reset during boot. Otherwise it won't come up. > > The schematics of Odroid U3 are detailed enough but after grabbing > knowledge also f

[PATCH 2/3] ARM: dts: da850: Add the cppi41 dma to the usb otg controller

2017-01-09 Thread Alexandre Bailon
This adds the cppi41 dma controller to the usb otg controller. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index d6b406a..0ed0cb9 100644 --- a/arch/arm/boo

Re: [PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

2017-01-09 Thread Javier Martinez Canillas
Hello Krzysztof, I think it would had been clearer if the subject prefix was "[PATCH v1.1 4/4]" :) On 01/07/2017 06:16 AM, Krzysztof Kozlowski wrote: > Odroid U3 needs a power sequence for lan9730, if it was enabled by > bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device > is pre

[PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

2017-01-09 Thread Alexandre Bailon
This adds the device tree node for the cppi41 dma used by the usb otg controller present in the da850 family of SoC's. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/bo

[PATCH 3/3] ARM: dts: da850: Enable cppi41 dma for da850-lcdk

2017-01-09 Thread Alexandre Bailon
This enable the cppi41 dma controller used by the usb otg for the da850-lcdk board. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850-lcdk.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts index afcb482..abb9

[PATCH 0/3] ARM: dts: da850: Enable cppi41 dma

2017-01-09 Thread Alexandre Bailon
This series enable support of cppi41 for da850. The bindings and DT support are added in the series "dmaengine: cppi41: Add dma support to da8xx". Alexandre Bailon (3): ARM: dts: da850: Add the cppi41 dma node ARM: dts: da850: Add the cppi41 dma to the usb otg controller ARM: dts: da850: Ena

[PATCH 0/4] usb: musb: da8xx: Add DMA support

2017-01-09 Thread Alexandre Bailon
This series update musb driver to add DMA support to da8xx. To work correctly, the follwings patches are required: "dmaengine: cppi41: Add dma support to da8xx", "ARM: davinci: da850: Share the usb20 clock", "ARM: dts: da850: Enable cppi41 dma", "dmaengine: cppi41: PM runtime fixes" I haven't chan

[PATCH 2/4] usb: musb: Add support of cppi41 dma controller for da8xx to Kconfig

2017-01-09 Thread Alexandre Bailon
Currently, cppi41 driver can only be built for omap platform. As da8xx platform has a cppi41 dma controller, update the Kconfig to also support the da8xx. Signed-off-by: Alexandre Bailon --- drivers/dma/Kconfig | 2 +- drivers/usb/musb/Kconfig | 4 ++-- 2 files changed, 3 insertions(+), 3 d

[PATCH 4/4] usb: musb: musb_cppi41: Workaround dma stall issue during teardown

2017-01-09 Thread Alexandre Bailon
The dma may hung up if a teardown is initiated while an endpoint is still active (Advisory 2.3.27 of da8xx errata). To workaround this issue, add a delay before to initiate the teardown. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 2 +- drivers/usb/musb/musb_core.h | 1

[PATCH 1/4] usb: musb: da8xx: Use the right dma controller

2017-01-09 Thread Alexandre Bailon
da8xx driver is registering and using the cppi dma controller but actually, the da8xx has a cppi41 dma controller. Update the driver to register and use the cppi41 dma controller. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 8 1 file changed, 4 insertions(+), 4 deleti

[PATCH 3/4] usb: musb: Use shared irq

2017-01-09 Thread Alexandre Bailon
In the da8xx, usb core and cppi41 are sharing the same interrupt line. Update the driver to request a shared irq. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/musb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/m

Re: XHCI regression on v4.10-rc1

2017-01-09 Thread Mathias Nyman
On 09.01.2017 16:23, Patrice Chotard wrote: On 01/09/2017 01:30 PM, Mathias Nyman wrote: On 09.01.2017 11:51, Patrice Chotard wrote: Hi Mathias, Greg Hi I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or B2120 STi boards platform with nothing plugged on USB3 connect

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-09 Thread Guenter Roeck
Hello Heikki, On Thu, Jan 05, 2017 at 02:01:18PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and

[PATCH v2 2/2] dmaengine: cppi41: Ignore EINPROGRESS for PM runtime in interrupt handler

2017-01-09 Thread Alexandre Bailon
We can occasionally get -EINPROGRESS for pm_runtime_get. This is happening when an interrupt is fired before PM runtime had time to update the PM state to RESUMED. In that case, don't print any error. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 5 ++--- 1 file changed, 2 insertion

[PATCH v2 0/2] dmaengine: cppi41: PM runtime fixes

2017-01-09 Thread Alexandre Bailon
I have tried to play music on usb headset on BeagleBone Black but it doesn't work. This series intend to fix it. [ 12.476441] usb 1-1: new full-speed USB device number 2 using musb-hdrc [ 12.896297] usb 1-1: New USB device found, idVendor=047f, idProduct=c035 [ 12.903413] usb 1-1: New USB de

[PATCH v2 1/2] dmaengine: cppi41: Fix list not empty warning on runtime suspend

2017-01-09 Thread Alexandre Bailon
Sometime, a transfer may not be queued due to a race between runtime pm and cppi41_dma_issue_pending(). Sometime, cppi41_runtime_resume() may be interrupted right before to update device PM state to RESUMED. When it happens, if a new dma transfer is issued, because the device is not in active state

Re: [PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

2017-01-09 Thread Krzysztof Kozlowski
On Mon, Jan 9, 2017 at 6:24 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > I think it would had been clearer if the subject prefix was "[PATCH v1.1 > 4/4]" :) Ah, yes. > > On 01/07/2017 06:16 AM, Krzysztof Kozlowski wrote: >> Odroid U3 needs a power sequence for lan9730, if it was e

Re: [PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

2017-01-09 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/09/2017 02:38 PM, Krzysztof Kozlowski wrote: > On Mon, Jan 9, 2017 at 6:24 PM, Javier Martinez Canillas > wrote: >> Hello Krzysztof, >> >> I think it would had been clearer if the subject prefix was "[PATCH v1.1 >> 4/4]" :) > > Ah, yes. > >> >> On 01/07/2017 06:16 AM, Kr

Re: [PATCH 3/3] ARM: dts: da850: Enable cppi41 dma for da850-lcdk

2017-01-09 Thread David Lechner
On 01/09/2017 10:24 AM, Alexandre Bailon wrote: This enable the cppi41 dma controller used by the usb otg for the da850-lcdk board. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850-lcdk.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/ar

Re: [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-09 Thread Anand Moon
Hi Krzysztof, On 7 January 2017 at 14:21, Krzysztof Kozlowski wrote: > Hi, > > Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter > Chen, we got a power sequence generic library which solves my long > standing Odroid U3 problem - no LAN9730 if it was enabled by bootloader.

Re: [PATCH v2 1/2] dmaengine: cppi41: Fix list not empty warning on runtime suspend

2017-01-09 Thread Sergei Shtylyov
Hello! On 01/09/2017 08:03 PM, Alexandre Bailon wrote: Sometime, a transfer may not be queued due to a race between runtime pm and cppi41_dma_issue_pending(). Sometime, cppi41_runtime_resume() may be interrupted right before to update device PM state to RESUMED. When it happens, if a new dma tr

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

2017-01-09 Thread Grygorii Strashko
On 01/09/2017 10:06 AM, Alexandre Bailon wrote: > The da8xx has a cppi41 dma controller. > This is add the glue layer required to make it work on da8xx, > as well some changes in driver (e.g to manage clock). > > Signed-off-by: Alexandre Bailon > --- > drivers/dma/cppi41.c | 95 >

Re: [PATCH v2 1/2] dmaengine: cppi41: Fix list not empty warning on runtime suspend

2017-01-09 Thread Grygorii Strashko
On 01/09/2017 11:03 AM, Alexandre Bailon wrote: > Sometime, a transfer may not be queued due to a race between runtime pm > and cppi41_dma_issue_pending(). > Sometime, cppi41_runtime_resume() may be interrupted right before to > update device PM state to RESUMED. > When it happens, if a new dma t

Re: [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-09 Thread Krzysztof Kozlowski
On Mon, Jan 09, 2017 at 11:34:48PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 7 January 2017 at 14:21, Krzysztof Kozlowski wrote: > > Hi, > > > > Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter > > Chen, we got a power sequence generic library which solves my long >

Re: [PATCH v3] USB: Add uPD78F0730 USB to Serial Adaptor Driver

2017-01-09 Thread Johan Hovold
On Thu, Dec 08, 2016 at 10:13:37PM +0300, Maksim Salau wrote: > The adaptor can be found on development boards for 78k, RL78 and V850 > microcontrollers produced by Renesas Electronics Corporation. > > This is not a full-featured USB to serial converter, however it allows > basic communication and

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

2017-01-09 Thread Sergei Shtylyov
Hello. On 01/09/2017 07:24 PM, Alexandre Bailon wrote: This adds the device tree node for the cppi41 dma used by the usb otg controller present in the da850 family of SoC's. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850.dtsi | 16 1 file changed, 16 insertions(

Re: [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-09 Thread Anand Moon
Hi Krzysztof, On 9 January 2017 at 23:47, Krzysztof Kozlowski wrote: > On Mon, Jan 09, 2017 at 11:34:48PM +0530, Anand Moon wrote: >> Hi Krzysztof, >> >> On 7 January 2017 at 14:21, Krzysztof Kozlowski wrote: >> > Hi, >> > >> > Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to

Re: [PATCH 1/4] usb: musb: da8xx: Use the right dma controller

2017-01-09 Thread Sergei Shtylyov
Hello! On 01/09/2017 07:38 PM, Alexandre Bailon wrote: da8xx driver is registering and using the cppi dma controller but actually, the da8xx has a cppi41 dma controller. Update the driver to register and use the cppi41 dma controller. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8x

Re: [PATCH v2 1/2] dmaengine: cppi41: Fix list not empty warning on runtime suspend

2017-01-09 Thread Tony Lindgren
Hi, * Alexandre Bailon [170109 09:04]: > Sometime, a transfer may not be queued due to a race between runtime pm > and cppi41_dma_issue_pending(). > Sometime, cppi41_runtime_resume() may be interrupted right before to > update device PM state to RESUMED. > When it happens, if a new dma transfer i

Re: [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-09 Thread Krzysztof Kozlowski
On Mon, Jan 09, 2017 at 11:56:41PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 9 January 2017 at 23:47, Krzysztof Kozlowski wrote: > > On Mon, Jan 09, 2017 at 11:34:48PM +0530, Anand Moon wrote: > >> Hi Krzysztof, > >> > >> On 7 January 2017 at 14:21, Krzysztof Kozlowski wrote: > >> > Hi, >

Re: [PATCH v2 2/2] dmaengine: cppi41: Ignore EINPROGRESS for PM runtime in interrupt handler

2017-01-09 Thread Tony Lindgren
* Alexandre Bailon [170109 09:04]: > We can occasionally get -EINPROGRESS for pm_runtime_get. > This is happening when an interrupt is fired before PM runtime had time > to update the PM state to RESUMED. > In that case, don't print any error. Hmm if the cppi41 interrupt fires, the device has res

Re: [PATCH 07/11] dt/bindings: da8xx-usb: Add binding for the cppi41 dma controller

2017-01-09 Thread Sergei Shtylyov
Hello! On 01/09/2017 07:06 PM, Alexandre Bailon wrote: DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx cppi41 dma controller. It's called CPPI 4.1, not cppi41. Let me introduce myself: I was the author of the 1st CPPI 4.1 drivers (never merged). Signed-off-by: Alexandre Bailon -

Re: [PATCH 4/4] usb: musb: musb_cppi41: Workaround dma stall issue during teardown

2017-01-09 Thread Sergei Shtylyov
Hello! On 01/09/2017 07:39 PM, Alexandre Bailon wrote: The dma may hung up if a teardown is initiated while an endpoint is still The DMA may hang up... active (Advisory 2.3.27 of da8xx errata). To workaround this issue, add a delay before to initiate the teardown. Signed-off-by: Alexand

Re: [PATCH 1/4] usb: musb: da8xx: Use the right dma controller

2017-01-09 Thread Tony Lindgren
* Sergei Shtylyov [170109 10:30]: > Hello! > > On 01/09/2017 07:38 PM, Alexandre Bailon wrote: > > > da8xx driver is registering and using the cppi dma controller but actually, > > the da8xx has a cppi41 dma controller. > > Update the driver to register and use the cppi41 dma controller. > > >

Re: [PATCH 11/11] dmaengine: cppi41: Fix teardown warnings

2017-01-09 Thread Sergei Shtylyov
On 01/09/2017 07:06 PM, Alexandre Bailon wrote: During the teardown of a RX channel, because there is only one completion queue available for RX channel, descriptor of another channel may be popped which will cause 2 warnings: - the first one because we popped a wrong descriptor (neither the c

Re: [PATCH 1/4] usb: musb: da8xx: Use the right dma controller

2017-01-09 Thread Sergei Shtylyov
On 01/09/2017 09:43 PM, Tony Lindgren wrote: da8xx driver is registering and using the cppi dma controller but actually, the da8xx has a cppi41 dma controller. Update the driver to register and use the cppi41 dma controller. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 8 +++

Re: [PATCH 1/4] usb: musb: da8xx: Use the right dma controller

2017-01-09 Thread Tony Lindgren
* Sergei Shtylyov [170109 10:55]: > On 01/09/2017 09:43 PM, Tony Lindgren wrote: > > > > > da8xx driver is registering and using the cppi dma controller but > > > > actually, > > > > the da8xx has a cppi41 dma controller. > > > > Update the driver to register and use the cppi41 dma controller. >

Re: [PATCH v2 2/2] dmaengine: cppi41: Ignore EINPROGRESS for PM runtime in interrupt handler

2017-01-09 Thread Grygorii Strashko
On 01/09/2017 12:39 PM, Tony Lindgren wrote: > * Alexandre Bailon [170109 09:04]: >> We can occasionally get -EINPROGRESS for pm_runtime_get. >> This is happening when an interrupt is fired before PM runtime had time >> to update the PM state to RESUMED. >> In that case, don't print any error. >

Fwd: Raw hid gadget

2017-01-09 Thread Rogan Dawes
Sigh! This got bounced because of HTML parts. Another question that arises, though: What sort of performance can I expect writing to and reading from a RAW HID gadget, configured using that descriptor? My understanding is that I should be able to get 64kBps, based on a 64-byte packet, and a 1000

[PATCH] usb: musb: fix runtime PM in debugfs

2017-01-09 Thread Bin Liu
MUSB driver now has runtime PM support, but the debugfs driver misses the PM _get/_put() calls, which could cause MUSB register access failure. Cc: sta...@vger.kernel.org # 4.9+ Acked-by: Tony Lindgren Signed-off-by: Bin Liu --- drivers/usb/musb/musb_debugfs.c | 20 +++- 1 file

[PATCH] musb fixes for v4.10-rc4

2017-01-09 Thread Bin Liu
Hi Greg, Here is musb fixes for v4.10-rc4, it only has one debugfs fix for a regression created in v4.9. Please let me know if any change is needed. Thanks, -Bin. --- Bin Liu (1): usb: musb: fix runtime PM in debugfs drivers/usb/musb/musb_debugfs.c | 20 +++- 1 file changed,

[PATCH 2/3] usb: dwc2: gadget: Fix DMA memory freeing

2017-01-09 Thread John Youn
From: Vardan Mikayelyan Remove DMA memory free from EP disable flow by replacing dma_alloc_coherent with dmam_alloc_coherent. Cc: John Stultz Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 14 +++--- 1 file changed, 3 insertions(+), 11 delet

[PATCH 0/3] usb: dwc2: fixes for 4.10-rc4

2017-01-09 Thread John Youn
Hi Felipe, These are a few dwc2 fixes from the list that are missing in your tree. Can you queue for the next -rc? Thanks, John John Stultz (1): usb: dwc2: Avoid suspending if we're in gadget mode Leo Yan (1): usb: dwc2: use u32 for DT binding parameters Vardan Mikayelyan (1): usb: dwc2

[PATCH 1/3] usb: dwc2: use u32 for DT binding parameters

2017-01-09 Thread John Youn
From: Leo Yan Commit 05ee799f2021 ("usb: dwc2: Move gadget settings into core_params") changes to type u16 for DT binding "g-rx-fifo-size" and "g-np-tx-fifo-size" but use type u32 for "g-tx-fifo-size". Finally the the first two parameters cannot be passed successfully with wrong data format. This

[PATCH 3/3] usb: dwc2: Avoid suspending if we're in gadget mode

2017-01-09 Thread John Youn
From: John Stultz I've found when booting HiKey with the usb gadget cable attached if I then try to connect via adb, I get an infinite spew of: dwc2 f72c.usb: dwc2_hsotg_ep_sethalt(ep ffc0790ecb18 ep1out, 0) dwc2 f72c.usb: dwc2_hsotg_ep_sethalt(ep ffc0790eca18 ep1in, 0) It seems

Re: [PATCH 2/3] usb: dwc2: gadget: Fix DMA memory freeing

2017-01-09 Thread John Stultz
On Mon, Jan 9, 2017 at 1:10 PM, John Youn wrote: > From: Vardan Mikayelyan > > Remove DMA memory free from EP disable flow by replacing > dma_alloc_coherent with dmam_alloc_coherent. > > Cc: John Stultz > Signed-off-by: Vardan Mikayelyan > Signed-off-by: John Youn This has my Tested-by: John

Re: [PATCH v8 1/2] usbip: vhci extension: modifications to userspace

2017-01-09 Thread Shuah Khan
On 12/26/2016 12:18 AM, Nobuo Iwata wrote: > Modification to the userspace tools including usbip/libsrc and > usbip/src. Modification to do what? Could you please write a concise change log describing what this patch does and why? Please note that the information in the cover-letter doesn't go in

Re: [PATCH v8 2/2] usbip: vhci extension: dynamic extension

2017-01-09 Thread Shuah Khan
On 12/26/2016 12:18 AM, Nobuo Iwata wrote: > Modification for dynamic device registration and unregistration. Why is this necessary? Could make your change logs concise with important details on why a change is needed and the functionality it adds. This change log is way too long and doesn't summa

[PATCH 02/21] usb: dwc2: Add identifier in prototypes

2017-01-09 Thread John Youn
Fixes checkpatch warning: WARNING: function definition argument 'struct dwc2_hsotg *' should also have an identifier name Signed-off-by: John Youn --- drivers/usb/dwc2/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/debug.h b/drivers/usb/dwc2/deb

[PATCH 01/21] usb: dwc2: Cleanup some checkpatch issues

2017-01-09 Thread John Youn
This commmit is the result of running checkpatch --fix. The results were verified for correctness. Some of the fixes result in line over 80 char which we will fix manually later. The following is a summary of what was done by checkpatch: * Remove externs on function prototypes. * Replace symbolic

[PATCH 00/21] usb: dwc2: Rework core parameters

2017-01-09 Thread John Youn
This series depends on the dwc2 fixes for 4.10-rc4 [1]. Patches 1-9 are a minor rebase and resend of the dwc2 checkpatch fixes series [2]. The remaining patches complete the reworking of the dwc2 core parameters. This is a follow up to and simplification of the previous rework in 4.10. Unlike th

  1   2   >