Re: [PATCHv13 2/3] usb: USB Type-C connector class

2016-12-15 Thread Heikki Krogerus
On Wed, Dec 07, 2016 at 02:52:31PM +0200, Heikki Krogerus wrote: > Hi Oliver, > > On Wed, Dec 07, 2016 at 10:46:48AM +0100, Oliver Neukum wrote: > > On Fri, 2016-12-02 at 10:04 -0800, Guenter Roeck wrote: > > > > Hi, > > > > > At least for my part I very much concentrated on making sure that > >

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-15 Thread Greg KH
On Wed, Dec 14, 2016 at 09:11:08PM -0800, Mateusz Berezecki wrote: > Promote a variable keeping track of USB transfer memory usage to a > wider data type and allow for higher bandwidth transfers from a large > number of USB devices connected to a single host. > > Signed-off-by: Mateusz Berezecki

Re: [PATCHv13 2/3] usb: USB Type-C connector class

2016-12-15 Thread Oliver Neukum
On Thu, 2016-12-15 at 13:50 +0200, Heikki Krogerus wrote: > 1) Should we use "source" and "sink" instead of "device" and "host" > with the prefer_role attribute after all? I was uncomfortable with > that when we talked about it last time because the terms kept changing > with every new Type-C spec

[no subject]

2016-12-15 Thread Ryan
auth 12a8a74f subscribe linux-usb ryanphilip...@googlemail.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[1/2] usb: gadget: f_fs: Document eventfd effect on descriptor format.

2016-12-15 Thread Vincent Pelletier
When FUNCTIONFS_EVENTFD flag is set, __ffs_data_got_descs reads a 32bits, little-endian value right after the fixed structure header, and passes it to eventfd_ctx_fdget. Document this. Also, rephrase a comment to be affirmative about the role of string descriptor at index 0. Ref: USB 2.0 spec para

[2/2] usb: gadget: f_fs: Fix ExtCompat descriptor validation

2016-12-15 Thread Vincent Pelletier
Reserved1 is documented as expected to be set to 0, but this test fails when it it set to 0. Reverse the condition. Signed-off-by: Vincent Pelletier --- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/dr

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-15 Thread Alan Stern
Hmmm, this is the third patch labelled v2 that you have mailed. In the future, be more careful about your version numbering. On Wed, 14 Dec 2016, Mateusz Berezecki wrote: > Promote a variable keeping track of USB transfer memory usage to a > wider data type and allow for higher bandwidth transf

Re: [PATCHv13 2/3] usb: USB Type-C connector class

2016-12-15 Thread Guenter Roeck
On 12/15/2016 03:50 AM, Heikki Krogerus wrote: On Wed, Dec 07, 2016 at 02:52:31PM +0200, Heikki Krogerus wrote: Hi Oliver, On Wed, Dec 07, 2016 at 10:46:48AM +0100, Oliver Neukum wrote: On Fri, 2016-12-02 at 10:04 -0800, Guenter Roeck wrote: Hi, At least for my part I very much concentrated

Re: [PATCH] USB: serial: f81534: Detect errors from f81534_logic_to_phy_port()

2016-12-15 Thread Johan Hovold
On Wed, Dec 14, 2016 at 12:18:53PM +0100, Geert Uytterhoeven wrote: > With gcc 4.1.2: > > drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’: > drivers/usb/serial/f81534.c:1250: warning: comparison is always false due > to limited range of data type > > f81534_logic_to_phy_port

Re: xhci_reset_endpoint() doesn't reset endpoint

2016-12-15 Thread Michal Necasek
On 12/14/2016 3:28 PM, Mathias Nyman wrote: On 14.12.2016 12:58, Michal Necasek wrote: prior to the endpoint reset. SetFeature(CLEAR_HALT) resets the toggle on the device, but not on the host. But we know for a fact that the device sends a packet (with data toggle 0) which the host USB stack nev

RE: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2016-12-15 Thread Manish Narani
Thanks Greg. I have send another patch with changes as per your suggestions. Please review it and let me know if you have any concerns. - Manish -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, December 15, 2016 2:29 AM To: Manish Narani Cc: mathias.n

Re: [PATCH 10/13] USB: serial: ch341: fix baud rate and line-control handling

2016-12-15 Thread Johan Hovold
On Wed, Dec 14, 2016 at 04:28:07PM +0100, Johan Hovold wrote: > Some CH341 devices appear to require the use of the init vendor command > to set the baud rate and line-control register. Specifically, while > using direct register updates for speed and LCR seem to update those > settings correctly,

[usb-audio] 4.4.38: Zoom H2n hangs xhci

2016-12-15 Thread Sami Farin
Sandybridge system on Asus P8Z68-V PRO GEN3 motherboard. H2n connected to HP ZR24w's hub. When H2n is used as microphone: (H2n is now disconnected but it didn't make any diff.) Dec 15 19:53:45 n kernel: usb 5-2.1: new full-speed USB device number 4 using xhci_hcd Dec 15 19:53:45 n kernel: usb 5

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-15 Thread Mateusz Berezecki
> Il giorno 15 dic 2016, alle ore 03:52, Greg KH > ha scritto: > >> On Wed, Dec 14, 2016 at 09:11:08PM -0800, Mateusz Berezecki wrote: >> Promote a variable keeping track of USB transfer memory usage to a >> wider data type and allow for higher bandwidth transfers from a large >> number of USB

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-15 Thread Mateusz Berezecki
> Il giorno 15 dic 2016, alle ore 06:51, Alan Stern > ha scritto: > > Hmmm, this is the third patch labelled v2 that you have mailed. In the > future, be more careful about your version numbering. Ok. Maybe I misunderstood versioning of patches. I thought of versions numbering the concept/

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-15 Thread Greg KH
On Thu, Dec 15, 2016 at 10:41:47AM -0800, Mateusz Berezecki wrote: > > > > Il giorno 15 dic 2016, alle ore 03:52, Greg KH > > ha scritto: > > > >> On Wed, Dec 14, 2016 at 09:11:08PM -0800, Mateusz Berezecki wrote: > >> Promote a variable keeping track of USB transfer memory usage to a > >> wid

Re: [usb-audio] 4.4.38: Zoom H2n hangs xhci

2016-12-15 Thread Greg KH
On Thu, Dec 15, 2016 at 08:22:44PM +0200, Sami Farin wrote: > Sandybridge system on Asus P8Z68-V PRO GEN3 motherboard. > > H2n connected to HP ZR24w's hub. When H2n is used as microphone: > (H2n is now disconnected but it didn't make any diff.) Can you try 4.9 and see if you still have the same

[PATCH 2/5] usb: musb: dsps: remove redundant code

2016-12-15 Thread Bin Liu
The session is cleared in the core whenever musb_platform_disable() is called, so clearing it in the glue driver *_musb_disable() is redundant. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_dsps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/mu

[PATCH 5/5] usb: musb: davinci: remove redundant code

2016-12-15 Thread Bin Liu
The session is cleared in the core whenever musb_platform_disable() is called, so clearing it in the glue driver *_musb_disable() is redundant. Signed-off-by: Bin Liu --- drivers/usb/musb/davinci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/d

[PATCH 1/5] usb: musb: remove musb_generic_disable function

2016-12-15 Thread Bin Liu
musb_generic_disable() only has two lines of code. So remove it and let the callers directly call thoese two lines. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/usb/musb/musb_core.

[PATCH 3/5] usb: musb: da8xx: remove redundant code

2016-12-15 Thread Bin Liu
The session is cleared in the core whenever musb_platform_disable() is called, so clearing it in the glue driver *_musb_disable() is redundant. Signed-off-by: Bin Liu --- drivers/usb/musb/da8xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx

[PATCH 4/5] usb: musb: am35x: remove redundant code

2016-12-15 Thread Bin Liu
The session is cleared in the core whenever musb_platform_disable() is called, so clearing it in the glue driver *_musb_disable() is redundant. Signed-off-by: Bin Liu --- drivers/usb/musb/am35x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-15 Thread Alan Stern
On Thu, 15 Dec 2016, Mateusz Berezecki wrote: > > Il giorno 15 dic 2016, alle ore 06:51, Alan Stern > > ha scritto: > > > > Hmmm, this is the third patch labelled v2 that you have mailed. In the > > future, be more careful about your version numbering. > > Ok. Maybe I misunderstood versionin

Re: [PATCH 1/5] usb: musb: remove musb_generic_disable function

2016-12-15 Thread Liu [EP], Bin
> On Dec 15, 2016, at 3:05 PM, Liu [EP], Bin wrote: > > musb_generic_disable() only has two lines of code. So remove it and let > the callers directly call thoese two lines. s/thoese/those/ > > Signed-off-by: Bin Liu > --- > drivers/usb/musb/musb_core.c | 26 ++ > 1 fi

Re: [usb-audio] 4.4.38: Zoom H2n hangs xhci

2016-12-15 Thread Sami Farin
With earlier kernels H2n didn't work when connected to OTHER USB ports than HP's hub, but now it's the other way around. When I connect H2n directly to computer's front panel (USB 3), audio recording works and I don't get any warnings. On Thu, Dec 15, 2016 at 11:11:30 -0800, Greg KH wrote: > On T

Re: [usb-audio] 4.4.38: Zoom H2n hangs xhci

2016-12-15 Thread Sami Farin
On Thu, Dec 15, 2016 at 11:11:30 -0800, Greg KH wrote: > On Thu, Dec 15, 2016 at 08:22:44PM +0200, Sami Farin wrote: > > Sandybridge system on Asus P8Z68-V PRO GEN3 motherboard. > > > > H2n connected to HP ZR24w's hub. When H2n is used as microphone: > > (H2n is now disconnected but it didn't mak

[PATCH] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-15 Thread Peter Rosin
The devm_gpiod_get_optional function does not want the -gpio suffix. The descriptor based APIs handle active high/low automatically. The vbus gpios are output, request enable while getting the gpio. Don't try to get any vbus gpios for ports outside num-ports. WTF? Big sigh. Fixes: 054d4b7b577d ("

Re: [PATCH 0/3] usb: musb: da8xx: Add support of suspend / resume

2016-12-15 Thread Bin Liu
On Mon, Nov 28, 2016 at 05:26:18PM +0100, Alexandre Bailon wrote: > There is no suspend / resume support for da8xx. > Add the PM methods to da8xx glue. > In addition, introduce a new quirk to not clear the devctl register. > Clearing devctl will power off vbus on da8xx platform > (when it is host m

Re: [PATCH 2/3] usb: musb: Add a quirk to preserve MUSB_DEVCTL during suspend

2016-12-15 Thread Bin Liu
On Mon, Nov 28, 2016 at 05:26:20PM +0100, Alexandre Bailon wrote: > On da8xx, VBUS is not maintained during suspend when musb is in host mode. > On resume, all the connected devices will be disconnected and then will > be enumerated again. > This happens because MUSB_DEVCTL is cleared during suspen

Re: [PATCH 3/3] usb: musb: da8xx: Fix host mode suspend

2016-12-15 Thread Bin Liu
On Mon, Nov 28, 2016 at 05:26:21PM +0100, Alexandre Bailon wrote: > On da8xx, VBUS is not maintained during suspend when musb is in host mode. > On resume, all the connected devices will be disconnected and then will > be enumerated again. > This happens because MUSB_DEVCTL is cleared during suspen

Re: [PATCH] usb: musb: fix compilation warning on unused function

2016-12-15 Thread Bin Liu
On Wed, Dec 07, 2016 at 10:58:44PM -0500, Jérémy Lefaure wrote: > The function musb_run_resume_work is called only when CONFIG_PM is > enabled. So this function should not be defined when CONFIG_PM is > disabled. Otherwise the compiler issues a warning: > > drivers/usb/musb/musb_core.c:2057:12: er

Re: [PATCH] usb: musb: debugfs: allow forcing host mode together with speed in testmode

2016-12-15 Thread Bin Liu
On Wed, Dec 14, 2016 at 08:23:45PM +0100, Pali Rohár wrote: > Based on the musb ug, force_host bit is allowed to be set along with > force_hs or force_fs bit. > > It could help to implement forced host mode via testmode on Nokia N900. > > Signed-off-by: Pali Rohár > --- > drivers/usb/musb/musb_

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

2016-12-15 Thread Jerry Huang
> -Original Message- > From: Changming Huang [mailto:jerry.hu...@nxp.com] > Sent: Tuesday, December 13, 2016 5:06 PM > To: ba...@kernel.org; gre...@linuxfoundation.org > Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Jerry Huang > ; Rajesh Bhagat > Subject: [PATCH] USB3/DWC3

RE: dma-coherent and snooping set

2016-12-15 Thread Jerry Huang
Hi, Balbi, > -Original Message- > From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] > Sent: Wednesday, December 14, 2016 7:35 PM > To: Jerry Huang > Cc: linux-usb@vger.kernel.org > Subject: Re: dma-coherent and snooping set > > > Hi, > > Jerry Huang writes: > > hi, Balbi, > > so