On Tue, Dec 06, 2016 at 02:57:00PM +0200, Ozgur Karatas wrote:
> Hello all,
This isn't needed in a changelog text.
> I will solve a checkpatch.pl script errors.
> drivers/usb/class/usbtmc.c:719: ERROR: else should follow close brace '}'
> drivers/usb/class/usbtmc.c:735: ERROR: space required aft
Hello,
> Generally what this series does is just changing the initiator role.
Please note that this series 'adds' new operation.
Current (bind-and attach) operation is kept as it is.
New operation is available if the new daemon is started.
> 1) I would like to see some real numbers of performanc
Hi, Balbi,
Sorry for later responding.
I tested Linux 4.8, 4.7, 4.6 and 4.5, has the same issue:
[0.756166] xhci-hcd: probe of xhci-hcd.0.auto failed with error -5
Then I found one patch (dwc3 initiated xhci probe problem in arm64 4.4 kernel
due to DMA setup) as below link, and I applied this
(no top-posting, please. It's the 2nd time I'm asking)
Hi,
Jerry Huang writes:
> Hi, Balbi,
> Sorry for later responding.
> I tested Linux 4.8, 4.7, 4.6 and 4.5, has the same issue:
> [0.756166] xhci-hcd: probe of xhci-hcd.0.auto failed with error -5
>
> Then I found one patch (dwc3 initiat
On 12/07/2016 01:05 AM, fx IWATA NOBUO wrote:
> Hello,
>
>> how about usbip_meta_driver_set(type)?
>
> Good.
>
> I'd like to confirm the 'type' parameter.
>
> #define USBIP_DRIVER_TYPE_HOST 0
> #define USBIP_DRIVER_TYPE_DEVICE 1
>
> Then usbip_meta_driver_init should not be included.
> It
Hi,
Jerry Huang writes:
>> Jerry Huang writes:
>> > Hi, Balbi,
>> > Sorry for later responding.
>> > I tested Linux 4.8, 4.7, 4.6 and 4.5, has the same issue:
>> > [0.756166] xhci-hcd: probe of xhci-hcd.0.auto failed with error -5
>> >
>> > Then I found one patch (dwc3 initiated xhci probe
On Fri, Dec 02, 2016 at 10:04:39AM -0800, Guenter Roeck wrote:
> At least for my part I very much concentrated on making sure that
> the user space ABI as well as the port driver API are sane and usable.
>
> The driver interface is not my area of expertise. As such, my testing
> and understanding
Hi Alan,
On 12/06/2016 09:21 PM, Alan Stern wrote:
> Krzysztof:
>
> Your patch doesn't address a bug that has been present in
> usb_add_gadget_udc_release() for some time. If the bind callback fails
> with any error other than -EPROBE_DEFER, the driver remains unbound to
> the gadget but it is n
On Fri, 2016-12-02 at 10:04 -0800, Guenter Roeck wrote:
Hi,
> At least for my part I very much concentrated on making sure that
> the user space ABI as well as the port driver API are sane and usable.
Rightly so, as this part cannot be changed once included in a kernel
release.
So, can we agree
On Tue, 6 Dec 2016 22:59:43 +0100
Boris Brezillon wrote:
> desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK is not necessarily
> equal to ep->index and that's perfectly fine. The usba endpoint index is
> just an internal identifier used by the driver to know which registers
> to use for a USB e
Fix variable type for dev_err about usb_bulk_msg()
Signed-off-by: Kim Jae Joong
---
drivers/usb/misc/rio500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/misc/rio500.c b/drivers/usb/misc/rio500.c
index 13731d5..fc329c9 100644
--- a/drivers/usb/misc/rio500.c
++
Hi, Balbi,
> -Original Message-
> From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com]
> Sent: Wednesday, December 07, 2016 5:11 PM
> To: Jerry Huang ; st...@rowland.harvard.edu;
> linux-usb@vger.kernel.org; Mathias Nyman
> ; Arnd Bergmann
> Cc: Sriram Dash ; Greg Kroah-Hartman
>
> Su
On Tue, Dec 6, 2016 at 9:30 PM, Alan Stern wrote:
> [CC: list drastically trimmed]
>
> On Tue, 6 Dec 2016, Andrey Konovalov wrote:
>
>> On Tue, Dec 6, 2016 at 1:28 PM, Andrey Konovalov
>> wrote:
>> > On Mon, Dec 5, 2016 at 8:31 PM, Alan Stern
>> > wrote:
>> >> On Mon, 5 Dec 2016, Andrey Konova
On Tue, Dec 06, 2016 at 09:24:19PM +0100, Giuseppe Lippolis wrote:
> I try to attach the file.
This still wouldn't apply without some manual intervention. Next time,
try sending the patch to yourself first (e.g. using git-send-email) and
make sure you can apply the result with git-am.
> Adding re
Hi,
On 29/11/16 14:28, Roger Quadros wrote:
> Hi,
>
> On 29/11/16 13:51, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Roger Quadros writes:
>>> DCFG.DEVSPD == 0x3 is not valid and we need to set
>>> DCFG.DEVSPD to 0x1 for full speed mode.
>>
>> seems like it has been made invalid somewhere between 1.73a
Instead of using:
if (cond) {
WARN_ON(1);
do_stuff();
}
Use a better pattern with WARN_ON() placed in if condition:
if (WARN_ON(cond))
do_stuff();
Signed-off-by: Atul Raj
---
drivers/usb/chipidea/core.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/driver
Instead of using:
if (cond) {
WARN_ON(1);
do_stuff();
}
Use a better pattern with WARN_ON() placed in if condition:
if (WARN_ON(cond))
do_stuff();
Signed-off-by: Atul Raj
---
drivers/usb/chipidea/ci_hdrc_imx.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a
2016-12-05 14:04 GMT+01:00 Daniele Palmas :
> Hi,
>
> 2016-12-05 11:10 GMT+01:00 Bjørn Mork :
>> Daniele Palmas writes:
>>
>>> I went back to this and further checking revealed that MBIM function
>>> reset is not needed and the only problem is related to commit
>>> 48906f62c96cc2cd35753e59310cb70e
> -Original Message-
> From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com]
> Sent: Wednesday, December 07, 2016 4:41 PM
> To: Jerry Huang ; st...@rowland.harvard.edu;
> linux-usb@vger.kernel.org; Mathias Nyman
> ; Arnd Bergmann
> Cc: Sriram Dash ; Greg Kroah-Hartman
>
> Subject: RE:
Hi,
Felipe Balbi writes:
> hi Mathias,
>
> here's a much longer series of cleanups which I have been working on for
> the past few days. Let me know what you think about it.
>
> I did some light tests SKL and everything still works as before. I know
> you have some reservations about my changes
Hi,
Roger Quadros writes:
>>> Roger Quadros writes:
DCFG.DEVSPD == 0x3 is not valid and we need to set
DCFG.DEVSPD to 0x1 for full speed mode.
>>>
>>> seems like it has been made invalid somewhere between 1.73a and
>>> 2.60a. Can you figure it out from Documentation why and when it wa
Hi,
I just bought a bag of usb-serial converters off of ebay, from china for
super low price (~$2/each). I just plugged a couple of them in,
connected together through a null-modem adapter. When I plug them, on
both stock ubuntu 16.04's kernel and 4.8.9 built from git, I get a
reasonable lookin
Telit LE922A MBIM based composition does not work properly
with altsetting toggle done in cdc_ncm_bind_common.
This patch adds CDC_MBIM_FLAG_AVOID_ALTSETTING_TOGGLE quirk
to avoid this procedure that, instead, is mandatory for
other modems.
Signed-off-by: Daniele Palmas
---
drivers/net/usb/cdc_
Telit LE922A MBIM based composition does not work properly
with altsetting toggle done in cdc_ncm_bind_common.
This patch adds CDC_MBIM_FLAG_AVOID_ALTSETTING_TOGGLE quirk
to avoid this procedure that, instead, is mandatory for
other modems.
References:
https://www.spinics.net/lists/linux-usb/msg1
Hi Oliver,
On Wed, Dec 07, 2016 at 10:46:48AM +0100, Oliver Neukum wrote:
> On Fri, 2016-12-02 at 10:04 -0800, Guenter Roeck wrote:
>
> Hi,
>
> > At least for my part I very much concentrated on making sure that
> > the user space ABI as well as the port driver API are sane and usable.
>
> Righ
On Wed, Dec 07, 2016 at 05:46:09PM +0530, Atul Raj wrote:
> Instead of using:
> if (cond) {
>WARN_ON(1);
>do_stuff();
> }
>
> Use a better pattern with WARN_ON() placed in if condition:
>
> if (WARN_ON(cond))
>do_stuff();
Why? What does this help with?
And why are you sending patch
On Wed, Dec 07, 2016 at 04:42:21AM -0800, Russell Senior wrote:
> I just bought a bag of usb-serial converters off of ebay, from china for
> super low price (~$2/each). I just plugged a couple of them in,
> connected together through a null-modem adapter. When I plug them, on
> both stock ubuntu
Hi,
Jerry Huang writes:
>> Jerry Huang writes:
>> >> Jerry Huang writes:
>> >> > Hi, Balbi,
>> >> > Sorry for later responding.
>> >> > I tested Linux 4.8, 4.7, 4.6 and 4.5, has the same issue:
>> >> > [0.756166] xhci-hcd: probe of xhci-hcd.0.auto failed with error -5
>> >> >
>> >> > Then
Since:
commit 855ed04a3758 ("usb: gadget: udc-core: independent registration
of gadgets and gadget drivers")
if we load gadget module but there is no free udc available
then it will be stored on a pending gadgets list.
$ modprobe g_zero.ko
$ modprobe g_ether.ko
[] udc-core: couldn't find an avai
If we found a matching driver but its bind() function failed for some
reason, let's continue our search as there may be some other gadget
pending on a list which bind() will succeed for this udc.
Reported-by: Alan Stern
Signed-off-by: Krzysztof Opasiak
---
drivers/usb/gadget/udc/core.c | 12 +++
Use list_del_init() instead of list_del() in case
if gadget driver bind() fails to avaid troubles
during usb_gadget_unregister_driver().
Reported-by: Alan Stern
Signed-off-by: Krzysztof Opasiak
---
drivers/usb/gadget/udc/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Daniele Palmas writes:
> Telit LE922A MBIM based composition does not work properly
> with altsetting toggle done in cdc_ncm_bind_common.
>
> This patch adds CDC_MBIM_FLAG_AVOID_ALTSETTING_TOGGLE quirk
> to avoid this procedure that, instead, is mandatory for
> other modems.
>
> Signed-off-by: Da
On 7 Dec 2016 18:56, "Greg KH" wrote:
>
> On Wed, Dec 07, 2016 at 05:46:09PM +0530, Atul Raj wrote:
> > Instead of using:
> > if (cond) {
> >WARN_ON(1);
> >do_stuff();
> > }
> >
> > Use a better pattern with WARN_ON() placed in if condition:
> >
> > if (WARN_ON(cond))
> >do
On 07.12.2016 14:41, Felipe Balbi wrote:
Hi,
Felipe Balbi writes:
hi Mathias,
here's a much longer series of cleanups which I have been working on for
the past few days. Let me know what you think about it.
I did some light tests SKL and everything still works as before. I know
you have som
On Wed, Dec 07, 2016 at 08:12:10PM +0900, Kim Jae Joong wrote:
> Fix variable type for dev_err about usb_bulk_msg()
What was wrong with it before this change? What warning are you
"changing"?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of
On Wed, Dec 07, 2016 at 03:00:29PM +, Atul Raj wrote:
> On 7 Dec 2016 18:56, "Greg KH" wrote:
> >
> > On Wed, Dec 07, 2016 at 05:46:09PM +0530, Atul Raj wrote:
> > > Instead of using:
> > > if (cond) {
> > >WARN_ON(1);
> > >do_stuff();
> > > }
> > >
> > > Use a better pattern
On Wed, 7 Dec 2016, Krzysztof Opasiak wrote:
> If we found a matching driver but its bind() function failed for some
> reason, let's continue our search as there may be some other gadget
> pending on a list which bind() will succeed for this udc.
>
> Reported-by: Alan Stern
> Signed-off-by: Krzy
Since:
commit 855ed04a3758 ("usb: gadget: udc-core: independent registration
of gadgets and gadget drivers")
if we load gadget module but there is no free udc available
then it will be stored on a pending gadgets list.
$ modprobe g_zero.ko
$ modprobe g_ether.ko
[] udc-core: couldn't find an avai
If we found a matching driver but its bind() function failed for some
reason, let's continue our search as there may be some other gadget
pending on a list which bind() will succeed for this udc.
Reported-by: Alan Stern
Signed-off-by: Krzysztof Opasiak
---
Changes since v1:
- break from the loop
Use list_del_init() instead of list_del() in case
if gadget driver bind() fails to avaid troubles
during usb_gadget_unregister_driver().
Reported-by: Alan Stern
Signed-off-by: Krzysztof Opasiak
---
drivers/usb/gadget/udc/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On 12/07/2016 04:31 PM, Alan Stern wrote:
> On Wed, 7 Dec 2016, Krzysztof Opasiak wrote:
>
>> If we found a matching driver but its bind() function failed for some
>> reason, let's continue our search as there may be some other gadget
>> pending on a list which bind() will succeed for this udc.
On Wed, 2016-12-07 at 15:50 +0100, Greg KH wrote:
> On Wed, Dec 07, 2016 at 08:12:10PM +0900, Kim Jae Joong wrote:
> > Fix variable type for dev_err about usb_bulk_msg()
>
> What was wrong with it before this change? What warning are you
> "changing"?
It was subtle. The error message printed a s
On Wed, 7 Dec 2016, Andrey Konovalov wrote:
> > And in any case, is there any way you can post the series of system
> > calls that syzkaller makes so we can tell what went wrong?
>
> I've attached a reproducer for a use-after-free in gadgetfs_setup().
> You need to enable KASAN to see the reports
Dear Johan,
Thanks for the tips.
Here is the patch.
Bye.
---
drivers/usb/serial/option.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 9894e34..386b687 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
On Thu, Nov 24, 2016 at 02:21:42PM +0200, Heikki Krogerus wrote:
> Make a simple helper for matching strings with sysfs
> attribute files. In most parts the same as match_string(),
> except sysfs_match_string() uses sysfs_streq() instead of
> strcmp() for matching. This is more convenient when used
On 12/08/2016 01:54 AM, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> This patch will fix the checkpatch.pl following warnings:
> WARNING: Missing a blank line after declarations
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Manjunath Goudar
On 12/08/2016 12:34 AM, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> Remove usb_disabled() extern declaration as it is already declared
> as extern in include/linux/usb.h.
>
> Signed-off-by: Manjunath Goudar
> Cc: Vladimir Zapolskiy
> Cc: Sylvain Lemieux
> Cc: Alan Stern
> Cc:
> "Johan" == Johan Hovold writes:
>> I attach the tty's with GNU screen (but I have also tried microcom
>> and minicom with the same results). This was my first experience
>> with or even awareness of ch341. I have much more experience with
>> pl2303 and somewhat less with ftdi. With these
Dear Shuah,
I'm afraid there's one thing I have concerned.
I think it's better to move sysfs_attr_init() before
status->attr.attr.name = status->name;
Best Regards,
nobuo.iwata
//
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On
Hi Nobuo.iwata,
I noticed that in many places sysfs_attr_init() is called
before populating the fields such as name etc. However, I
don't think the order matters.
sysfs_attr_init() doesn't depend on name or any other fields
being set:
#define sysfs_attr_init(attr) \
do
On 12/7/2016 4:44 AM, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
Roger Quadros writes:
> DCFG.DEVSPD == 0x3 is not valid and we need to set
> DCFG.DEVSPD to 0x1 for full speed mode.
seems like it has been made invalid somewhere between 1.73a and
2.60a. Can
Somehow starting with v4.9-rc7 there have been imprecise
external aborts on omap5-uevm dwc3 controller. I have not been
able to bisect what exactly triggered this as it does not always
happen. It seems that something changed with probing that
now exposes the issue:
Unhandled fault: imprecise exter
The function musb_run_resume_work is called only when CONFIG_PM is
enabled. So this function should not be defined when CONFIG_PM is
disabled. Otherwise the compiler issues a warning:
drivers/usb/musb/musb_core.c:2057:12: error: ‘musb_run_resume_work’ defined but
not used [-Werror=unused-function]
Dear Shuah,
> I noticed that in many places sysfs_attr_init() is called before populating
> the fields such as name etc. However, I don't think the order matters.
>
> sysfs_attr_init() doesn't depend on name or any other fields being set:
>
> #define sysfs_attr_init(attr)
Hi, Balbi,
> -Original Message-
> From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com]
> Sent: Wednesday, December 07, 2016 9:39 PM
> To: Jerry Huang ; st...@rowland.harvard.edu;
> linux-usb@vger.kernel.org; Mathias Nyman
> ; Arnd Bergmann
> Cc: Sriram Dash ; Greg Kroah-Hartman
>
> Su
* Laurent Pinchart [161123 08:44]:
> Hello,
>
> On Wednesday 23 Nov 2016 18:40:09 Tomi Valkeinen wrote:
> > On 23/11/16 18:34, Tony Lindgren wrote:
> > > OK. And what changes to your current .config make the musb_bus_suspend()
> > > issues show up?
> > >
> > > If it happens with USB-B cable from
Hi Mathias and Felipe,
On 28 November 2016 at 14:43, Baolin Wang wrote:
> Enable the xhci plat runtime PM for parent device to suspend/resume xhci.
> Also call pm_runtime_get_noresume() in probe() function in case the parent
> device doesn't call suspend/resume callback by runtime PM now.
>
> Sig
On Wed, Dec 07, 2016 at 03:54:45PM -0800, Guenter Roeck wrote:
> > +int __sysfs_match_string(const char * const *array, size_t n, const char
> > *str)
> > +{
> > + const char *item;
> > + int index;
> > +
> > + for (index = 0; index < n; index++) {
> > + item = array[index];
> > +
Hi Felipe,
On 28 November 2016 at 14:43, Baolin Wang wrote:
> For some mobile devices with strict power management, we also want to suspend
> the host when the slave is detached for power saving. Thus we add the host
> suspend/resume functions to support this requirement.
>
> Signed-off-by: Baoli
59 matches
Mail list logo
