If a command event is found on the event ring during an interrupt,
we need to stop the command timer with del_timer(). Since del_timer()
can fail if the timer is running and waiting on the xHCI lock, then
it maybe get the wrong timeout command in xhci_handle_command_timeout()
if host fetched a new
On 12/03/2016 07:47 PM, Felix Hädicke wrote:
> Hi,
>
>> On 12/01/2016 10:44 PM, Felix Hädicke wrote:
>>> Hi,
>>>
Hi,
Good catch but I have a few comments to commit message:
On 12/01/2016 12:24 AM, Felix Hädicke wrote:
> This fixes a regression which was introduced by
Hi Mason,
On 12/02/2016 07:00 PM, Mason wrote:
> [ Fix incorrect address for Felipe ]
>
> On 02/12/2016 14:46, Neil Armstrong wrote:
>
>> On 12/02/2016 11:24 AM, Mason wrote:
>>
>>> (Sad face) All the documentation I have is in front of me, and nothing
>>> is ringing a bell. This is a Sigma Desi
Hi,
2016-11-28 12:23 GMT+01:00 Daniele Palmas :
> 2016-11-26 22:17 GMT+01:00 Bjørn Mork :
>> Bjørn Mork writes:
>>
>>> Finally, I found my modems (or at least a number of them) again today.
>>> But I'm sorry to say, that the troublesome Huawei E3372h-153 is still
>>> giving us a hard time. It do
On Sun, 2016-12-04 at 13:10 +0800, Pan Bian wrote:
> From: Pan Bian
>
> Function hid_post_reset() returns 0 on success, or 1 on failures.
It seems like hid_post_reset() is buggy in not returning
a proper error code in the failure case. So your diagnosis
is right, but the fix is at the wrong plac
Hi,
On 12/02/2016 09:39 PM, Mathias Nyman wrote:
> On 02.12.2016 04:29, Lu Baolu wrote:
>> handle_cmd_completion() frees a command structure which might
>> be still referenced by xhci->current_cmd. This might cause
>> problem when xhci->current_cmd is accessed after that.
>>
>> A real-life case co
Vincent Pelletier writes:
> Problem is, I could not reproduce the "Command completion event does not
> match command" error either (which used to happen even on successful
> boots), even without your patch. Checking my syslog, I see it did
> happen with my previous kernel (vanilla 4.6.0).
> Could
On Sat, 2016-12-03 at 10:05 +0100, Greg KH wrote:
> I think these values have grown over the years due to bad devices
> being
> reported. Look at the kernel logs for details. So we can not reduce
> them by default.
>
> That being said, this is a nice change, but I really hate module
> parameters
On Thu, Dec 01, 2016 at 04:38:39PM +0100, Daniele Palmas wrote:
> This patch adds support for PIDs 0x1040, 0x1041 of Telit LE922A.
>
> Since the interface positions are the same than the ones used
> for other Telit compositions, previous defined blacklists are used.
>
> Signed-off-by: Daniele Pal
Hi,
Todd Brandt writes:
> Add a module parameter that replaces the USB_RESUME_TIMEOUT
> and other hardcoded delay numbers with the USB spec minimums.
> By default the patch retains the current values.
>
> The USB subsystem currently uses heavily padded values for TDRSMDN
> and TRSTRCY. This patc
And I tested USB2.0 disk, with Sriram's 6 patches, it works well. So Just
USB3.0 can't work.
BTW,
The board with USB3.0 DWC3 controller and the USB3.0 disk work well with
Linux-4.1.8.
Best Regards
Jerry Huang
-Original Message-
From: Jerry Huang
Sent: Monday, December 05, 2016 6:11
Hi Krzysztof,
On 2016-12-05 11:09, Krzysztof Opasiak wrote:
Since:
commit 855ed04a3758 ("usb: gadget: udc-core: independent registration
of gadgets and gadget drivers")
if we load gadget module but there is no free udc available
then it will be stored on a pending gadgets list.
$ modprobe g_
On Sat, Dec 03, 2016 at 07:47:11PM +0100, Giuseppe Lippolis wrote:
> Dear All,
>
> > If possible you want to tell the option driver which interfaces to
> > bind to (white-listing) rather than specifying which not to bind to
> > (black-listing). The latter typically means probing all interfaces,
(no top-posting, please)
Hi,
it helps if you include maintainers for correct
drivers. scripts/get_maintainer.pl helps a lot.
Jerry Huang writes:
> And I tested USB2.0 disk, with Sriram's 6 patches, it works well. So Just
> USB3.0 can't work.
>
> BTW,
> The board with USB3.0 DWC3 controller a
Function hid_post_reset() should return negative error codes on
failures. However, in its implementation, it incorrectly returns 1.
This patch fixes the bug, returning proper error codes on failures.
Signed-off-by: Pan Bian
---
drivers/hid/usbhid/hid-core.c | 6 +++---
1 file changed, 3 insertio
Daniele Palmas writes:
> I went back to this and further checking revealed that MBIM function
> reset is not needed and the only problem is related to commit
> 48906f62c96cc2cd35753e59310cb70eb08cc6a5 cdc_ncm: toggle altsetting to
> force reset before setup, that, however, is mandatory for some H
On Sat, Dec 3, 2016 at 6:13 PM, Greg Kroah-Hartman
wrote:
> On Sat, Dec 03, 2016 at 05:36:35PM +0100, Andrey Konovalov wrote:
>> Hi!
>>
>> I've got the following error report while running the syzkaller fuzzer.
>>
>> On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2).
>>
>> general protect
On Sat, Dec 3, 2016 at 6:31 PM, Felix Hädicke wrote:
> Hi,
>> Hi!
>>
>> I've got the following error report while running the syzkaller fuzzer.
>>
>> On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2).
>>
>> general protection fault: [#1] SMP KASAN
>> Dumping ftrace buffer:
>>(ftr
On Sat, Dec 3, 2016 at 6:13 PM, Greg Kroah-Hartman
wrote:
> On Sat, Dec 03, 2016 at 05:36:35PM +0100, Andrey Konovalov wrote:
>> Hi!
>>
>> I've got the following error report while running the syzkaller fuzzer.
>>
>> On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2).
>>
>> general protect
Hi!
I've got the following error report while running the syzkaller fuzzer.
On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2).
BUG: KASAN: use-after-free in gadgetfs_setup+0x208a/0x20e0 at addr
88003dfe5bf2
Read of size 2 by task syz-executor0/22994
CPU: 3 PID: 22994 Comm: syz-execu
Hi,
2016-12-05 11:10 GMT+01:00 Bjørn Mork :
> Daniele Palmas writes:
>
>> I went back to this and further checking revealed that MBIM function
>> reset is not needed and the only problem is related to commit
>> 48906f62c96cc2cd35753e59310cb70eb08cc6a5 cdc_ncm: toggle altsetting to
>> force reset
On 05.12.2016 13:00, Felipe Balbi wrote:
(no top-posting, please)
Hi,
it helps if you include maintainers for correct
drivers. scripts/get_maintainer.pl helps a lot.
Jerry Huang writes:
And I tested USB2.0 disk, with Sriram's 6 patches, it works well. So Just
USB3.0 can't work.
BTW,
The b
On 12/05/2016 01:50 PM, Andrey Konovalov wrote:
> On Sat, Dec 3, 2016 at 6:13 PM, Greg Kroah-Hartman
> wrote:
>> On Sat, Dec 03, 2016 at 05:36:35PM +0100, Andrey Konovalov wrote:
>>> Hi!
>>>
>>> I've got the following error report while running the syzkaller fuzzer.
>>>
>>> On commit 3c49de52d56
On 05.12.2016 09:51, Baolin Wang wrote:
When current command was supposed to be aborted, host will free the command
in handle_cmd_completion() function. But it might be still referenced by
xhci->current_cmd, which need to set NULL.
Signed-off-by: Baolin Wang
---
This patch is based on Lu Baolu'
On Sat, Dec 03, 2016 at 03:25:21AM +, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> Remove usb_disabled() extern declaration as it is already declared
> as EXPORT_SYMBOL_GPL declaration in drivers/usb/core/usb.c
The EXPORT_SYMBOL_GPL() has nothing to do with this, it's the fact
On Sat, Dec 03, 2016 at 03:25:23AM +, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> Remove usb_disabled() extern declaration as it is already declared
> as EXPORT_SYMBOL_GPL declaration.
And same thing again...
--
To unsubscribe from this list: send the line "unsubscribe linux-
On Sat, Dec 03, 2016 at 03:25:22AM +, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> Remove usb_disabled() and ocpi_enable() extern declaration
> as it is already declared as EXPORT_SYMBOL_GPL declaration.
Same here, EXPORT_SYMBOL* doesn't matter for stuff like this.
thanks,
gr
On Sat, Dec 03, 2016 at 03:25:23AM +, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> Remove usb_disabled() extern declaration as it is already declared
> as EXPORT_SYMBOL_GPL declaration.
merge this with your first patch please, it belongs with it.
--
To unsubscribe from this lis
Add device-id entry for GW Instek AFG-125, which has a byte swapped
bInterfaceSubClass (0x20).
Signed-off-by: Nathaniel Quillin
---
drivers/usb/class/cdc-acm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index fada988..c5ff13f 100
Hi!
I've got the following error report while running the syzkaller fuzzer.
On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2).
WARNING: CPU: 0 PID: 5257 at drivers/usb/gadget/udc/dummy_hcd.c:672
dummy_free_request+0x153/0x170
Kernel panic - not syncing: panic_on_warn set ...
usb 2-1: s
On Mon, 2016-12-05 at 06:53 -0800, Nathaniel Quillin wrote:
> Add device-id entry for GW Instek AFG-125, which has a byte swapped
> bInterfaceSubClass (0x20).
>
> Signed-off-by: Nathaniel Quillin
Acked-by: Oliver Neukum
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
On 05/12/2016 09:26, Neil Armstrong wrote:
> On 12/02/2016 07:00 PM, Mason wrote:
>
>> On 02/12/2016 14:46, Neil Armstrong wrote:
>>
>>> On 12/02/2016 11:24 AM, Mason wrote:
>>>
(Sad face) All the documentation I have is in front of me, and nothing
is ringing a bell. This is a Sigma Desi
> Signed-off-by: Pan Bian
> ---
> drivers/net/usb/lan78xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index db558b8..f33460c 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -3395,6 +3395,7 @@ s
On Wed, Nov 30, 2016 at 09:45:03AM +0100, Maxime Ripard wrote:
> On Wed, Nov 30, 2016 at 02:57:35PM +0900, Chanwoo Choi wrote:
> > This patch just uses the resource-managed extcon API when registering
> > the extcon notifier.
> >
> > Signed-off-by: Chanwoo Choi
>
> Acked-by: Maxime Ripard
It w
On Fri, Dec 02, 2016 at 03:23:50PM +0100, Alexandre Bailon wrote:
> On 11/29/2016 06:56 PM, Bin Liu wrote:
> > On Tue, Nov 29, 2016 at 06:41:04PM +0100, Alexandre Bailon wrote:
> >> On 11/29/2016 05:16 PM, Bin Liu wrote:
> >>> Hi,
> >>>
> >>> On Mon, Nov 28, 2016 at 05:26:20PM +0100, Alexandre Bail
Hi,
Using kernel 4.4 or more (4.8.11-1 on arch), an USB 3.0 external HDD dies all
the time when writing on it.
Tested on multiple computers, multiples disks, and multiple external disks.
Only works on my 3.10 kernel (CentOS7).
On dmesg I got this :
[ 117.372521] sd 2:0:0:0: [sdb] Synchroniz
From: Alexandre Belloni
> Sent: 02 December 2016 16:19
> On 02/12/2016 at 15:59:57 +, David Laight wrote :
> > From: Alexandre Belloni
> > > Sent: 01 December 2016 10:27
> > > Use devm_kasprintf instead of simple kasprintf to free the allocated
> > > memory
> > > when needed.
> >
> > s/when ne
Hi, Guys,
1. I tested the USB3.0 DWC3 with latest Linux-4.9-rc7 on LS1043ardb board.
But I got the below errors, this error is returned from dma_supported(dev,
mask) while running " dma_set_mask_and_coherent" in function " xhci_plat_probe".
...
[0.756166] xhci-hcd: probe of xhci-hcd.0.auto fai
From: Pan Bian
Date: Sat, 3 Dec 2016 19:24:48 +0800
> In function lan78xx_probe(), variable ret takes the errno code on
> failures. However, when the call to usb_alloc_urb() fails, its value
> will keeps 0. 0 indicates success in the context, which is inconsistent
> with the execution result. Th
On Mon, 5 Dec 2016, Andrey Konovalov wrote:
> Hi!
>
> I've got the following error report while running the syzkaller fuzzer.
>
> On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2).
>
> BUG: KASAN: use-after-free in gadgetfs_setup+0x208a/0x20e0 at addr
> 88003dfe5bf2
> Read of size
vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs
attributes triggering the lock-class key not persistent warning. Call
sysfs_attr_init() for dynamically allocated sysfs attributes to fix it.
vhci_hcd vhci_hcd: USB/IP Virtual Host Controller
vhci_hcd vhci_hcd: new USB bus regist
Hi Andrey,
On 12/05/2016 12:56 PM, Shuah Khan wrote:
> vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs
> attributes triggering the lock-class key not persistent warning. Call
> sysfs_attr_init() for dynamically allocated sysfs attributes to fix it.
>
> vhci_hcd vhci_hcd: USB/
On Wed, Nov 30, 2016 at 11:35:09AM +0530, Raviteja Garimella wrote:
> This patch adds documentation for Synopsis Designware Cores AHB
> Subsystem Device Controller (UDC).
>
> Signed-off-by: Raviteja Garimella
> ---
> .../devicetree/bindings/usb/snps,dw-ahb-udc.txt| 29
>
From: Rafał Miłecki
Calling brightness_set manually isn't safe as some LED drivers don't
implement this callback. The best idea is to just use a proper helper
which will fallback to the brightness_set_blocking callback if needed.
This fixes:
[ 1461.761528] Unable to handle kernel NULL pointer de
On 2016년 12월 06일 01:32, Bin Liu wrote:
> On Wed, Nov 30, 2016 at 09:45:03AM +0100, Maxime Ripard wrote:
>> On Wed, Nov 30, 2016 at 02:57:35PM +0900, Chanwoo Choi wrote:
>>> This patch just uses the resource-managed extcon API when registering
>>> the extcon notifier.
>>>
>>> Signed-off-by: Chanwoo
Hi Kishon,
Could you review and pick the patch1/2 for phy driver?
Best Regards,
Chanwoo Choi
On 2016년 11월 30일 14:57, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_set_cable_state_() -> extcon_set_state_sync()
>
> Signed-off-by: Chanwoo Choi
> ---
Hi Sebastian,
Could you please review and pick the patch3/4 for power-supply driver?
Best Regards,
Chanwoo Choi
On 2016년 11월 30일 14:57, Chanwoo Choi wrote:
> This patch uses the resource-managed extcon API for extcon_register_notifier()
> and replaces the deprecated extcon API as following:
> -
Add the following files to .gitignore
compile
libsrc/libusbip_la-sysfs_utils.lo
libsrc/libusbip_la-usbip_device_driver.lo
libsrc/libusbip_la-usbip_host_common.lo
Signed-off-by: Shuah Khan
---
tools/usb/usbip/.gitignore | 4
1 file changed, 4 insertions(+)
diff --git a/tools/usb/usbip/.git
Hi,
> From: Chanwoo Choi
> Sent: Wednesday, November 30, 2016 2:58 PM
>
> This patch replaces the deprecated extcon API as following:
> - extcon_get_cable_state_() -> extcon_get_state()
>
> Signed-off-by: Chanwoo Choi
Thank you for the patch!
Acked-by: Yoshihiro Shimoda
Best regards,
Yoshih
Hi,
> From: Chanwoo Choi
> Sent: Wednesday, November 30, 2016 2:57 PM
>
> This patch replaces the deprecated extcon API as following:
> - extcon_set_cable_state_() -> extcon_set_state_sync()
>
> Signed-off-by: Chanwoo Choi
Thank you for the patch!
Acked-by: Yoshihiro Shimoda
Best regards,
Y
Hello,
> > usbip_driver_ has widely used as function names and file
> > names for host side abstraction.
> > If they were usbip_host_, I can use usbip_driver_open/close
> > for both host(stub/vudc) and vhci.
>
> usbip_host() is not correct name to use for both stub and vudc as from
> USB point of
Hi,
Do you have any feedback on this?
Thanks,
Thang Q. Nguyen
On Sun, Dec 4, 2016 at 7:42 PM, Thang Q. Nguyen wrote:
> From: Thang Nguyen
>
> As per USB 2.0 link power management addendum ECN, table 1-2, page 4,
> device or host initiated via resume signaling; device-initiated resumes
> can be
On Tue, Dec 06, 2016 at 01:59:00PM +0700, Thang Q. Nguyen wrote:
> Hi,
> Do you have any feedback on this?
>
> Thanks,
> Thang Q. Nguyen
>
> On Sun, Dec 4, 2016 at 7:42 PM, Thang Q. Nguyen wrote:
It has been 1 day, please relax, wait, and be patient. If after 2 weeks
there has not been a respo
On Mon, Dec 05, 2016 at 10:18:58PM +, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> This patch will fix the checkpatch.pl warnings and errors.
what warnings and errors? Please always be specific.
And don't send a single patch to fix everything up, break it up into
logical type
On Mon, Dec 05, 2016 at 10:18:58PM +, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> This patch will fix the checkpatch.pl warnings and errors.
>
> Signed-off-by: Manjunath Goudar
> Cc: Alan Stern
> Cc: Greg Kroah-Hartman
> Cc: linux-usb@vger.kernel.org
> Cc: linux-ker...@vger
Andrey Konovalov reported that we were not properly checking the upper
limit before of a device configuration size before calling
memdup_user(), which could cause some problems.
So set the upper limit to PAGE_SIZE * 4, which should be good enough for
all devices.
Reported-by: Andrey Konovalov
Cc
56 matches
Mail list logo
