Re: Writing a Brand New Driver

2016-11-19 Thread Greg KH
On Fri, Nov 18, 2016 at 02:13:03PM -0500, Brian Chrzanowski wrote: > Hi linux-usb, > > Quite simply, I would like to get into kernel development. I figured that I > could jumpstart this by writing a driver for this device: > > http://www.gamestop.com/wii-u/accessories/wii-u-gamecube-adapter/1154

Re: [PATCH v2 1/5] cdc-acm: reindent log messages

2016-11-19 Thread Greg KH
On Fri, Nov 18, 2016 at 11:14:03AM +0100, Oliver Neukum wrote: > On Thu, 2016-11-17 at 23:56 +0100, Ladislav Michl wrote: > > Use only one tab to indent dev_{(v)dbg,err} parameters. > > > > Signed-off-by: Ladislav Michl > Acked-by: Oliver Neukum > For all of these, or just this one? -- To unsu

Re: [PATCH v2 1/5] cdc-acm: reindent log messages

2016-11-19 Thread Oliver Neukum
On Sat, 2016-11-19 at 17:06 +0100, Greg KH wrote: > On Fri, Nov 18, 2016 at 11:14:03AM +0100, Oliver Neukum wrote: > > On Thu, 2016-11-17 at 23:56 +0100, Ladislav Michl wrote: > > > Use only one tab to indent dev_{(v)dbg,err} parameters. > > > > > > Signed-off-by: Ladislav Michl > > Acked-by: Oli

[PATCH 0/3] usb: xhci: Add broken port disable quirk

2016-11-19 Thread Roger Quadros
Hi, Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. If the attached high-speed device is misbehaving, the USB stack typically disables the port using the PED bit in PORTSC. For the controllers that have broken port disable, the port fails to detect further attach/detach even

Re: [v5,1/5] USB: ohci: da8xx: use ohci priv data instead of globals

2016-11-19 Thread David Lechner
On 11/14/2016 08:40 AM, ahas...@baylibre.com wrote: Instead of global variables, use the extra_priv_size of the ohci driver. We cannot yet move the ocic mask because this is used on the interrupt handler which is registerded through platform data and does not have an hcd pointer. This will be mo

Re: [v5,3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-19 Thread David Lechner
On 11/14/2016 08:41 AM, ahas...@baylibre.com wrote: Using a regulator to handle VBUS will eliminate the need for platform data and callbacks, and make the driver more generic allowing different types of regulators to handle VBUS. The regulator equivalents to the platform callbacks are: set_p

Re: [v5,3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-19 Thread David Lechner
On 11/19/2016 09:31 PM, David Lechner wrote: On 11/14/2016 08:41 AM, ahas...@baylibre.com wrote: +ocic_mask |= 1; I thought that a previous patch got rid of all globals. Why is ocic_mask still a global variable? I suppose if I read the commit message, I will know the answer ;-) -- T