Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread Felipe Balbi
Hi, Peter Chen writes: > On Tue, Nov 01, 2016 at 01:29:59PM +0200, Felipe Balbi wrote: >> According to Dave Miller "the networking stack has a >> hard requirement that all SKBs which are transmitted >> must have their completion signalled in a fininte >> amount of time. This is because, until th

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread Peter Chen
On Wed, Nov 02, 2016 at 09:55:44AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > On Tue, Nov 01, 2016 at 01:29:59PM +0200, Felipe Balbi wrote: > >> According to Dave Miller "the networking stack has a > >> hard requirement that all SKBs which are transmitted > >> must have their

Re: [PATCH v2 3/6] usb: ehci: fsl: use bus->sysdev for DMA configuration

2016-11-02 Thread kbuild test robot
ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Sriram-Dash/inherit-dma-configuration-from-parent-dev/20161102-141353 base: https://git.kernel.org/pub/

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread Felipe Balbi
Hi, Peter Chen writes: >> >> diff --git a/drivers/usb/gadget/function/u_ether.c >> >> b/drivers/usb/gadget/function/u_ether.c >> >> index f4a640216913..119a2e5848e8 100644 >> >> --- a/drivers/usb/gadget/function/u_ether.c >> >> +++ b/drivers/usb/gadget/function/u_ether.c >> >> @@ -589,14 +589,6

Re: [PATCH V11 1/1] usb:serial: Add Fintek F81532/534 driver

2016-11-02 Thread Johan Hovold
On Fri, Oct 14, 2016 at 04:20:46PM +0800, Ji-Ze Hong (Peter Hong) wrote: > This driver is for Fintek F81532/F81534 USB to Serial Ports IC. > > F81532 spec: > https://drive.google.com/file/d/0B8vRwwYO7aMFOTRRMmhWQVNvajQ/view?usp= > sharing > > F81534 spec: > https://drive.google.com/file/d/0B8vRww

[PATCH 3/3] usb: ohci-da8xx: rename driver to ohci-da8xx

2016-11-02 Thread Axel Haslam
To be consistent on the usb driver for the davinci platform follow the example of musb, and add the "-da8xx" postfix to the driver name. Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-da8xx.c

[PATCH 0/3] fix ohci phy name

2016-11-02 Thread Axel Haslam
The usb ohci clock match is not working because the usb clock is registered as "ohci" instead of "ohci.0" But since there is only a single ohci instance, lets pass -1 to the platform data id parameter and avoid the extra ".0" matching. while we are fixing this, rename the driver to "ohci-da8xx" t

[PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

2016-11-02 Thread Axel Haslam
There is only one ohci on the da8xx series of chips, so remove the ".0" when creating the phy. Also add the "-da8xx" postfix to be consistent across davinci usb drivers. Signed-off-by: Axel Haslam --- drivers/phy/phy-da8xx-usb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --

[PATCH 1/3] ARM: davinci: da8xx: Fix ohci driver name

2016-11-02 Thread Axel Haslam
There is a single instance of the ohci driver, while the clk lookup table is making reference to "ohci" other subsystems (such as phy) are looking for "ohci.0" Since there is a single ohci instance, change the dev id to -1, and add the "-da8xx" for consitancy with the musb driver name. Signed-off

[PATCH v3] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-02 Thread Yoshihiro Shimoda
This patch adds sysfs "role" for usb role swap. This parameter can be read and write. If you use this file as the following, you can swap the usb role. For example: 1) Connect a usb cable using 2 Salvator-x boards 2) On A-Device (ID pin is low), you input the following command: # echo periphe

[PATCH] cdc-acm: fix uninitialized variable

2016-11-02 Thread Oliver Neukum
variable struct usb_cdc_parsed_header h may be used uninitialized in acm_probe. In kernel 4.8. /* handle quirks deadly to normal probing*/ if (quirks == NO_UNION_NORMAL) ... goto skip_normal_probe; } we bypass call to cdc_parse_cdc_header(&h, intf, buffer, bufl

Re: Bug in cdc-acm: variable struct usb_cdc_parsed_header h may be used uninitialized in acm_probe.

2016-11-02 Thread Oliver Neukum
On Sat, 2016-10-29 at 15:48 +0300, Victor Sologoubov wrote: > Bug in cdc-acm: variable struct usb_cdc_parsed_header h may be used > uninitialized in acm_probe. Hi, good catch. Apatch with credits to you has been submitted. Regards Oliver -- To unsubscribe from this list

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread David Miller
From: Peter Chen Date: Wed, 2 Nov 2016 14:02:02 +0800 > Felipe, it may increase cpu utilization since more interrupts will be there, > it may affect the SoC which has lower cpu frequency. This code existed > many years, why this problem has only reported at dwc3 recently? It's a bug, and it's go

[PATCH] USB hub_probe: refactor ugly goto-into-compound-statement

2016-11-02 Thread Eugene Korenevsky
Rework smelling code (goto inside compound statement). Perhaps this is legacy. Anyway such code is not appropriate for Linux kernel. --- drivers/usb/core/hub.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/

Ich werde auf Ihre Antwort warten

2016-11-02 Thread Andrew Chung
Lieber Freund, Wie geht es Ihnen heute? Ich habe eine Investitionsmöglichkeit mit Ihnen zu teilen, die die Übertragung einer großen Geldsumme zum gegenseitigen Nutzen für beide von uns betreffen. Mein Name ist Andrew Hau Chung, ich in einem Finanzinstitut arbeiten hier in Hong Kong. Wenn Sie

[PATCH v2] USB hub_probe: remove ugly goto-into-compound-statement

2016-11-02 Thread Eugene Korenevsky
Rework smelling code (goto inside compound statement). Perhaps this is legacy. Anyway such code is not appropriate for Linux kernel. Signed-off-by: Eugene Korenevsky --- drivers/usb/core/hub.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/

Re: [RFC/PATCH 27/45] usb: musb: make use of new usb_endpoint_maxp_mult()

2016-11-02 Thread Bin Liu
On Tue, Nov 01, 2016 at 12:55:18PM +0200, Felipe Balbi wrote: > > Hi, > > Bin Liu writes: > > On Wed, Sep 28, 2016 at 04:05:36PM +0300, Felipe Balbi wrote: > >> We have introduced a helper to calculate multiplier > >> value from wMaxPacketSize. Start using it. > >> > >> Cc: Bin Liu > >> Signed

Re: [PATCH 00/82] usb: patch bomb

2016-11-02 Thread Bin Liu
On Tue, Nov 01, 2016 at 10:17:37AM +0200, Felipe Balbi wrote: > > Hi, > > Bin Liu writes: > > Hi Felipe, > > > > On Mon, Oct 31, 2016 at 12:47:52PM +0200, Felipe Balbi wrote: > >> Hi guys, > >> > >> Sorry for the patch bomb, but I wanted to make sure everyoby knows which > >> patches are alread

Re: [PATCH 1/3] ARM: davinci: da8xx: Fix ohci driver name

2016-11-02 Thread David Lechner
On 11/02/2016 07:44 AM, Axel Haslam wrote: There is a single instance of the ohci driver, while the clk lookup table is making reference to "ohci" other subsystems (such as phy) are looking for "ohci.0" This patch changes the "device" name, not the "driver" name. You use "driver" above and in

Re: [PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

2016-11-02 Thread David Lechner
On 11/02/2016 07:44 AM, Axel Haslam wrote: There is only one ohci on the da8xx series of chips, so remove the ".0" when creating the phy. Also add the "-da8xx" postfix to be consistent across davinci usb drivers. It would be more accurate to say that the device name is being changed in the mac

Re: [PATCH 3/3] usb: ohci-da8xx: rename driver to ohci-da8xx

2016-11-02 Thread David Lechner
On 11/02/2016 07:44 AM, Axel Haslam wrote: To be consistent on the usb driver for the davinci platform follow the example of musb, and add the "-da8xx" postfix to the driver name. It is probably worth mentioning that the existing driver name is "ohci" which is a bit too generic. -- To unsub

Re: [PATCH] usb: musb: da8xx: Don't print phy error on -EPROBE_DEFER

2016-11-02 Thread Ladislav Michl
Hi, On Tue, Oct 25, 2016 at 02:02:50PM -0500, David Lechner wrote: > This suppresses printing the error message "failed to get phy" in the > kernel log when the error is -EPROBE_DEFER. This prevents usless noise > in the kernel log. > > Signed-off-by: David Lechner > --- > drivers/usb/musb/da8x

RE: [PATCH v2 3/6] usb: ehci: fsl: use bus->sysdev for DMA configuration

2016-11-02 Thread Sriram Dash
>From: Sriram Dash [mailto:sriram.d...@nxp.com] >From: Arnd Bergmann > >For the dual role ehci fsl driver, sysdev will handle the dma config. > >Signed-off-by: Arnd Bergmann >Signed-off-by: Sriram Dash >--- >Changes in v2: > - fix compile warnings > > > drivers/usb/host/ehci-fsl.c | 4 ++-- > 1

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread Peter Chen
On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > From: Peter Chen > Date: Wed, 2 Nov 2016 14:02:02 +0800 > > > Felipe, it may increase cpu utilization since more interrupts will be there, > > it may affect the SoC which has lower cpu frequency. This code existed > > many years, why

STRICTLY CONFIDENTIAL

2016-11-02 Thread Acct. Dept.
I have important transaction for you as next of kin to claim US$18.37m Mail me on my private email: chimwia...@gmail.com so I can send you more details Thanks Mr.Chim Wai Kim ==MOVE TO INBOX=== DISCLAIMER: This email and any

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread Peter Chen
On Wed, Nov 02, 2016 at 01:02:59PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > >> >> diff --git a/drivers/usb/gadget/function/u_ether.c > >> >> b/drivers/usb/gadget/function/u_ether.c > >> >> index f4a640216913..119a2e5848e8 100644 > >> >> --- a/drivers/usb/gadget/function/u_eth

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-02 Thread NeilBrown
On Tue, Nov 01 2016, Baolin Wang wrote: >> So I won't be responding on this topic any further until I see a genuine >> attempt to understand and resolve the inconsistencies with >> usb_register_notifier(). > > Any better solution? I'm not sure exactly what you are asking, so I'll assume you are

[PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

2016-11-02 Thread Lu Baolu
cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is not used any more. This patch removes it. Signed-off-by: Lu Baolu --- drivers/usb/host/xhci-mem.c | 1 - drivers/usb/host/xhci.h | 1 - 2 files changed, 2 dele