Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.

2016-09-29 Thread Greg KH
On Thu, Sep 29, 2016 at 02:16:44PM +0530, Manish Narani wrote: > This patch adds support to configure bulk maxburst through > module parameter. This parameter can be used to modify bulk > maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT > performance. Eeek, this isn't the 1990's, ple

Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.

2016-09-29 Thread Krzysztof Opasiak
On 09/29/2016 10:46 AM, Manish Narani wrote: > This patch adds support to configure bulk maxburst through > module parameter. This parameter can be used to modify bulk > maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT > performance. > If you would like such option to f_sourcesink

Re: [RFC/PATCH 14/45] media: usb: uvc: make use of new usb_endpoint_maxp_mult()

2016-09-29 Thread Laurent Pinchart
Hi Felipe, Thanks for the patch. On Wednesday 28 Sep 2016 16:05:23 Felipe Balbi wrote: > We have introduced a helper to calculate multiplier > value from wMaxPacketSize. Start using it. > > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: > Signed-off-by: Felipe Balbi > --- > drivers/

Re: [RFC/PATCH 30/45] media: usb: uvc: remove unnecessary & operation

2016-09-29 Thread Laurent Pinchart
Hi Felipe, Thank you for the patch. On Wednesday 28 Sep 2016 16:05:39 Felipe Balbi wrote: > Now that usb_endpoint_maxp() only returns the lowest > 11 bits from wMaxPacketSize, we can remove the & > operation from this driver. > > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: > Signed

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-29 Thread Laurent Pinchart
Hi Tony, On Wednesday 28 Sep 2016 11:42:35 Tony Lindgren wrote: > * Tony Lindgren [160920 11:37]: > > * Tony Lindgren [160920 10:11]: > >> * Laurent Pinchart [160919 23:36]: > >>> No, I perform the following steps: > >>> > >>> - Connect the panda board to the USB through USB (which powers the

Re: [RFC/PATCH 14/45] media: usb: uvc: make use of new usb_endpoint_maxp_mult()

2016-09-29 Thread Felipe Balbi
Hi, Laurent Pinchart writes: > Hi Felipe, > > Thanks for the patch. > > On Wednesday 28 Sep 2016 16:05:23 Felipe Balbi wrote: >> We have introduced a helper to calculate multiplier >> value from wMaxPacketSize. Start using it. >> >> Cc: Laurent Pinchart >> Cc: Mauro Carvalho Chehab >> Cc: >>

Re: [PATCH 2/2] usb: dwc3: gadget: set PCM1 field of isochronous-first TRBs

2016-09-29 Thread Felipe Balbi
Hi, yfw writes: > On 2016/9/26 16:12, Felipe Balbi wrote: >> In case of High-Speed, High-Bandwidth endpoints, we >> need to tell DWC3 that we have more than one packet >> per interval. We do that by setting PCM1 field of >> Isochronous-First TRB. >> >> Signed-off-by: Felipe Balbi >> --- >> dri

RE: [LINUX PATCH] usb: gadget: Configure data verification through module parameter in gadget zero

2016-09-29 Thread Peter Chen
> >This patch adds support to configure data verification through module >parameter. >This parameter can be used to disable data verification in case if one wants to >measure peak Bulk/Isoc-IN/OUT performance > Would configfs parameter 'pattern' can't satisfy you? Peter >Signed-off-by: Manish

[PATCH v2] usb: ohci-at91: Use descriptor-based gpio APIs

2016-09-29 Thread Wenyou Yang
Use the descriptor-based interface to manipulate GPIOs, instead of the legacy integer-based interface. Signed-off-by: Wenyou Yang --- Changes in v2: - Retain the vbus_pin_active_low[] member and its manipulations. drivers/usb/host/ohci-at91.c | 121 +++

[PATCH v1] usb: ohci-at91: Set RemoteWakeupConnected bit explicitly.

2016-09-29 Thread Wenyou Yang
The reset value of RWC is 0, set RemoteWakeupConnected bit explicitly before calling ohci_run, it also fixes the issue that the mass storage stick connected wasn't suspended when the system suspend. Signed-off-by: Wenyou Yang --- drivers/usb/host/ohci-at91.c | 9 ++--- 1 file changed, 6 ins

Re: [PATCH] mos7840: fix chars_in_buffer() return value

2016-09-29 Thread Johan Hovold
On Sat, Sep 24, 2016 at 06:00:57PM +0300, Stas Sergeev wrote: > The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on > a correct behaviour of that. > mos7840 implements it wrongly: if you write just one char, TIOCOUTQ > will return 32. > This patch should fix it by accounting the num

[LINUX PATCH] usb: gadget: Configure data verification through module parameter in gadget zero

2016-09-29 Thread Manish Narani
This patch adds support to configure data verification through module parameter. This parameter can be used to disable data verification in case if one wants to measure peak Bulk/Isoc-IN/OUT performance Signed-off-by: Manish Narani --- drivers/usb/gadget/function/f_sourcesink.c | 6 -- drive

Re: [PATCH 2/2] usb: dwc3: gadget: set PCM1 field of isochronous-first TRBs

2016-09-29 Thread yfw
Hi Felipe, On 2016/9/29 17:48, Felipe Balbi wrote: Hi, yfw writes: On 2016/9/26 16:12, Felipe Balbi wrote: In case of High-Speed, High-Bandwidth endpoints, we need to tell DWC3 that we have more than one packet per interval. We do that by setting PCM1 field of Isochronous-First TRB. Signed

Re: [PATCH 1/2] usb: add helper to extract bits 12:11 of wMaxPacketSize

2016-09-29 Thread yfw
Hi Bin, On 2016/9/29 3:48, Bin Liu wrote: On Wed, Sep 28, 2016 at 09:51:32AM -0500, Bin Liu wrote: On Wed, Sep 28, 2016 at 05:15:59PM +0300, Felipe Balbi wrote: Hi, Bin Liu writes: uvc_video set the each request size (you could check function uvc_video_alloc_requests()) for uvc: r

[LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.

2016-09-29 Thread Manish Narani
This patch adds support to configure bulk maxburst through module parameter. This parameter can be used to modify bulk maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT performance. Signed-off-by: Manish Narani --- drivers/usb/gadget/function/f_sourcesink.c | 14 ++ dr

Re: [LINUX PATCH] usb: gadget: Configure data verification through module parameter in gadget zero

2016-09-29 Thread Greg KH
On Thu, Sep 29, 2016 at 02:18:54PM +0530, Manish Narani wrote: > This patch adds support to configure data verification through > module parameter. This parameter can be used to disable data > verification in case if one wants to measure peak Bulk/Isoc-IN/OUT > performance > > Signed-off-by: Manis

[PATCH stable-4.4] USB: serial: cp210x: fix hardware flow-control disable

2016-09-29 Thread Johan Hovold
From: Konstantin Shkolnyy commit a377f9e906af4df9071ba8ddba60188cb4013d93 upstream A bug in the CRTSCTS handling caused RTS to alternate between CRTSCTS=0 => "RTS is transmit active signal" and CRTSCTS=1 => "RTS is used for receive flow control" instead of CRTSCTS=0 => "RTS is statically acti

Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.

2016-09-29 Thread Felipe Balbi
Hi, Greg KH writes: > On Thu, Sep 29, 2016 at 02:16:44PM +0530, Manish Narani wrote: >> This patch adds support to configure bulk maxburst through >> module parameter. This parameter can be used to modify bulk >> maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT >> performance. > >

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-29 Thread Mathias Nyman
On 28.09.2016 22:08, Pierre de Villemereuil wrote: Hi! When entering "cat /sys/bus/pci/devices/\:00\:14.0/power/runtime_status", I got: - on battery: suspended - on AC: active Ok thanks, So current guess is that xhci-hcd driver suspend was called, it stopped the xhci controller, and expec

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-29 Thread Wim Osterholt
On Wed, Sep 28, 2016 at 05:23:30PM +0200, Oliver Neukum wrote: > > > > HP src # sync > > HP src # [ 3744.914184] BUG: unable to handle kernel NULL pointer > > dereference at 0249 > > The last view lines before that please with the debugging level ramped > up to 9 please. Recompiled again, d

Re: [RFC/PATCH 24/45] usb: host: ehci: make use of new usb_endpoint_maxp_mult()

2016-09-29 Thread Alan Stern
On Wed, 28 Sep 2016, Felipe Balbi wrote: > We have introduced a helper to calculate multiplier > value from wMaxPacketSize. Start using it. > > Cc: Alan Stern > Cc: > Signed-off-by: Felipe Balbi > --- > drivers/usb/host/ehci-sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)

2016-09-29 Thread Guenter Roeck
On Thu, Sep 29, 2016 at 7:35 AM, Jun Li wrote: > Hi Guenter, > >> -Original Message- >> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- >> ow...@vger.kernel.org] On Behalf Of Guenter Roeck >> Sent: Wednesday, August 24, 2016 5:11 AM >> To: Felipe Balbi >> Cc: Chandra Sekhar Anaga

RE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)

2016-09-29 Thread Jun Li
Hi Guenter, > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Guenter Roeck > Sent: Wednesday, August 24, 2016 5:11 AM > To: Felipe Balbi > Cc: Chandra Sekhar Anagani ; Bruce > Ashfield ; Bin Gao ; > Pranav Tipnis ; Heikk

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-29 Thread Pierre de Villemereuil
Hi Mathias, It seems you are right: entering echo on > /sys/bus/pci/devices/\:00\:14.0/power/control does tame USB to behave properly. However, every time the AC is plugged/unplugged, this value gets overridden. Any way to make this permanent? (I realise this would harm a tiny bit of my b

Re: [PATCH] mos7840: fix chars_in_buffer() return value

2016-09-29 Thread Stas Sergeev
29.09.2016 13:09, Johan Hovold пишет: On Sat, Sep 24, 2016 at 06:00:57PM +0300, Stas Sergeev wrote: The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch shou

Re: BUG: scheduling while atomic in f_fs when gadget remove driver

2016-09-29 Thread Chen Yu
Hi Michal, Thanks for the patch. 在 2016/9/29 5:38, Michal Nazarewicz 写道: > On Wed, Sep 28 2016, Michal Nazarewicz wrote: >> With that done, the only thing which needs a mutex is >> epfile->read_buffer. > > Perhaps this would do: > I tested the patch on Hikey board with adb function on android,

[PATCH v11 6/9] usbip: exporting devices: modifications to attach and detach

2016-09-29 Thread Nobuo Iwata
Refactoring to attach and detatch operation. Common parts to new application(vhci)-side daemon are moved to libsrc/vhci_driver.c. Signed-off-by: Nobuo Iwata --- tools/usb/usbip/libsrc/vhci_driver.c | 99 tools/usb/usbip/libsrc/vhci_driver.h | 6 +- tools/usb/usbip

[PATCH v11 3/9] usbip: exporting devices: new connect operation

2016-09-29 Thread Nobuo Iwata
New connect operation. Signed-off-by: Nobuo Iwata --- tools/usb/usbip/src/Makefile.am | 3 +- tools/usb/usbip/src/usbip.c | 9 +- tools/usb/usbip/src/usbip.h | 5 +- tools/usb/usbip/src/usbip_connect.c | 228 4 files changed, 242 insertions(

[PATCH v11 1/9] usbip: exporting devices: modifications to network header

2016-09-29 Thread Nobuo Iwata
Modification to export and un-export response in tools/usb/usbip/src/usbip_network.h. It just changes return code type from int to uint32_t as same as other responses. Added export and un-export request/response to Documentation/usb/usbip_protocol.txt. Signed-off-by: Nobuo Iwata --- Document

Re: [PATCH v3 2/2] usb: dwc3: Wait for control tranfer completed when stopping gadget

2016-09-29 Thread Baolin Wang
Hi Felipe, On 19 September 2016 at 19:52, Baolin Wang wrote: > When we change the USB function with configfs dynamically, we possibly met > this > situation: one core is doing the control transfer, another core is trying to > unregister the USB gadget from userspace, we must wait for completing

[PATCH v11 4/9] usbip: exporting devices: new disconnect operation

2016-09-29 Thread Nobuo Iwata
New disconnect operation. Signed-off-by: Nobuo Iwata --- tools/usb/usbip/src/Makefile.am| 2 +- tools/usb/usbip/src/usbip.c| 6 + tools/usb/usbip/src/usbip.h| 2 + tools/usb/usbip/src/usbip_disconnect.c | 215 + 4 files changed, 224 i

[PATCH v6 2/2] usbip: vhci extension: dynamic extension

2016-09-29 Thread Nobuo Iwata
Modification for dynamic device registration and unregistration. 1. kernel config Followings are added. USBIP_VHCI_HC_PORTS: Number of ports per USB/IP virtual host controller. The default is 8 - same as current VHCI_NPORTS. USBIP_VHCI_MAX_HCS: Muximum number of USB/IP virtual host controllers.

[PATCH v11 9/9] usbip: exporting devices: chage to documenattion

2016-09-29 Thread Nobuo Iwata
This patch adds function and usage of new connect operation, disconnect operation and application(vhci)-side daemon to README and manuals. At this point, the wording, 'server' and 'client' are ambiguous in several place. For existing attach command, the daemon runs device side machine and atta

[PATCH v11 2/9] usbip: exporting devices: modifications to host side libraries

2016-09-29 Thread Nobuo Iwata
usbip_get_device() method in usbip_host_driver_ops was not used. It is modified as a function to find an exported device for new operations 'connect' and 'disconnect'. bind and unbind function are exported for the new operations. Signed-off-by: Nobuo Iwata --- tools/usb/usbip/libsrc/usbip_hos

[PATCH v1 1/1] usbip: deletion of incorrect socket descriptor checking

2016-09-29 Thread Nobuo Iwata
This patch removes checking of socket descriptor value in daemons. It was checked to be less than FD_SETSIZE(1024 usually) but it's not correct. To be exact, the maximum value of descriptor comes from rlimit(RLIMIT_NOFILE). Following kernel code determines the value : get_unused_fd_flags()

[PATCH v6 0/2] usbip: vhci number of ports extension

2016-09-29 Thread Nobuo Iwata
This series of patches extends number of ports limitaion in application (vhci) side. 1. Background Assuming a system shown below that services distributerd devices in home or office via USB/IP, if the devices are set at every doors and windows, number devices may be up to tens. Home/SOHO/Ente

[PATCH v11 8/9] usbip: exporting devices: change to usbip_list.c

2016-09-29 Thread Nobuo Iwata
Correction to wording inconsistency around import and export in usbip_list.c. Please, see also cover letter about wording. Signed-off-by: Nobuo Iwata --- tools/usb/usbip/src/usbip_list.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/tools/usb/usbi

[PATCH v11 0/9] usbip: exporting devices

2016-09-29 Thread Nobuo Iwata
Dear all, This series of patches adds exporting device operation to USB/IP. 1. Overview Exporting devices may not be a new idea. The request and response PDU have been defined in tools/usbip/usbip/src/usbip_network.h. #define OP_EXPORT 0x06 #define OP_REQ_EXPORT (OP_REQUEST | OP_EXPORT)

[PATCH v11 7/9] usbip: exporting devices: new application-side daemon

2016-09-29 Thread Nobuo Iwata
New application(vhci)-side daemon. Signed-off-by: Nobuo Iwata --- tools/usb/usbip/libsrc/vhci_driver.c | 19 +++ tools/usb/usbip/libsrc/vhci_driver.h | 1 + tools/usb/usbip/src/Makefile.am | 7 +- tools/usb/usbip/src/usbipd.c | 12 +- tools/usb/usbip/src/usbipd_app.c | 242

[PATCH v11 5/9] usbip: exporting devices: modifications to daemon

2016-09-29 Thread Nobuo Iwata
Refactoring to the daemon. usbipd_dev.c is device-side specific code extracted from usbipd.c. usbipd.c is left as common parts for both device(stub)-side and application(vhci)-side daemon. usbip_net_set_nodelay() is the middle of device side daemon operation and it does not make mush sence. In

[PATCH v6 1/2] usbip: vhci extension: modifications to userspace

2016-09-29 Thread Nobuo Iwata
Modification to the userspace tools including usbip/libsrc and usbip/src. Changed corresponding to new vhci_sysfs.c. nports in sysfs is used to get total number of ports. Old get_nports() ignores the last status line because udev_device_get_sysattr_value() drops last new line. New version use

RE: ARM juno R2 board USB Issue (EHCI probe failed)

2016-09-29 Thread Sajjan, Vikas C
Hi Sudeep, -Original Message- From: Sudeep Holla [mailto:sudeep.ho...@arm.com] Sent: Tuesday, September 27, 2016 2:38 PM To: Sajjan, Vikas C ; Vikas Sajjan ; linux-usb@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-a...@vger.kernel.org Cc: Sudeep Holla ; mark.rutl...@arm.c

RE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)

2016-09-29 Thread Jun Li
Hi Guenter, > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Guenter Roeck > Sent: Wednesday, August 24, 2016 5:11 AM > To: Felipe Balbi > Cc: Chandra Sekhar Anagani ; Bruce > Ashfield ; Bin Gao ; > Pranav Tipnis ; Heikki