Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Hi, Arnd Bergmann writes: > On Thursday, September 8, 2016 2:00:13 PM CEST Felipe Balbi wrote: >> Arnd Bergmann writes: >> > On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: >> >> Arnd Bergmann writes: >> >> > That sounds a bit clumsy for the sake of consistency with PCI. >>

[PATCH] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

When we change the USB function with configfs dynamically, we possibly met this situation: one core is doing the control transfer, another core is trying to unregister the USB gadget from userspace, we must wait for completing this control tranfer, or it will hang the controller to set the DEVCTRLH

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 2:20:58 PM CEST Felipe Balbi wrote: > >> It's quite a hack, though. I still think that inheriting DMA (or > >> manually initializing a child with parent's DMA bits and pieces) is the > >> best way to go. So we're back to of_dma_configure() and > >> acpi_dma_configure(

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Hi, Arnd Bergmann writes: >> >> But this needs to be done before dwc3_probe() executes. For dwc3-pci >> >> that's easy, but for DT devices, seems like it should be in of >> >> core. Below is, clearly, not enough but should show the idea: >> >> >> >> diff --git a/drivers/of/device.c b/drivers/of

Re: [PATCH] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

Hi, Baolin Wang writes: > When we change the USB function with configfs dynamically, we possibly met > this > situation: one core is doing the control transfer, another core is trying to > unregister the USB gadget from userspace, we must wait for completing this > control tranfer, or it will h

crash by cdc_acm driver in kernels 4.8-rc1/5

L.S. up to vanilla kernel 4.7.3 I've seen no problems. On two different dekstops running vanilla kernel-4.8 I can force a crash by inserting an USB-modem that requires module cdc_acm.ko . (Strangely enough that doesn't happen on my laptop.) The moment that cdc_acm loads (manually or automatically

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On 09/08/2016 02:00 PM, Felipe Balbi wrote: > > Hi, > > Arnd Bergmann writes: >> On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: >>> Arnd Bergmann writes: On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote: >> If we do that, we have to put child devi

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 3:02:56 PM CEST Grygorii Strashko wrote: > dwc3: probe() > if (!&pdev->dev->of_node) > legacy case - hard-code DMA props > dwc->sysdev = &pdev->dev; The PCI case will fall into this too, as we almost never have an ->of_node po

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

On Thu, 2016-09-08 at 13:58 +0200, Wim Osterholt wrote: > L.S. > > up to vanilla kernel 4.7.3 I've seen no problems. > On two different dekstops running vanilla kernel-4.8 I can force a > crash by > inserting an USB-modem that requires module cdc_acm.ko . > (Strangely enough that doesn't happen on

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thu, Sep 08, 2016 at 12:17:21PM +0200, Arnd Bergmann wrote: > On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: > > Arnd Bergmann writes: > > > On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote: > > >> > If we do that, we have to put child devices of the dwc3

[PATCH 3/3] usb: chipidea: udc: Use the preferred form for passing a size of a struct

From: Fabio Estevam According to Documentation/CodingStyle: "The preferred form for passing a size of a struct is the following: p = kmalloc(sizeof(*p), ...); " , so do as suggested to improve readability. Signed-off-by: Fabio Estevam --- drivers/usb/chipidea/udc.c | 2 +- 1 file cha

[PATCH 2/3] usb: chipidea: udc: Fit into a single line

From: Fabio Estevam No need to split the dma_pool_zalloc() line into two as it can perfectly fit into a single line. Signed-off-by: Fabio Estevam --- drivers/usb/chipidea/udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipid

[PATCH 1/3] usb: chipidea: udc: Use dma_pool_zalloc()

From: Fabio Estevam We can make the code simpler by using dma_pool_zalloc() instead of calling dma_pool_zalloc() and then a memset(). Signed-off-by: Fabio Estevam --- drivers/usb/chipidea/udc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/chipidea/udc.c

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 2:52:46 PM CEST Felipe Balbi wrote: > Arnd Bergmann writes: > >> If we make dwc3.ko a library which glue calls directly then all these > >> problems are solved but we break all current DTs and fall into the trap > >> of having another MUSB. > > > > I don't see how we

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 8:28:10 PM CEST Peter Chen wrote: > On Thu, Sep 08, 2016 at 12:17:21PM +0200, Arnd Bergmann wrote: > > On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: > > > Arnd Bergmann writes: > > > > On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

On Thu, Sep 08, 2016 at 02:20:38PM +0200, Oliver Neukum wrote: > > > > The oops tells things that I didn't all write down, but it says > > null pointer dereference at 0246 > > That is the important part. I am sorry, but without the oops > nobody can help you. Please capture it Sep 6 19:12:3

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On 09/08/2016 03:28 PM, Peter Chen wrote: > On Thu, Sep 08, 2016 at 12:17:21PM +0200, Arnd Bergmann wrote: >> On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: >>> Arnd Bergmann writes: On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote: >> If we do that,

RE: [PATCH net-next 0/3] r8152: configuration setting

Bjørn Mork [mailto:bj...@mork.no] > Sent: Thursday, September 08, 2016 3:55 PM [...] > Yes, I see that. But is that strictly necessary? Couldn't you just say: > "CDC ECM is supported by cdc_ether and therefore limited to the features > implemented by cdc_ether. If you want feature X, then please

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

On Thu, 2016-09-08 at 14:58 +0200, Wim Osterholt wrote: > On Thu, Sep 08, 2016 at 02:20:38PM +0200, Oliver Neukum wrote: > > > > > > The oops tells things that I didn't all write down, but it says > > > null pointer dereference at 0246 > > > > That is the important part. I am sorry, but witho

Re: [PATCH net-next 0/3] r8152: configuration setting

On Thu, 2016-09-08 at 13:02 +, Hayes Wang wrote: > I tested above method before. And I found that the cdc_ether > was loaded before switching the configuration. The behavior > of loading one driver and changing to another driver has > opportunity to let our some previous chips become abnorma

Re: [PATCH net-next 0/3] r8152: configuration setting

Hayes Wang writes: > Bjørn Mork [mailto:bj...@mork.no] >> Sent: Thursday, September 08, 2016 3:55 PM > [...] >> Yes, I see that. But is that strictly necessary? Couldn't you just say: >> "CDC ECM is supported by cdc_ether and therefore limited to the features >> implemented by cdc_ether. If you

Re: unusual_devs addition for Kingston DT100G3/32GB 0951:1666

David Laight wrote on 07/09/16 18:25: > I'd expect files much smaller than 500MB to fail if the problem was > actually to do with a 64 sector limit. > > So I'm guessing that this isn't the fix. > > Much more likely is that limiting the sector count to 64 stops transfers > crossing some sector bou

RE: unusual_devs addition for Kingston DT100G3/32GB 0951:1666

From: Wolfgang Breyha [mailto:wbre...@gmx.net] > Sent: 08 September 2016 14:27 > David Laight wrote on 07/09/16 18:25: > > I'd expect files much smaller than 500MB to fail if the problem was > > actually to do with a 64 sector limit. > > > > So I'm guessing that this isn't the fix. > > > > Much mor

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

On 07.09.2016 17:53, Alan Stern wrote: On Wed, 7 Sep 2016, Mathias Nyman wrote: I'm still seeing occasional problems. For example, when I unplugged the dock last night, it seems to have wedged some things, and then plugging it back in didn't work. See some logs below. I ran a show-blocked-t

[PATCH 1/4] phy: Add reset callback

The only use for this is for solving a hardware design problem in usb of Rockchip RK3288. Signed-off-by: Randy Li --- drivers/phy/phy-core.c | 14 ++ include/linux/phy/phy.h | 3 +++ 2 files changed, 17 insertions(+) diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c ind

[PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full system suspend but also a wakeup from autosuspend). We can get the PHY out of its bad state by asserting its "port reset", but unfortun

[PATCH 0/4] the fix for the USB HOST1 at rk3288 platform

At this stage it is the only "full features" and well verified USB EHCI controller in this platform. More review is always necessary. Changelog: - v7: adding a wrapper for the reset operation for phy using that wrapper - v6: move pwms pinctrl to pwms node fix the order of the

[PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup

It is a hardware bug in RK3288, the only way to solve it is to reset the phy. Signed-off-by: Randy Li --- .../devicetree/bindings/phy/rockchip-usb-phy.txt | 3 +++ drivers/phy/phy-rockchip-usb.c | 20 2 files changed, 23 insertions(+) diff --git a

[PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset

The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. We'll use the reset that's in the CRU to reset the port when it's in a bad state. Note that we add the reset to both dwc2 controllers ev

Re: [PATCH 1/3] usb: gadgetfs: introduce feature control mechanism

On Thu, 8 Sep 2016, Felipe Balbi wrote: > >> >> > +struct usb_gadgetfs_features { > >> >> > + uint64_t bitmap[4]; > >> >> > >> >> this should really be: > >> >> > >> >> uint64_t features0; > >> >> > >> >> /* Keep 24 bytes reserved for possible future usage */ > >> >>

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

On Thu, 8 Sep 2016, Mathias Nyman wrote: > > ehci-hcd includes checks in several places for ehci->rh_state == > > RH_STATE_RUNNING. The removal pathway sets ehci->rh_state to > > RH_STATE_HALTED. As a result, the driver avoids waiting for things > > that will never happen. > > > > Yes, seems th

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

On Thu, Sep 08, 2016 at 03:05:15PM +0200, Oliver Neukum wrote: > > Sep 6 19:12:38 localhost kernel: Call Trace: > > Sep 6 19:12:38 localhost kernel: [] ? 0xc01f4347 > > Hi, > > your stack trace is broken. Did you fail to install the System.map file? Never needed that for anything the last 20

Re: [PATCH 1/4] phy: Add reset callback

Am Donnerstag, 8. September 2016, 22:27:13 CEST schrieb Randy Li: > The only use for this is for solving a hardware design problem in > usb of Rockchip RK3288. > > Signed-off-by: Randy Li to me this looks good. Although Kishon suggested earlier to have the init callback do the reset and simply

Re: unusual_devs addition for Kingston DT100G3/32GB 0951:1666

David Laight wrote on 08/09/16 15:30: > Try with raw writes to the disk, rather than going through the filesystem. > That will remove effects caused by the alignment of the filesystem and the > size of the filesystem blocks. Ok, I did dd if=768MB.test of=/dev/sdb oflag=direct bs=1M dd if=/dev/sdb

RE: unusual_devs addition for Kingston DT100G3/32GB 0951:1666

From: Wolfgang Breyha > Sent: 08 September 2016 16:32 > David Laight wrote on 08/09/16 15:30: > > Try with raw writes to the disk, rather than going through the filesystem. > > That will remove effects caused by the alignment of the filesystem and the > > size of the filesystem blocks. > > Ok, I d

Re: TCPCI driver issue

On Thu, Sep 8, 2016 at 3:29 AM, Heikki Krogerus wrote: > Hi Steve, > > On Wed, Sep 07, 2016 at 10:00:28PM -0400, Steve Schefter wrote: >> Hi Heikki. >> >> I'm seeing an issue with the USB-C TCPCI driver. On startup, I get a panic >> with the following error and stack dump. >> >> Unable to handle

[PATCH V5] leds: trigger: Introduce a USB port trigger

From: Rafał Miłecki This commit adds a new trigger responsible for turning on LED when USB device gets connected to the selected USB port. This can can useful for various home routers that have USB port(s) and a proper LED telling user a device is connected. The trigger gets its documentation fi

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

On Thu, Sep 08, 2016 at 03:05:15PM +0200, Oliver Neukum wrote: > > Sep 6 19:12:38 localhost kernel: Call Trace: > > Sep 6 19:12:38 localhost kernel: [] ? 0xc01f4347 > > Hi, > > your stack trace is broken. Did you fail to install the System.map file? Source is available under /usr/src/linux --

Re: TCPCI driver issue

Hi Guenter. I think (hope) I did mention that the tcpci patch was compile tested only. Apologies if not. I'll try to get to it today and send a fix, though it will obviously only be a workaround (config data is platform specific). I also hope I can send a Reviewed-by: for Heikki's series today.

Re: [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

On 9/8/2016 7:27 AM, Randy Li wrote: > On the rk3288 USB host-only port (the one that's not the OTG-enabled > port) the PHY can get into a bad state when a wakeup is asserted (not > just a wakeup from full system suspend but also a wakeup from > autosuspend). > > We can get the PHY out of its bad

Re: [PATCH 1/3] usb: gadgetfs: introduce feature control mechanism

> On 8 Sep 2016, at 17:34, Alan Stern wrote: > > On Thu, 8 Sep 2016, Felipe Balbi wrote: > >>> +struct usb_gadgetfs_features { >>> + uint64_t bitmap[4]; >> >> this should really be: >> >> uint64_t features0; >> >>/* Keep 24 bytes reserved for poss

Re: [PATCH 1/3] usb: gadgetfs: introduce feature control mechanism

On Thu, 8 Sep 2016, Binyamin Sharet (bsharet) wrote: > > I was thinking more like: > > > > struct usb_gadgetfs_ioctl_arg { > > uint16_t length; > > uint8_t reserved[2]; > > > > uint8_t data[0]; > > } > > > > but the principle is pretty much the same. > > > > Alan Stern > > > > Wo

Re: TCPCI driver issue

Hi Steve, On Thu, Sep 8, 2016 at 9:32 AM, Steve Schefter wrote: > Hi Guenter. > >> I think (hope) I did mention that the tcpci patch was compile tested >> only. Apologies if not. I'll try to get to it today and send a fix, >> though it will obviously only be a workaround (config data is platform

Re: [PATCH 1/7] clk: gxbb: expose USB clocks

Stephen Boyd writes: > On 09/04, Martin Blumenstingl wrote: >> USB0_DDR_BRIDGE and USB1_DDR_BRIDGE1 are needed for the related >> dwc2 usb controller. USB, USB0 and USB1 are needed for the PHYs. >> Expose these clocks to DT and comment out in clk driver. >> >> Signed-off-by: Jerome Brunet >> Si

Re: TCPCI driver issue

On Thu, Sep 8, 2016 at 12:21 PM, Guenter Roeck wrote: > Hi Steve, > > On Thu, Sep 8, 2016 at 9:32 AM, Steve Schefter wrote: >> Hi Guenter. >> >>> I think (hope) I did mention that the tcpci patch was compile tested >>> only. Apologies if not. I'll try to get to it today and send a fix, >>> though

Re: [PATCH 1/3] usb: gadgetfs: introduce feature control mechanism

> On 8 Sep 2016, at 22:20, Alan Stern wrote: > > On Thu, 8 Sep 2016, Binyamin Sharet (bsharet) wrote: > >>> I was thinking more like: >>> >>> struct usb_gadgetfs_ioctl_arg { >>> uint16_t length; >>> uint8_t reserved[2]; >>> >>> uint8_t data[0]; >>> } >>> >>> but the principle is

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

On 08/09/16 20:35, Kevin Hilman wrote: Martin Blumenstingl writes: This is a new driver for the USB PHY found in Meson8b and GXBB SoCs. Signed-off-by: Martin Blumenstingl Signed-off-by: Jerome Brunet I tested this on meson-gxbb-p200 with USB host and a mass storage device. Tested-by: Kev

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman wrote: >> + phy = devm_phy_create(&pdev->dev, NULL, &phy_meson_usb2_ops); >> + if (IS_ERR(phy)) { >> + dev_err(&pdev->dev, "failed to create PHY\n"); >> + return PTR_ERR(phy); >> + } >> + >> + if (usb_reset_refcnt

Re: TCPCI driver issue

On Thu, Sep 8, 2016 at 12:35 PM, Guenter Roeck wrote: > On Thu, Sep 8, 2016 at 12:21 PM, Guenter Roeck wrote: >> Hi Steve, >> >> On Thu, Sep 8, 2016 at 9:32 AM, Steve Schefter wrote: >>> Hi Guenter. >>> I think (hope) I did mention that the tcpci patch was compile tested only. Apologie

Re: TCPCI driver issue

Hi Steve, On Thu, Sep 8, 2016 at 12:42 PM, Steve Schefter wrote: > Hi Guenter. > >>> I would be interested in seeing the test driver, either on the list or >>> privately if you are not comfortable with a general release. >>> >> Please try to clone >> https://chromium.googlesource.com/chromiumos/t

Re: [PATCHv8 1/2] usb: USB Type-C connector class

On Thu, Sep 01, 2016 at 02:49:47PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port s

[PATCH] usb: gadget: remove variable ret and remove unnecessary if statement

From: Colin Ian King the if statement in lb_modinit is unnecessary so we can totally remove the variable ret and just return the return value from the call to usb_function_register. Signed-off-by: Colin Ian King --- drivers/usb/gadget/function/f_loopback.c | 8 ++-- 1 file changed, 2 inser

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

On 08/09/16 20:52, Martin Blumenstingl wrote: On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman wrote: + phy = devm_phy_create(&pdev->dev, NULL, &phy_meson_usb2_ops); + if (IS_ERR(phy)) { + dev_err(&pdev->dev, "failed to create PHY\n"); + return PTR_ERR(phy); + }

Re: [PATCH 1/3] usb: gadgetfs: introduce feature control mechanism

On Thu, 8 Sep 2016, Binyamin Sharet (bsharet) wrote: > > > On 8 Sep 2016, at 22:20, Alan Stern wrote: > > > > On Thu, 8 Sep 2016, Binyamin Sharet (bsharet) wrote: > > > >>> I was thinking more like: > >>> > >>> struct usb_gadgetfs_ioctl_arg { > >>> uint16_t length; > >>> uint8_t reserved[

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

Ben Dooks writes: > On 08/09/16 20:52, Martin Blumenstingl wrote: >> On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman wrote: + phy = devm_phy_create(&pdev->dev, NULL, &phy_meson_usb2_ops); + if (IS_ERR(phy)) { + dev_err(&pdev->dev, "failed to create PHY\n"); +

Re: TCPCI driver issue

Hi Guenter. I would be interested in seeing the test driver, either on the list or privately if you are not comfortable with a general release. Please try to clone https://chromium.googlesource.com/chromiumos/third_party/kernel and fetch refs/sandbox/groeck/typec-4.4-cros-090816 (sha a3fb79db5

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

On 08/09/16 21:42, Kevin Hilman wrote: Ben Dooks writes: On 08/09/16 20:52, Martin Blumenstingl wrote: On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman wrote: + phy = devm_phy_create(&pdev->dev, NULL, &phy_meson_usb2_ops); + if (IS_ERR(phy)) { + dev_err(&pdev->dev, "failed t

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

On Thu, Sep 8, 2016 at 10:53 PM, Ben Dooks wrote: > On 08/09/16 21:42, Kevin Hilman wrote: >> >> Ben Dooks writes: >> >>> On 08/09/16 20:52, Martin Blumenstingl wrote: On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman wrote: >> >> + phy = devm_phy_create(&pdev->dev, NULL, &

Re: unusual_devs addition for Kingston DT100G3/32GB 0951:1666

On 08/09/16 17:47, David Laight wrote: > Try writing with: > dd if=768MB.test of=/dev/sdb oflag=direct bs=1M seek_bytes seek=$((n*512)) > for several small values of 'n' so that the writes are misaligned. > > It may also be worth finding out what the USB transfers look like. I was wrong when I wr

Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Thu, Sep 08 2016, Baolin Wang wrote: > On 8 September 2016 at 15:31, NeilBrown wrote: >> On Thu, Sep 08 2016, Baolin Wang wrote: >>> >>> Now the usb charger will not get charger type from 'extcon' subsystem, >>> we get the charger type from 'power_supply' and calllback >>> 'get_charger_type' f

Re: [PATCH v4 00/22] Support qcom's HSIC USB and rewrite USB2 HS support

On Thu, Sep 08, 2016 at 02:13:28PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-07 19:06:45) > > On Thu, Sep 8, 2016 at 5:34 AM, Stephen Boyd > > wrote: > > > The state of USB ChipIdea support on Qualcomm's platforms is not great. > > > The DT description of these devices requires up

Re: [uas] ORICO 2588US3 USB HDD enclosure goes offline after idle

On 06.09.2016 12:56, Oliver Neukum wrote: Could you apply the attached patch, Thanks, will do as soon as I have a chance to reboot. enable SCSI logging (with scsi_logging_level) and retest? What command line invocation should I use? Or what logging level, at least? -- To unsubscribe from t

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thu, Sep 08, 2016 at 02:52:29PM +0200, Arnd Bergmann wrote: > On Thursday, September 8, 2016 8:28:10 PM CEST Peter Chen wrote: > > On Thu, Sep 08, 2016 at 12:17:21PM +0200, Arnd Bergmann wrote: > > > On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: > > > > Arnd Bergmann write

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thu, Sep 08, 2016 at 03:59:19PM +0300, Grygorii Strashko wrote: > On 09/08/2016 03:28 PM, Peter Chen wrote: > > On Thu, Sep 08, 2016 at 12:17:21PM +0200, Arnd Bergmann wrote: > >> On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: > >>> Arnd Bergmann writes: > On Thursday,

Re: [PATCH] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

Hi Felipe, On 8 September 2016 at 20:00, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> When we change the USB function with configfs dynamically, we possibly met >> this >> situation: one core is doing the control transfer, another core is trying to >> unregister the USB gadget from us

[PATCH v3 1/1] usb: xhci: fix return value of xhci_setup_device()

xhci_setup_device() should return failure with correct error number when xhci host has died, removed or halted. During usb device enumeration, if usb host is not accessible (died, removed or halted), the hc_driver->address_device() should return a corresponding error code to usb core. But current

[PATCH v2 1/1] usb: dwc3: fix Clear Stall EP command failure

Commit 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command") sets ClearPendIN bit for all IN endpoints of v2.60a+ cores. This causes ClearStall command fails on 2.60+ cores operating in HighSpeed mode. In page 539 of 2.60a specification: "When issuing Clear Stall command

Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On 9 September 2016 at 07:13, NeilBrown wrote: > On Thu, Sep 08 2016, Baolin Wang wrote: > >> On 8 September 2016 at 15:31, NeilBrown wrote: >>> On Thu, Sep 08 2016, Baolin Wang wrote: Now the usb charger will not get charger type from 'extcon' subsystem, we get the charger type fr

Re: [PATCH v2 1/1] usb: xhci: fix return value of xhci_setup_device()

Hi Greg, On 09/08/2016 02:38 PM, Greg KH wrote: > On Thu, Sep 08, 2016 at 08:41:02AM +0800, Lu Baolu wrote: >> xhci_setup_device() should return failure with correct error number >> when xhci host has died, removed or halted. >> >> Cc: sta...@vger.kernel.org # 4.3+ > Why is this a stable kernel is

Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Thu, Sep 08 2016, Baolin Wang wrote: > Hi Neil, > > On 6 September 2016 at 13:40, NeilBrown wrote: >> On Mon, Aug 29 2016, Baolin Wang wrote: >> >>> Hi Felipe, >>> >>> On 11 August 2016 at 11:14, Baolin Wang wrote: Hi Felipe, On 1 August 2016 at 15:09, Baolin Wang wrote: >

Re: [PATCH] usb: dwc3: OCTEON: add support for device tree

Hi Steven, "Steven J. Hill" writes: > This patch adds support to parse probe data for > the dwc3-octeon driver using device tree. The > DWC3 IP core is found on OCTEON III processors. > > Signed-off-by: Steven J. Hill > --- > drivers/usb/dwc3/Kconfig | 10 + > drivers/usb/dwc3/Makefi

Re: [PATCH net-next 0/3] r8152: configuration setting

Hayes Wang writes: > Bjørn Mork [mailto:bj...@mork.no] >> Sent: Wednesday, September 07, 2016 9:51 PM > [...] >> So this adds a lot of code to work around the issues you introduced by >> unnecessarily blacklisting the CDC ECM configuration earlier, and still >> makes the r8152 driver handle the d

ULPI phy issue with

Hi, I have an imx53 based boards with an ULPI phy (smsc 3315) connected to usbh2 and usbh3 and encounter problem with patch "usb: chipidea: coordinate usb phy initialization for different phy type". In drivers/usb/chipidea/core.c:ci_usb_phy_init, if I call hw_phymode_configure() before usb_ph

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Hi, Arnd Bergmann writes: >> Arnd Bergmann writes: >> >> [...] >> >> > Regarding the DMA configuration that you mention in ci_hdrc_add_device(), >> > I think we should replace >> > >> > pdev->dev.dma_mask = dev->dma_mask; >> > pdev->dev.dma_parms = dev->dma_parms; >> >

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 9:15:36 AM CEST Peter Chen wrote: > > > > Right, I was specifically talking about the code in chipidea here, > > which I think is never used on the PCI bus, and how the current > > code is broken. We can probably do better than of_dma_configure() > > (see below), but

Re: [PATCH 1/1] usb: dwc3: avoid setting ClearPendIn for Intel Cherry Trail devices

Hi Felipe, On 09/07/2016 11:05 AM, Lu Baolu wrote: > Commit 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear > Stall EP command") causes Clear Stall EP command failure on Intel > Cherry Trail devices. This patch add a quirk to avoid setting this > bit for those Intel devices. > > Cc: st

Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On 8 September 2016 at 15:31, NeilBrown wrote: > On Thu, Sep 08 2016, Baolin Wang wrote: > >> Hi Neil, >> >> On 6 September 2016 at 13:40, NeilBrown wrote: >>> On Mon, Aug 29 2016, Baolin Wang wrote: >>> Hi Felipe, On 11 August 2016 at 11:14, Baolin Wang wrote: > Hi Felipe, >>

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 11:03:10 AM CEST Felipe Balbi wrote: > Arnd Bergmann writes: > >> Arnd Bergmann writes: > just look at the history of the file, you'll see that an Intel employee > was a maintainer of chipidea driver. Also: > > $ git ls-files drivers/usb/chipidea/ | grep pci > driv

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Hi, Arnd Bergmann writes: >> > @@ -178,7 +179,7 @@ static void dwc3_frame_length_adjustment(struct dwc3 >> > *dwc) >> > static void dwc3_free_one_event_buffer(struct dwc3 *dwc, >> >struct dwc3_event_buffer *evt) >> > { >> > - dma_free_coherent(dwc->dev, evt->length, evt->buf, evt

Re: [PATCH 1/1] usb: dwc3: avoid setting ClearPendIn for Intel Cherry Trail devices

Hi Baolu, Lu Baolu writes: > Hi Felipe, > > On 09/07/2016 11:05 AM, Lu Baolu wrote: >> Commit 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear >> Stall EP command") causes Clear Stall EP command failure on Intel >> Cherry Trail devices. This patch add a quirk to avoid setting this >>

[PATCH 1/1] usb: dwc3: fix Clear Stall EP command failure

Commit 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command") sets ClearPendIN bit for all IN endpoints in v2.60a+ cores no matter which speed mode they're in. This causes Clear Stall EP command failing on some Intel devices. In page 539 of 2.60a specification, it says: "W

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote: > > If we do that, we have to put child devices of the dwc3 devices into > > the platform glue, and it also breaks those dwc3 devices that don't > > have a parent driver. > > Well, this is easy to fix: > > if (dwc->dev->p

Re: [PATCH v2 1/1] usb: xhci: fix return value of xhci_setup_device()

On Thu, Sep 08, 2016 at 03:29:25PM +0800, Lu Baolu wrote: > Hi Greg, > > On 09/08/2016 02:38 PM, Greg KH wrote: > > On Thu, Sep 08, 2016 at 08:41:02AM +0800, Lu Baolu wrote: > >> xhci_setup_device() should return failure with correct error number > >> when xhci host has died, removed or halted. >

Re: [PATCH v2 1/1] usb: xhci: fix return value of xhci_setup_device()

Hi Greg, On 09/08/2016 04:58 PM, Greg KH wrote: > On Thu, Sep 08, 2016 at 03:29:25PM +0800, Lu Baolu wrote: >> Hi Greg, >> >> On 09/08/2016 02:38 PM, Greg KH wrote: >>> On Thu, Sep 08, 2016 at 08:41:02AM +0800, Lu Baolu wrote: xhci_setup_device() should return failure with correct error numbe

[PATCH v1 1/1] usb: gadget: f_fs: Stop ffs_closed NULL pointers.

From: Jim Baxter The struct ffs_data::private_data has a pointer to ffs_dev stored in it during the ffs_fs_mount() function however it is not cleared when the ffs_dev is freed later which causes the ffs_closed function to crash with "Unable to handle kernel NULL pointer dereference" error when us

[PATCH v1 0/1] usb: gadget: f_fs: Stop ffs_closed NULL pointers

This patchset fixes the crash in ffs_closed during a disconnect of a USB composite FFS session. The issue was caused by the use of an outdated pointer in ffs_closed which had been deleted and not Nulled. Note: Testing has only been done on an ARM i.MX6 based platform. Jim Baxter (1): usb: ga

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Hi, Arnd Bergmann writes: > On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote: >> > If we do that, we have to put child devices of the dwc3 devices into >> > the platform glue, and it also breaks those dwc3 devices that don't >> > have a parent driver. >> >> Well, this is easy

Re: [PATCH 1/1] usb: dwc3: fix Clear Stall EP command failure

Hi Felipe, On 09/08/2016 04:41 PM, Lu Baolu wrote: > Commit 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear > Stall EP command") sets ClearPendIN bit for all IN endpoints in > v2.60a+ cores no matter which speed mode they're in. This causes > Clear Stall EP command failing on some Inte

Re: [PATCH 1/1] usb: dwc3: fix Clear Stall EP command failure

Hi, Lu Baolu writes: > Commit 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear > Stall EP command") sets ClearPendIN bit for all IN endpoints in > v2.60a+ cores no matter which speed mode they're in. This causes > Clear Stall EP command failing on some Intel devices. Well, the fact t

*** MICROSOFT FINAL WARNING ***

Outlook A few of your incoming mails were placed on pending status due to the recent upgrade on our database. In order to receive your messages, click on the link below to login and wait for response from Webmail. CLICK HERE We apologise for any inconve

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: > Arnd Bergmann writes: > > On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote: > >> > If we do that, we have to put child devices of the dwc3 devices into > >> > the platform glue, and it also breaks those dwc3 de

Re: TCPCI driver issue

Hi Steve, On Wed, Sep 07, 2016 at 10:00:28PM -0400, Steve Schefter wrote: > Hi Heikki. > > I'm seeing an issue with the USB-C TCPCI driver. On startup, I get a panic > with the following error and stack dump. > > Unable to handle kernel NULL pointer dereference at virtual address 002c > >

Re: [PATCH] scsi: introduce a quirk for false cache reporting

On Thu, 2016-08-18 at 22:19 -0400, Martin K. Petersen wrote: > > "Oliver" == Oliver Neukum writes: > > Oliver> Some SATA to USB bridges fail to cooperate with some drives > Oliver> resulting in no cache being present being reported to the > Oliver> host. That causes the host to skip sending a

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Hi, Arnd Bergmann writes: > On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: >> Arnd Bergmann writes: >> > On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote: >> >> > If we do that, we have to put child devices of the dwc3 devices into >> >> > the platform glu

Re: [PATCH 1/1] usb: dwc3: fix Clear Stall EP command failure

Hi, Lu Baolu writes: >> Commit 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear >> Stall EP command") sets ClearPendIN bit for all IN endpoints in >> v2.60a+ cores no matter which speed mode they're in. This causes >> Clear Stall EP command failing on some Intel devices. >> >> In page

Re: [PATCH 1/3] usb: gadgetfs: introduce feature control mechanism

Hi, Alan Stern writes: >> Alan Stern writes: >> > On Wed, 7 Sep 2016, Felipe Balbi wrote: >> > >> >> > --- a/include/uapi/linux/usb/gadgetfs.h >> >> > +++ b/include/uapi/linux/usb/gadgetfs.h >> >> > @@ -85,4 +85,33 @@ struct usb_gadgetfs_event { >> >> > */ >> >> > #defineGADGETFS_CLEAR_H

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 2:00:13 PM CEST Felipe Balbi wrote: > Arnd Bergmann writes: > > On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: > >> Arnd Bergmann writes: > >> > That sounds a bit clumsy for the sake of consistency with PCI. > >> > The advantage is that xhci can