Hi Arnd,
On 02/09/16 18:51, Arnd Bergmann wrote:
> On Friday, September 2, 2016 10:21:23 AM CEST Alan Stern wrote:
>> On Fri, 2 Sep 2016, Felipe Balbi wrote:
>>
>>> Hi,
>>>
>>> Russell King - ARM Linux writes:
On Fri, Sep 02, 2016 at 12:43:39PM +0200, Arnd Bergmann wrote:
> On Thursday,
Hi Stefan,
On 06/09/16 21:01, Stefan Agner wrote:
> On 2016-09-06 01:22, Mark Brown wrote:
>> On Tue, Sep 06, 2016 at 10:45:19AM +0300, Felipe Balbi wrote:
>>> Stefan Agner writes:
>>
According to the device tree bindings the vcc-supply is optional.
>>
>> This is nonsense unless the device c
On Tue, Sep 06, 2016 at 03:27:43PM +0200, Arnd Bergmann wrote:
> On Tuesday, September 6, 2016 1:50:48 PM CEST Felipe Balbi wrote:
> > Hi,
> >
> > Arnd Bergmann writes:
> > > On Tuesday, September 6, 2016 9:40:19 AM CEST Felipe Balbi wrote:
> > >>
> > >> this only solves the problem for DT devic
Hi Mathias,
On 09/07/2016 02:51 PM, Mathias Nyman wrote:
> On 07.09.2016 09:22, Lu Baolu wrote:
>> From: "Lu, Baolu"
>>
>> xhci_setup_device() should return failure with correct error number
>> when xhci host has died, removed or halted.
>>
>
> Thanks, will add.
> Might go to 4.9 as 4.8-rc5 is al
Hi,
Roger Quadros writes:
Stefan Agner writes:
>>>
> According to the device tree bindings the vcc-supply is optional.
>>>
>>> This is nonsense unless the device can work without this supply. Given
>>> that the supply is called VCC that doesn't seem entirely likely.
>>
>> Afaik it is
On 07.09.2016 10:54, Lu Baolu wrote:
Hi Mathias,
On 09/07/2016 02:51 PM, Mathias Nyman wrote:
On 07.09.2016 09:22, Lu Baolu wrote:
From: "Lu, Baolu"
xhci_setup_device() should return failure with correct error number
when xhci host has died, removed or halted.
Thanks, will add.
Might go t
If CONFIG_USB_NET_CDCETHER is enabled, support ECM mode through cdc_ether
driver.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 255 ++--
1 file changed, 247 insertions(+), 8 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/us
Some people prefer to use ECM mode rather than vendor mode. Therefore, I add
CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB
configuration value which they want. The default is to support vendor mode
only.
Hayes Wang (3):
r8152: check hw version first
r8152: suppor
Check hw version first in probe(). Do nothing if the driver doesn't
support the chips.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 102 ++--
1 file changed, 63 insertions(+), 39 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/n
According to CONFIG_RTL8152_CONFIG_VALUE, to determine which mode the
driver supports. The value 0 means to support both vendor mode and
ECM mode. The value 1 means to support vendor mode only. The value 2
means to support ECM mode only.
Signed-off-by: Hayes Wang
---
drivers/net/usb/Kconfig | 13
On Wednesday, September 7, 2016 10:17:31 AM CEST Roger Quadros wrote:
> >
> > Speaking of that flag, I suppose we need the same logic to know where
> > to look for USB devices attached to a dwc3 host when we need to describe
> > them in DT. By default we look for child device nodes under the
> > n
On 08/19/2016 10:31 AM, Felipe Balbi wrote:
> Hi,
>
> Binyamin Sharet writes:
>> I think this will cause existing implementation over gadgetfs to fail
>> with this
>> special kernel (as now it will delegate everything all of the time). How
>> about
>> using a ioctl to configure
On 01/09/16 08:53, Richard van der Hoff wrote:
On 30/08/16 21:52, Richard van der Hoff wrote:
On 30/08/16 19:48, Alan Stern wrote:
On Tue, 30 Aug 2016, Richard van der Hoff wrote:
I have a USB-3.1 dock; sometimes I see a kernel panic when I unplug it,
which hangs the entire system. It appears
On Wednesday, September 7, 2016 2:33:13 PM CEST Peter Chen wrote:
> >
> > Right, that should make it work with iommu as well. However, it does
> > not solve the other issue I mentioned above, with boards that have
> > USB devices hardwired to a chipidea host controller that need
> > configuration
On Wednesday, September 7, 2016 3:44:28 PM CEST Peter Chen wrote:
>
> The pre-condition of DT function at USB HCD core works is the host
> controller device has of_node, since it is the root node for USB tree
> described at DT. If the host controller device is not at DT, it needs
> to try to get i
On Wed, Sep 07, 2016 at 10:52:46AM +0200, Arnd Bergmann wrote:
> On Wednesday, September 7, 2016 3:44:28 PM CEST Peter Chen wrote:
> >
> > The pre-condition of DT function at USB HCD core works is the host
> > controller device has of_node, since it is the root node for USB tree
> > described at D
On Wed, Sep 07, 2016 at 05:29:01PM +0800, Peter Chen wrote:
> On Wed, Sep 07, 2016 at 10:52:46AM +0200, Arnd Bergmann wrote:
> > On Wednesday, September 7, 2016 3:44:28 PM CEST Peter Chen wrote:
> > >
> > > The pre-condition of DT function at USB HCD core works is the host
> > > controller device
2016-08-29 11:07 GMT+02:00 Romain Izard :
> Disabling USB gadget functions configured through configfs is something
> that can happen in normal use cases. Keep the existing log for this type
> of event, but only as debug, not as an error.
>
> Signed-off-by: Romain Izard
> ---
> v1 -> v2:
> - use d
On Wed, Sep 07, 2016 at 10:48:06AM +0200, Arnd Bergmann wrote:
> On Wednesday, September 7, 2016 2:33:13 PM CEST Peter Chen wrote:
> > >
> > > Right, that should make it work with iommu as well. However, it does
> > > not solve the other issue I mentioned above, with boards that have
> > > USB dev
Hi,
Alan Stern writes:
> On Tue, 6 Sep 2016, Peter Zijlstra wrote:
>
>> On Tue, Sep 06, 2016 at 01:49:37PM +0200, Peter Zijlstra wrote:
>> > On Tue, Sep 06, 2016 at 02:43:39PM +0300, Felipe Balbi wrote:
>>
>> > > My fear now, however, is that changing smp_[rw]mb() to smp_mb() just
>> > > adds e
Hi,
Russell King - ARM Linux writes:
> On Wed, Sep 07, 2016 at 05:29:01PM +0800, Peter Chen wrote:
>> On Wed, Sep 07, 2016 at 10:52:46AM +0200, Arnd Bergmann wrote:
>> > On Wednesday, September 7, 2016 3:44:28 PM CEST Peter Chen wrote:
>> > >
>> > > The pre-condition of DT function at USB HCD c
Hi,
Arnd Bergmann writes:
[...]
> Regarding the DMA configuration that you mention in ci_hdrc_add_device(),
> I think we should replace
>
> pdev->dev.dma_mask = dev->dma_mask;
> pdev->dev.dma_parms = dev->dma_parms;
> dma_set_coherent_mask(&pdev->dev, dev->coherent_dma
Hi,
Binyamin Sharet writes:
>>> I think this will cause existing implementation over gadgetfs to fail
>>> with this
>>> special kernel (as now it will delegate everything all of the time). How
>>> about
>>> using a ioctl to configure it, but wrapping this ioctl with Kconfig?
Hi,
Stefan Wahren writes:
> Hi John,
>
>> John Youn hat am 1. September 2016 um 23:07
>> geschrieben:
>>
>>
>> This series accounts for the delay from the IDDIG debounce filter when
>> switching modes. This delay is a function of the PHY clock speed and
>> can range from 5-50 ms. This delay m
On 07/09/16 10:55, Peter Chen wrote:
[...]
>> Regarding the DMA configuration that you mention in ci_hdrc_add_device(),
>> I think we should replace
>>
>> pdev->dev.dma_mask = dev->dma_mask;
>> pdev->dev.dma_parms = dev->dma_parms;
>> dma_set_coherent_mask(&pdev->dev, dev->
Hi,
Arnd Bergmann writes:
> Starting with v4.8-rc5, we get a warning about the dwc3_pci_pm_dummy function
> when CONFIG_PM_SLEEP is disabled:
>
> drivers/usb/dwc3/dwc3-pci.c:253:12: warning: 'dwc3_pci_pm_dummy' defined but
> not used
>
> Using __maybe_unused instead of #ifdef lets the compiler
Romain Izard writes:
> 2016-08-29 11:07 GMT+02:00 Romain Izard :
>> Disabling USB gadget functions configured through configfs is something
>> that can happen in normal use cases. Keep the existing log for this type
>> of event, but only as debug, not as an error.
>>
>> Signed-off-by: Romain Izar
Hi,
Robin Murphy writes:
> On 07/09/16 10:55, Peter Chen wrote:
> [...]
>>> Regarding the DMA configuration that you mention in ci_hdrc_add_device(),
>>> I think we should replace
>>>
>>> pdev->dev.dma_mask = dev->dma_mask;
>>> pdev->dev.dma_parms = dev->dma_parms;
>>> d
On Tue, Sep 06, 2016 at 10:44:31PM +1200, Eddie Stanley wrote:
> SUMMARY:
> Logitech Precision Gamepad shows axis activity upon connection
>
> DESCRIPTION:
> When I connect my Logitech Precision Gamepad (or the machine starts up
> with it connected) it exhibits activity on both axes until I press
On Wednesday, September 7, 2016 1:39:16 PM CEST Felipe Balbi wrote:
>
> seems like it would've been enough to define dwc3_pci_pm_dummy() if
> CONFIG_PM_SLEEP. Right? IOW:
>
> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index 0a32430f4c41..6df0f5dad9a4 100644
> --- a/d
This patch series adds support for delegation of GET_DESCRIPTOR requests
from
GadgetFS to user mode driver. This will allow deeper testing of USB hosts
using GadgetFS, since it allows a user mode driver to control the responses
to to GET_DESCRIPTOR requests, and respond with malformed descriptors.
Feature control mechanism allows addition of dynamic features to
gadgetfs.
It provides a user-mode driver the ability to control those features,
by querying the supported and enabled features and enable/disable
features in runtime via ioctl on ep0 fd.
---
drivers/usb/gadget/legacy/inode.c | 67
++
When this feature is enabled, all GET_DESCRIPTOR control requests
will not be handled by gadgetfs, but delegated to the user mode
driver for handling.
The feature is disabled when ep0 file is opened, and can be set via
ioctl, since when enabled, it breaks compatibility with older versions,
and wil
Added USB_GADGETFS_ALLOW_DELEGATE_DESCRIPTORS to Kconfig, this
option is available under USB_GADGETFS and requires EXPERT.
Enabling this option will not change the default behavior of
GadgetFS, but will allow a user to enable descriptor delegation
using ioctls.
---
drivers/usb/gadget/legacy/Kconfi
Hi,
Binyamin Sharet writes:
> Feature control mechanism allows addition of dynamic features to
> gadgetfs.
>
> It provides a user-mode driver the ability to control those features,
> by querying the supported and enabled features and enable/disable
> features in runtime via ioctl on ep0 fd.
> --
Actually make it retutn useful information.
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index ea7d361..7c21567 100644
--- a/drivers/usb/class/cdc
Some debug messages merely provide a function trace without
additional debug data. They predate ftrace and can be replaced
by it. Drop them without replacement.
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 20 +++-
1 file changed, 3 insertions(+), 17 deletions(-
Further cleanup making the debug messages more precise, useful
and removing mere trace points.
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-
When building a kernel with CONFIG_PM_SLEEP=n, we
get the following warning:
drivers/usb/dwc3/dwc3-pci.c:253:12: warning: 'dwc3_pci_pm_dummy' defined but
not used
In order to fix this, we should only define
dwc3_pci_pm_dummy() when CONFIG_PM_SLEEP is defined.
Fixes: f6c274e11e3b ("usb: dwc3: pc
Binyamin Sharet writes:
> Added USB_GADGETFS_ALLOW_DELEGATE_DESCRIPTORS to Kconfig, this
> option is available under USB_GADGETFS and requires EXPERT.
> Enabling this option will not change the default behavior of
> GadgetFS, but will allow a user to enable descriptor delegation
> using ioctls.
>
On 09/07/2016 03:40 PM, Felipe Balbi wrote:
> Binyamin Sharet writes:
>
>> Added USB_GADGETFS_ALLOW_DELEGATE_DESCRIPTORS to Kconfig, this
>> option is available under USB_GADGETFS and requires EXPERT.
>> Enabling this option will not change the default behavior of
>> GadgetFS, but will allow a use
Binyamin Sharet writes:
> On 09/07/2016 03:40 PM, Felipe Balbi wrote:
>> Binyamin Sharet writes:
>>
>>> Added USB_GADGETFS_ALLOW_DELEGATE_DESCRIPTORS to Kconfig, this
>>> option is available under USB_GADGETFS and requires EXPERT.
>>> Enabling this option will not change the default behavior of
On 09/07/2016 03:36 PM, Felipe Balbi wrote:
> Hi,
>
> Binyamin Sharet writes:
>> Feature control mechanism allows addition of dynamic features to
>> gadgetfs.
>>
>> It provides a user-mode driver the ability to control those features,
>> by querying the supported and enabled features and enable/di
On 07/09/16 11:29, Arnd Bergmann wrote:
> On Wednesday, September 7, 2016 10:17:31 AM CEST Roger Quadros wrote:
>>>
>>> Speaking of that flag, I suppose we need the same logic to know where
>>> to look for USB devices attached to a dwc3 host when we need to describe
>>> them in DT. By default we lo
[ CCing Oliver, who AFAIK still is the cdc_ether maintainer and should
have the final word on this ]
Hayes Wang writes:
> Some people prefer to use ECM mode rather than vendor mode. Therefore, I add
> CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB
> configuration
On 07.09.2016 11:46, Richard van der Hoff wrote:
On 01/09/16 08:53, Richard van der Hoff wrote:
On 30/08/16 21:52, Richard van der Hoff wrote:
On 30/08/16 19:48, Alan Stern wrote:
On Tue, 30 Aug 2016, Richard van der Hoff wrote:
I have a USB-3.1 dock; sometimes I see a kernel panic when I un
Hi Greg
One small but important fix that would be nice to get into 4.8
Fixes a NULL pointer dereference seen by two people already when
a hotplugged xHC host is removed at the same time as a usb device is
unplugged.
-Mathias
Mathias Nyman (1):
xhci: fix null pointer dereference in stop comma
The stop endpoint command has its own 5 second timeout timer.
If the timeout function is triggered between USB3 and USB2 host
removal it will try to call usb_hc_died(xhci_to_hcd(xhci)->primary_hcd)
the ->primary_hcd will be set to NULL at USB3 hcd removal.
Fix this by first checking if the PCI ho
On Wednesday, September 7, 2016 4:04:52 PM CEST Roger Quadros wrote:
> > The main use for it is to let you specify a MAC address for on-board
> > ethernet devices that lack an EPROM, but any other information can be
> > added that way too.
> >
> >> There is a bug in the USB core because of which
On Wed, 7 Sep 2016, Felipe Balbi wrote:
> > --- a/include/uapi/linux/usb/gadgetfs.h
> > +++ b/include/uapi/linux/usb/gadgetfs.h
> > @@ -85,4 +85,33 @@ struct usb_gadgetfs_event {
> > */
> > #defineGADGETFS_CLEAR_HALT_IO('g', 3)
> >
> > +
> > +
> > +struct usb_gadgetfs_features {
> > +
On Wed, 7 Sep 2016, Mathias Nyman wrote:
> > I'm still seeing occasional problems. For example, when I unplugged the
> > dock last night, it seems to have wedged some things, and then plugging it
> > back in didn't work. See some logs below.
> >
> >
> > I ran a show-blocked-tasks after plugging
On Wednesday, September 7, 2016 1:24:07 PM CEST Felipe Balbi wrote:
>
> Hi,
>
> Arnd Bergmann writes:
>
> [...]
>
> > Regarding the DMA configuration that you mention in ci_hdrc_add_device(),
> > I think we should replace
> >
> > pdev->dev.dma_mask = dev->dma_mask;
> > pdev->d
On 09/07/2016 03:51 PM, Felipe Balbi wrote:
> Binyamin Sharet writes:
>
>> On 09/07/2016 03:40 PM, Felipe Balbi wrote:
>>> Binyamin Sharet writes:
>>>
Added USB_GADGETFS_ALLOW_DELEGATE_DESCRIPTORS to Kconfig, this
option is available under USB_GADGETFS and requires EXPERT.
Enabling
On Wed, 7 Sep 2016, Arnd Bergmann wrote:
> However, to summarize the discussion so far, I agree that
> of_dma_configure() is not the solution to these problems, and I think
> we can do much better:
>
> Splitting the usb_bus->controller field into the Linux-internal device
> (used for the sysfs hi
Hi!
I purchased a Kingston DT100G3/32GB and it corrupts large files (> ~500MB) on
write with plain "cp". I already filed a bug at
https://bugzilla.redhat.com/show_bug.cgi?id=1371183
with detailed descriptions how I tested the device.
Kingston suspected a broken device and sent me a new one as rep
From: Wolfgang Breyha
> Sent: 07 September 2016 17:10
> I purchased a Kingston DT100G3/32GB and it corrupts large files (> ~500MB) on
> write with plain "cp". I already filed a bug at
> https://bugzilla.redhat.com/show_bug.cgi?id=1371183
> with detailed descriptions how I tested the device.
>
> Ki
Hello.
On 09/07/2016 03:30 PM, Oliver Neukum wrote:
Actually make it retutn useful information.
Return? Or maybe just "print"?
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/class/cdc-
On Tue, Sep 06, 2016 at 11:01:15AM -0700, Stefan Agner wrote:
> On 2016-09-06 01:22, Mark Brown wrote:
> > This is nonsense unless the device can work without this supply. Given
> > that the supply is called VCC that doesn't seem entirely likely.
> Afaik it is kind of a generic device tree bindi
Hi,
Binyamin Sharet writes:
> On 09/07/2016 03:51 PM, Felipe Balbi wrote:
>> Binyamin Sharet writes:
>>
>>> On 09/07/2016 03:40 PM, Felipe Balbi wrote:
Binyamin Sharet writes:
> Added USB_GADGETFS_ALLOW_DELEGATE_DESCRIPTORS to Kconfig, this
> option is available under USB_GAD
Hi,
Binyamin Sharet writes:
> On 09/07/2016 03:36 PM, Felipe Balbi wrote:
>> Hi,
>>
>> Binyamin Sharet writes:
>>> Feature control mechanism allows addition of dynamic features to
>>> gadgetfs.
>>>
>>> It provides a user-mode driver the ability to control those features,
>>> by querying the su
Hi,
Alan Stern writes:
> On Wed, 7 Sep 2016, Felipe Balbi wrote:
>
>> > --- a/include/uapi/linux/usb/gadgetfs.h
>> > +++ b/include/uapi/linux/usb/gadgetfs.h
>> > @@ -85,4 +85,33 @@ struct usb_gadgetfs_event {
>> > */
>> > #defineGADGETFS_CLEAR_HALT_IO('g', 3)
>> >
>> > +
>> > +
>> >
On Wednesday, September 7, 2016 12:08:20 PM CEST Alan Stern wrote:
> On Wed, 7 Sep 2016, Arnd Bergmann wrote:
>
> > drivers/usb/host/ehci-fsl.c| 4 ++--
>
> How did this driver end up in the patch?
>
> > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> > index 9f5ffb6
On Wed, 7 Sep 2016, Felipe Balbi wrote:
> Hi,
>
> Alan Stern writes:
> > On Wed, 7 Sep 2016, Felipe Balbi wrote:
> >
> >> > --- a/include/uapi/linux/usb/gadgetfs.h
> >> > +++ b/include/uapi/linux/usb/gadgetfs.h
> >> > @@ -85,4 +85,33 @@ struct usb_gadgetfs_event {
> >> > */
> >> > #define
Hi Kishon,
There was some discussion about the 6th patch in this set, so I've
dropped this for now (needs a universal dt binding), but the other
5 are still useful without this patch and are ready for merging.
Can you please add these 5 to your next branch ?
Thanks & Regards,
Hans
--
To unsubsc
The phy-sun4i-usb code supports forced ending a session on systems
which lack Vbus detection, to allow switching between host and peripheral
mode on such systems.
Role switching via the musb driver "mode" sysfs attribute requires force
ending the session too. This commit refactors the code to allo
If we cannot get dr_mode or no id gpio is specified simply assume
peripheral mode, as this is always safe.
Signed-off-by: Hans de Goede
---
Changes in v2:
-Keep sun4i_usb_phy0_get_id_det() logic as is rather then re-ordering
the switch-case
Changes in v3:
-No changes
---
drivers/phy/phy-sun4i-u
We're using bool as true/false type in most places in phy-sun4i-usb.c
for consistency fixup the remaining uses of ints which are ever only
0 or 1 to be bools too.
Signed-off-by: Hans de Goede
---
Changes in v2:
-No changes
Changes in v3:
-No changes
---
drivers/phy/phy-sun4i-usb.c | 7 ---
1
Together with some musb sunxi glue changes this allows run-time dr_mode
switching support via the "mode" musb sysfs attribute.
Signed-off-by: Hans de Goede
---
Changes in v2:
-No changes
Changes in v3:
-Fix switch-case code style
---
drivers/phy/phy-sun4i-usb.c | 30 +
Warn when external vbus is detected when we're trying to enable our
own vbus.
Signed-off-by: Hans de Goede
---
Changes in v2:
-No changes
Changes in v3:
-No changes
---
drivers/phy/phy-sun4i-usb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/phy-sun4i-usb.c
On 2016-09-07 11:53, Mark Brown wrote:
> On Tue, Sep 06, 2016 at 11:01:15AM -0700, Stefan Agner wrote:
>> On 2016-09-06 01:22, Mark Brown wrote:
>
>> > This is nonsense unless the device can work without this supply. Given
>> > that the supply is called VCC that doesn't seem entirely likely.
>
>
On Tue, 6 Sep 2016, Ulf Hansson wrote:
> On 5 September 2016 at 17:58, Alan Stern wrote:
> > On Mon, 5 Sep 2016, Ritesh Raj Sarraf wrote:
> >
> >> -BEGIN PGP SIGNED MESSAGE-
> >> Hash: SHA512
> >>
> >> On Sun, 2016-09-04 at 15:46 -0400, Alan Stern wrote:
> >> >
> >> > This is not the prob
On 9/4/2016 2:32 PM, Martin Blumenstingl wrote:
> From: Jerome Brunet
>
> Add compatible strings for amlogic Meson8b and GXBB SoCs with the
> corresponding configuration parameters.
>
> Signed-off-by: Martin Blumenstingl
> Signed-off-by: Jerome Brunet
> ---
> Documentation/devicetree/bindings
On 09/04, Martin Blumenstingl wrote:
> USB0_DDR_BRIDGE and USB1_DDR_BRIDGE1 are needed for the related
> dwc2 usb controller. USB, USB0 and USB1 are needed for the PHYs.
> Expose these clocks to DT and comment out in clk driver.
>
> Signed-off-by: Jerome Brunet
> Signed-off-by: Martin Blumensting
On Wed, Sep 7, 2016 at 2:33 AM, Stephen Boyd wrote:
> On 09/04, Martin Blumenstingl wrote:
>> USB0_DDR_BRIDGE and USB1_DDR_BRIDGE1 are needed for the related
>> dwc2 usb controller. USB, USB0 and USB1 are needed for the PHYs.
>> Expose these clocks to DT and comment out in clk driver.
>>
>> Signed
In the case of ULPI devices, we want to be able to load the
driver before registering the device so that we don't get stuck
in a loop waiting for the phy module to appear and failing usb
controller probe. Currently we request the ulpi module via the
ulpi ids, but in the DT case we might need to req
The state of USB ChipIdea support on Qualcomm's platforms is not great.
The DT description of these devices requires up to three different nodes
for what amounts to be the same hardware block, when there should really
only be one. Furthermore, the "phy" driver that is in mainline (phy-msm-usb.c)
du
We don't call hw_device_reset() with the ci->lock held, so it
doesn't seem like this lock here is protecting anything. Let's
just remove it. This allows us to call sleeping functions like
phy_init() from within the CI_HDRC_CONTROLLER_RESET_EVENT hook.
Acked-by: Peter Chen
Cc: Greg Kroah-Hartman
We need to pick the correct phy at runtime based on how the SoC
has been wired onto the board. If the secondary phy is used, take
it out of reset and mux over to it by writing into the TCSR
register. Make sure to do this on reset too, because this
register is reset to the default value (primary phy
If two devices are probed with this same driver, they'll share
the same platform data structure, while the chipidea core layer
writes and modifies it. This can lead to interesting results
especially if one device is an OTG type chipidea controller and
another is a host. Let's create a copy of this
If something fails in ci_hdrc_add_device() due to probe defer, we
shouldn't print an error message. Be silent in this case as we'll
try probe again later.
Acked-by: Peter Chen
Cc: Greg Kroah-Hartman
Signed-off-by: Stephen Boyd
---
drivers/usb/chipidea/ci_hdrc_msm.c | 3 ++-
1 file changed, 2 i
The MSM_USB_BASE macro trick is not very clear, and we're using
it for only one register write so let's just move to using
hw_write_id_reg() and passing the ci pointer instead. That
clearly shows what offset we're using and avoids needing to
include the msm_hsusb_hw.h file when we're going to delet
The chipidea/udc.c file sends a CI_HDRC_CONTROLLER_RESET_EVENT to
the wrapper drivers when it calls hw_device_reset(), but that
function is not called from chipidea/host.c. And the udc.c file
sends the CI_HDRC_CONTROLLER_STOPPED_EVENT but the host.c file
doesn't do anything.
The intent of the rese
The ULPI phy on qcom platforms needs to be initialized and
powered on after a USB reset and before we toggle the run/stop
bit. Otherwise, the phy locks up and doesn't work properly.
Therefore, add a flag to skip any phy power management in the
core layer, leaving it up to the glue driver to manage.
When the RESET bit is set in the USBCMD register it resets quite
a few of the wrapper's registers to their reset state. This
includes the GENCONFIG and GENCONFIG2 registers. Currently this
is done by the usb phy and ehci-msm drivers writing into the
controller wrapper's MMIO address space. Let's co
The msm chipidea controller uses two main clks, an AHB clk to
read/write the MMIO registers and a core clk called the system
clk that drives the controller itself. Add support for these clks
as they're required in all designs.
Also add support for an optional third clk that we need to turn
on to r
The high-speed phy on qcom SoCs is controlled via the ULPI
viewport.
Cc: Kishon Vijay Abraham I
Cc:
Signed-off-by: Stephen Boyd
---
.../devicetree/bindings/phy/qcom,usb-hs-phy.txt| 83 ++
drivers/phy/Kconfig| 8 +
drivers/phy/Makefile
The HSIC USB controller on qcom SoCs has an integrated all
digital phy controlled via the ULPI viewport.
Cc: Kishon Vijay Abraham I
Cc:
Signed-off-by: Stephen Boyd
---
.../devicetree/bindings/phy/qcom,usb-hsic-phy.txt | 65 +
drivers/phy/Kconfig| 7 +
The MSM chipidea wrapper has two bits that are used to reset the
first or second phy. Add support for these bits via the reset
controller framework, so that phy drivers can reset their
hardware at the right time during initialization.
Acked-by: Peter Chen
Cc: Greg Kroah-Hartman
Signed-off-by: St
The core framework already handles setting this parameter with a
platform quirk. Add the appropriate flag so that we always set
AHBBURST to 0. Technically DT should be doing this, but we always
do it for msm chipidea devices so setting the flag in the driver
works just as well. If the burst needs t
The ULPI phy on qcom platforms needs to be initialized and
powered on after a USB reset and before we toggle the run/stop
bit. Otherwise, the phy locks up and doesn't work properly. Hook
the phy initialization into the RESET event and the phy power off
into the STOPPED event.
Acked-by: Peter Chen
Some phys for the chipidea controller are controlled via the ULPI
viewport. Add support for the ULPI bus so that these sorts of
phys can be probed and read/written automatically without having
to duplicate the viewport logic in each phy driver.
Acked-by: Peter Chen
Cc: Greg Kroah-Hartman
Cc: Hei
We're not properly marking the glue layer/wrapper device as
runtime active, so runtime PM believes that the hardware state is
inactive when we call pm_runtime_enable() in this driver. This
causes a problem when the glue layer has a power domain
associated with it, because runtime PM will go and dis
The two extcon notifiers are almost the same except for the
variable name for the cable structure and the id notifier inverts
the cable->state logic. Make it the same and replace two
functions with one to save some lines. This also makes it so that
the id cable state is true when the id pin is pull
We're currently emulating the vbus and id interrupts in the OTGSC
read API, but we also need to make sure that if we're handling
the events with extcon that we don't enable the interrupts for
those events in the hardware. Therefore, properly emulate this
register if we're using extcon, but don't en
The qcom HSIC ULPI phy doesn't have any bits set in the vendor or
product ID registers. This makes it impossible to make a ULPI
driver match against the ID registers. Add support to discover
the ULPI phys via DT help alleviate this problem. In the DT case,
we'll look for a ULPI bus node underneath
With the id and vbus detection done via extcon we need to make
sure we poll the status of OTGSC properly by considering what the
extcon is saying, and not just what the register is saying. Let's
move this hw_wait_reg() function to the only place it's used and
simplify it for polling the OTGSC regis
The ULPI bus can be built as a module, and it will soon be
calling these functions when it supports probing devices from DT.
Export them so they can be used by the ULPI module.
Cc: Rob Herring
Cc:
Signed-off-by: Stephen Boyd
---
drivers/of/device.c | 2 ++
1 file changed, 2 insertions(+)
diff
On 09/07, Martin Blumenstingl wrote:
> On Wed, Sep 7, 2016 at 2:33 AM, Stephen Boyd wrote:
> > On 09/04, Martin Blumenstingl wrote:
> >> USB0_DDR_BRIDGE and USB1_DDR_BRIDGE1 are needed for the related
> >> dwc2 usb controller. USB, USB0 and USB1 are needed for the PHYs.
> >> Expose these clocks to
On Thu, Sep 1, 2016 at 11:07 PM, Greg KH wrote:
> On Fri, Sep 02, 2016 at 01:20:21AM +0100, James wrote:
>> This patch fixes a NULL pointer dereference caused by a race codition in the
>> probe
>> function of the legousbtower driver. The probe function does not deregister
>> the
>> usb interface
From: Hayes Wang
Date: Wed, 7 Sep 2016 16:12:19 +0800
> Some people prefer to use ECM mode rather than vendor mode. Therefore, I add
> CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB
> configuration value which they want. The default is to support vendor mode
> only.
1 - 100 of 121 matches
Mail list logo
