On Tue, Jul 26, 2016 at 07:59:41PM +0200, Mathieu OTHACEHE wrote:
> __uX types should only be used for user-space interactions.
>
> Signed-off-by: Mathieu OTHACEHE
> ---
>
> Changelog:
> v2:
> * Replace cpu_to_be16s calls by cpu_to_be16
> * Remove other useless casts
You should have mentioned t
On Tue, Jul 26, 2016 at 07:59:42PM +0200, Mathieu OTHACEHE wrote:
> Remove useless or redundant dev_dbg messages.
> Fix debug-message typos.
You never fix any typos, and forgot to mention the added NULL-check for
oldtermios, which is currently not needed and really should go in its
own patch.
> S
On Wed, Jul 27, 2016 at 02:46:32PM +0200, Mathieu OTHACEHE wrote:
>
> > in that case, where is the initialisation to 0 you avoid and hence
> > can remove from the code?
>
> Hi,
>
> In v1, kzalloc was useful to avoid wFlags initialisation to 0 :
>
> https://lkml.org/lkml/2016/5/12/139
>
> In v2
On Mon, 2016-08-22 at 17:21 -0600, Jose Marino wrote:
> I'm using my phone (Nexus 5X running Android) to tether a USB connection
> to my laptop (XPS 15 9550). I plug the phone through the USB-C
> connection and in the phone I select USB tethering. Initially things
> look normal: a usb0 network
On Tue, Jul 26, 2016 at 07:59:44PM +0200, Mathieu OTHACEHE wrote:
> It is useless to check the return of usb_get_serial_port_data.
Please be more specific in your commit messages in general. In this case
it should mention that there's no need to check for NULL private data in
the tty or tty-port c
On Tue, Jul 26, 2016 at 07:59:47PM +0200, Mathieu OTHACEHE wrote:
> Use macros to define 3410 and 5052 baud bases.
> Use macro to define usb download timeout.
>
> Signed-off-by: Mathieu OTHACEHE
> ---
> drivers/usb/serial/ti_usb_3410_5052.c | 22 +++---
> 1 file changed, 15 inser
Hi Johan,
Johan Hovold 於 2016/8/22 下午 09:14 寫道:
+static const struct reg_value f81534_pin_control[4][3] = {
+ /* M0_SDM1 M2 */
+ {{0x2ae8, 7}, {0x2a90, 5}, {0x2a90, 4}, }, /* port 0 pins */
+ {{0x2ae8, 6}, {0x2ae8, 0}, {0x2ae8, 3}, }, /* port 1 p
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Thank you Alan for confirming the bug.
On Mon, 2016-08-22 at 15:09 -0400, Alan Stern wrote:
> > https://people.debian.org/~rrs/tmp/usb_1u-usbmon.txt.gz
> >
> > https://people.debian.org/~rrs/tmp/dmesg-usbmon.txt
>
> The usbmon trace shows two sepa
On Tue, Jul 26, 2016 at 07:59:46PM +0200, Mathieu OTHACEHE wrote:
> Remove variables affected but never read.
This commit message is also incomplete. The tp_flags variable was indeed
read, even if it was always ANDed with 0.
I applied it anyway this time, and also dropped the now unused
TI_SET_SE
On Mon, Apr 11, 2016 at 02:27:20PM -0700, Aaron Marburg wrote:
>
> Add callbacks to handle TIOCGRS485 and TIOCSRS485 ioctl
> calls in mos7840.c, allowing configuration of the chip's
> "scratchpad" register to strobe the DTR line while transmitting.
>
> This functionality is required for R
On Tue, Aug 23, 2016 at 04:23:44PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Hi Johan,
>
> Johan Hovold 於 2016/8/22 下午 09:14 寫道:
> >> +{
> >> + size_t count = F81534_USB_MAX_RETRY;
> >> + int status;
> >> + u8 *tmp;
> >> +
> >> + tmp = kmalloc(sizeof(u8), GFP_KERNEL);
> >> + if (!tmp)
> >> +
Hi Blabi,
On 18/08/16 08:12, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" writes:
>> The default_length parameter of alloc_ep_req was not really necessary
>> and gadget drivers would almost always create an inline function to pass
>> the same value to len and default_len.
>>
>> So this p
Hi,
On 22/08/16 08:45, Felipe Balbi wrote:
>
> Hi,
>
> John Youn writes:
>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>>> Use gadget's framework allocation function instead of directly calling
>>> usb_ep_alloc_request().
>>>
>>> Signed-off-by: Felipe F. Tonello
>>> ---
>>> drivers/usb/gad
On Wednesday 13 July 2016 07:36 AM, Peter Chen wrote:
Hi all,
This is a follow-up for my last power sequence framework patch set [1].
According to Rob Herring and Ulf Hansson's comments[2], I use a generic
power sequence library for parsing the power sequence elements on DT,
and implement gene
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Hi all,
This is a follow-up for my last power sequence framework patch set [1].
According to Rob Herring and Ulf Hansson's comments[2], I use a generic
power sequence library for parsing the power sequence elements on DT,
and implement gener
On Tuesday 23 August 2016 03:52 PM, Vaibhav Hiremath wrote:
On Wednesday 13 July 2016 07:36 AM, Peter Chen wrote:
Hi all,
This is a follow-up for my last power sequence framework patch set [1].
According to Rob Herring and Ulf Hansson's comments[2], I use a generic
power sequence library fo
On 23.08.2016 02:21, Jose Marino wrote:
I'm using my phone (Nexus 5X running Android) to tether a USB connection to my
laptop (XPS 15 9550). I plug the phone through the USB-C connection and in the
phone I select USB tethering. Initially things look normal: a usb0 network
interface appears in
Hi,
Felipe Ferreri Tonello writes:
>> John Youn writes:
>>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
Use gadget's framework allocation function instead of directly calling
usb_ep_alloc_request().
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/functi
Hi,
Felipe Ferreri Tonello writes:
>> "Felipe F. Tonello" writes:
>>> The default_length parameter of alloc_ep_req was not really necessary
>>> and gadget drivers would almost always create an inline function to pass
>>> the same value to len and default_len.
>>>
>>> So this patch also removes
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Tue, 2016-08-23 at 14:21 +0530, Ritesh Raj Sarraf wrote:
> In one of yesterday's email, I have shared the output of
> /sys/kernel/debug/usb/devices before the bug is triggered. The same I've
> pasted
> below.
>
> T: Bus=01 Lev=01 Prnt=01 Port=03
On 23.08.2016 13:54, Mathias Nyman wrote:
On 23.08.2016 02:21, Jose Marino wrote:
I'm using my phone (Nexus 5X running Android) to tether a USB connection to my
laptop (XPS 15 9550). I plug the phone through the USB-C connection and in the
phone I select USB tethering. Initially things look n
22.08.2016 22:20, Dan Williams пишет:
> On Mon, 2016-08-22 at 20:07 +0300, Aleksandr Makarov wrote:
>> 22.08.2016 18:03, Dan Williams пишет:
>>>
>>> On Sat, 2016-08-20 at 14:50 +0300, Aleksandr Makarov wrote:
USB: serial: option: add WeTelecom WM-D200
Add support for WeTelecom W
Hi Balbi,
On 23/08/16 12:03, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>> John Youn writes:
On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
> Use gadget's framework allocation function instead of directly calling
> usb_ep_alloc_request().
>
> Signed-off
Hi Balbi,
On 23/08/16 12:01, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>> "Felipe F. Tonello" writes:
The default_length parameter of alloc_ep_req was not really necessary
and gadget drivers would almost always create an inline function to pass
the same val
__dwc3_gadget_wakeup() is called while holding a spinlock, then depends on
jiffies in order to timeout while polling the USB core for a link state
update. In the case the wakeup failed, the timeout will never happen and
will also cause the cpu to stall until rcu_preempt kicks in.
This switches to
This driver should clear the bit. Otherwise, the VBUS will output
wrongly if the usb port on a board has VBUS output capability.
Fixes: 746bfe63bba3 ("usb: gadget: renesas_usb3: add support for
Renesas USB3.0 peripheral controller")
Cc: # v4.5+
Signed-off-by: Yoshihiro Shimo
On 23.08.2016 14:26, Mathias Nyman wrote:
On 23.08.2016 13:54, Mathias Nyman wrote:
On 23.08.2016 02:21, Jose Marino wrote:
I'm using my phone (Nexus 5X running Android) to tether a USB connection to my
laptop (XPS 15 9550). I plug the phone through the USB-C connection and in the
phone I se
On Tue, Aug 23, 2016 at 01:54:05PM +0300, Mathias Nyman wrote:
> On 23.08.2016 02:21, Jose Marino wrote:
> > I'm using my phone (Nexus 5X running Android) to tether a USB connection to
> > my laptop (XPS 15 9550). I plug the phone through the USB-C connection and
> > in the phone I select USB te
On Tue, 2016-08-23 at 14:25 +0300, Aleksandr Makarov wrote:
> 22.08.2016 22:20, Dan Williams пишет:
> >
> > On Mon, 2016-08-22 at 20:07 +0300, Aleksandr Makarov wrote:
> > >
> > > 22.08.2016 18:03, Dan Williams пишет:
> > > >
> > > >
> > > > On Sat, 2016-08-20 at 14:50 +0300, Aleksandr Makarov
On Tue, 23 Aug 2016, Mathias Nyman wrote:
> Or then this happens:
> (I'll call the hcds usb2_hcd and usb3_hcd to keep track of them, usb2_hcd is
> the primary_hcd)
>
> to begin with:
Actually, to begin with neither usb2_hcd nor usb3_hcd exists. Then
usb2_hcd is registered, at which point we h
On Mon, 22 Aug 2016, Vittorio Zecca wrote:
> I can reproduce the UBSAN report by inserting in the USB receptacle a
> HUAWEI Mobile Broadband E353 HSPA+ USB Stick.
> If there is any patch I'll be happy to try it.
Thank you. Please let us know what happens with the patch below.
Alan Stern
Ind
On Tue, 23 Aug 2016, Mathias Nyman wrote:
> The Dell XPS 9550 has an additional xhci controller for handling the type-C
> port.
> This controller is hotplug removed from the PCI bus when the last USB type-c
> device is disconnected.
>
> xhci driver, and usb core it seems is not really designed w
In v_recv_cmd_submit(), urb_p->urb->pipe has the type unsigned int
(which is 32-bit long on x86_64) but 11<<30 results in a 34-bit integer.
Therefore the 2 leading bits are truncated and
urb_p->urb->pipe &= ~(11 << 30);
has the same meaning as
urb_p->urb->pipe &= ~(3 << 30);
This second
Hi,
On Tue, Aug 23, 2016 at 09:57:17AM +0800, Ayaka wrote:
>
>
> 從我的 iPad 傳送
>
> > Bin Liu 於 2016年8月19日 上午12:08 寫道：
> >
> > Hi,
> >
> >> On Fri, Aug 12, 2016 at 10:23:15AM +0800, ayaka wrote:
> >> Hello all:
> >> I recently add a support for customize am3358 board using the branch
> >> proc
On Tue, 23 Aug 2016, Wenyou Yang wrote:
> The usb controller does not manage correctly the suspend mode for
> the ehci. In echi mode, there is no way to suspend without any
> device connected to it. This is why this specific control is added
> to fix this issue. Since the suspend mode works in ohc
On Tue, 23 Aug 2016, Peter Chen wrote:
> I will add #ifdef CONFIG_OF for related code. And put the content at
> hub_pwrseq_on at hub_probe directly, how about below?
>
> hub_probe() {
>
> ...
>
> if (hub_configure(hub, endpoint) >= 0) {
> #ifdef CONFIG_OF
> for_each_ch
After applying the patch above the UBSAN issue in devio.c disappeared.
However, I got the following messages in dmesg, probably due to a NetworkManager
malfunctioning, and if I click on the NetworkManager icon I get
"NetworkManager is not running"
but maybe this is another issue and your patch did
On 08/23/2016 01:57 AM, Oliver Neukum wrote:
On Mon, 2016-08-22 at 17:21 -0600, Jose Marino wrote:
I'm using my phone (Nexus 5X running Android) to tether a USB connection
to my laptop (XPS 15 9550). I plug the phone through the USB-C
connection and in the phone I select USB tethering. Initia
On 08/23/2016 06:36 AM, Mathias Nyman wrote:
On 23.08.2016 14:26, Mathias Nyman wrote:
On 23.08.2016 13:54, Mathias Nyman wrote:
On 23.08.2016 02:21, Jose Marino wrote:
I'm using my phone (Nexus 5X running Android) to tether a USB
connection to my laptop (XPS 15 9550). I plug the phone throug
On 23.08.2016 16:13, Greg KH wrote:
On Tue, Aug 23, 2016 at 01:54:05PM +0300, Mathias Nyman wrote:
On 23.08.2016 02:21, Jose Marino wrote:
I'm using my phone (Nexus 5X running Android) to tether a USB connection to my
laptop (XPS 15 9550). I plug the phone through the USB-C connection and in t
On 23.08.2016 17:53, Alan Stern wrote:
On Tue, 23 Aug 2016, Mathias Nyman wrote:
Or then this happens:
(I'll call the hcds usb2_hcd and usb3_hcd to keep track of them, usb2_hcd is
the primary_hcd)
to begin with:
Actually, to begin with neither usb2_hcd nor usb3_hcd exists. Then
usb2_hcd is
The default_length parameter of alloc_ep_req was not really necessary
and gadget drivers would almost always create an inline function to pass
the same value to len and default_len.
This patch removes that parameter and updates all calls to alloc_ep_req() to
use the new API.
Signed-off-by: Felipe
Patch #1 removes a unnecessary and confusing parameter from alloc_ep_req().
Also, this series updates f_hid function to use alloc/free_ep_req() instead of
allocating/freeing requests directly.
Felipe F. Tonello (3):
usb: gadget: remove useless parameter in alloc_ep_req()
usb: gadget: f_hid: us
We should always use free_ep_req() when allocating requests with
alloc_ep_req().
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_hid.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/function/f_hid.c
b/drivers/usb/gadget/funct
Use gadget's framework allocation function instead of directly calling
usb_ep_alloc_request().
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_hid.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/function/f_hid.c
b/drivers/usb/gadg
On 23.08.2016 18:10, Alan Stern wrote:
On Tue, 23 Aug 2016, Mathias Nyman wrote:
The Dell XPS 9550 has an additional xhci controller for handling the type-C
port.
This controller is hotplug removed from the PCI bus when the last USB type-c
device is disconnected.
xhci driver, and usb core it
On 23.08.2016 19:14, Jose Marino wrote:
On 08/23/2016 06:36 AM, Mathias Nyman wrote:
On 23.08.2016 14:26, Mathias Nyman wrote:
On 23.08.2016 13:54, Mathias Nyman wrote:
On 23.08.2016 02:21, Jose Marino wrote:
I'm using my phone (Nexus 5X running Android) to tether a USB
connection to my lapt
On Sun, Aug 21, 2016 at 02:16:38PM +0200, Hans de Goede wrote:
> On some devices the musb otg controller can be used in both device and
> host mode, but requires software mode switching since there is no id pin
> connected. The usb0 phy code will default to device mode in this case.
>
> On some sy
23.08.2016 17:42, Dan Williams пишет:
> On Tue, 2016-08-23 at 14:25 +0300, Aleksandr Makarov wrote:
>> 22.08.2016 22:20, Dan Williams пишет:
>>>
>>> On Mon, 2016-08-22 at 20:07 +0300, Aleksandr Makarov wrote:
22.08.2016 18:03, Dan Williams пишет:
>
>
> On Sat, 2016-08-20 at 14
On Sun, Aug 21, 2016 at 03:56:43PM +0800, Randy Li wrote:
> It is a hardware bug in RK3288, the only way to solve it is to
> reset the phy.
>
> Signed-off-by: Randy Li
> ---
> .../devicetree/bindings/phy/rockchip-usb-phy.txt | 3 +++
> drivers/phy/phy-rockchip-usb.c |
Hi,
On 08/23/2016 08:00 PM, Rob Herring wrote:
On Sun, Aug 21, 2016 at 02:16:38PM +0200, Hans de Goede wrote:
On some devices the musb otg controller can be used in both device and
host mode, but requires software mode switching since there is no id pin
connected. The usb0 phy code will default
On 8/22/2016 9:41 PM, Stefan Wahren wrote:
> Hi John,
>
>> John Youn hat am 23. August 2016 um 00:08
>> geschrieben:
>>
>>
>> On 8/22/2016 1:47 PM, Stefan Wahren wrote:
>>> Hi John,
>>>
John Youn hat am 22. August 2016 um 22:06
geschrieben:
On 8/20/2016 6:03 AM, Stefan W
Hi John,
> John Youn hat am 23. August 2016 um 20:37
> geschrieben:
>
>
>
> How about we fall back to smaller defaults if the original values
> fail? And don't configure more than the amount of endpoints.
this sounds good. I would prefer to calculate the estimated gadget fifo size
before conf
On Tue, 23 Aug 2016, Vittorio Zecca wrote:
> After applying the patch above the UBSAN issue in devio.c disappeared.
>
> However, I got the following messages in dmesg, probably due to a
> NetworkManager
> malfunctioning, and if I click on the NetworkManager icon I get
> "NetworkManager is not ru
On Tue, 23 Aug 2016, Ritesh Raj Sarraf wrote:
> This one is after a fresh boot.
>
> T: Bus=02 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#= 9 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=ff MxPS=64 #Cfgs= 1
> P: Vendor=0bda ProdID=0129 Rev=39.60
> S: Manufacturer=Generic
> S: Product=US
Hi,
i'm using a iMX233-OLinuXino board and the kernel panics during shutdown with
4.8.0-rc2-next-20160819:
[ 420.04] ci_hdrc ci_hdrc.0: remove, state 1
[ 420.05] usb usb1: USB disconnect, device number 1
[ 420.06] usb 1-1: USB disconnect, device number 2
[ 420.06] usb 1-1.1: U
UBSAN complains about a left shift by -1 in proc_do_submiturb(). This
can occur when an URB is submitted for a bulk or control endpoint on
a high-speed device, since the code doesn't bother to check the
endpoint type; normally only interrupt or isochronous endpoints have
a nonzero bInterval value.
On Fri, Aug 5, 2016 at 2:27 PM, Stephen Boyd wrote:
> Quoting Peter Chen (2016-07-08 02:04:58)
>> On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote:
>> > @@ -39,6 +42,10 @@ static int ulpi_match(struct device *dev, struct
>> > device_driver *driver)
>> > struct ulpi *ulpi = to_ul
On Fri, Aug 5, 2016 at 2:40 PM, Stephen Boyd wrote:
> Quoting Rob Herring (2016-07-17 19:23:55)
>> On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote:
>> > +---
>> > +
>> > +usb {
>> > + compatible = "vendor,usb-controller";
>> > +
>> > + ulpi {
>> > + phy {
>> >
On 8/21/2016 12:32 PM, Randy Li wrote:
> On the rk3288 USB host-only port (the one that's not the OTG-enabled
> port) the PHY can get into a bad state when a wakeup is asserted (not
> just a wakeup from full system suspend but also a wakeup from
> autosuspend).
>
> We can get the PHY out of its ba
On Thu, 18 Aug 2016, Felipe Balbi wrote:
> >> You mean a ep0 ioctl? Makes sense to me. Then we can add more features
> >> later. Perhaps just add a "Get supported features" IOCTL which returns
> >> a struct with 256 bits (4x uint64_t). I doubt we will ever need that
> >> many bits, but better safe
The port controller interface driver interconnects the Type-C Port
Manager with a Type-C Port Controller Interface (TCPCI) compliant
port controller.
Signed-off-by: Guenter Roeck
---
v3:
- No change
v2:
- Adjust to modified callbacks into tcpm code
drivers/usb/typec/Kconfig | 9 +
drivers/
The following series of patches implements a USB Type-C Port Manager
using the pending USB Type-C class code as basis. The code is still WIP,
but I think it is important to get feedback from the community at this point.
There are two patches in the series. The first patch implements the Type-C
Por
This driver implements the USB Type-C Power Delivery state machine
for both source and sink ports. Alternate mode support is not
fully implemented.
The driver attaches to the USB Type-C class code implemented in
the following patches.
usb: typec: add driver for Intel Whiskey Cove PMIC USB
From: Rafał Miłecki
This commit adds a new trigger responsible for turning on LED when USB
device gets connected to the specified USB port. This can can useful for
various home routers that have USB port(s) and a proper LED telling user
a device is connected.
The trigger gets its documentation f
On Tue, Aug 23, 2016 at 3:00 PM, Stephen Boyd wrote:
> On Fri, Aug 5, 2016 at 2:40 PM, Stephen Boyd wrote:
>> Quoting Rob Herring (2016-07-17 19:23:55)
>>> On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote:
>>> > +---
>>> > +
>>> > +usb {
>>> > + compatible = "vendor,usb-contro
On Tue, Aug 23, 2016 at 4:06 PM, Rob Herring wrote:
> On Tue, Aug 23, 2016 at 3:00 PM, Stephen Boyd wrote:
>> On Fri, Aug 5, 2016 at 2:40 PM, Stephen Boyd wrote:
>>> Quoting Rob Herring (2016-07-17 19:23:55)
On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote:
> +---
unsubscribe
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 23, 2016 at 09:17:02PM +0200, Stefan Wahren wrote:
> Hi,
>
> i'm using a iMX233-OLinuXino board and the kernel panics during shutdown with
> 4.8.0-rc2-next-20160819:
>
> [ 420.04] ci_hdrc ci_hdrc.0: remove, state 1
> [ 420.05] usb usb1: USB disconnect, device number 1
> [ 4
Hi Johan,
Johan Hovold 於 2016/8/23 下午 05:50 寫道:
On Tue, Aug 23, 2016 at 04:23:44PM +0800, Ji-Ze Hong (Peter Hong) wrote:
Hi Johan,
Johan Hovold 於 2016/8/22 下午 09:14 寫道:
I'd say it's not worth trying to avoid that extra allocation, and there
will be several further allocations done in the usb
Dear all,
Could you please help me to review the code?
Thank you very much.
On Tue, 2016-08-09 at 16:23 +0800, Chunfeng Yun wrote:
> These patches introduce the MediaTek USB3 dual-role controller
> driver.
>
> The driver can be configured as Dual-Role Device (DRD),
> Peripheral O
From: Colin Ian King
trivial typo fix in dev_err message
Signed-off-by: Colin Ian King
---
drivers/usb/gadget/udc/net2280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index 614ab951..d8c9ab4 100644
---
72 matches
Mail list logo
