Re: [PATCH 00/16] net: don't print error when allocating urb fails

2016-08-14 Thread David Miller
From: Wolfram Sang Date: Thu, 11 Aug 2016 23:05:19 +0200 > This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses > kmalloc which already prints enough information on failure. So, let's simply > remove those "allocation failed" messages from drivers like we did already for

Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
Hi! > It seems that in v4.8-rc0, /dev/sdX got reordered, and now USB devices > are probed before SATA drivers. That is pretty anti-social. It > broke my boot on my primary machine, and unfortunately due to BIOS > problems (keyboard does not work when connected through a hub) it is > less fun than

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Tom Yan
Since when it is expected that SATA disks will always be probed before USB disks? We can't guarantee that even if we make sure all ata drivers are loaded before usb-storage/uas. That's why we need consistent namings (e.g. /dev/disk/by-id/*). On 14 August 2016 at 17:20, Pavel Machek wrote: > Hi! >

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
On Sun 2016-08-14 17:34:18, Tom Yan wrote: > Since when it is expected that SATA disks will always be probed before > USB disks? We can't guarantee that even if we make sure all ata > drivers are loaded before usb-storage/uas. That's why we need > consistent namings (e.g. /dev/disk/by-id/*). Since

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Tom Yan
On 14 August 2016 at 18:01, Pavel Machek wrote: > > Since SATA support was merged, certainly since v2.4, and from way > before /dev/disk/by-id existed. I have no idea how "SATA before USB" had been done in the past (if it was ever a thing in the kernel), but that has not been the case since at le

[PATCH v2 0/3] USB Audio Gadget refactoring

2016-08-14 Thread Ruslan Bilovol
I came to this patch series when wanted to do two things: - use UAC1 as virtual ALSA sound card on gadget side, just like UAC2 is used so it's possible to do rate resampling - have both playback/capture support in UAC1 Since I wanted to have same behavior for both UAC1/UAC2, obviously I've

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
On Sun 2016-08-14 11:20:44, Pavel Machek wrote: > Hi! > > > It seems that in v4.8-rc0, /dev/sdX got reordered, and now USB devices > > are probed before SATA drivers. That is pretty anti-social. It > > broke my boot on my primary machine, and unfortunately due to BIOS > > problems (keyboard does n

[PATCH v2 2/3] usb: gadget: f_uac2: split out audio core

2016-08-14 Thread Ruslan Bilovol
Abstract the peripheral side ALSA sound card code from the f_uac2 function into a component that can be called by various functions, so the various flavors can be split apart and selectively reused. Visible changes: - add uac_params structure to pass audio paramteres for gaudio_setup - make A

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Tom Yan
On 14 August 2016 at 18:07, Tom Yan wrote: > On 14 August 2016 at 18:01, Pavel Machek wrote: >> >> Since SATA support was merged, certainly since v2.4, and from way >> before /dev/disk/by-id existed. > > I have no idea how "SATA before USB" had been done in the past (if it > was ever a thing in t

[PATCH v2 3/3] usb: gadget: add f_uac1 variant based on new u_audio api

2016-08-14 Thread Ruslan Bilovol
This patch adds new function f_uac1_newapi that uses recently created u_audio api. This makes f_uac1_newapi implementation much simpler by reusing existing u_audio core utilities. This also drops previous f_uac1 approach (write audio samples directly to existing ALSA sound card) and moves to more

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread David Lang
On Sun, 14 Aug 2016, Tom Yan wrote: On 14 August 2016 at 18:07, Tom Yan wrote: On 14 August 2016 at 18:01, Pavel Machek wrote: Since SATA support was merged, certainly since v2.4, and from way before /dev/disk/by-id existed. I have no idea how "SATA before USB" had been done in the past (

[PATCH v2 1/3] usb: gadget: f_uac2: remove platform driver/device creation

2016-08-14 Thread Ruslan Bilovol
Simplify f_uac2 by removing platform driver/device creation; use composite's usb_gadget device as parent for sound card and for debug prints. This removes extra layer of code without any functional change. Signed-off-by: Ruslan Bilovol --- drivers/usb/gadget/function/f_uac2.c | 107 +

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Tom Yan
Btw, why hasn't this been CC'd to linux-scsi at the very least? The SCSI disk (sd) driver is obviously the sociopath here. It should really differentiate disks from libata and usb-storage/uas, and wait for at least a minute to see if there's gonna be an ATA drive popping up before enumerating disks

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
Hi! On Sun 2016-08-14 18:17:39, Tom Yan wrote: > On 14 August 2016 at 18:07, Tom Yan wrote: > > On 14 August 2016 at 18:01, Pavel Machek wrote: > >> > >> Since SATA support was merged, certainly since v2.4, and from way > >> before /dev/disk/by-id existed. > > > > I have no idea how "SATA before

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Greg KH
On Sun, Aug 14, 2016 at 03:26:45AM -0700, David Lang wrote: > On Sun, 14 Aug 2016, Tom Yan wrote: > > > On 14 August 2016 at 18:07, Tom Yan wrote: > > > On 14 August 2016 at 18:01, Pavel Machek wrote: > > > > > > > > Since SATA support was merged, certainly since v2.4, and from way > > > > befo

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Tom Yan
On 14 August 2016 at 11:10, Pavel Machek wrote: > > It is the case in v4.6. We had change hda->sda for SATA drives long > time ago, it was stable since that. Not for me. It has been like forever (even if it wasn't the fact) that the disk order is not consistent among boots. Only that would logica

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
Hi! > > > > I have no idea how "SATA before USB" had been done in the past (if it > > > > was ever a thing in the kernel), but that has not been the case since > > > > at least v3.0 AFAIR. > > > > > > > > > > > > > > People may not run udev, and you can't use /dev/disk/by-id on kernel > > > > >

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Greg KH
On Sun, Aug 14, 2016 at 02:03:27PM +0200, Pavel Machek wrote: > Hi! > > > > > > I have no idea how "SATA before USB" had been done in the past (if it > > > > > was ever a thing in the kernel), but that has not been the case since > > > > > at least v3.0 AFAIR. > > > > > > > > > > > > > > > > > P

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Oliver Neukum
On Sun, 2016-08-14 at 10:53 +, Tom Yan wrote: > Btw, why hasn't this been CC'd to linux-scsi at the very least? The > SCSI disk (sd) driver is obviously the sociopath here. It should > really differentiate disks from libata and usb-storage/uas, and wait > for at least a minute to see if there's

Re: [PATCH] cdc-acm: fix wrong pipe type on rx interrupt xfers

2016-08-14 Thread Oliver Neukum
On Fri, 2016-08-12 at 00:52 -0700, gavi...@thegavinli.com wrote: > From: Gavin Li > > This fixes the "BOGUS urb xfer" warning logged by usb_submit_urb(). > > Signed-off-by: Gavin Li Acked-by: Oliver Neukum -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Alan Stern
On Sun, 14 Aug 2016, Pavel Machek wrote: > > That being said, it would be great if the original reporter could use > > 'git bisect' and let the linux-usb and linux-scsi mailing list know what > > the offending patch is, and we can take it from there. > > Original reporter is me :-(. > > Yes, I c

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-14 Thread Oliver Neukum
On Wed, 2016-08-10 at 22:40 -0400, Martin K. Petersen wrote: > > "Oliver" == Oliver Neukum writes: > > Oliver> Some SATA to USB bridges fail to cooperate with some drives > Oliver> resulting in no cache being present being reported to the > Oliver> host. That causes the host to skip sending a

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
On Sun 2016-08-14 12:14:38, Pavel Machek wrote: > On Sun 2016-08-14 11:20:44, Pavel Machek wrote: > > Hi! > > > > > It seems that in v4.8-rc0, /dev/sdX got reordered, and now USB devices > > > are probed before SATA drivers. That is pretty anti-social. It > > > broke my boot on my primary machine,

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread One Thousand Gnomes
On Sun, 14 Aug 2016 17:34:18 +0800 Tom Yan wrote: > Since when it is expected that SATA disks will always be probed before > USB disks? We can't guarantee that even if we make sure all ata > drivers are loaded before usb-storage/uas. That's why we need > consistent namings (e.g. /dev/disk/by-id/*

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
On Sun 2016-08-14 10:56:54, Alan Stern wrote: > On Sun, 14 Aug 2016, Pavel Machek wrote: > > > > That being said, it would be great if the original reporter could use > > > 'git bisect' and let the linux-usb and linux-scsi mailing list know what > > > the offending patch is, and we can take it fro

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
On Sun 2016-08-14 18:06:53, Pavel Machek wrote: > On Sun 2016-08-14 12:14:38, Pavel Machek wrote: > > On Sun 2016-08-14 11:20:44, Pavel Machek wrote: > > > Hi! > > > > > > > It seems that in v4.8-rc0, /dev/sdX got reordered, and now USB devices > > > > are probed before SATA drivers. That is prett

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Hans de Goede
Hi, On 14-08-16 19:55, Pavel Machek wrote: On Sun 2016-08-14 18:06:53, Pavel Machek wrote: On Sun 2016-08-14 12:14:38, Pavel Machek wrote: On Sun 2016-08-14 11:20:44, Pavel Machek wrote: Hi! It seems that in v4.8-rc0, /dev/sdX got reordered, and now USB devices are probed before SATA driver

[PATCH 0/7] musb: sunxi: Add support for run-time changing dr-mode through sysfs

2016-08-14 Thread Hans de Goede
Hi All, Here is a patch series which implements run-time changing the dr-mode of sunxi musb controllers through the (already existing) musb "mode" sysfs attribute. This is useful on boards where there is no id pin, e.g. some tv-boxes use the musb controller to get an extra usb A port without need

[PATCH 1/7] phy-sun4i-usb: Use bool where appropriate

2016-08-14 Thread Hans de Goede
We're using bool as true/false type in most places in phy-sun4i-usb.c for consistency fixup the remaining uses of ints which are ever only 0 or 1 to be bools too. Signed-off-by: Hans de Goede --- drivers/phy/phy-sun4i-usb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 6/7] musb: sunxi: Always register both host and udc when build with dual-role support

2016-08-14 Thread Hans de Goede
On sunxi the handling of host- / peripheral-only mode is fully taken care of in the phy driver. So we can always safely let the musb-core register both the host and udc. Besides a nice cleanup, this is also a preparation patch for adding run-time dr_mode switching support via the "mode" musb sysfs

[PATCH 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-14 Thread Hans de Goede
This allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede --- drivers/usb/musb/sunxi.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c index

[PATCH 5/7] phy-sun4i-usb: Warn when external vbus is detected

2016-08-14 Thread Hans de Goede
Warn when external vbus is detected when we're trying to enable our own vbus. Signed-off-by: Hans de Goede --- drivers/phy/phy-sun4i-usb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c index fd66991..ffe599e 10064

[PATCH 3/7] phy-sun4i-usb: Simplify missing dr_mode handling

2016-08-14 Thread Hans de Goede
If we cannot get dr_mode or no id gpio is specified simply assume peripheral mode, as this is always safe. Signed-off-by: Hans de Goede --- drivers/phy/phy-sun4i-usb.c | 43 ++- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/phy/ph

[PATCH 2/7] phy-sun4i-usb: Refactor forced session ending

2016-08-14 Thread Hans de Goede
The phy-sun4i-usb code supports forced ending a session on systems which lack Vbus detection, to allow switching between host and peripheral mode on such systems. Role switching via the musb driver "mode" sysfs attribute requires force ending the session too. This commit refactors the code to allo

[PATCH 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-14 Thread Hans de Goede
Together with some musb sunxi glue changes this allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede --- drivers/phy/phy-sun4i-usb.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/phy/phy-sun4i-usb.c b/

[lkp] [usb] ad05399d68: BUG: unable to handle kernel NULL pointer dereference at 0000000000000012

2016-08-14 Thread kernel test robot
FYI, we noticed the following commit: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next commit ad05399d68b6ae1649cdcfc82ce3ffea1a7c5104 ("usb: udc: core: fix error handling") in testcase: boot on test machine: 1 threads qemu-system-x86_64 -enable-kvm -cpu SandyBridge w