Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy

2016-07-31 Thread Amit Tomer
Hello , > @@ -264,6 +266,12 @@ static int sun4i_usb_phy_init(struct phy *_phy) > val = readl(phy->pmu + REG_PMU_UNK_H3); > writel(val & ~2, phy->pmu + REG_PMU_UNK_H3); > } else { > + /* A64 needs also this unknown bit */ > + if (d

Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy

2016-07-31 Thread Hans de Goede
Hi, On 31-07-16 13:25, Icenowy Zheng wrote: There's something unknown in the pmu part. Signed-off-by: Icenowy Zheng Cool, I really like the work you're doing on A64 support, keep up the good work! --- drivers/phy/phy-sun4i-usb.c | 21 +++-- 1 file changed, 19 insertions(+)

Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy

2016-07-31 Thread Chen-Yu Tsai
Hi, On Sun, Jul 31, 2016 at 10:39 PM, Hans de Goede wrote: > Hi, > > On 31-07-16 13:25, Icenowy Zheng wrote: >> >> There's something unknown in the pmu part. >> >> Signed-off-by: Icenowy Zheng > > > Cool, I really like the work you're doing on A64 support, > keep up the good work! > >> --- >> d

Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy

2016-07-31 Thread Hans de Goede
Hi, On 31-07-16 16:50, Chen-Yu Tsai wrote: FYI: H3 USB PHY support is not complete. USB0 PHY is not supported, and it does not work. I did a preliminary comparison of this PHY driver and the code in Allwinner's SDK. There are some bits missing. Right that is a known issue, I believe someone w

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-31 Thread Matwey V. Kornilov
Hello, I've also just found that the same commit breaks cpufreq on BeagleBone Black :) So, probably without HCD_BH flag musb works correctly only at 1Ghz CPU frequency, which is unlisted and being set to 720Mhz by cpufreq driver (as it did whet there was cpufreq driver). 2016-07-29 21:01 GMT+03:

Re: [v3,2/6] power: add power sequence library

2016-07-31 Thread Peter Chen
On Fri, Jul 29, 2016 at 01:06:48PM -0700, Matthias Kaehlcke wrote: > Hi Peter, > > Thanks for your work on this, a few comments inline > > > On 07/20/2016 02:40 AM, Peter Chen wrote: > > >... > > > >+static int pwrseq_generic_on(struct device_node *np, struct pwrseq *pwrseq) > >+{ > > > >... >