[PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Bhaktipriya Shridhar
alloc_ordered_workqueue replaces the deprecated create_singlethread_workqueue. There are multiple work items on the work queue, which require ordering. Hence, an ordered workqueue has been used. The workqueue "wq_otg" is not being used on a memory reclaim path. Hence, WQ_MEM_RECLAIM has not been

[PATCH] usb: lvstest: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Bhaktipriya Shridhar
The workqueue has a single work item(&lvs->rh_work) and hence doesn't require ordering. Also, it is not being used on a memory reclaim path. Hence, the singlethreaded workqueue has been replaced with the use of system_wq. System workqueues have been able to handle high level of concurrency for a l

xhci_hcd crash on linux 4.7.0

2016-07-28 Thread Alex Damian
Hello all, Hope this is the right place to report a bug; if not, please direct me to where it should go. I am running a mainline kernel build by the Ubuntu mainline PPA, on a 2015 Macbook. It is being tainted by use of the vboxdrv module. I am repeatedly getting errors on xhci_hcd irq handler. T

Re: xhci_hcd crash on linux 4.7.0

2016-07-28 Thread Greg KH
On Thu, Jul 28, 2016 at 11:29:41AM +0100, Alex Damian wrote: > Hello all, > > Hope this is the right place to report a bug; if not, please direct me > to where it should go. > > I am running a mainline kernel build by the Ubuntu mainline PPA, on a > 2015 Macbook. It is being tainted by use of the

Re: [PATCH] usb: hub: Fix unbalanced reference count and memory leak

2016-07-28 Thread Alan Stern
On Wed, 27 Jul 2016, Viresh Kumar wrote: > If the hub gets disconnected while the core is still activating it, this > can result in leaking memory of few USB structures. > > This will happen if we have done a kref_get() from hub_activate() and > scheduled a delayed work item for HUB_INIT2/3. Now

Re: [PATCH] usb: hub: Fix unbalanced reference count and memory leak

2016-07-28 Thread Viresh Kumar
On 28-07-16, 10:13, Alan Stern wrote: > On Wed, 27 Jul 2016, Viresh Kumar wrote: > > > If the hub gets disconnected while the core is still activating it, this > > can result in leaking memory of few USB structures. > > > > This will happen if we have done a kref_get() from hub_activate() and > >

Re: [PATCH v3 0/6] power: add power sequence library

2016-07-28 Thread Joshua Clayton
Hi, Peter On 07/20/2016 02:40 AM, Peter Chen wrote: > Hi all, > > This is a follow-up for my last power sequence framework patch set [1]. > According to Rob Herring and Ulf Hansson's comments[2], I use a generic > power sequence library for parsing the power sequence elements on DT, > and implemen

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-28 Thread Matwey V. Kornilov
Hello, I've just bisected commit, which fixed the issue in v4.7 commit 9fa64d6424adabf0e3a546ae24d01a62a927b342 Merge: f55532a febce40 Author: Rafael J. Wysocki Date: Sat Apr 2 01:07:17 2016 +0200 Merge back intel_pstate fixes for v4.6. * pm-cpufreq: intel_pstate: Avoid extra i

Re: [PATCH v3 4/6] usb: core: add power sequence handling for USB devices

2016-07-28 Thread Joshua Clayton
Peter, On 07/27/2016 06:45 PM, Peter Chen wrote: > On Wed, Jul 27, 2016 at 09:25:11AM -0700, Joshua Clayton wrote: >> Patch 4 does not apply for me >> (The Makefile has a "usbcore-$(CONFIG_OF) += of.o" >> line which I don't see in 4.7 or linux/next master). >> Is there another patch set this seri

USB vulnerability

2016-07-28 Thread roswest
Alan, Hi, I am an engineer at Cisco Systems, and this summer we tasked some interns with performing USB fuzzing. One of the interns, Jake Lamberson, was able to cause a kernel panic when emulating an HID keyboard because the OHCI driver fails to reserve bandwidth for the device. Please see the a

Re: [PATCH v3 0/6] power: add power sequence library

2016-07-28 Thread Fabio Estevam
Hi Joshua, On Thu, Jul 28, 2016 at 12:56 PM, Joshua Clayton wrote: > I assume there is a v4 coming due to rmk's comments on patch 5. > I couldn't figure out where to null the of_node in error paths, but in testing > we did put a line of code to null the of_node on release. > > but... > As an asi

Re: USB vulnerability

2016-07-28 Thread Greg KH
On Thu, Jul 28, 2016 at 12:23:01PM -0400, roswest wrote: > > Alan, > > Hi, I am an engineer at Cisco Systems, and this summer we tasked some > interns with performing USB fuzzing. One of the interns, Jake Lamberson, > was able to cause a kernel panic when emulating an HID keyboard because > the O

Re: USB vulnerability

2016-07-28 Thread Alan Stern
On Thu, 28 Jul 2016, Greg KH wrote: > On Thu, Jul 28, 2016 at 12:23:01PM -0400, roswest wrote: > > > > Alan, > > > > Hi, I am an engineer at Cisco Systems, and this summer we tasked some > > interns with performing USB fuzzing. One of the interns, Jake Lamberson, > > was able to cause a kernel p

Re: USB vulnerability

2016-07-28 Thread roswest
Greg, Oops message attached. Rosie Hall On Thu Jul 28 2016 12:45:06 GMT-0400 (EDT), Greg KH wrote: > On Thu, Jul 28, 2016 at 12:23:01PM -0400, roswest wrote: >> >> Alan, >> >> Hi, I am an engineer at Cisco Systems, and this summer we tasked some >> interns with performing USB fuzzing. One of the

[PATCH v3] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

2016-07-28 Thread Sheng-Hui Chu
BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC. To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board. Signed-off-by: Sheng-Hui Chu --- drivers/usb/seri

[PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-07-28 Thread robert . foss
From: Prathmesh Prabhu Implemented queued response handling. This queue is processed every time the WDM_READ flag is cleared. In case of a read error, userspace may not actually read the data, since the driver returns an error through wdm_poll. After this, the underlying device may attempt to se

[PATCH] USB: ftdi_sio: Added custom PIDs for Ivium Technologies electrochemical interface products

2016-07-28 Thread Robert Deliƫn
Ivium Technologies uses the FTDI VID with custom PIDs for their line of electrochemical interfaces and the PalmSens they developed for PalmSens BV. PIDs are kept in numerical order, entries in id_table_combined[] are at the same position as far as possible. Signed-off-by: Robert Delien --- driv

Re: [PATCH v3] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

2016-07-28 Thread Greg KH
On Thu, Jul 28, 2016 at 01:38:22PM +, Sheng-Hui Chu wrote: > BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO > IC. > > To support BCM920706V2_EVAL dev board for WICED development on Linux. Add > the VID(0a5c) and > PID(6422) to ftdi_sio driver to allow loading

Re: USB vulnerability

2016-07-28 Thread Alan Stern
On Thu, 28 Jul 2016, Alan Stern wrote: > Only bits 10..0 of the wMaxPacketSize field contain the maximum packet > size; bits 12..11 contain something else (valid only for high-speed > periodic endpoints) and bits 15..13 are reserved (see Table 9-13 in the > USB-2.0 spec). > > Furthermore, the val

Re: USB vulnerability

2016-07-28 Thread Alan Stern
On Thu, 28 Jul 2016, Alan Stern wrote: > On Thu, 28 Jul 2016, Greg KH wrote: > > > On Thu, Jul 28, 2016 at 12:23:01PM -0400, roswest wrote: > > > > > > Alan, > > > > > > Hi, I am an engineer at Cisco Systems, and this summer we tasked some > > > interns with performing USB fuzzing. One of the i

[PATCH v4] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

2016-07-28 Thread Sheng-Hui J. Chu
BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC. To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board. Signed-off-by: Sheng-Hui J. Chu --- drivers/usb/s

Re: [PATCH v4] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

2016-07-28 Thread Greg KH
On Thu, Jul 28, 2016 at 04:05:40PM -0400, Sheng-Hui J. Chu wrote: > BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO > IC. > > To support BCM920706V2_EVAL dev board for WICED development on Linux. Add > the VID(0a5c) and > PID(6422) to ftdi_sio driver to allow loading

[PATCH v5] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

2016-07-28 Thread Sheng-Hui J. Chu
BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC. To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board. Signed-off-by: Sheng-Hui Chu --- drivers/usb/ser

[PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

2016-07-28 Thread Sheng-Hui J. Chu
BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC. To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board. Signed-off-by: Sheng-Hui J. Chu --- drivers/usb/

Re: USB vulnerability

2016-07-28 Thread Greg KH
On Thu, Jul 28, 2016 at 04:01:53PM -0400, Alan Stern wrote: > On Thu, 28 Jul 2016, Alan Stern wrote: > > > On Thu, 28 Jul 2016, Greg KH wrote: > > > > > On Thu, Jul 28, 2016 at 12:23:01PM -0400, roswest wrote: > > > > > > > > Alan, > > > > > > > > Hi, I am an engineer at Cisco Systems, and this

Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

2016-07-28 Thread Greg KH
On Thu, Jul 28, 2016 at 05:01:45PM -0400, Sheng-Hui J. Chu wrote: > BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO > IC. > > To support BCM920706V2_EVAL dev board for WICED development on Linux. Add > the VID(0a5c) and > PID(6422) to ftdi_sio driver to allow loadi

[PACTH v1 2/2] usb: xhci: plat: Enable async suspend/resume

2016-07-28 Thread robert . foss
From: Andrew Bresticker USB host controllers can take a significant amount of time to suspend and resume, adding several hundred miliseconds to the kernel resume time. Since the XHCI controller has no outside dependencies (other than clocks, which are suspended late/resumed early), allow it to su

[PACTH v1 0/2] usb: xhci: plat: Enable PM, async resume/suspend

2016-07-28 Thread robert . foss
From: Robert Foss This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Andrew Bresticker (2): usb: xhci: plat: Enable runtime PM usb: xhci: plat: Enable async suspend/resume drivers/usb/host/xhci-plat.c | 20 ++-- 1 file changed, 18

[PACTH v1 1/2] usb: xhci: plat: Enable runtime PM

2016-07-28 Thread robert . foss
From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 19 +-- 1 file changed, 17 insertions(+

RE: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

2016-07-28 Thread Sheng-Hui J. Chu
From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 28, 2016 5:09 PM To: Sheng-Hui J. Chu Cc: linux-usb@vger.kernel.org; jo...@kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board On Thu,

Re: [PACTH v1 0/2] usb: xhci: plat: Enable PM, async resume/suspend

2016-07-28 Thread Robert Foss
This series should be labelled v2 instead of v1. This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Andrew Bresticker (2): usb: xhci: plat: Enable runtime PM usb: xhci: plat: Enable async suspend/resume drivers/usb/host/xhci-plat.c | 20 +

Re: [RFC] usb: phy: generic: get rid of VBUS handling

2016-07-28 Thread Zhangfei Gao
Hi, Balbi & Robert Have one question about commit 7acc9973e3c4 ("usb: phy: generic: add vbus support"). Sorry asking here. Commit 7acc9973e3c4 ("usb: phy: generic: add vbus support") is adding GPIO-based VBUS handling for phy-generic.c And now we are uploading usb phy to drivers/phy/, as Balbi

Re: [PATCH v3 0/6] power: add power sequence library

2016-07-28 Thread Peter Chen
On Thu, Jul 28, 2016 at 08:56:40AM -0700, Joshua Clayton wrote: > Hi, Peter > > On 07/20/2016 02:40 AM, Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hansson's comments[2], I use a generic > > powe

Re: [PATCH v3 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-07-28 Thread Peter Chen
On Wed, Jul 20, 2016 at 05:40:24PM +0800, Peter Chen wrote: > Add binding doc for generic power sequence library. > > Signed-off-by: Peter Chen > Acked-by: Philipp Zabel > --- > .../bindings/power/pwrseq/pwrseq-generic.txt | 48 > ++ > 1 file changed, 48 insertions(+)