Ruslan Bilovol wrote:
> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote:
On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
wrote:
> it may break current usecase for some people
>>
>> And what are the benefits that justify breaking the kernel API?
>
> Main limitation with curre
For case 14 and case 21, their correct return value is the number
of bytes transferred, so it is a positive integer. But in usbtest_ioctl,
it takes non-zero as false return value for usbtest_do_ioctl, so
it will treat the correct test as wrong test, then the time on
tests will be the minus value.
On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol
wrote:
> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote:
On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
wrote:
> it may break current usecase for some people
>>
>> And what are the benefits that justify breaking the kernel A
Hi,
usb-next already has:
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/ehci-platform.c?h=usb-next&id=76d15c8fba655c9b2d60cf01834858f2c44483dc
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/ohci-platform.c?h=usb-next&id=6
Hi Baolin,
Sorry for not replying for previous emails because for some reason these
emails were archived. :(
On 12/07/16 10:01, Baolin Wang wrote:
> Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size
> attribute, which means it need to align the request buffer's size to a
it is about an usb error handling in function "hid_io_error":
the comments shows
/* Retries failed, so do a port reset unless we lack bandwidth*/
but actually the code do the opposite
Signed-off-by:Sheng Li
drivers/hid/usbhid/hid-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
On Tue, 2016-07-26 at 10:59 +, Sheng Li (李盛) wrote:
> it is about an usb error handling in function "hid_io_error":
>
> the comments shows
>
> /* Retries failed, so do a port reset unless we lack bandwidth*/
>
> but actually the code do the opposite
>
>
> Signed-off-by:Sheng Li
Hi,
On 07/26/2016 10:53 AM, Jassi Brar wrote:
> On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol
> wrote:
>> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote:
> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
> wrote:
>> it may break current usecase for some people
>>>
>>> And wh
On Tuesday, July 26, 2016 1:29:55 PM CEST Build bot for Mark Brown wrote:
> Tree/Branch: master
> Git describe: v4.7-1605-ge658052
> Commit: e65805251f Merge branch 'irq-core-for-linus' of
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
>
> Build Time: 106 min 43 sec
>
> Passed:7 / 9
On Tue, Jul 26, 2016 at 02:38:00PM +0200, Arnd Bergmann wrote:
> On Tuesday, July 26, 2016 1:29:55 PM CEST Build bot for Mark Brown wrote:
> > Tree/Branch: master
> > Git describe: v4.7-1605-ge658052
> > Commit: e65805251f Merge branch 'irq-core-for-linus' of
> > git://git.kernel.org/pub/scm/linux
From: Heikki Krogerus
Intel Kabylake PCH has the same DWC3 than Intel
Sunrisepoint. Add the new ID to the supported devices.
Cc:
Signed-off-by: Heikki Krogerus
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/d
On Tue, Jul 26, 2016 at 02:38:00PM +0200, Arnd Bergmann wrote:
> The build report doesn't actually show the error unfortunately, but
> I'm pretty sure it's this one:
> drivers/staging/built-in.o: In function `nbu2ss_drv_probe':
> (.text+0x2428): undefined reference to `usb_ep_set_maxpacke
Add missing platform_set_drvdata() in dwc3_of_simple_probe(), otherwise
calling platform_get_drvdata() in remove returns NULL.
This is detected by Coccinelle semantic patch.
Signed-off-by: Wei Yongjun
---
drivers/usb/dwc3/dwc3-of-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/driv
Add missing platform_set_drvdata() in omap_otg_probe(), otherwise
calling platform_get_drvdata() in remove returns NULL.
This is detected by Coccinelle semantic patch.
Signed-off-by: Wei Yongjun
---
drivers/usb/phy/phy-omap-otg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb
On Tue, Jul 26, 2016 at 10:47:20AM +0530, Bhaktipriya Shridhar wrote:
> The status workqueue is involved in initializing the Uxxx and polling
> the Uxxx until a supported PCMCIA CardBus device is detected.
> It then starts the command and respond workqueues and then loads the
> module that handles
On Tue, Jul 26, 2016 at 11:11:18AM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "wq" is involved in controlling the brightness of an
> Apple Cinema Display over USB.
>
> It has a single work item(&pdata->work) per appledisplay and hence
> doesn't require ordering. Also, it is not being used
On Mon, Jul 25, 2016 at 11:35:39AM +0200, Johan Hovold wrote:
> Hi Greg,
>
> Here are my exceptionally late usb-serial updates for 4.8-rc1. Mostly
> clean ups, so there's nothing here (except the device-id patch) which
> cannot wait until 4.9 if you prefer to hold off on these instead of
> sending
Disabling USB gadget functions configured through configfs is something
that can happen in normal use cases. Keep the existing log for this type
of event, but only as information, not as an error.
Signed-off-by: Romain Izard
---
drivers/usb/gadget/configfs.c | 5 +++--
1 file changed, 3 insertio
The workqueue "wq" is involved in controlling the brightness of an
Apple Cinema Display over USB.
It has a single work item(&pdata->work) per appledisplay and hence
doesn't require ordering. Also, it is not being used on a memory
reclaim path.
Hence, the singlethreaded workqueue has been replaced
On Tue, Jul 26, 2016 at 10:19:18PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "wq" is involved in controlling the brightness of an
> Apple Cinema Display over USB.
>
> It has a single work item(&pdata->work) per appledisplay and hence
> doesn't require ordering. Also, it is not being used
Remove useless or redundant dev_dbg messages.
Fix debug-message typos.
Signed-off-by: Mathieu OTHACEHE
---
Changelog:
v2:
* Keep some debug messages
drivers/usb/serial/ti_usb_3410_5052.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/ser
There is no need to keep a pointer to usb_serial in ti_port
structure.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/
Setting DTR/RTS is handled using dtr_rts in tty_core.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index 3a88c2f..b5ea850 100644
--- a/dr
Fix some minor indentation problems.
Also correct a multi-line comment.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 42 +++
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/dri
Add CMSPAR support in set_termios callback.
Move TI_UART_ENABLE_PARITY_CHECKING setting in the upper
block to avoid doing it twice.
Delete useless TI_UART_ENABLE_PARITY_CHECKING unsetting.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 19 ++-
1 file
Save msr before testing the delta and waking up any waiters.
Also use port directly instead of tport->tp_port.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_
If speed is non null anymore, we can raise DTR and RTS flags in
ti_set_termios.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index d4
Remove variables affected but never read.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index 29bb62c..2b7fe89 100644
--- a/dr
ti_command_in_sync and ti_command_out_sync shouldn't use userspace
datatypes (__uX), data should be void* to avoid casting and size
should be size_t.
This patch rewrite those functions with new names: ti_send_ctrl_data_urb
and ti_recv_ctrl_urb. Also add a ti_send_ctrl_urb to simplify command
sendi
Use kzalloc instead of kmalloc to avoid field initialisation to 0.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index 50
The buffer used to store firmware is allocated to maximum firmware
size (TI_FIRMWARE_BUF_SIZE) + header size.
This buffer is filled with requested firmware (fw_p->size) and padded
with 0xff bytes. The header is written over the 3 first bytes of the
buffer (overwritting the 3 first bytes of the requ
The old_termios parameter is never used in set_termios callback.
Add a check to old_termios to see if we can return right away because
there is nothing to change.
Also pass NULL for old_termios in open callback because it is the
initial call to set_termios.
Signed-off-by: Mathieu OTHACEHE
---
C
Use variables for vendor and product in download_firmware to improve
readability.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial
Use the format "error text: error value\n" when possible.
Drop redundant function names from error messages.
Also move a couple err messages to dbg messages.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 105 --
1 file changed, 50 ins
It is useless to check the return of usb_get_serial_port_data.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 34 +-
1 file changed, 1 insertion(+), 33 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/ser
Use macros to define 3410 and 5052 baud bases.
Use macro to define usb download timeout.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/
It is useless to pass a specific context (ti_device) to the interrupt
callback. So use the default context (usb_serial_port).
Remove useless variables in ti_interrupt_callback.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 58 ---
1
Remove useless ti_device pointer, and change addr to u32.
Change size variable in function from int to size_t.
Also fix minor style issue.
Signed-off-by: Mathieu OTHACEHE
---
Changelog:
v2:
* Do not delete prototype and move function declaration
drivers/usb/serial/ti_usb_3410_5052.c | 20 +
It is sufficient to pass usb_serial_port structure to ti_get_serial_info
and ti_set_serial_info.
Also use unsigned int instead of unsigned for cwait variable.
Signed-off-by: Mathieu OTHACEHE
---
Changelog:
v2:
* Do not remove prototypes and move functions declarations.
drivers/usb/serial/ti_us
tty_wakeup is already called when blocked bulk-out transfers complete.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index e8515e
Hi Johan,
Thanks for your review ! Here is the v2 of the serie.
I didn't resubmit patches related to the switch to generic
implementation (open, close, read and write).
I will work on them later when this first batch will be
pushed.
Thank you,
Mathieu
Mathieu OTHACEHE (22):
usb: serial: ti_u
__uX types should only be used for user-space interactions.
Signed-off-by: Mathieu OTHACEHE
---
Changelog:
v2:
* Replace cpu_to_be16s calls by cpu_to_be16
* Remove other useless casts
drivers/usb/serial/ti_usb_3410_5052.c | 101 +-
1 file changed, 51 insertions(
Use C_X tty.h macros to avoid direct manipulation of termios
c_cflag variable.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/seria
This series introduce a USB PD(Power Delivery) sink port simple state
machine driver and adds USB PD sink port support for Intel BXT Whiskey
Cove PMIC Type-C phy driver.
This series depends on these two patches:
https://lkml.org/lkml/2016/6/29/349
https://lkml.org/lkml/2016/6/29/350
Bin Gao (1):
This patch implements a simple USB Power Delivery sink port state machine.
It assumes the hardware only handles PD packet transmitting and receiving
over the CC line of the USB Type-C connector. The state transition is
completely controlled by software. This patch only implement the sink port
funct
From: Chandra Sekhar Anagani
This adds PD sink port support for the USB Type-C PHY on Intel WhiskeyCove
PMIC which is available on some of the Intel Broxton SoC based platforms.
This patch depends on these two patches:
https://lkml.org/lkml/2016/6/29/349
https://lkml.org/lkml/2016/6/29/350
Sign
Currently the fifo sizes for host/otg mode are defined per platform
and doesn't take the mode into account. So we will get errors
like this:
dwc2 2098.usb: 256 invalid for host_nperio_tx_fifo_size.
dwc2 2098.usb: Setting host_nperio_tx_fifo_size to 32
So add DT properties for these mode s
This patch series is only a draft and not intended to be merged. Patches 1 and 2
aren't bcm2835 specific and should be helpful for other platforms.
The patches 2 - 4 are required for otg / gadget mode. The last patch
based on the work of Lubomir Rintel [1] and Noralf Trønnes [2].
Changes since V1
The Raspberry Pi Zero is a minified version of model A+. It's
notable there is no PWR LED and the ACT LED is inverted.
Signed-off-by: Stefan Wahren
---
arch/arm/boot/dts/Makefile |3 +-
arch/arm/boot/dts/bcm2835-rpi-zero.dts | 57
2 files change
Signed-off-by: Stefan Wahren
---
.../devicetree/bindings/arm/bcm/brcm,bcm2835.txt |4
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt
b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt
index 6ffe087..9c97de2 100644
---
In order to use DWC2 in otg or gadget mode the USB PHY must be
specified. Since there is no bcm283x USB PHY driver use the generic
one.
Signed-off-by: Stefan Wahren
---
arch/arm/boot/dts/bcm283x.dtsi |6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/ar
According to the DWC2 binding an appropriate clock is required.
This clock isn't handled by bcm2835 clock driver, so add a fixed
clock to the bcm283x DT.
Signed-off-by: Stefan Wahren
---
arch/arm/boot/dts/bcm283x.dtsi |9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/
In gadget mode On bcm2835 platform the host tx fifo size could be zero.
So add zero to range and avoid such nonsense errors:
dwc2 2098.usb: 0 invalid for host_nperio_tx_fifo_size.
dwc2 2098.usb: Setting host_nperio_tx_fifo_size to 0
dwc2 2098.usb: 0 invalid for host_perio_tx_fifo_size.
This parameter was not really necessary and gadget drivers would almost always
create an inline function to pass the same value to len and default_len.
So this patch also removes duplicate code from few drivers.
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_hid.c| 1
This change makes sure that the ALSA buffers are cleaned if an endpoint
becomes disabled.
Before this change, if the internal ALSA buffer did overflow, the MIDI
function would stop sending MIDI to the host.
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_midi.c | 27 +
Use gadget's framework allocation function instead of directly calling
usb_ep_alloc_request().
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_hid.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/function/f_hid.c
b/drivers/usb/gadg
We should always use free_ep_req() when allocating requests with
alloc_ep_req().
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_hid.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/function/f_hid.c
b/drivers/usb/gadget/funct
USB spec specifies wMaxPacketSize to be little endian (as other properties),
so when using this variable in the driver we should convert to the current
CPU endianness if necessary.
This patch also introduces usb_ep_align() which does always returns the
aligned buffer size for an endpoint. This is
As discussed with Baolin Wang, Michal Nazarewicz and Felipe Balbi. I propose
the forced buffer alignment of OUT endpoints USB requests. This is implemented
by patches #1 and #2.
That not just simplifies the driver code, but it also prevents nasty bugs when
buflen is not aligned or even less than w
512 is the value used by wMaxPacketSize, as specified by the USB Spec. This
makes sure this driver uses, by default, the most optimal value for IN and OUT
endpoint requests.
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_midi.c | 2 +-
drivers/usb/gadget/legacy/gmidi.c| 2
This refactor results in a cleaner state machine code and promotes
consistency, readability, and maintanability of this driver.
This refactor state machine was well tested and it is currently running in
production code and devices.
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/functio
This parameter was not really necessary and gadget drivers would almost always
create an inline function to pass the same value to len and default_len.
So this patch also removes duplicate code from few drivers.
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_hid.c| 1
Forgot to mention, but changes from v1 is a typo alloc_ep_req().
On 26/07/16 20:18, Felipe F. Tonello wrote:
> This parameter was not really necessary and gadget drivers would almost always
> create an inline function to pass the same value to len and default_len.
>
> So this patch also removes d
The new version of alloc_ep_req() already aligns the buffer size to
wMaxPacketSize on OUT endpoints.
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_midi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c
b/drivers/
Using usb_ep_align() makes sure that the buffer size for OUT endpoints is
always aligned with wMaxPacketSize (512 usually). This makes sure
that no buffer has the wrong size, which can cause nasty bugs.
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/u_f.c | 3 +++
1 file changed, 3 inse
From: Grant Grundler
For the record, I believe I am not the author of these patches.
I believe the original author is
Signed-off-by: Freddy Xin
as recorded in the following code reviews (and testing) that I was
responsible for:
https://chromium-review.googlesource.com/#/q/owner:%22G
On Tue, Jul 26, 2016 at 11:06 AM, Clemens Ladisch wrote:
> Ruslan Bilovol wrote:
>> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote:
> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
> wrote:
>> it may break current usecase for some people
>>>
>>> And what are the benefits th
On Tue, Jul 26, 2016 at 11:53 AM, Jassi Brar wrote:
> On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol
> wrote:
>> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote:
> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
> wrote:
>> it may break current usecase for some people
>>>
>
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote:
...
> Thanks for the feedback (for this patch and the other ones)!
> I'm preparing a v2 and will submit it withing a day or two.
Excellent! very welcome and thanks again for picking this up.
...
>> FTR, current drivers/net/usb/ax88179_178a.c u
On Tue, Jul 26, 2016 at 3:02 PM, Krzysztof Opasiak
wrote:
>
>
> On 07/26/2016 10:53 AM, Jassi Brar wrote:
>> On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol
>> wrote:
>>> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch
>>> wrote:
>> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
>>
Hi Felipe,
On 26 July 2016 at 19:06, Felipe Ferreri Tonello wrote:
> Hi Baolin,
>
> Sorry for not replying for previous emails because for some reason these
> emails were archived. :(
>
> On 12/07/16 10:01, Baolin Wang wrote:
>> Some gadget device (such as dwc3 gadget) requires quirk_ep_out_align
There may be a race condition if f_fs calls unregister_gadget_item in
ffs_closed() when unregister_gadget is called by UDC store at the same time.
this leads to a kernel NULL pointer dereference:
[ 310.644928] Unable to handle kernel NULL pointer dereference at virtual
address 0004
[ 310.64
72 matches
Mail list logo
