On Tue, Jul 12, 2016 at 03:24:49PM +0800, Li Jun wrote:
> As all usb power supply use low active for over current flag on imx6
> imx7 boards, and the default register setting(0) is for high active,
> this patch is to correct it.
>
We may can't ensure all USB power switch chips work like that, I
s
On Tue, Jul 12, 2016 at 03:59:07AM +, Rajesh Bhagat wrote:
> > > +
> > > +err_clks:
> > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev);
> >
> > If you have only one clock, it is unnecessary to use dedicated APIs for
> > clock operation.
> >
>
> We do have multiple clocks, but currently one
On Tue, Jul 12, 2016 at 03:59:14AM +, Rajesh Bhagat wrote:
>
>
> > -Original Message-
> > From: Peter Chen [mailto:hzpeterc...@gmail.com]
> > Sent: Monday, July 11, 2016 12:19 PM
> > To: Rajesh Bhagat
> > Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
> > devicet...@vge
Bin Gao writes:
> This patch implements a simple USB Power Delivery sink port state machine.
> It assumes the hardware only handles PD packet transmitting and receiving
> over the CC line of the USB Type-C connector. The state transition is
> completely controlled by software. This patch only imp
>> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
>> wrote:
>>> it may break current usecase for some people
And what are the benefits that justify breaking the kernel API?
Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majo
> -Original Message-
> From: Peter Chen [mailto:hzpeterc...@gmail.com]
> Sent: Friday, July 15, 2016 12:45 PM
> To: Rajesh Bhagat
> Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
> devicet...@vger.kernel.org; Peter Chen ;
> gre...@linuxfoundation.org; kis...@ti.com; robh...
On Fri, 2016-07-15 at 10:25 +0300, Felipe Balbi wrote:
> > +int pd_sink_queue_msg(struct pd_sink_msg *msg)
> > +{
> > + unsigned long flags;
> > + struct pd_sink_port *port;
> > +
> > + if (msg->port < 0 || msg->port >= MAX_NR_SINK_PORTS) {
> > + pr_err("Invalid port number\
On Fri, 2016-07-15 at 08:14 +0900, Greg KH wrote:
> Doh, nevermind, that's what I get for writing emails early in the
> morning while jet-lagged.
>
> Sorry for the noise, you are correct.
No problem. Do you want me to resubmit?
Regards
Oliver
--
To unsubscribe from this
Now some usb controllers (such as dwc3 controller) need 'XHCI_SLOW_SUSPEND'
quirk when suspending the xhci, thus we need to add 'usb3_slow_suspend' member
in xhci platform data to support this.
Signed-off-by: Baolin Wang
---
drivers/usb/host/xhci-plat.c |3 +++
include/linux/usb/xhci_pdr
When dwc3 core enters into suspend mode, the system (especially for mobile
device) may power off the dwc3 controller for power saving, that will cause
dwc3 controller lost the mode operation when resuming dwc3 core.
Thus we can move the mode setting into dwc3_core_init() function to avoid this
iss
For mobile devices, they usually require very strict power management.
Such as dwc3 controller, we should enter suspend mode when no cable plug in,
then we can power off the dwc3 controller for saving power.
Now dwc3 gadget can support suspend/resume well, but we also want to suspend/
resume the h
For some mobile devices with strict power management, we also want to suspend
the host when the slave is detached for power saving.
Thus we add the host suspend/resume functions to support this requirement, and
we also should enable the 'XHCI_SLOW_SUSPEND' quirk for extraordinary delay when
suspen
It will reset the xhci quirks in xhci_gen_setup() function when xhci try to
add one hcd, thus we need to move the XHCI_LPM_SUPPORT quirk checking after
adding hcd.
Signed-off-by: Baolin Wang
---
drivers/usb/host/xhci-plat.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff -
On Fri, Jul 15, 2016 at 07:38:23AM +, Jun Li wrote:
> Hi,
> > -Original Message-
> > From: Peter Chen [mailto:hzpeterc...@gmail.com]
> > Sent: Friday, July 15, 2016 3:02 PM
> > To: Jun Li
> > Cc: Peter Chen ; linux-usb@vger.kernel.org
> > Subject: Re: [PATCH 2/2] usb: chipidea: usbmisc
On Fri, Jul 15, 2016 at 10:45:36AM +0200, Oliver Neukum wrote:
> On Fri, 2016-07-15 at 08:14 +0900, Greg KH wrote:
> > Doh, nevermind, that's what I get for writing emails early in the
> > morning while jet-lagged.
> >
> > Sorry for the noise, you are correct.
>
> No problem. Do you want me to re
On 15 July 2016 at 08:22, Peter Chen wrote:
> On Fri, Jul 15, 2016 at 07:48:11AM +0200, Rafał Miłecki wrote:
>> >> > Below I supply another thought, please check if it is feasible.
>> >> > In below design, you don't need to change any usb codes.
>> >> >
>> >> > dts:
>> >> >
>> >> > led_1 {
>> >> >
Hi,
Oliver Neukum writes:
> On Fri, 2016-07-15 at 10:25 +0300, Felipe Balbi wrote:
>> > +int pd_sink_queue_msg(struct pd_sink_msg *msg)
>> > +{
>> > + unsigned long flags;
>> > + struct pd_sink_port *port;
>> > +
>> > + if (msg->port < 0 || msg->port >= MAX_NR_SINK_PORTS) {
>> > +
Hi,
Bin Gao writes:
> +static void print_message(int port, bool is_cmsg, u8 msg, bool recv)
> +{
> + pr_info("sink port %d: %s message %s %s\n", port,
> + is_cmsg ? "Control" : "Data",
> + msg_to_string(is_cmsg, msg),
> + r
Hi,
I'm working on a project to support USB headset on a device containing TI
chipset DM8168 SoC. It runs Linux kernel version 2.6.37. The headset works
fine with proper audio when connected to USB 2.0 ports which uses musb host
controller driver. However, when I connect the headset to USB 3.0 por
On Fri, 2016-07-15 at 11:35 +0200, Johan Hovold wrote:
> which I find much harder to parse. We don't always enforce a common
> prefix for function names, making grouping related functions even
> harder.
>
> Usually, what is printed in a debug message only makes sense in
> combination with the func
On Thu, May 12, 2016 at 10:48:32AM +0200, Mathieu OTHACEHE wrote:
> Hi,
>
> The now reverted mxu11x0 turned out to be a copy of ti_usb_3410_5052 driver.
> This aim of this serie is to apply all of the cleanups we did in mxu11x0 to
> ti_usb_3410_5052.
I apologise for the late review of this one. I
On Thu, May 12, 2016 at 10:48:35AM +0200, Mathieu OTHACEHE wrote:
> The definitions in ti_usb_3410_5052.h are only used in
> ti_usb_3410_5052.c.
> The content of the header is copied in ti_usb_3410_5052.c.
>
> Also correct a typo in macro TI_PIPE_MODE_CONTINOUS.
>
> Signed-off-by: Mathieu OTHACEH
On Thu, May 12, 2016 at 03:00:39PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 5/12/2016 11:48 AM, Mathieu OTHACEHE wrote:
>
> > Inline functions are preferable to macros resembling functions.
> >
> > Signed-off-by: Mathieu OTHACEHE
> > ---
> > drivers/usb/serial/ti_usb_3410_5052.c | 16 +
On Thu, May 12, 2016 at 10:48:37AM +0200, Mathieu OTHACEHE wrote:
> ti_read_data_request, ti_read_data_bytes and ti_interrupt are unused.
>
> Signed-off-by: Mathieu OTHACEHE
> ---
> drivers/usb/serial/ti_usb_3410_5052.c | 21 -
> 1 file changed, 21 deletions(-)
>
> diff --gi
On Thu, May 12, 2016 at 10:48:38AM +0200, Mathieu OTHACEHE wrote:
> __uX types should only be used for user-space interactions.
>
> Signed-off-by: Mathieu OTHACEHE
> ---
> drivers/usb/serial/ti_usb_3410_5052.c | 66
> ++-
> 1 file changed, 34 insertions(+), 32 de
On Fri, Jul 15, 2016 at 10:38:04AM +, Goutham BG wrote:
> Hi,
>
> I'm working on a project to support USB headset on a device containing TI
> chipset DM8168 SoC. It runs Linux kernel version 2.6.37.
Wow that's an obsolete and very very old kernel version, many hundreds
of thousands of changes
On Thu, May 12, 2016 at 10:48:39AM +0200, Mathieu OTHACEHE wrote:
> Closing wait delay is configurable per device using TIOCSSERIAL.
Please try to make the commit messages self-contained and not rely on
the commit summary to make sense.
> Also initialise tty_port closing_wait in port_probe with d
On Fri, Jul 15, 2016 at 01:38:12PM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Bin Gao writes:
> > +static void print_message(int port, bool is_cmsg, u8 msg, bool recv)
> > +{
> > + pr_info("sink port %d: %s message %s %s\n", port,
> > + is_cmsg ? "Control" : "Data",
> > +
On Thu, May 12, 2016 at 10:48:40AM +0200, Mathieu OTHACEHE wrote:
> Remove useless or redundant dev_dbg messages.
> Fix debug-message typos.
>
> Signed-off-by: Mathieu OTHACEHE
> ---
> drivers/usb/serial/ti_usb_3410_5052.c | 28 +---
> 1 file changed, 9 insertions(+), 19
On Fri, Jul 15, 2016 at 12:40:45PM +0200, Oliver Neukum wrote:
> On Fri, 2016-07-15 at 11:35 +0200, Johan Hovold wrote:
> > which I find much harder to parse. We don't always enforce a common
> > prefix for function names, making grouping related functions even
> > harder.
> >
> > Usually, what is
We can't assign -EINVAL to a u16.
Fixes: 3948f0e0c999 ('usb: add Freescale QE/CPM USB peripheral controller
driver')
Signed-off-by: Dan Carpenter
diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c
b/drivers/usb/gadget/udc/fsl_qe_udc.c
index 93d28cb..901366f 100644
--- a/drivers/usb/gadget/udc/fs
On Thu, May 12, 2016 at 10:48:44AM +0200, Mathieu OTHACEHE wrote:
> Remove read_bulk_callback, write_bulk_callback, write, write_room,
> chars_in_buffer, throttle and unthrottle callbacks who uselessly
> reimplements generic functions.
>
> Signed-off-by: Mathieu OTHACEHE
> ---
> drivers/usb/seri
Hi,
Greg Kroah-Hartman writes:
> On Fri, Jul 15, 2016 at 01:38:12PM +0300, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Bin Gao writes:
>> > +static void print_message(int port, bool is_cmsg, u8 msg, bool recv)
>> > +{
>> > + pr_info("sink port %d: %s message %s %s\n", port,
>> > +
On Fri, Jul 15, 2016 at 08:14:26PM +0900, Greg KH wrote:
> On Fri, Jul 15, 2016 at 12:40:45PM +0200, Oliver Neukum wrote:
> > On Fri, 2016-07-15 at 11:35 +0200, Johan Hovold wrote:
> > > which I find much harder to parse. We don't always enforce a common
> > > prefix for function names, making grou
On Thu, May 12, 2016 at 10:48:48AM +0200, Mathieu OTHACEHE wrote:
> Use bulk_out_size instead of recalculate it with kfifo_size
>
> Signed-off-by: Mathieu OTHACEHE
> ---
> drivers/usb/serial/ti_usb_3410_5052.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/
On Thu, May 12, 2016 at 10:48:49AM +0200, Mathieu OTHACEHE wrote:
> The generic driver doesn't call tty_wakeup in
> usb_serial_generic_msr_changed so this tty_wakeup seems useless.
While we strive to have the generic implementation as complete as
possible, it not doing something does not mean it m
On Thu, May 12, 2016 at 10:48:50AM +0200, Mathieu OTHACEHE wrote:
> Remove useless ti_device pointer, and change addr to u32.
> Move function upper to avoid function prototyping.
That's just noise. Having an occasional prototype is just fine. You may
want to consider reordering functions for the f
> -Original Message-
> From: Peter Chen [mailto:hzpeterc...@gmail.com]
> Sent: Friday, July 15, 2016 12:43 PM
> To: Rajesh Bhagat
> Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
> devicet...@vger.kernel.org; Peter Chen ;
> gre...@linuxfoundation.org; kis...@ti.com; robh...
On Fri, Jul 15, 2016 at 08:26:25PM +0900, Greg Kroah-Hartman wrote:
> On Fri, Jul 15, 2016 at 08:14:26PM +0900, Greg KH wrote:
> > On Fri, Jul 15, 2016 at 12:40:45PM +0200, Oliver Neukum wrote:
> > > On Fri, 2016-07-15 at 11:35 +0200, Johan Hovold wrote:
> > > > which I find much harder to parse. W
On Thu, May 12, 2016 at 10:48:53AM +0200, Mathieu OTHACEHE wrote:
> Use usb_serial_generic_close in close callback.
>
> Signed-off-by: Mathieu OTHACEHE
> ---
> drivers/usb/serial/ti_usb_3410_5052.c | 12 ++--
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb
On Thu, May 12, 2016 at 10:48:54AM +0200, Mathieu OTHACEHE wrote:
> It is sufficient to pass usb_serial_port structure to ti_get_serial_info
> and ti_set_serial_info.
>
> Also move functions above ioctl to avoid function prototyping
> and use unsigned int instead of unsigned for cwait variable.
A
On Thu, May 12, 2016 at 10:48:56AM +0200, Mathieu OTHACEHE wrote:
> Use usb_serial_generic_open in open callback to start read urb.
> Also remove useless usb_device pointer.
>
> Signed-off-by: Mathieu OTHACEHE
> ---
> drivers/usb/serial/ti_usb_3410_5052.c | 21 -
> 1 file cha
On Thu, May 12, 2016 at 10:48:57AM +0200, Mathieu OTHACEHE wrote:
> The old_termios parameter is never used in set_termios callback.
There we go. :)
> Add a check to old_termios to see if we can return right away because
> there is nothing to change.
> Add a check to old_termios CBAUD to see if w
On Thu, May 12, 2016 at 10:49:07AM +0200, Mathieu OTHACEHE wrote:
> Declare functions in a the right order to avoid prototyping.
> There is no functional change here.
I'm not sure this is needed.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of
On Fri, Jul 15, 2016 at 12:48:25PM +0200, Johan Hovold wrote:
> On Thu, May 12, 2016 at 10:48:32AM +0200, Mathieu OTHACEHE wrote:
> > Hi,
> >
> > The now reverted mxu11x0 turned out to be a copy of ti_usb_3410_5052 driver.
> > This aim of this serie is to apply all of the cleanups we did in mxu11x
On Thu, May 19, 2016 at 07:34:36PM +0530, Muhammad Falak R Wani wrote:
> Use kmemdup when some other buffer is immediately copied into allocated
> region. It replaces call to allocation followed by memcpy, by a single
> call to kmemdup.
>
> Signed-off-by: Muhammad Falak R Wani
Now applied, thank
On Mon, Jun 06, 2016 at 12:38:17PM +0200, Daniele Palmas wrote:
> This patch adds support for 0x1206 PID of Telit LE910.
>
> Since the interfaces positions are the same than the ones for
> 0x1043 PID of Telit LE922, telit_le922_blacklist_usbcfg3 is used.
>
> Signed-off-by: Daniele Palmas
Now ap
On Thu, Jul 14, 2016 at 03:01:40PM +0200, Oliver Neukum wrote:
> This patch turns status in a variable read once from the URB.
> The long term plan is to deliver status to the callback.
> In addition it makes the code a bit more elegant.
>
> Signed-off-by: Oliver Neukum
I've applied this one, an
Fix io submissions failing with ENODEV.
Signed-off-by: Mathieu Laurendeau
Fixes: 7fe3976e0f3a ("gadget: switch ep_io_operations to
->read_iter/->write_iter")
---
drivers/usb/gadget/legacy/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/legacy/inode
Hi again,
Felipe Balbi writes:
> Oliver Neukum writes:
>> On Fri, 2016-07-15 at 10:25 +0300, Felipe Balbi wrote:
>>> > +int pd_sink_queue_msg(struct pd_sink_msg *msg)
>>> > +{
>>> > + unsigned long flags;
>>> > + struct pd_sink_port *port;
>>> > +
>>> > + if (msg->port < 0 || msg->p
> -Original Message-
> From: Peter Chen [mailto:hzpeterc...@gmail.com]
> Sent: Friday, July 15, 2016 5:21 PM
> To: Jun Li
> Cc: Peter Chen ; linux-usb@vger.kernel.org
> Subject: Re: [PATCH 2/2] usb: chipidea: usbmisc: set over current polarity
> for imx6 and imx7
>
> On Fri, Jul 15, 201
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.
Signed-off-by: Philippe Reynes
---
drivers/net/usb/ax88172a.c | 22 ++
1 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/
On Thu, 14 Jul 2016, Warren Postma wrote:
> I am also able to reproduce this USB disconnect glitch on a Dell Xeon
> workstation. Is there any way I can get more verbose output to dmesg:
>
>
> On Sat, Jun 25, 2016 at 12:29:39PM +,
> bugzilla-dae...@bugzilla.kernel.org wrote:
> > https://bugz
On Fri, 2016-07-15 at 13:52 +0200, Johan Hovold wrote:
> > Johan, how are you enabling dynamic debug for these modules? If you
> > just use "+p" no function name should be there, you have to add
> "+mf" to
> > get module and function names, right?
>
> Usually I just use "+p", but I could start us
Hi,
> -Original Message-
> From: Peter Chen [mailto:hzpeterc...@gmail.com]
> Sent: Friday, July 15, 2016 3:02 PM
> To: Jun Li
> Cc: Peter Chen ; linux-usb@vger.kernel.org
> Subject: Re: [PATCH 2/2] usb: chipidea: usbmisc: set over current polarity
> for imx6 and imx7
>
> On Tue, Jul 12, 2
Hi,
[auto build test ERROR on balbi-usb/next]
[cannot apply to v4.7-rc7 next-20160715]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Baolin-Wang/Support-dwc3-host-suspend-resume/20160715
From: Bjørn Mork
> Sent: 13 July 2016 23:23
...
> Or how about the more generic?:
>
> if (bp[0] & 0x02)
> eth_hw_addr_random(net);
> else
> ether_addr_copy(net->dev_addr, bp);
>
> That would catch similar screwups from other vendors too.
Not really, that
David Laight writes:
> From: Bjørn Mork
>> Sent: 13 July 2016 23:23
> ...
>> Or how about the more generic?:
>>
>> if (bp[0] & 0x02)
>> eth_hw_addr_random(net);
>> else
>> ether_addr_copy(net->dev_addr, bp);
>>
>> That would catch similar screwups from othe
Hi,
[auto build test ERROR on balbi-usb/next]
[cannot apply to v4.7-rc7 next-20160715]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Baolin-Wang/Support-dwc3-host-suspend-resume/20160715
From: Oliver Neukum
Date: Thu, 14 Jul 2016 15:41:29 +0200
> Experience has shown that making all CDC drivers depend on usbnet
> is not practical, because some of them are not network drivers.
> So this patch moves the common parser from usbnet into the messages
> helpers of usbcore.
> The rest of
> "Hans" == Hans de Goede writes:
Hans> Oliver Neukum is taking over uas maintainership from me and Gerd
Hans> Hoffmann.
Applied to 4.8/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a m
On Fri, 15 Jul 2016, Rafał Miłecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
>
This commit adds a new trigger that can turn on LED when USB device gets
connected to the USB port. This can be useful for various home routers
that have USB port and a proper LED telling user a device is connected.
Right now this trigger is usable with a proper DT only, there isn't a
way to speci
From: Grant Grundler
Date: Thu, 14 Jul 2016 11:27:16 -0700
> ethtool -i provides a driver version that is hard coded.
> Export the same value via "modinfo".
>
> Signed-off-by: Grant Grundler
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a messa
On Fri, Jul 15, 2016 at 2:25 PM, David Miller wrote:
> From: Grant Grundler
> Date: Thu, 14 Jul 2016 11:27:16 -0700
>
>> ethtool -i provides a driver version that is hard coded.
>> Export the same value via "modinfo".
>>
>> Signed-off-by: Grant Grundler
>
> Applied.
Excellent - thank you. :)
g
On Fri, Jul 15, 2016 at 11:51:47AM -0700, David Miller wrote:
> From: Oliver Neukum
> Date: Thu, 14 Jul 2016 15:41:29 +0200
>
> > Experience has shown that making all CDC drivers depend on usbnet
> > is not practical, because some of them are not network drivers.
> > So this patch moves the commo
On Fri, Jul 15, 2016 at 08:31:08AM +0200, Oliver Neukum wrote:
> > +static void ack_message(struct pd_sink_port *port, int msg_id)
> > +{
> > + struct pd_msg_header *header = kzalloc(PD_MSG_HEADER_LEN, GFP_KERNEL);
>
> This must be GFP_NOIO. We are in a cycle that can lead to deadlock.
>
> Assu
On Fri, Jul 15, 2016 at 02:21:48PM +0300, Felipe Balbi wrote:
> Greg Kroah-Hartman writes:
> > On Fri, Jul 15, 2016 at 01:38:12PM +0300, Felipe Balbi wrote:
> >>
> >> Hi,
> >>
> >> Bin Gao writes:
> >> > +static void print_message(int port, bool is_cmsg, u8 msg, bool recv)
> >> > +{
> >> > +
On Fri, Jul 15, 2016 at 10:25:36AM +0300, Felipe Balbi wrote:
> Bin Gao writes:
>
> > This patch implements a simple USB Power Delivery sink port state machine.
> > It assumes the hardware only handles PD packet transmitting and receiving
> > over the CC line of the USB Type-C connector. The stat
On Fri, Jul 15, 2016 at 03:41:10PM -0700, Bin Gao wrote:
> On Fri, Jul 15, 2016 at 02:21:48PM +0300, Felipe Balbi wrote:
> > Greg Kroah-Hartman writes:
> > > On Fri, Jul 15, 2016 at 01:38:12PM +0300, Felipe Balbi wrote:
> > >>
> > >> Hi,
> > >>
> > >> Bin Gao writes:
> > >> > +static void print
On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote:
> Describes the qoriq usb 2.0 controller driver binding, currently used
> for LS1021A and LS1012A platform.
>
> Signed-off-by: Rajesh Bhagat
> ---
> Changes in v2:
> - Adds DT binding documentation for qoriq usb 2.0 controller
> -
On Sat, Jul 09, 2016 at 10:00:55AM +0530, Rajesh Bhagat wrote:
> Describes the qoriq usb 2.0 phy driver binding, currently used
> for LS1021A and LS1012A platform.
>
> Signed-off-by: Rajesh Bhagat
> ---
> Changes in v2:
> - Adds DT binding documentation for qoriq usb 2.0 phy
> - Changed the com
In 'composite_os_desc_req_prepare', if one of the memory allocations fail,
0 will be returned, which means success.
We should return -ENOMEM instead.
Signed-off-by: Christophe JAILLET
---
drivers/usb/gadget/composite.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
'cdev->os_desc_req' has been allocated with 'usb_ep_alloc_request' so
'usb_ep_free_request' should be used to free it.
Signed-off-by: Christophe JAILLET
---
drivers/usb/gadget/composite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/composite.c b/drivers
'cdev->os_desc_req' has been allocated with 'usb_ep_alloc_request' so
'usb_ep_free_request' should be used to free it.
Signed-off-by: Christophe JAILLET
---
drivers/usb/gadget/composite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/composite.c b/drivers
75 matches
Mail list logo
