Hi Bjørn,
On Thu, Jul 14, 2016 at 12:23 AM, Bjørn Mork wrote:
>
> Or how about the more generic?:
>
> if (bp[0] & 0x02)
> eth_hw_addr_random(net);
> else
> ether_addr_copy(net->dev_addr, bp);
>
> That would catch similar screwups from other vendors
On Thu, Jul 14, 2016 at 9:54 AM, Kristian Evensen
wrote:
> Hi Bjørn,
>
> On Thu, Jul 14, 2016 at 12:23 AM, Bjørn Mork wrote:
>>
>> Or how about the more generic?:
>>
>> if (bp[0] & 0x02)
>> eth_hw_addr_random(net);
>> else
>> ether_addr_copy(net->de
From: Kristian Evensen
Some devices of the same type all export the same, random MAC address. This
behavior has been seen on the ZTE MF910, MF823 and MF831, and there are
probably more devices out there. Fix this by generating a valid random MAC
address if we read a random MAC from device.
Also,
Oliver Neukum writes:
> The dependencies were impossible to handle preventing
> drivers for CDC devices not which are not network drivers
> from using the common parser.
>
> Signed-off-by: Oliver Neukum
> ---
> drivers/net/usb/usbnet.c | 138
> drivers
Generic phy support added in xhci platform driver.
In the case of multiple phys to the xhci controller, this approach
is helpful to pass multiple phandles to xhci platform driver from
xhci device node.
Signed-off-by: Srinath Mannam
Reviewed-by: Ray Jui
Reviewed-by: Scott Branden
diff --git a/d
++ Felipe Balbi
Thanks & Regards,
Srinath Mannam.
On Thu, Jul 14, 2016 at 2:03 PM, Srinath Mannam
wrote:
> Generic phy support added in xhci platform driver.
> In the case of multiple phys to the xhci controller, this approach
> is helpful to pass multiple phandles to xhci platform driver from
>
This series add support for rockchip dwc3 driver,
and add additional optional properties for specific
platforms (e.g., rockchip rk3399 platform).
William Wu (5):
usb: dwc3: of-simple: add compatible for rockchip rk3399
usb: dwc3: add dis_u2_freeclk_exists_quirk
usb: dwc3: make usb2 phy utmi
Add snps,phyif-utmi-width devicetree property to configure
the UTMI+ PHY with an 8- or 16-bit interface. UTMI+ PHY
interface is a hardware property, and it's platform dependent.
Normally,the PHYIF can be configured during coreconsultant.
But for some specific USB cores(e.g. rk3399 SoC DWC3), the
de
Add a quirk to clear the GUSB2PHYCFG.U2_FREECLK_EXISTS bit,
which specifies whether the USB2.0 PHY provides a free-running
PHY clock, which is active when the clock control input is active.
Signed-off-by: William Wu
---
Changes in v7:
- None
Changes in v6:
- use '-' instead of '_' in dts (Rob He
Add a quirk to clear the GUSB3PIPECTL.DELAYP1TRANS bit,
which specifies whether disable delay PHY power change
from P0 to P1/P2/P3 when link state changing from U0
to U1/U2/U3 respectively.
Signed-off-by: William Wu
---
Changes in v7:
- None
Changes in v6:
- use '-' instead of '_' in dts (Rob He
Rockchip platform merely enable usb3 clocks and
populate its children. So we can use this generic
glue layer to support Rockchip dwc3.
Signed-off-by: William Wu
---
Changes in v7:
- None
Changes in v6:
- None
Changes in v5:
- change compatible from "rockchip,dwc3" to "rockchip,rk3399-dwc3" (Hei
This patch adds the devicetree documentation required for Rockchip
USB3.0 core wrapper consisting of USB3.0 IP from Synopsys.
It supports DRD mode, and could operate in device mode (SS, HS, FS)
and host mode (SS, HS, FS, LS).
Signed-off-by: William Wu
Acked-by: Rob Herring
---
Changes in v7:
-
Oliver Neukum writes:
> This introduces the common parser for extra CDC headers now that it no longer
> depends on usbnet.
>
> Signed-off-by: Oliver Neukum
> ---
> drivers/usb/class/cdc-acm.c | 68
> +++--
> 1 file changed, 10 insertions(+), 58 deletions
Oliver Neukum writes:
> Now that the common parser resides in USB core, it can
> be used for CDC-WDM.
Looking good to me. Nice code reduction without any additional cost
here.
Reviewed-by: Bjørn Mork
Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body o
Oliver Neukum writes:
> A small update to unify error handling during probe().
>
> Signed-off-by: Oliver Neukum
> ---
> drivers/usb/class/cdc-acm.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index
This patch turns status in a variable read once from the URB.
The long term plan is to deliver status to the callback.
In addition it makes the code a bit more elegant.
Signed-off-by: Oliver Neukum
---
drivers/usb/serial/generic.c | 18 ++
1 file changed, 10 insertions(+), 8 dele
Oliver Neukum writes:
> @@ -360,22 +361,22 @@ void usb_serial_generic_read_bulk_callback(struct urb
> *urb)
>
> dev_dbg(&port->dev, "%s - urb %d, len %d\n", __func__, i,
> urb->actual_length);
> - switch (urb->status) {
> + sw
On Wed, Jul 13, 2016 at 04:40:53PM +0200, Rafał Miłecki wrote:
> On 13 July 2016 at 15:50, Felipe Balbi wrote:
> > Rafał Miłecki writes:
> >> On 13 July 2016 at 15:20, Felipe Balbi
> >> wrote:
> >>> Rafał Miłecki writes:
> Hi again,
>
> This is my second try of getting HCD provi
Hi,
Srinath Mannam writes:
> Generic phy support added in xhci platform driver.
> In the case of multiple phys to the xhci controller, this approach
> is helpful to pass multiple phandles to xhci platform driver from
> xhci device node.
>
> Signed-off-by: Srinath Mannam
> Reviewed-by: Ray Jui
Hi,
Peter Chen writes:
> On Wed, Jul 13, 2016 at 04:40:53PM +0200, Rafał Miłecki wrote:
>> On 13 July 2016 at 15:50, Felipe Balbi wrote:
>> > Rafał Miłecki writes:
>> >> On 13 July 2016 at 15:20, Felipe Balbi
>> >> wrote:
>> >>> Rafał Miłecki writes:
>> Hi again,
>>
>> This i
Oliver Neukum is taking over uas maintainership from me and
Gerd Hoffmann.
Cc: Oliver Neukum
Cc: Gerd Hoffmann
Signed-off-by: Hans de Goede
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5c728d1..9c220f0 100644
--- a/MAINTA
On Thu, 2016-07-14 at 14:26 +0200, Hans de Goede wrote:
> Oliver Neukum is taking over uas maintainership from me and
> Gerd Hoffmann.
>
> Cc: Oliver Neukum
> Cc: Gerd Hoffmann
> Signed-off-by: Hans de Goede
Acked-by: Oliver Neukum
--
To unsubscribe from this list: send the line "unsubscribe
This patch turns status in a variable read once from the URB.
The long term plan is to deliver status to the callback.
In addition it makes the code a bit more elegant.
Signed-off-by: Oliver Neukum
---
drivers/usb/serial/generic.c | 18 ++
1 file changed, 10 insertions(+), 8 dele
dev_dbg() already can state the function name.
No need to state it again explicitly.
Signed-off-by: Oliver Neukum
---
drivers/usb/serial/visor.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
index 337a0be..
dev_dbg() already can state the function name.
No need to state it again explicitly.
Signed-off-by: Oliver Neukum
---
drivers/usb/serial/whiteheat.c | 37 ++---
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/whiteheat.c b/driver
dev_dbg() already can state the function name.
No need to state it again explicitly.
Signed-off-by: Oliver Neukum
---
drivers/usb/serial/usb_wwan.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_ww
This assigns urb->status to a variable and as Bjorn notes,
these drivers were often mechanically converted to dev_dbg and abuse it.
So here's a cleanup.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info
dev_dbg already states the function it is called from. Printing
it again is wasted space.
Signed-off-by: Oliver Neukum
---
drivers/usb/serial/generic.c | 33 +
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/serial/generic.c b/drivers/u
Now that the common parser resides in USB core, it can
be used for CDC-WDM.
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-wdm.c | 30 +-
1 file changed, 5 insertions(+), 25 deletions(-)
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
i
This introduces the common parser for extra CDC headers now that it no longer
depends on usbnet.
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 69 +++--
1 file changed, 10 insertions(+), 59 deletions(-)
diff --git a/drivers/usb/class/cdc-
The dependencies were impossible to handle preventing
drivers for CDC devices not which are not network drivers
from using the common parser.
Signed-off-by: Oliver Neukum
---
drivers/net/usb/usbnet.c | 138
drivers/usb/core/message.c | 153 +
This removes some overly long lines by renaming variables and giving
them local scope.
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 44
1 file changed, 24 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/dri
Experience has shown that making all CDC drivers depend on usbnet
is not practical, because some of them are not network drivers.
So this patch moves the common parser from usbnet into the messages
helpers of usbcore.
The rest of the series applies it to the non-network CDC drivers.
I hope it can
A small update to unify error handling during probe().
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 70bd642..1857fad 100644
--- a/drivers/us
On Wed, 13 Jul 2016, Rafał Miłecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
>
On Thu, 14 Jul 2016, Huang, Huki wrote:
> On Mon, 11 Jul 2016: Alan Stern wrote:
>
> > On Mon, 11 Jul 2016, Huang, Huki wrote:
>
> > > When end user inserts a usb3 device and put dut to s3.
>
> > What does "dut" mean?
>
> DUT : Device under test
Don't call it that in the patch description. "
On Do, 2016-07-14 at 14:26 +0200, Hans de Goede wrote:
> Oliver Neukum is taking over uas maintainership from me and
> Gerd Hoffmann.
>
> Cc: Oliver Neukum
> Cc: Gerd Hoffmann
> Signed-off-by: Hans de Goede
Acked-by: Gerd Hoffmann
--
To unsubscribe from this list: send the line "unsubscribe
On 14 July 2016 at 16:11, Alan Stern wrote:
> On Wed, 13 Jul 2016, Rafał Miłecki wrote:
>
>> Probing function was using &dev->dev and dev->dev.of_node over 20 times
>> so I believe it made sense to use helper variables for both of them.
>> To avoid some uncommon variable name for struct device I f
On 14 July 2016 at 11:48, Peter Chen wrote:
> On Wed, Jul 13, 2016 at 04:40:53PM +0200, Rafał Miłecki wrote:
>> On 13 July 2016 at 15:50, Felipe Balbi wrote:
>> > Rafał Miłecki writes:
>> >> On 13 July 2016 at 15:20, Felipe Balbi
>> >> wrote:
>> >>> Rafał Miłecki writes:
>> Hi again,
>>
ethtool -i provides a driver version that is hard coded.
Export the same value via "modinfo".
Signed-off-by: Grant Grundler
---
drivers/net/usb/r8152.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 0da72d3..1c01ed5 100644
--- a/driver
Hi!
I'm trying to get working USBIP server on 3.16.0 kernel and winxp
client (windows driver is from sf.net).
I did 'usbip attach' to my device (hp scanner) on server and started
usbipd. Windows machine can successfully obtain list of devices
available on server, but when I'm trying to attach it
Ping?
On Wed, Jun 8, 2016 at 11:03 AM, Ruslan Bilovol
wrote:
> Hi guys,
>
> Any feedback on this patch series? Has anybody had a chance to test it?
>
> Regards,
> Ruslan
>
> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
> wrote:
>> I came to this patch series when wanted to do two things:
>>
On Thu, Jul 14, 2016 at 03:01:44PM +0200, Oliver Neukum wrote:
> dev_dbg() already can state the function name.
No it doesn't. It shows the device, and driver bound to that device,
but not a function name.
> No need to state it again explicitly.
I think it might still be needed here, if the str
On Thu, Jul 14, 2016 at 03:01:41PM +0200, Oliver Neukum wrote:
> dev_dbg already states the function it is called from. Printing
> it again is wasted space.
Nope, it's not printed "again", test it and see :)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a
On Thu, Jul 14, 2016 at 03:01:43PM +0200, Oliver Neukum wrote:
> dev_dbg() already can state the function name.
> No need to state it again explicitly.
Nope, not true :)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
Mo
On Thu, Jul 14, 2016 at 03:01:42PM +0200, Oliver Neukum wrote:
> dev_dbg() already can state the function name.
> No need to state it again explicitly.
Same comment as before...
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kerne
On Fri, 2016-07-15 at 06:45 +0900, Greg KH wrote:
> On Thu, Jul 14, 2016 at 03:01:41PM +0200, Oliver Neukum wrote:
> > dev_dbg already states the function it is called from. Printing
> > it again is wasted space.
>
> Nope, it's not printed "again", test it and see :)
>
>
echo -n "module usbcore
On Fri, Jul 15, 2016 at 12:06:55AM +0200, Oliver Neukum wrote:
> On Fri, 2016-07-15 at 06:45 +0900, Greg KH wrote:
> > On Thu, Jul 14, 2016 at 03:01:41PM +0200, Oliver Neukum wrote:
> > > dev_dbg already states the function it is called from. Printing
> > > it again is wasted space.
> >
> > Nope,
Greg KH writes:
> On Thu, Jul 14, 2016 at 03:01:44PM +0200, Oliver Neukum wrote:
>> dev_dbg() already can state the function name.
>
> No it doesn't. It shows the device, and driver bound to that device,
> but not a function name.
Use dynamic debugging. You can have the function name, line numb
On Thu, 14 Jul 2016, Rafał Miłecki wrote:
> > Okay except for...
> >
> >> - priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
> >> - "phys", "#phy-cells");
> >> + priv->num_phys = of_count_phandle_with_args(np, "phys",
> >> +
I am also able to reproduce this USB disconnect glitch on a Dell Xeon
workstation. Is there any way I can get more verbose output to dmesg:
On Sat, Jun 25, 2016 at 12:29:39PM +,
bugzilla-dae...@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=120981
>
> Bu
On Fri, Jul 15, 2016 at 02:36:27AM +0200, Bjørn Mork wrote:
> Greg KH writes:
> > On Thu, Jul 14, 2016 at 03:01:44PM +0200, Oliver Neukum wrote:
> >> dev_dbg() already can state the function name.
> >
> > No it doesn't. It shows the device, and driver bound to that device,
> > but not a function
This series introduce a USB PD(Power Delivery) sink port simple state
machine driver and adds USB PD sink port support for Intel BXT Whiskey
Cove PMIC Type-C phy driver.
This series depends on these two patches:
https://lkml.org/lkml/2016/6/29/349
https://lkml.org/lkml/2016/6/29/350
Bin Gao (1):
This patch implements a simple USB Power Delivery sink port state machine.
It assumes the hardware only handles PD packet transmitting and receiving
over the CC line of the USB Type-C connector. The state transition is
completely controlled by software. This patch only implement the sink port
funct
From: Chandra Sekhar Anagani
This adds PD sink port support for the USB Type-C PHY on Intel WhiskeyCove
PMIC which is available on some of the Intel Broxton SoC based platforms.
This patch depends on these two patches:
https://lkml.org/lkml/2016/6/29/349
https://lkml.org/lkml/2016/6/29/350
Sign
On Thu, Jul 14, 2016 at 05:52:43PM +0200, Rafał Miłecki wrote:
> On 14 July 2016 at 11:48, Peter Chen wrote:
> > On Wed, Jul 13, 2016 at 04:40:53PM +0200, Rafał Miłecki wrote:
> >> On 13 July 2016 at 15:50, Felipe Balbi
> >> wrote:
> >> > Rafał Miłecki writes:
> >> >> On 13 July 2016 at 15:20,
Probing function was using &dev->dev and dev->dev.of_node over 20 times
so I believe it made sense to use helper variables for both of them.
To avoid some uncommon variable name for struct device I first replaced
existing dev variable with pdev.
Signed-off-by: Rafał Miłecki
Acked-by: Alan Stern
Probing function was using &dev->dev and dev->dev.of_node over 20 times
so I believe it made sense to use helper variables for both of them.
To avoid some uncommon variable name for struct device I first replaced
existing dev variable with pdev.
Signed-off-by: Rafał Miłecki
---
drivers/usb/host/
On 15 July 2016 at 04:28, Peter Chen wrote:
> On Thu, Jul 14, 2016 at 05:52:43PM +0200, Rafał Miłecki wrote:
>> On 14 July 2016 at 11:48, Peter Chen wrote:
>> > On Wed, Jul 13, 2016 at 04:40:53PM +0200, Rafał Miłecki wrote:
>> >> Thanks for your effort and looking at this closely. You're right, I
On Thu, Jul 14, 2016 at 09:13:28PM -0400, Warren Postma wrote:
> I am also able to reproduce this USB disconnect glitch on a Dell Xeon
> workstation. Is there any way I can get more verbose output to dmesg:
>
>
> On Sat, Jun 25, 2016 at 12:29:39PM +,
> bugzilla-dae...@bugzilla.kernel.org wro
On Fri, Jul 15, 2016 at 07:48:11AM +0200, Rafał Miłecki wrote:
> >> > Below I supply another thought, please check if it is feasible.
> >> > In below design, you don't need to change any usb codes.
> >> >
> >> > dts:
> >> >
> >> > led_1 {
> >> > led_gpio_1;
> >> > usb_port = &ohci_p
On Thu, 2016-07-14 at 19:14 -0700, Bin Gao wrote:
> This patch implements a simple USB Power Delivery sink port state machine.
> It assumes the hardware only handles PD packet transmitting and receiving
> over the CC line of the USB Type-C connector. The state transition is
> completely controlled
On Wed, Jul 13, 2016 at 01:14:33PM +0300, Dan Carpenter wrote:
> The udc->eps[] array has USB_MAX_ENDPOINTS elements so > should be >=.
>
> Fixes: 3948f0e0c999 ('usb: add Freescale QE/CPM USB peripheral controller
> driver')
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/usb/gadget/udc
63 matches
Mail list logo
