Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Heikki Krogerus
Hi Guenter, On Thu, Jun 30, 2016 at 03:02:20PM -0700, Guenter Roeck wrote: > > +static ssize_t > > +preferred_role_store(struct device *dev, struct device_attribute *attr, > > +const char *buf, size_t size) > > +{ > > + struct typec_port *port = to_typec_port(dev); > > + enum t

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Heikki Krogerus
On Thu, Jun 30, 2016 at 10:10:25AM -0700, Guenter Roeck wrote: > On Wed, Jun 29, 2016 at 04:38:37PM +0300, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status and > > basic information about USB Type-C connect

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> NOP_USB_XCEIV is used not only by gadget drivers but by >>> host drivers as well e.g. EHCI_OMAP. >>> >>> commit 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") >>> made it so that NOP_USB_XCEIV can't be built-in if USB_GADGET is 'm'. >>> But this

RE: ftdi_sio: overrun errors

2016-07-01 Thread David Laight
From: Michael Walle ... > What comes directly to my mind is the handling of the break condition. > Can't look into that at the moment. But if break conditions are > translated into status-only packets, how are two consecutive breaks > recognized. Ie. if the break condition flag is sticky (until a n

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Roger Quadros
On 01/07/16 10:57, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: NOP_USB_XCEIV is used not only by gadget drivers but by host drivers as well e.g. EHCI_OMAP. commit 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") made it so that NOP_USB_XCEIV

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Felipe Balbi
Hi, Roger Quadros writes: > NOP_USB_XCEIV is used not only by gadget drivers but by > host drivers as well e.g. EHCI_OMAP. > > commit 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") > made it so that NOP_USB_XCEIV can't be built-in if USB_GADGET is 'm'. >>

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Roger Quadros
On 01/07/16 11:15, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> NOP_USB_XCEIV is used not only by gadget drivers but by >> host drivers as well e.g. EHCI_OMAP. >> >> commit 5a8d651a2bde ("usb: gadget: move gadget API functions to >> udc-core") >> made it so t

[PATCH 0/3] usb: gadget: fix several coverity warnings

2016-07-01 Thread Peter Chen
Hi Felipe, Below three patches are fixes for warning which are found during coverity code scan, all for dereference after null pointer check. Peter Chen (3): usb: gadget: composite: fix dereference after null check coverify warning usb: gadget: u_ether: fix dereference after null check co

[PATCH 3/3] usb: gadget: u_ether: fix dereference after null check coverify warning

2016-07-01 Thread Peter Chen
skb is checked for null pointer at above code, so skb might be null. eem_wrap uses it without checking null pointer, fix it by adding null pointer check. Signed-off-by: Peter Chen --- drivers/usb/gadget/function/u_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH 1/3] usb: gadget: composite: fix dereference after null check coverify warning

2016-07-01 Thread Peter Chen
cdev->config is checked for null pointer at above code, so cdev->config might be null, fix it by adding null pointer check. Signed-off-by: Peter Chen --- drivers/usb/gadget/composite.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/compo

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> NOP_USB_XCEIV is used not only by gadget drivers but by >>> host drivers as well e.g. EHCI_OMAP. >>> >>> commit 5a8d651a2bde ("usb: gadget: move gadget API functions to >>> udc-core") >>> made it so that NOP_USB_XCEIV can't be built-in if US

[RFC] usb: phy: generic: get rid of VBUS handling

2016-07-01 Thread Felipe Balbi
Hi Robert, your commit 7acc9973e3c4 ("usb: phy: generic: add vbus support") added GPIO-based VBUS handling for phy-generic.c, but that ends up calling usb_gadget_vbus_connect() which forces NOP to depend on the gadget API. I was grepping around and couldn't find any users for that VBUS gpio _and

Re: [PATCH net] r8152: clear LINK_OFF_WAKE_EN after autoresume

2016-07-01 Thread David Miller
From: Hayes Wang Date: Thu, 30 Jun 2016 15:33:35 +0800 > LINK_OFF_WAKE_EN should be cleared after autoresume, otherwise after > system suspend, the system would wake up when linking off occurs. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Roger Quadros
On 01/07/16 12:41, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: NOP_USB_XCEIV is used not only by gadget drivers but by host drivers as well e.g. EHCI_OMAP. commit 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core")

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Heikki Krogerus
On Fri, Jul 01, 2016 at 10:13:48AM +0300, Heikki Krogerus wrote: > Hi Guenter, > > On Thu, Jun 30, 2016 at 03:02:20PM -0700, Guenter Roeck wrote: > > > +static ssize_t > > > +preferred_role_store(struct device *dev, struct device_attribute *attr, > > > + const char *buf, size_t size)

Re: [RFC] usb: phy: generic: get rid of VBUS handling

2016-07-01 Thread Robert Jarzmik
Felipe Balbi writes: > Hi Robert, > > your commit 7acc9973e3c4 ("usb: phy: generic: add vbus support") added > GPIO-based VBUS handling for phy-generic.c, but that ends up calling > usb_gadget_vbus_connect() which forces NOP to depend on the gadget API. > > I was grepping around and couldn't find

[PATCH 2/3] usb: gadget: u_ether: fix dereference after null check coverify warning

2016-07-01 Thread Peter Chen
dev->port_usb is checked for null pointer at above code, so dev->port_usb might be null, fix it by adding null pointer check. Signed-off-by: Peter Chen --- drivers/usb/gadget/function/u_ether.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/u_et

Re: [RFC] usb: phy: generic: get rid of VBUS handling

2016-07-01 Thread Felipe Balbi
Hi, Robert Jarzmik writes: >> your commit 7acc9973e3c4 ("usb: phy: generic: add vbus support") added >> GPIO-based VBUS handling for phy-generic.c, but that ends up calling >> usb_gadget_vbus_connect() which forces NOP to depend on the gadget API. >> >> I was grepping around and couldn't find an

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Guenter Roeck
On Fri, Jul 01, 2016 at 03:05:35PM +0300, Heikki Krogerus wrote: > On Fri, Jul 01, 2016 at 10:13:48AM +0300, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Thu, Jun 30, 2016 at 03:02:20PM -0700, Guenter Roeck wrote: > > > > +static ssize_t > > > > +preferred_role_store(struct device *dev, struc

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Guenter Roeck
On Fri, Jul 01, 2016 at 10:38:03AM +0300, Heikki Krogerus wrote: > On Thu, Jun 30, 2016 at 10:10:25AM -0700, Guenter Roeck wrote: > > On Wed, Jun 29, 2016 at 04:38:37PM +0300, Heikki Krogerus wrote: > > > The purpose of USB Type-C connector class is to provide > > > unified interface for the user s

Re: [GIT PULL] usb: chipidea changes for v4.8-rc1

2016-07-01 Thread Greg Kroah-Hartman
On Fri, Jul 01, 2016 at 10:11:26AM +0800, Peter Chen wrote: > The following changes since commit aa5e94a2e13377e374795de5400e346c978f46be: > > Revert "usb: ohci-at91: Forcibly suspend ports while USB suspend" > (2016-06-20 07:42:07 -0700) > > are available in the git repository at: > > git:

[GIT PULL] USB driver fixes for 4.7-rc6

2016-07-01 Thread Greg KH
The following changes since commit 33688abb2802ff3a230bd2441f765477b94cc89e: Linux 4.7-rc4 (2016-06-19 21:30:02 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.7-rc6 for you to fetch changes up to ab2a4bf83902c170d29ba1

Re: [PATCH 00/21] Support qcom's HSIC USB and rewrite USB2 HS phy support

2016-07-01 Thread John Stultz
On Tue, Jun 28, 2016 at 1:34 AM, Stephen Boyd wrote: > Quoting John Stultz (2016-06-27 20:09:30) >> >> I haven't yet been able to test with this, as I need some other fixes >> it seems too to deal with some of the iommu changes in my flo-WIP tree >> (it can't find of_dma_configure), but will let y