Re: [PATCH 1/2] usb-audio: correct speed checking

2016-05-08 Thread Takashi Iwai
On Wed, 04 May 2016 14:18:39 +0200, Oliver Neukum wrote: > > Allow handling SS+ USB devices correctly. > > Signed-off-by: Oliver Neukum Thanks, applied both patches now. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-08 Thread Benjamin Herrenschmidt
On Sun, 2016-05-08 at 00:54 +0200, Christian Lamparter via Linuxppc-dev wrote: > Hello, > > I've been looking in getting the MyBook Live Duo's USB OTG port > to function. The SoC is a APM82181. Which has a PowerPC 464 core > and related to the supported canyonlands architecture in > arch/powerpc/

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-08 Thread Christian Lamparter
On Sunday, May 08, 2016 08:40:55 PM Benjamin Herrenschmidt wrote: > On Sun, 2016-05-08 at 00:54 +0200, Christian Lamparter via Linuxppc-dev > wrote: > > I've been looking in getting the MyBook Live Duo's USB OTG port > > to function. The SoC is a APM82181. Which has a PowerPC 464 core > > and rela

intermittent USB disconnection, (sb_reset_and_verify_device Failed to disable LTM)

2016-05-08 Thread Daniel Duris
https://bugzilla.kernel.org/show_bug.cgi?id=117811 --- Comment #1 from Greg Kroah-Hartman --- On Sun, May 08, 2016 at 11:25:34AM +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=117811 > > Bug ID: 117811 >Summary: intermitten

Re: intermittent USB disconnection, (sb_reset_and_verify_device Failed to disable LTM)

2016-05-08 Thread Greg KH
On Sun, May 08, 2016 at 02:46:12PM +0200, Daniel Duris wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=117811 Please provide the details here. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More

Re: intermittent USB disconnection, (sb_reset_and_verify_device Failed to disable LTM)

2016-05-08 Thread Daniel Duris
Every few seconds or minutes intermittent eth0 disconnection occurs (via USB adapter DA200 on Dell XPS computer): [ 7745.623668] usb 4-1.4: usb_reset_and_verify_device Failed to disable LTM . [ 7745.626674] usb 4-1.4: USB disconnect, device number 10 [ 7746.656564] usb 4-1.4: new S

Re: intermittent USB disconnection, (sb_reset_and_verify_device Failed to disable LTM)

2016-05-08 Thread Greg KH
On Sun, May 08, 2016 at 02:54:29PM +0200, Daniel Duris wrote: > Every few seconds or minutes intermittent eth0 disconnection occurs (via USB > adapter DA200 on Dell XPS computer): > > [ 7745.623668] usb 4-1.4: usb_reset_and_verify_device Failed to disable LTM >. > [ 7745.626674] u

[PATCH 1/8] USB: serial: io_edgeport: fix memory leaks in attach error path

2016-05-08 Thread Johan Hovold
Private data, URBs and buffers allocated for Epic devices during attach were never released on errors (e.g. missing endpoints). Fixes: 6e8cf7751f9f ("USB: add EPIC support to the io_edgeport driver") Cc: stable # v2.6.21 Signed-off-by: Johan Hovold --- drivers/usb/serial/io_edgeport.c | 39

[PATCH 4/8] USB: serial: keyspan: fix URB unlink

2016-05-08 Thread Johan Hovold
A driver must not rely on the URB status field to try to determine if an URB is active. Signed-off-by: Johan Hovold --- drivers/usb/serial/keyspan.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/

[PATCH 0/8] USB: serial: fix interface URB leaks and use-after-free

2016-05-08 Thread Johan Hovold
This series fixes a number of issues where resources were not properly released on probe errors. Typically, URBs allocated and submitted in an attach callback were never unlinked or released in a matching release callback. This could lead to memory leaks and use-after-free bugs as we could end up w

[PATCH 3/8] USB: serial: keyspan: fix use-after-free in probe error path

2016-05-08 Thread Johan Hovold
The interface instat and indat URBs were submitted in attach, but never unlinked in release before deallocating the corresponding transfer buffers. In the case of a late probe error (e.g. due to failed minor allocation), disconnect would not have been called before release, causing the buffers to

[PATCH 5/8] USB: serial: keyspan: fix debug and error messages

2016-05-08 Thread Johan Hovold
The URB status is signed and should be printed using %d rather than %x. Also print endpoint addresses consistently using %x rather than %d, and merge a broken-up error message string. Signed-off-by: Johan Hovold --- drivers/usb/serial/keyspan.c | 42 +- 1

[PATCH 6/8] USB: serial: mxuport: fix use-after-free in probe error path

2016-05-08 Thread Johan Hovold
The interface read and event URBs are submitted in attach, but were never explicitly unlinked by the driver. Instead the URBs would have been killed by usb-serial core on disconnect. In case of a late probe error (e.g. due to failed minor allocation), disconnect is never called and we could end up

[PATCH 8/8] USB: serial: fix minor-number allocation

2016-05-08 Thread Johan Hovold
Due to a missing upper bound, invalid minor numbers could be assigned to ports. Such devices would later fail to register, but let's catch this early as intended and avoid having devices with only a subset of their ports registered (potentially the empty set). Signed-off-by: Johan Hovold --- dri

[PATCH 7/8] USB: serial: quatech2: fix use-after-free in probe error path

2016-05-08 Thread Johan Hovold
The interface read URB is submitted in attach, but was only unlinked by the driver at disconnect. In case of a late probe error (e.g. due to failed minor allocation), disconnect is never called and we would end up with active URBs for an unbound interface. This in turn could lead to deallocated me

[PATCH 2/8] USB: serial: io_edgeport: fix memory leaks in probe error path

2016-05-08 Thread Johan Hovold
URBs and buffers allocated in attach for Epic devices would never be deallocated in case of a later probe error (e.g. failure to allocate minor numbers) as disconnect is then never called. Fix by moving deallocation to release and making sure that the URBs are first unlinked. Fixes: f9c99bb8b3a1

Re: [GIT PULL] USB-serial fixes for v4.6-rc7

2016-05-08 Thread Johan Hovold
On Sat, May 07, 2016 at 07:46:14PM +0200, Greg Kroah-Hartman wrote: > On Thu, May 05, 2016 at 12:13:11PM +0200, Johan Hovold wrote: > > Hi Greg, > > > > Here are some new modem device ids for the option driver. These have all > > been in linux-next over night and could go into -rc7 unless you pref

[PATCH] usb/host/fotg210: remove dead code in create_sysfs_files

2016-05-08 Thread Colin King
From: Colin Ian King The goto in create_sysfs_files is never executed, so remove it and clean up the code. Signed-off-by: Colin Ian King --- drivers/usb/host/fotg210-hcd.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/ho

[PATCH 1/1] usb: gadget: f_tcm: out of bound access in usbg_drop_tpg

2016-05-08 Thread Heinrich Schuchardt
Commit dc8c46a5ae77 ("usb: gadget: f_tcm: convert to new function interface with backward compatibility") introduced a possible out of bounds memory access: If tpg is not found in function usbg_drop_tpg, tpg_instances[TPG_INSTANCES] is accessed. Fixes: dc8c46a5ae77 ("usb: gadget: f_tcm: convert t

[PATCH 1/1] usb: gadget: avoid exposing kernel stack

2016-05-08 Thread Heinrich Schuchardt
Function in_rq_cur copies random bytes from the stack. Zero the memory instead. Fixes: 132fcb460839 ("usb: gadget: Add Audio Class 2.0 Driver") Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/function/f_uac2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/funct

[PATCH 1/1] usb: gadget: hid: remove redundant breaks

2016-05-08 Thread Heinrich Schuchardt
Code after goto is never reached. Remove redundant breaks. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/function/f_hid.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index 51980c5..6ee81e5 100644 ---

[PATCH 1/1] usb: net2272: avoid shifting 0

2016-05-08 Thread Heinrich Schuchardt
Remove redundant code. Or'ing with a shifted value of zero is a NOP. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/udc/net2272.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c in

[PATCH 1/1] USB: FHCI: avoid redundant condition

2016-05-08 Thread Heinrich Schuchardt
The right part of the following or expression is only evaluated if td is nonzero. !td || (td && td.status == USB_TD_INPROGRESS) So no need to check td again. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/fhci-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-08 Thread Benjamin Herrenschmidt
On Sun, 2016-05-08 at 13:44 +0200, Christian Lamparter wrote: > On Sunday, May 08, 2016 08:40:55 PM Benjamin Herrenschmidt wrote: > > > > On Sun, 2016-05-08 at 00:54 +0200, Christian Lamparter via Linuxppc-devĀ  > > wrote: > > > > > > I've been looking in getting the MyBook Live Duo's USB OTG port

Re: [PATCH 8/8] USB: serial: fix minor-number allocation

2016-05-08 Thread Greg KH
On Sun, May 08, 2016 at 08:08:03PM +0200, Johan Hovold wrote: > Due to a missing upper bound, invalid minor numbers could be assigned to > ports. Such devices would later fail to register, but let's catch this > early as intended and avoid having devices with only a subset of their > ports register