Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-20 Thread Roger Quadros
On 19/04/16 11:06, Peter Chen wrote: > On Tue, Apr 05, 2016 at 05:05:12PM +0300, Roger Quadros wrote: >> +/** >> + * usb_otg_start_host - start/stop the host controller >> + * @otg:usb_otg instance >> + * @on: true to start, false to stop >> + * >> + * Start/stop the USB host contro

Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-20 Thread Roger Quadros
On 20/04/16 08:08, Yoshihiro Shimoda wrote: > Hi, > >> From: Peter Chen >> Sent: Tuesday, April 19, 2016 6:18 PM >> >> On Fri, Apr 15, 2016 at 10:03:16AM +, Yoshihiro Shimoda wrote: >>> Hi, >>> From: Yoshihiro Shimoda Sent: Friday, April 15, 2016 6:59 PM Hi, > From

Re: What are Shared HCD and Companion Controller(HCD?)

2016-04-20 Thread Peter Chen
On Tue, Apr 19, 2016 at 10:20:33AM -0400, Alan Stern wrote: > On Tue, 19 Apr 2016, Felipe Balbi wrote: > > > Hi, > > > > Peter Chen writes: > > > Hi all, > > > > > > When I review the patch [1] for adding companion controller support for > > > OTG framework, I am puzzled several concepts, like s

[PATCH] usb: gadget: f_fs: Fix use-after-free

2016-04-20 Thread Felipe Balbi
From: Lars-Peter Clausen When using asynchronous read or write operations on the USB endpoints the issuer of the IO request is notified by calling the ki_complete() callback of the submitted kiocb when the URB has been completed. Calling this ki_complete() callback will free kiocb. Make sure tha

Re: What are Shared HCD and Companion Controller(HCD?)

2016-04-20 Thread Felipe Balbi
Peter Chen writes: > On Tue, Apr 19, 2016 at 10:20:33AM -0400, Alan Stern wrote: >> On Tue, 19 Apr 2016, Felipe Balbi wrote: >> >> > Hi, >> > >> > Peter Chen writes: >> > > Hi all, >> > > >> > > When I review the patch [1] for adding companion controller support for >> > > OTG framework, I am p

Re: What are Shared HCD and Companion Controller(HCD?)

2016-04-20 Thread Peter Chen
On Wed, Apr 20, 2016 at 10:41:42AM +0300, Felipe Balbi wrote: > Peter Chen writes: > > On Tue, Apr 19, 2016 at 10:20:33AM -0400, Alan Stern wrote: > >> On Tue, 19 Apr 2016, Felipe Balbi wrote: > >> > >> > Hi, > >> > > >> > Peter Chen writes: > >> > > Hi all, > >> > > > >> > > When I review the

Re: [PATCH] usb/gadget: fix gadgetfs aio support

2016-04-20 Thread Mathieu Laurendeau
On 2016-04-20 09:27, Mathieu Laurendeau wrote: On 2016-03-23 12:51, Mathieu Laurendeau wrote: Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget: switch ep_io_operations to ->read_iter/->write_iter") io submissions fail with ENODEV. Signed-off-by: Mathieu Laurendeau --- drivers/

Re: [PATCH v6 06/12] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG

2016-04-20 Thread Roger Quadros
On 18/04/16 11:05, Peter Chen wrote: > On Tue, Apr 05, 2016 at 05:05:11PM +0300, Roger Quadros wrote: >> Let's use CONFIG_USB_OTG as a single config option to enable >> USB OTG and the OTG FSM. This makes things a lot less confusing. >> >> Update all users of CONFIG_USB_OTG_FSM to CONFIG_USB_OTG. >

Re: [PATCH] usb/gadget: fix gadgetfs aio support

2016-04-20 Thread Felipe Balbi
Hi, Mathieu Laurendeau writes: > On 2016-04-20 09:27, Mathieu Laurendeau wrote: >> On 2016-03-23 12:51, Mathieu Laurendeau wrote: >>> Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget: switch >>> ep_io_operations to ->read_iter/->write_iter") io submissions fail >>> with >>> ENODEV

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-20 Thread Roger Quadros
On 19/04/16 04:56, Peter Chen wrote: > On Mon, Apr 18, 2016 at 10:11:29AM -0400, Alan Stern wrote: >> On Mon, 18 Apr 2016, Peter Chen wrote: >> >>> On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: On 06/04/16 09:09, Felipe Balbi wrote: > > Hi, > > Roger Quadros w

[GIT PULL] USB fixes for v4.6-rc5

2016-04-20 Thread Felipe Balbi
Hi Greg, here's what I hope to be my last pull request to this -rc series. Patches have been tested (where applicable) with intel platforms I have around. They have also been in next for a little while without any reports of problems. cheers The following changes since commit c3b46c73264b03000

Re: [PATCH] usb/gadget: fix gadgetfs aio support

2016-04-20 Thread Mathieu Laurendeau
On 2016-03-23 12:51, Mathieu Laurendeau wrote: Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget: switch ep_io_operations to ->read_iter/->write_iter") io submissions fail with ENODEV. Signed-off-by: Mathieu Laurendeau --- drivers/usb/gadget/legacy/inode.c |2 +- 1 file change

Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-20 Thread Peter Chen
On Wed, Apr 20, 2016 at 09:54:49AM +0300, Roger Quadros wrote: > On 18/04/16 05:09, Peter Chen wrote: > > On Fri, Apr 15, 2016 at 02:00:46PM +0300, Roger Quadros wrote: > >> On 15/04/16 12:25, Peter Chen wrote: > >>> On Tue, Apr 05, 2016 at 05:05:12PM +0300, Roger Quadros wrote: > + * usb_otg_

Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-20 Thread Peter Chen
On Wed, Apr 20, 2016 at 10:02:33AM +0300, Roger Quadros wrote: > On 19/04/16 11:06, Peter Chen wrote: > > On Tue, Apr 05, 2016 at 05:05:12PM +0300, Roger Quadros wrote: > >> +/** > >> + * usb_otg_start_host - start/stop the host controller > >> + * @otg: usb_otg instance > >> + * @on: tr

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-20 Thread Peter Chen
On Wed, Apr 20, 2016 at 11:15:30AM +0300, Roger Quadros wrote: > On 19/04/16 04:56, Peter Chen wrote: > > On Mon, Apr 18, 2016 at 10:11:29AM -0400, Alan Stern wrote: > >> On Mon, 18 Apr 2016, Peter Chen wrote: > >> > >>> On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: > On 06/04

[PATCHv2] usb: Add driver for UCSI

2016-04-20 Thread Heikki Krogerus
USB Type-C Connector System Software Interface (UCSI) is specification that defines the registers and data structures that can be used to control USB Type-C ports on a system. UCSI is used on several Intel Broxton SoC based platforms. Things that UCSI can be used to control include at least USB Dat

[RESEND PATCH v4] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2016-04-20 Thread Dirk Gouders
If choices consist of choice_values that depend on symbols set to 'm', those choice_values are not set to 'n' if the choice is changed from 'm' to 'y' (in which case only one active choice_value is allowed). Those values are also written to the config file causing modules to be built when they shou

Re: [RFC] DMA initialization for manually created devices

2016-04-20 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > David Woodhouse writes: >> On Tue, 2016-04-19 at 14:38 +0300, Felipe Balbi wrote: >>> >>> The reason for that I'm using a manually created platform_device and >>> that misses dev->archdata which the underlying/parent PCI device has. >> >> Typically we'd expect

Re: [RESEND PATCH v4] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2016-04-20 Thread kbuild test robot
Hi, [auto build test ERROR on v4.6-rc4] [also build test ERROR on next-20160420] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Dirk-Gouders/kconfig-symbol-c-handle-choice_values-that-depend

Re: [RESEND PATCH v4] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2016-04-20 Thread kbuild test robot
Hi, [auto build test ERROR on v4.6-rc4] [also build test ERROR on next-20160420] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Dirk-Gouders/kconfig-symbol-c-handle-choice_values-that-depend

Re: 03f0:521d Hewlett-Packard

2016-04-20 Thread mirkt
Hello, I got HP Pro X2 612 G1 with 03f0:521d and unfortunately can not connect to mobile broadband (using network manager). I have tried booting Linux Mint 17.3, Fedora 23, Ubuntu 14.10 from USB stick.. Network Manager shows Mobile Broadband option ((it even shows signal strength)) after: # modpr

Re: [RESEND PATCH v4] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2016-04-20 Thread Dirk Gouders
kbuild test robot writes: > Hi, > > [auto build test ERROR on v4.6-rc4] > [also build test ERROR on next-20160420] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: > https://github.com/0day-ci

[PATCH 1/2] USB: LTM also for USB 3.1

2016-04-20 Thread Oliver Neukum
LTM is also defined for SS+. The correct test is to check for anything slower than SS not exactly SS. Signed-off-by: Oliver Neukum --- include/linux/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index 6a9a0c2..29aba760 100644

[PATCH 2/2] USB: correct intervals for SS+

2016-04-20 Thread Oliver Neukum
SS+ also expresses intervals in units of 125ms. Testing must be for SS or faster, not SS exactly. Signed-off-by: Oliver neukum --- include/linux/usb.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index 29aba760..7824f45 100644

[PATCH 0/2] Correcting a few remaining test for USB_SPEED_SUPER

2016-04-20 Thread Oliver Neukum
It looks to me like the tests for LTM and the units of intervals for periodic transfers used ==USB_SPEED_SUPER where >=USB_SPEED_SUPER should have been used. Oliver Neukum (2): USB: LTM also for USB 3.1 USB: correct intervals for SS+ include/linux/usb.h | 6 +++--- 1 file changed, 3 insertio

[PATCH] hub: admit devices are SS+

2016-04-20 Thread Oliver Neukum
If a port can do 10 Gb/s the kernel should say so. The corresponding check needs to be added. Signed-off.by: Oliver Neukum > --- drivers/usb/core/hub.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 38cc4ba..c2270d8 100644 --- a/drivers

[PATCH] USB: serial: Use IS_ENABLED() instead of checking for FOO || FOO_MODULE

2016-04-20 Thread Javier Martinez Canillas
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either built-in or as a module, use that macro instead of open coding the same. Signed-off-by: Javier Martinez Canillas --- drivers/usb/serial/usb-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

Re: XHCI is slow during boot (bios/efi) and leaves many dmesg messages

2016-04-20 Thread Olliver Schinagl
Hey all, On 11-04-16 20:29, Janna Martl wrote: On Mon, Apr 11, 2016 at 02:15:24PM -0400, Janna Martl wrote: On Mon, Apr 11, 2016 at 11:22:12AM +0300, Felipe Balbi wrote: Just to confirm, can you check that disabling LPM solves the problem ? I tried your patch on 4.6.0-rc3 but it doesn't seem

[PATCH 1/2] Documentation: dt-bindings: dwc2: add the resets and reset-names property

2016-04-20 Thread dinguyen
From: Dinh Nguyen Document the optional 'resets' and 'reset-names' property for the DWC2 usb core. Signed-off-by: Dinh Nguyen Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/d

[PATCHv6 2/2] usb: dwc2: Add reset control to dwc2

2016-04-20 Thread dinguyen
From: Dinh Nguyen Allow for platforms that have a reset controller driver in place to bring the USB IP out of reset. Signed-off-by: Dinh Nguyen --- v6: fix 80 line checkpatch warning in dev_err print v5: updated error conditions for not finding the reset property v4: use dev_dbg() if not a -EPR

4.5.1: UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:9

2016-04-20 Thread Martin MOKREJŠ
Hi, I am not certain to to forward this to, so I am trying linux-usb and ext4. Please add relevant people/lists, thank you. # dmesg | grep "UBSAN: Undefined behaviour" [2.638843] UBSAN: Undefined behaviour in drivers/usb/host/ehci-hub.c:873:47 [8.553620] UBSAN: Undefined behaviour in f

Re: 03f0:521d Hewlett-Packard

2016-04-20 Thread Greg KH
On Wed, Apr 20, 2016 at 12:20:29PM +, mirkt wrote: > Hello, > > I got HP Pro X2 612 G1 with 03f0:521d and unfortunately can not connect to > mobile broadband (using network manager). I have tried booting Linux Mint > 17.3, Fedora 23, Ubuntu 14.10 from USB stick.. Network Manager shows Mobile >

Re: 4.5.1: UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:9

2016-04-20 Thread Greg KH
On Thu, Apr 21, 2016 at 12:22:49AM +0200, Martin MOKREJŠ wrote: > Hi, > I am not certain to to forward this to, so I am trying linux-usb and ext4. > Please add relevant people/lists, thank you. > > # dmesg | grep "UBSAN: Undefined behaviour" > [2.638843] UBSAN: Undefined behaviour in > dri

[PATCH] usb: xhci-mtk: fixup mouse wakeup failure during system suspend

2016-04-20 Thread Chunfeng Yun
Click mouse after xhci suspend completion but before system suspend completion, system will not be waken up by mouse if the duration of them is larger than 20ms which is the device UFP's resume signaling lasted. Another reason is that the SPM is not enabled before system suspend compeltion, this ca

Microsoft wireless usb mouse frequently fails to detect in ubuntu 15.10/16.04

2016-04-20 Thread rootsr
Hello all, I am using ubuntu 16.04 (upgraded yesterday from 15.10) on Dell inspiron 15 3000 series (core i7). While using Microsoft wireless mouse, it fails to detect most of the time. The issue is not there when I use the same mouse in Windows / other linux distro / TV / PS4 etc. Here is the K

Re: 03f0:521d Hewlett-Packard

2016-04-20 Thread mirkt
Hello, Greg KH writes: > What is the output of 'lsusb -v -d 03f0:521d' ? Bus 001 Device 007: ID 03f0:521d Hewlett-Packard Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 255 Vendor Specific Class bDeviceSubClass

RE: [PATCH v6 09/12] usb: gadget: udc: adapt to OTG core

2016-04-20 Thread Jun Li
Hi, ... > > /** > + * usb_gadget_start - start the usb gadget controller and connect to > +bus > + * @gadget: the gadget device to start > + * > + * This is external API for use by OTG core. > + * > + * Start the usb device controller and connect to bus (enable pull). > + */ > +static int usb_ga

Re: What are Shared HCD and Companion Controller(HCD?)

2016-04-20 Thread Peter Chen
On Tue, Apr 19, 2016 at 10:20:33AM -0400, Alan Stern wrote: > On Tue, 19 Apr 2016, Felipe Balbi wrote: > > > Hi, > > > > Peter Chen writes: > > > Hi all, > > > > > > When I review the patch [1] for adding companion controller support for > > > OTG framework, I am puzzled several concepts, like s