Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-08 Thread Roger Quadros
On 08/04/16 04:01, Peter Chen wrote: > On Thu, Apr 07, 2016 at 01:40:21PM +0300, Roger Quadros wrote: >> On 07/04/16 12:42, Peter Chen wrote: >>> On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: On 06/04/16 09:09, Felipe Balbi wrote: > > Hi, > > Roger Quadros wri

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-08 Thread Peter Chen
On Fri, Apr 08, 2016 at 10:16:30AM +0300, Roger Quadros wrote: > On 08/04/16 04:01, Peter Chen wrote: > > On Thu, Apr 07, 2016 at 01:40:21PM +0300, Roger Quadros wrote: > >> On 07/04/16 12:42, Peter Chen wrote: > >>> On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: > On 06/04/16

RE: [PATCH v10 1/4] gadget: Introduce the usb charger framework

2016-04-08 Thread Jun Li
Hi, Baolin > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Baolin Wang > Sent: Thursday, April 07, 2016 7:49 PM > To: ba...@kernel.org; gre...@linuxfoundation.org; s...@kernel.org; > dbarysh...@gmail.com; dw...@infradead

[PATCHv2] usb: f_mass_storage: test whether thread is running before starting another

2016-04-08 Thread Michal Nazarewicz
When binding the function to usb_configuration, check whether the thread is running before starting another one. Without that, when function instance is added to multiple configurations, fsg_bing starts multiple threads with all but the latest one being forgotten by the driver. This leads to obvi

RE: [PATCH] option.c: Support for Gemalto's Cinterion PH8 and AHxx products added

2016-04-08 Thread Schemmel Hans-Christoph
> -Original Message- > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold > Sent: Donnerstag, 7. April 2016 11:51 > To: Schemmel Hans-Christoph > Cc: jo...@kernel.org; gre...@linuxfoundation.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH] option.c: Support for Gem

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

2016-04-08 Thread Sedat Dilek
On Thu, Apr 7, 2016 at 10:11 PM, Jiri Kosina wrote: > On Wed, 6 Apr 2016, Dmitry Torokhov wrote: > >> > I forgot to tell that I have some patches on top of vanilla Linux v4.6-rc2. >> > >> > Dropping the patches from makes >> > the issue go away. >> > Unsure what is the cause. >> >> Hmm, this is q

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

2016-04-08 Thread Jiri Kosina
On Fri, 8 Apr 2016, Sedat Dilek wrote: > Hmm, I could not reproduce it again. > Cursor up/down (pageup/pagedown) works again - unsure if the dmesg > outputs are related to this. > ( And I have some (rfc) locking patches from PeterZ on top. ) Ok, I'll not let this block for-4.6/upstream-fixes goin

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

2016-04-08 Thread Sedat Dilek
On Wed, Apr 6, 2016 at 11:34 PM, Jiri Kosina wrote: > On Wed, 6 Apr 2016, Dmitry Torokhov wrote: > >> >>> [ 685.425634] atkbd serio0: Unknown key pressed (translated set 2, >> >>> code 0xa8 on isa0060/serio0). >> >>> [ 685.425648] atkbd serio0: Use 'setkeycodes e028 ' to make it >> >>> known. >

[PATCH] usb: core: buffer: avoid NULL pointer dereferrence

2016-04-08 Thread Chunfeng Yun
NULL pointer dereferrence will happen when class driver wants to allocate zero length buffer and pool_max[0] can't be used, so skip reserved pool in this case. Signed-off-by: Chunfeng Yun --- drivers/usb/core/buffer.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH] phy: phy-mt65xx-usb3: add support for mt2701 platform

2016-04-08 Thread Chunfeng Yun
A new compatible string, "mediatek,mt2701-u3phy", is added. Some register settings to avoid RX sensitivity level degradation which may arise on mt8173 platform are separated from other platforms. Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/phy/phy-mt65xx-usb.txt |4 +- drive

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

2016-04-08 Thread Brian Chadwick
On 08/04/16 01:59, Greg KH wrote: On Fri, Apr 08, 2016 at 01:34:51AM +1000, Brian Chadwick wrote: On 08/04/16 00:44, Greg KH wrote: On Thu, Apr 07, 2016 at 03:04:55PM +1000, Brian Chadwick wrote: On 06/04/16 19:53, Greg KH wrote: On Tue, Apr 05, 2016 at 06:42:51PM +1000, Brian Chadwick wrote:

[PATCH v3 0/2] Add a new debugfs entry to dump FIFO/Queue available space

2016-04-08 Thread changbin . du
From: "Du, Changbin" FIFO/Queue available space info can be used to debug dwc3 issues. First we remove unnecessary checking for debugfs api call, then add the new entry. changes from v2: 1. Remove commit "usb: dwc3: free dwc->regset on dwc3_debugfs_exit" Du, Changbin (2): usb: dwc3: make d

[PATCH v3 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space

2016-04-08 Thread changbin . du
From: "Du, Changbin" For DWC3 USB controller, the Global Debug Queue/FIFO Space Available Register(GDBGFIFOSPACE) can be used to dump FIFO/Queue available space. This can be used to check some special issues, like whether data is successfully copied from memory to fifo when a trb is blocked. Sig

[PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void

2016-04-08 Thread changbin . du
From: "Du, Changbin" Debugfs init failure is not so important. We can continue our job on this failure. Also no need to check debugfs_create_file call results. Signed-off-by: Du, Changbin --- changes from v2: no changes --- drivers/usb/dwc3/core.c| 10 +- drivers/usb/dwc3/debug.

[PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

2016-04-08 Thread changbin . du
From: "Du, Changbin" dwc->regset is allocated on dwc3_debugfs_init, and should be released on dwc3_debugfs_exit. Signed-off-by: Du, Changbin --- This patch is seperated from patch set: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs Because it is not related to other 2 patches.

Re: [PATCH v10 1/4] gadget: Introduce the usb charger framework

2016-04-08 Thread Baolin Wang
Hi Jun, On 8 April 2016 at 16:04, Jun Li wrote: > Hi, Baolin > >> +/* >> + * usb_charger_detect_type() - detect the charger type manually. >> + * @uchger - usb charger device >> + * >> + * Note: You should ensure you need to detect the charger type manually >> +on your >> + * platform. >> + * You

Re: [PATCH 3/7] xhci: Don't suspend a xhci usb bus if there is a pending event.

2016-04-08 Thread Mathias Nyman
On 07.04.2016 17:23, Alan Stern wrote: On Thu, 7 Apr 2016, Mathias Nyman wrote: In this case there may be alternatives. For example, you could just delay a few ms until the pending event has been handled. Or, if you really just want to prevent runtime suspend, you should check to see if this

Re: [RFT PATCH 0/4] usb: dwc2: Fix core reset and force mode delay problems

2016-04-08 Thread Michael Niewoehner
Am 08.04.2016 um 00:12 schrieb John Youn : > On 4/7/2016 1:36 PM, Michael Niewoehner wrote: >> >> Am 07.04.2016 um 20:41 schrieb John Youn : >> >>> On 3/31/2016 2:44 PM, Michael Niewoehner wrote: Hi John, Am 29.03.2016 um 04:36 schrieb John Youn : > Hi, > > Th

Re: [PATCH v10 1/4] gadget: Introduce the usb charger framework

2016-04-08 Thread Baolin Wang
Hi Jun, >> >> +/* >> >> + * usb_charger_detect_type() - detect the charger type manually. >> >> + * @uchger - usb charger device >> >> + * >> >> + * Note: You should ensure you need to detect the charger type >> >> +manually on your >> >> + * platform. >> >> + * You should call it at the right gad

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-08 Thread Yoshihiro Shimoda
Hi, > From: Roger Quadros > Sent: Thursday, April 07, 2016 8:45 PM > > Hi, > > On 07/04/16 11:52, Yoshihiro Shimoda wrote: > > Hi, > > > >> From: Roger Quadros > >> Sent: Tuesday, April 05, 2016 11:05 PM < snip > > > diff --git a/drivers/usb/common/usb-otg.c b/drivers/usb/common/usb-otg.c > > in

Re: [PATCH 3/7] xhci: Don't suspend a xhci usb bus if there is a pending event.

2016-04-08 Thread Mathias Nyman
On 08.04.2016 13:16, Mathias Nyman wrote: On 07.04.2016 17:23, Alan Stern wrote: On Thu, 7 Apr 2016, Mathias Nyman wrote: In this case there may be alternatives. For example, you could just delay a few ms until the pending event has been handled. Or, if you really just want to prevent runtim

RE: [PATCH v10 1/4] gadget: Introduce the usb charger framework

2016-04-08 Thread Jun Li
> -Original Message- > From: Baolin Wang [mailto:baolin.w...@linaro.org] > Sent: Friday, April 08, 2016 7:00 PM > To: Jun Li > Cc: ba...@kernel.org; gre...@linuxfoundation.org; s...@kernel.org; > dbarysh...@gmail.com; dw...@infradead.org; peter.c...@freescale.com; > st...@rowland.harvard

Re: [PATCH v10 1/4] gadget: Introduce the usb charger framework

2016-04-08 Thread Baolin Wang
On 8 April 2016 at 19:27, Jun Li wrote: > > >> -Original Message- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Friday, April 08, 2016 7:00 PM >> To: Jun Li >> Cc: ba...@kernel.org; gre...@linuxfoundation.org; s...@kernel.org; >> dbarysh...@gmail.com; dw...@infradead.org;

RE: [PATCH v10 1/4] gadget: Introduce the usb charger framework

2016-04-08 Thread Jun Li
Hi > -Original Message- > From: Baolin Wang [mailto:baolin.w...@linaro.org] > Sent: Friday, April 08, 2016 5:56 PM > To: Jun Li > Cc: ba...@kernel.org; gre...@linuxfoundation.org; s...@kernel.org; > dbarysh...@gmail.com; dw...@infradead.org; peter.c...@freescale.com; > st...@rowland.harva

[PATCH v2 0/6] xhci fixes for usb-linus, try 2

2016-04-08 Thread Mathias Nyman
Hi Greg, Second try. These xhci fixes solve various small issues such as: * USB 3 device enumeration issues after runtime resume seen on NEC hosts * Add a PCI ID and needed quirk for a new controller * Remove extra 10 seconds driver timeouts on PCI hotplugged xhcis * R-Car SoC xhci quirks to s

[PATCH v2 5/6] usb: xhci: fix wild pointers in xhci_mem_cleanup

2016-04-08 Thread Mathias Nyman
From: Lu Baolu This patch fixes some wild pointers produced by xhci_mem_cleanup. These wild pointers will cause system crash if xhci_mem_cleanup() is called twice. Reported-and-tested-by: Pengcheng Li Signed-off-by: Lu Baolu Cc: sta...@vger.kernel.org Signed-off-by: Mathias Nyman --- drivers

[PATCH v2 3/6] usb: host: xhci: add a new quirk XHCI_NO_64BIT_SUPPORT

2016-04-08 Thread Mathias Nyman
From: Yoshihiro Shimoda On some xHCI controllers (e.g. R-Car SoCs), the AC64 bit (bit 0) of HCCPARAMS1 is set to 1. However, the xHCs don't support 64-bit address memory pointers actually. So, in this case, this driver should call dma_set_coherent_mask(dev, DMA_BIT_MASK(32)) in xhci_gen_setup().

[PATCH v2 4/6] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-04-08 Thread Mathias Nyman
From: Yoshihiro Shimoda This patch fixes an issue that cannot work if R-Car Gen2/3 run on above 4GB physical memory environment to use a quirk XHCI_NO_64BIT_SUPPORT. Cc: Signed-off-by: Yoshihiro Shimoda Reviewed-by: Felipe Balbi Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-plat.c

[PATCH v2 2/6] xhci: resume USB 3 roothub first

2016-04-08 Thread Mathias Nyman
Give USB3 devices a better chance to enumerate at USB 3 speeds if they are connected to a suspended host. Solves an issue with NEC uPD720200 host hanging when partially enumerating a USB3 device as USB2 after host controller runtime resume. Cc: Tested-by: Mike Murdoch Signed-off-by: Mathias Nyma

[PATCH v2 6/6] xhci: fix 10 second timeout on removal of PCI hotpluggable xhci controllers

2016-04-08 Thread Mathias Nyman
PCI hotpluggable xhci controllers such as some Alpine Ridge solutions will remove the xhci controller from the PCI bus when the last USB device is disconnected. Add a flag to indicate that the host is being removed to avoid queueing configure_endpoint commands for the dropped endpoints. For PCI ho

[PATCH v2 1/6] usb: xhci: applying XHCI_PME_STUCK_QUIRK to Intel BXT B0 host

2016-04-08 Thread Mathias Nyman
From: Rafal Redzimski Broxton B0 also requires XHCI_PME_STUCK_QUIRK. Adding PCI device ID for Broxton B and adding to quirk. Cc: Signed-off-by: Rafal Redzimski Signed-off-by: Robert Dobrowolski Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-pci.c | 4 +++- 1 file changed, 3 insertio

[GIT PULL] USB-serial fixes for v4.6-rc3

2016-04-08 Thread Johan Hovold
Hi Greg, Here are some new device ids for -rc3. Thanks, Johan The following changes since commit 9735a22799b9214d17d3c231fe377fc852f042e9: Linux 4.6-rc2 (2016-04-03 09:09:40 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git

Re: [PATCH] phy: phy-mt65xx-usb3: add support for mt2701 platform

2016-04-08 Thread Matthias Brugger
On 08/04/16 11:13, Chunfeng Yun wrote: A new compatible string, "mediatek,mt2701-u3phy", is added. Some register settings to avoid RX sensitivity level degradation which may arise on mt8173 platform are separated from other platforms. Signed-off-by: Chunfeng Yun --- .../devicetree/bindings

Re: [PATCH] usb: core: buffer: avoid NULL pointer dereferrence

2016-04-08 Thread Greg Kroah-Hartman
On Fri, Apr 08, 2016 at 05:08:03PM +0800, Chunfeng Yun wrote: > NULL pointer dereferrence will happen when class driver > wants to allocate zero length buffer and pool_max[0] > can't be used, so skip reserved pool in this case. Why would a driver want to allocate a 0 length buffer? What driver do

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

2016-04-08 Thread Greg KH
On Fri, Apr 08, 2016 at 07:37:12PM +1000, Brian Chadwick wrote: > On 08/04/16 01:59, Greg KH wrote: > > On Fri, Apr 08, 2016 at 01:34:51AM +1000, Brian Chadwick wrote: > > > On 08/04/16 00:44, Greg KH wrote: > > > > On Thu, Apr 07, 2016 at 03:04:55PM +1000, Brian Chadwick wrote: > > > > > On 06/04/

[PATCH] usb: renesas_usbhs: fix signed-unsigned return

2016-04-08 Thread Sudip Mukherjee
The return type of usbhsp_setup_pipecfg() was u16 but it was returning a negative value (-EINVAL). Instead lets return a pointer to u16 which will hold the value to be returned or in case of error, return the error code in ERR_PTR. Signed-off-by: Sudip Mukherjee --- drivers/usb/renesas_usbhs/pip

Re: [PATCHv2 / RESEND 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2016-04-08 Thread Alan Stern
On Fri, 8 Apr 2016, Felipe Balbi wrote: > > Aside from the multi-line comment formatting, you should avoid adding a > > I can fix the multiline comment style, but I'm merely following what's > already in the file. What do people prefer in this case ? How about a > patch 3/3 fixing comment style i

Re: [PATCH] usb: core: buffer: avoid NULL pointer dereferrence

2016-04-08 Thread Alan Stern
On Fri, 8 Apr 2016, Greg Kroah-Hartman wrote: > On Fri, Apr 08, 2016 at 05:08:03PM +0800, Chunfeng Yun wrote: > > NULL pointer dereferrence will happen when class driver > > wants to allocate zero length buffer and pool_max[0] > > can't be used, so skip reserved pool in this case. > > Why would a

Re: [PATCHv2] usb: f_mass_storage: test whether thread is running before starting another

2016-04-08 Thread Alan Stern
On Fri, 8 Apr 2016, Michal Nazarewicz wrote: > When binding the function to usb_configuration, check whether the thread > is running before starting another one. Without that, when function > instance is added to multiple configurations, fsg_bing starts multiple > threads with all but the latest

Re: [PATCH 3/7] xhci: Don't suspend a xhci usb bus if there is a pending event.

2016-04-08 Thread Alan Stern
On Fri, 8 Apr 2016, Mathias Nyman wrote: > > A USB3 device connected to a runtime suspended host woke up the host, > > polled the roothub, > > found nothing and immediately tried to suspend again. > > > > Logs show: > > Feb 16 20:03:33 xhci_hcd :0e:00.0: // Setting command ring address to >

Re: PROBLEM: Mouse connected to USB-3 stopped working 2.6.38->39 regression

2016-04-08 Thread Alan Stern
On Fri, 8 Apr 2016, Sam Sany wrote: > I see these posts are from 2011, but I have the exact same dmesg output > after attaching a USB2.0 sound card to my 3.0 ports on kernel 4.2.0. It > shows over and over again the error: > > [ 38.659093] usb 1-1: Not enough bandwidth for altsetting 2 > [

USB xHCI regression after upgrading from kernel 3.19.0-51 to 4.2.0-34.]

2016-04-08 Thread Matthew Giassa
*Migrating from linux-media mailing list. Good day, I maintain an SDK for USB2.0 and USB3.0 U3V machine vision cameras, and several of our customers have reported severe issues since upgrading from kernel 3.19.0-51 (Ubuntu 14.04.3 LTS) to kernel 4.2.0-34 (Ubuntu 14.04.4 LTS). I've received helpfu

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

2016-04-08 Thread Jacek Anaszewski
On 04/07/2016 10:45 PM, Pavel Machek wrote: Hi! The "color" attribute would contain "R G B" values. Setting the "color" attribute of any of the three LED class devices would affect brightness properties (i.e. constituent colors) of the remaining two ones. It would result in disabling any active

[PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes

2016-04-08 Thread Denys Vlasenko
This function compiles to 298 bytes of machine code, has ~10 callsites. This is a USB 2.0 device, USB 2.0 is limited to 35 MB/s, so should be almost never CPU bound. No need to optimize for speed this agressively. Signed-off-by: Denys Vlasenko CC: Felipe Balbi CC: linux-usb@vger.kernel.org CC:

Re: USB gadgets with configfs hang reboot

2016-04-08 Thread Ivaylo Dimitrov
Hi, On 16.01.2016 12:40, Ivaylo Dimitrov wrote: Hi, On 16.01.2016 00:48, Tony Lindgren wrote: Hi all, Looks like there's some issue with the USB gadgets and configfs. I'm seeing rmmod of the UDC driver cause a warning and then reboot hangs the system. This happens at least with v4.4, and I'v

[PATCH] usb: gadget: composite: Clear reserved fields of SSP Dev Cap

2016-04-08 Thread John Youn
Set the reserved fields of the SuperSpeed Plus Device Capability descriptor to 0. Otherwise there might be stale data there which will cause USB CV to fail. Fixes: f228a8de242a ("usb: gadget: composite: Return SSP Dev Cap descriptor") Signed-off-by: John Youn --- drivers/usb/gadget/composite.c |

[PATCH v2] usb: gadget: composite: Clear reserved fields of SSP Dev Cap

2016-04-08 Thread John Youn
Set the reserved fields of the SuperSpeed Plus Device Capability descriptor to 0. Otherwise there might be stale data there which will cause USB CV to fail. Fixes: f228a8de242a ("usb: gadget: composite: Return SSP Dev Cap descriptor") Signed-off-by: John Youn --- v2: * Use cpu_to_le16() to set w

Re: [GIT PULL] USB-serial fixes for v4.6-rc3

2016-04-08 Thread Greg Kroah-Hartman
On Fri, Apr 08, 2016 at 03:56:28PM +0200, Johan Hovold wrote: > Hi Greg, > > Here are some new device ids for -rc3. > > Thanks, > Johan > > The following changes since commit 9735a22799b9214d17d3c231fe377fc852f042e9: > > Linux 4.6-rc2 (2016-04-03 09:09:40 -0500) > > are available in the git

Re: PROBLEM: Mouse connected to USB-3 stopped working 2.6.38->39 regression

2016-04-08 Thread Sam Sany
Hi Allen, thank you for quick reply. It is VERY much appreciated. The output of /sys/kernel/debug/usb/devices can be found here: http://pastebin.com/HyzefGyB (I believe the relevent portion is at the end, the "Focusrite Scarlett" device). According to the output of "cat /boot/config" the CONFIG