RE: [PATCH v2 0/2] usb: renesas_usbhs: fix to avoid unexpected condition

2016-03-22 Thread Felipe Balbi
Yoshihiro-san, Yoshihiro Shimoda writes: >> From: Yoshihiro Shimoda >> Sent: Thursday, March 10, 2016 11:30 AM >> >> This patch set is based on the latest Felipe's usb.git / testing/next branch. >> (commit id = ac5706631325ae3695bfa1527101ab2b2f64859f) > > Would you review the patch set? > > I

RE: [PATCH v2 0/2] usb: renesas_usbhs: fix to avoid unexpected condition

2016-03-22 Thread Yoshihiro Shimoda
Hi Felipe-san, > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Tuesday, March 22, 2016 4:16 PM > > Yoshihiro-san, > > Yoshihiro Shimoda writes: > >> From: Yoshihiro Shimoda > >> Sent: Thursday, March 10, 2016 11:30 AM > >> > >> This patch set is based on the latest Felipe's usb.git / tes

[PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread Nobuo Iwata
Modification to usbip_event.c. BEFORE) kernel threads are created in usbip_start_eh(). AFTER) one workqueue is created in new usbip_init_eh(). Event handler which was main loop of kernel thread is modified to workqueue handler. Events themselves are stored in struct usbip_device - same as bef

[PATCH v1 1/1] usbip: safe completion against unbind operation

2016-03-22 Thread Nobuo Iwata
This patch adds a code fragment to ignore completing URBs in closing connection. Regarding this patch, 2 execution contexts are related. 1) stub_tx.c: stub_complete() which is called from USB core 1-1) add to unlink list and free URB or 1-2) move to tx list 2) stub_dev.c: stub_shutdown_connecti

[PATCH v1 1/1] usbip: adding names db to port operation

2016-03-22 Thread Nobuo Iwata
Adding names database to port command. BEFORE) 'unknown' for vendor and product string. Imported USB devices Port 00: at Low Speed(1.5Mbps) unknown vendor : unknown product (03f0:0224) 3-1 -> usbip://10.0.2.15:3240/5-1 -> remote bus/dev 005/002 AFTE

[PATCH v1 2/2] usbip: modifications to drivers using event handler

2016-03-22 Thread Nobuo Iwata
Modifications to code using usbip_event.c Initialization and termination of workqueue are added to init and exit routine of usbip_core respectively. Signed-off-by: Nobuo Iwata --- drivers/usb/usbip/stub_dev.c | 3 +-- drivers/usb/usbip/usbip_common.c | 7 +++ 2 files changed, 8 inserti

[PATCH v1 0/2] usbip: event handler as one thread

2016-03-22 Thread Nobuo Iwata
Dear all, In existing implementation, event kernel threads are created for each port. The functions of the threads are closing connection and error handling so they don't have not so many events to handle. There' no need to have thread for each port. BEFORE) vhci side - VHCI_NPORTS(8) threads

Re: [PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread kbuild test robot
Hi Nobuo, [auto build test ERROR on v4.5-rc7] [also build test ERROR on next-20160321] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Nobuo-Iwata/usbip-event-handler-as-one-thread/20160322

Re: [PATCH v8 1/5] leds: core: add generic support for RGB LED's

2016-03-22 Thread Jacek Anaszewski
Hi Heiner, On 03/21/2016 06:24 PM, Heiner Kallweit wrote: Add generic support for RGB LED's. Basic idea is to use enum led_brightness also for the hue and saturation color components.This allows to implement the color extension w/o changes to struct led_classdev. Select LEDS_CLASS_RGB to enabl

Re: 答复: 【xhci】suspend and resume core dump problem

2016-03-22 Thread Oliver Neukum
On Mon, 2016-03-21 at 23:41 -0400, gre...@linuxfoundation.org wrote: > On Tue, Mar 22, 2016 at 03:17:08AM +, Lipengcheng wrote: > > Hi, > > Thanks for your reply. > > When the suspend and resume process , the operation of press ctrl + c > > will produce an interruput and cause to allocate

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-22 Thread Oliver Neukum
On Mon, 2016-03-21 at 15:30 -0400, Alan Stern wrote: > On Mon, 21 Mar 2016, Oliver Neukum wrote: > > > We have an autosuspend timeout because we think that IO, if it will > > come at all, is likeliest to come soon. If, however, the IO is > > periodic that heuristics is false. > > To save most pow

[PATCH] sur40:fix DMA on stack

2016-03-22 Thread Oliver Neukum
During the initialisation that driver uses a buffer on the stack for DMA. That violates the cache coherency rules. The fix is to allocate the buffer with kmalloc(). Signed-off-by: Oliver Neukum --- drivers/input/touchscreen/sur40.c | 20 1 file changed, 12 insertions(+), 8 d

Re: 答复: 答复: 【xhci】suspend and resume core dump problem

2016-03-22 Thread Mathias Nyman
On 22.03.2016 08:05, Lipengcheng wrote: Hi, Why is that function failing? That seems suspicious. According to the analysis, in list_for_each_entry_safe(tt, n, &xhci->rh_bw[i].tts, tt_list) function, (tt->tt_list).prev=0x0. When list_del(&tt->tt_list) causing to core dump. Looks

Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

2016-03-22 Thread Linus Walleij
On Fri, Mar 4, 2016 at 5:19 PM, Thierry Reding wrote: > From: Thierry Reding > > The NVIDIA Tegra XUSB pad controller provides a set of pads, each with a > set of lanes that are used for PCIe, SATA and USB. > > Signed-off-by: Thierry Reding > --- > Changes in v10: > - clarify that the hardware

Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-22 Thread Mathias Nyman
On 22.03.2016 07:19, Rajesh Bhagat wrote: -Original Message- From: Mathias Nyman [mailto:mathias.ny...@intel.com] Sent: Monday, March 21, 2016 2:46 PM To: Rajesh Bhagat ; Mathias Nyman ; linux-usb@vger.kernel.org; linux- ker...@vger.kernel.org Cc: gre...@linuxfoundation.org; Sriram Das

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-22 Thread Alan Stern
On Tue, 22 Mar 2016, Oliver Neukum wrote: > On Mon, 2016-03-21 at 15:30 -0400, Alan Stern wrote: > > On Mon, 21 Mar 2016, Oliver Neukum wrote: > > > > > > We have an autosuspend timeout because we think that IO, if it will > > > come at all, is likeliest to come soon. If, however, the IO is > >

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-22 Thread Oliver Neukum
On Tue, 2016-03-22 at 10:21 -0400, Alan Stern wrote: > I don't see any point in resuming the device just in order to collect > operating statistics. If it was already suspended then it wasn't > operating, so there will be no statistics to collect. Indeed. In that case the point is moot. But it

[PATCH 2/4] aiptek: stop saving struct usb_device

2016-03-22 Thread Oliver Neukum
The device can now easily be derived from the interface. Stop leaving a private copy. Signed-off-by: Oliver Neukum --- drivers/input/tablet/aiptek.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.

[PATCH 3/4] gtco: stop saving struct usb_device

2016-03-22 Thread Oliver Neukum
The device can now easily be derived from the interface. Stop leaving a private copy. Signed-off-by: Oliver Neukum --- drivers/input/tablet/gtco.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtc

[PATCH 0/4] tablet: remove private copy to USB device

2016-03-22 Thread Oliver Neukum
We now have a macro to easily get to the USB device from the interface. So we are cleaning up all drivers to not store a private pointer. Oliver Neukum (4): acecad: stop saving struct usb_device aiptek: stop saving struct usb_device gtco: stop saving struct usb_device kbtab: stop saving st

[PATCH 1/4] acecad: stop saving struct usb_device

2016-03-22 Thread Oliver Neukum
The device can now easily be derived from the interface. Stop leaving a private copy. Signed-off-by: Oliver Neukum --- drivers/input/tablet/acecad.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/input/tablet/acecad.c b/drivers/input/tablet/acecad.c inde

[PATCH 4/4] kbtab: stop saving struct usb_device

2016-03-22 Thread Oliver Neukum
The device can now easily be derived from the interface. Stop leaving a private copy. Signed-off-by: Oliver Neukum --- drivers/input/tablet/kbtab.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/tablet/kbtab.c b/drivers/input/tablet/kbtab.c index d2ac7c

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-22 Thread Alan Stern
On Tue, 22 Mar 2016, Oliver Neukum wrote: > On Tue, 2016-03-22 at 10:21 -0400, Alan Stern wrote: > > I don't see any point in resuming the device just in order to collect > > operating statistics. If it was already suspended then it wasn't > > operating, so there will be no statistics to collec

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-22 Thread Oliver Neukum
On Tue, 2016-03-22 at 11:13 -0400, Alan Stern wrote: > > Indeed. In that case the point is moot. But it is correct to ask > > the core whether the device is autosuspended at that point rather > > than keep a private flag if you can. > > That's why we have pm_runtime_status_suspended(). I guess we

[PATCH] Add DCD line support to CP210x driver

2016-03-22 Thread Valentin Yakovenkov
This patch adds DCD line support to CP210x USB serial driver. First it enables CP210x events embedding to incoming URB's by calling: cp210x_set_config_single(port, CP210X_EMBED_EVENTS, CP210X_ESCCHAR); Then it parses incoming URB's via custom routine: cp210x_process_read_urb(...) searches for eve

[RFC] xhci: one more quirk for PANTHERPOINT

2016-03-22 Thread Oliver Neukum
A T430 is reported to also need XHCI_SLOW_SUSPEND, lest a power off turn into a reboot. Signed-off-by: Oliver Neukum --- drivers/usb/host/xhci-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index f0640b7..604

[RFC] PANTHERPOINT needing yet another quirk

2016-03-22 Thread Oliver Neukum
I have a report of a T430 laptop needing this unless you want shut downs turn into reboot. Is there any hope of investigating this further at Intel, or do we go for the cautious approach? Oliver Neukum (1): xhci: one more quirk for PANTHERPOINT drivers/usb/host/xhci-pci.c | 4 +++- 1 file chan

Re: [PATCH 2/4] aiptek: stop saving struct usb_device

2016-03-22 Thread kbuild test robot
Hi Oliver, [auto build test WARNING on input/next] [also build test WARNING on v4.5 next-20160322] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Oliver-Neukum/tablet-remove-private-copy-to

[PATCH] aiptek: fix semicolon.cocci warnings

2016-03-22 Thread kbuild test robot
drivers/input/tablet/aiptek.c:849:54-55: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Oliver Neukum Signed-off-by: Fengguang Wu --- aiptek.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/tablet/aipte

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-22 Thread John Youn
On 3/18/2016 10:21 PM, Doug Anderson wrote: > Hi, > > On Wed, Mar 16, 2016 at 11:28 AM, John Youn wrote: >> On 3/10/2016 11:14 AM, John Youn wrote: >>> On 3/9/2016 11:06 AM, Doug Anderson wrote: Stefan, On Wed, Mar 9, 2016 at 11:01 AM, Stefan Wahren wrote: > >> Doug

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-22 Thread Doug Anderson
John, On Tue, Mar 22, 2016 at 12:26 PM, John Youn wrote: > Thanks for the debug logs and everyones help. > > After reviewing with our hardware engineers, it seems this is likely > to do with the IDDIG debounce filtering when switching between > modes. You can see if this is enabled in your core b

Re: [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading

2016-03-22 Thread Andreas Färber
Hi Hans, Am 21.03.2016 um 23:13 schrieb Hans de Goede: > Add a missing MODULE_DEVICE_TABLE() line which was causing the > sunxi-musb glue to not auto-load when build as a module. "built" > Should this get a Fixes: header for backporting to stable? > Signed-off-by: Hans de Goede > --- > driv

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-22 Thread John Youn
On 3/22/2016 12:44 PM, Doug Anderson wrote: > John, > > On Tue, Mar 22, 2016 at 12:26 PM, John Youn wrote: >> Thanks for the debug logs and everyones help. >> >> After reviewing with our hardware engineers, it seems this is likely >> to do with the IDDIG debounce filtering when switching between

Re: [linux-sunxi] Re: [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading

2016-03-22 Thread Hans de Goede
Hi, On 22-03-16 21:12, Andreas Färber wrote: Hi Hans, Am 21.03.2016 um 23:13 schrieb Hans de Goede: Add a missing MODULE_DEVICE_TABLE() line which was causing the sunxi-musb glue to not auto-load when build as a module. "built" Thanks. Should this get a Fixes: header for backporting to s

RE: [PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread fx IWATA NOBUO
our patch is applied to the > wrong git tree, please drop us a note to help improving the system] > > url: > https://github.com/0day-ci/linux/commits/Nobuo-Iwata/usbip-event-handl > er-as-one-thread/20160322-161050 > config: xtensa-allmodconfig (attached as .config) > reproduc

Re: [PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread gre...@linuxfoundation.org
On Tue, Mar 22, 2016 at 11:45:16PM +, fx IWATA NOBUO wrote: > Hi, > > The errors are cleared by patch 2/2. That's not ok, you can not have one patch that adds errors and the second fixes it. Each has to have no problems on their own. > Should I complete in patch 1/2? You need to fix patch

Re: [PATCH v3] usb: phy: mxs: Add DT bindings to configure TX settings

2016-03-22 Thread Peter Chen
On Tue, Mar 22, 2016 at 12:32 AM, Jaret Cantu wrote: > The TX settings can be calibrated for particular hardware. The > phy is reset by Linux, so this cannot be handled by the bootloader. > > The TRM mentions that the maximum resistance should be used for the > DN/DP calibration in order to pass

RE: [PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread fx IWATA NOBUO
Hello Greg, > adds errors and the second fixes it. I divided patches as 1/2 event handler itself 2/2 programs use event handler. So, programs use event handler which will be modified by 2/2 has errors at 1/2. > You need to fix patch 1/2 Could I send as one patch? Thank you, Nobuo // > -O

Re: [PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread gre...@linuxfoundation.org
On Wed, Mar 23, 2016 at 01:54:21AM +, fx IWATA NOBUO wrote: > Hello Greg, > > > adds errors and the second fixes it. > > I divided patches as > 1/2 event handler itself > 2/2 programs use event handler. > > So, programs use event handler which will be modified by 2/2 has errors at > 1/2. T

Re: 答复: 答复: 答复: 【xhci】suspend and resume core dump problem

2016-03-22 Thread Lu Baolu
On 03/22/2016 08:09 PM, Lipengcheng wrote: >> >diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c >> >index fbf75e5..406c872 100644 >> >--- a/drivers/usb/host/xhci-mem.c >> >+++ b/drivers/usb/host/xhci-mem.c >> >@@ -1856,6 +1856,7 @@ no_bw: >> > kfree(xhci->usb3_ports);

RE: [PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread fx IWATA NOBUO
> > So, programs use event handler which will be modified by 2/2 has errors > at 1/2. > > That's a problem, we can not accept patches like this. > > Could I send as one patch? > > Maybe, it's your decision on how to do this best. OK. Thank you for your help, n.iwata // > -Original Messag

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-22 Thread Rajesh Bhagat
> -Original Message- > From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com] > Sent: Tuesday, March 22, 2016 5:36 PM > To: Rajesh Bhagat > Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org; linux- > ker...@vger.kernel.org; Sriram Dash > Subject: Re: [PATCH] usb: xhci: Fix i

Re: [PATCH v3] usb: phy: mxs: Add DT bindings to configure TX settings

2016-03-22 Thread Peter Chen
On Mon, Mar 21, 2016 at 12:32:27PM -0400, Jaret Cantu wrote: > The TX settings can be calibrated for particular hardware. The > phy is reset by Linux, so this cannot be handled by the bootloader. > > The TRM mentions that the maximum resistance should be used for the > DN/DP calibration in order