Re: Freezable workqueue blocks non-freezable workqueue during the system resume process

2016-03-19 Thread Tejun Heo
Hello, Jan, Alan. On Tue, Mar 15, 2016 at 10:25:43AM +0100, Jan Kara wrote: > > The kernel does suspend device drivers; that is, it invokes their > > suspend callbacks. But it doesn't "freeze" them in any sense. Once a > > driver has been suspended, it assumes it won't receive any I/O requests

Re: [PATCH] usb_driver_claim_interface: add sanity checking

2016-03-19 Thread Oliver Neukum
On Thu, 2016-03-17 at 12:44 +0100, Oliver Neukum wrote: > On Wed, 2016-03-16 at 10:41 -0400, Alan Stern wrote: > > > While adding your check to usb_driver_claim_interface() is a reasonable > > thing to do, it might not solve all the problems. A driver might still > > try to use the invalid interf

Re: PROBLEM: Osprey 2 Mini sometimes resets every 200ms forever

2016-03-19 Thread ais523
On Thu, 2016-03-17 at 15:09 -0400, Alan Stern wrote: > On Thu, 17 Mar 2016, ais523 wrote: > > > > There's no question about it -- your problem is caused by a buggy > > > device. > > > > This actually doesn't surprise me at all; I became suspicious when I > > saw that the serial number was 012345

Re: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit()

2016-03-19 Thread John Youn
On 3/16/2016 6:56 AM, Felipe Balbi wrote: > > heh, +john > > Felipe Balbi writes: >> [ text/plain ] >> >> Hi, >> >> Roger Quadros writes: >>> [ text/plain ] >>> We will need this function for a workaround. >>> The function issues a softreset only to the device >>> controller and performs minima

Re: [PATCH v2] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

2016-03-19 Thread Babu Moger
Its been a while since I submit this patch. Ping 1. On 1/8/2016 9:39 AM, Babu Moger wrote: > I have never seen auto handoff working on TI and RENESAS cards. > Eventually, we force handoff. This code forces the handoff > unconditionally. It saves 5 seconds boot time for each card. > > Signed-off

Re: [PATCH v2 11/11] usb: musb: da8xx: Remove mach code

2016-03-19 Thread Sergei Shtylyov
On 3/17/2016 5:26 AM, David Lechner wrote: Use the new phy-da8xx-usb driver to take the place of the mach code that pokes CFGCHIP2 in the da8xx musb glue driver. Signed-off-by: David Lechner --- v2 changes: This is part of a previous patch that was split. This version uses the new phy driver

[PATCH] digi_acceleport: do sanity checking for the number of ports

2016-03-19 Thread Oliver Neukum
The driver can be crashed with devices that expose crafted descriptors with too few endpoints. See: http://seclists.org/bugtraq/2016/Mar/61 Signed-off-by: Oliver Neukum --- drivers/usb/serial/digi_acceleport.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/serial/digi_accel

Re: [PATCH v2 00/11] da8xx USB clocks

2016-03-19 Thread Sergei Shtylyov
On 3/17/2016 5:26 AM, David Lechner wrote: OK, ready for round two. You're quick... :-) I've added a new callback in the davinci clocks so that they can properly handle clock muxing. The clock functions are pretty much the same as in the previous patch set other than clk_set_parent() now

Re: [PATCH v10 7/9] dt-bindings: usb: xhci-tegra: Add Tegra210 XUSB controller support

2016-03-19 Thread Stephen Warren
On 03/04/2016 09:19 AM, Thierry Reding wrote: From: Thierry Reding Extend the Tegra XUSB controller device tree binding with Tegra210 support. Acked-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.o

[PATCH v5 4/6] usb: mux: add driver for Intel gpio controlled port mux

2016-03-19 Thread Lu Baolu
In some Intel platforms, a single usb port is shared between USB host and device controller. The shared port is under control of GPIO pins. This patch adds the support for USB GPIO controlled port mux. Signed-off-by: David Cohen Signed-off-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed-by:

RE: USB Ethernet/RNDIS Gadget issue

2016-03-19 Thread Gil Weber
Hi, > interesting. Wonder what Windows is doing differently. Yeah, I guess the > best way forward is to find which commit caused the regression and git > bisect is the way to do that. Would be nice to see v3.13, v3.14, > v3.15... are working or not. The idea is to find the smallest interval > for

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 09:54:14 Peter Chen wrote: > > > > I don't think it's a very widespread problem, there are only very few > > developers that intentionally use this method, and some use the > > platform_device_register_full() call to create a device with a known > > mask, which is generally

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-19 Thread Martin Sperl
> On 19.03.2016, at 03:17, Eric Anholt wrote: > > Stefan Wahren writes: > >> Hi Eric, >> hi Martin, >> >>> John Youn hat am 16. März 2016 um 19:28 >>> geschrieben: >>> >>> >>> On 3/10/2016 11:14 AM, John Youn wrote: On 3/9/2016 11:06 AM, Doug Anderson wrote: > > John: it's p

Re: [PATCH 2/3] usb: dwc3: increase maximum number of TRBs per endpoint

2016-03-19 Thread Bin Liu
Hi, On Fri, Mar 11, 2016 at 6:54 AM, Felipe Balbi wrote: > previously we were using a maximum of 32 TRBs per > endpoint. With each TRB being 16 bytes long, we were > using 512 bytes of memory for each endpoint. > > However, SLAB/SLUB will always allocate PAGE_SIZE > chunks. In order to better uti

Re: [PATCH v1 1/5] usb: gadged: pch_udc: PCI core handles power state for us

2016-03-19 Thread kbuild test robot
Hi Andy, [auto build test ERROR on v4.5-rc7] [also build test ERROR on next-20160318] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/usb-gadged-pch_udc-PCI-core-handles-power-s

Re: [PATCH] digi_acceleport: do sanity checking for the number of ports

2016-03-19 Thread Johan Hovold
On Thu, Mar 17, 2016 at 12:17:34PM +0100, Oliver Neukum wrote: > On Wed, 2016-03-16 at 10:58 -0400, Johan Hovold wrote: > > Note that this needs to be done for not just the port structure > > (ds_oob_port) by making sure that the serial->num_ports is large > > enough, > > but also that the oob-port

Re: [PATCH] usb_driver_claim_interface: add sanity checking

2016-03-19 Thread Oliver Neukum
On Wed, 2016-03-16 at 10:08 -0400, Alan Stern wrote: > On Wed, 16 Mar 2016, Oliver Neukum wrote: > > > Attacks that trick drivers into passing a NULL pointer > > to usb_driver_claim_interface() using forged descriptors are > > known. This thwarts them by sanity checking. > > I'm curious -- how do

Re: rtl8xxxu 4.4.5(from f23): I get a panic adding a new device to the driver

2016-03-19 Thread Jes Sorensen
Greg KH writes: > On Thu, Mar 17, 2016 at 09:01:25PM +0100, poma wrote: >> On 17.03.2016 19:02, Jes Sorensen wrote: >> > Jes Sorensen writes: >> >> Xose Vazquez Perez writes: >> >>> Hi, >> >>> >> >>> If I do: >> >>> # echo "0bda 8176" > /sys/bus/usb/drivers/rtl8xxxu/new_id >> >> >> >> Hi Xose, >

[PATCH] cypress_m8: add sanity checking

2016-03-19 Thread Oliver Neukum
An attack using missing endpoints exists. CVE-2016-3137 Signed-off-by: Oliver Neukum CC: sta...@vger.kernel.org --- drivers/usb/serial/cypress_m8.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c i

[PATCH v4 6/7] usb: pci-quirks: add Intel USB drcfg mux device

2016-03-19 Thread Lu Baolu
In some Intel platforms, a single usb port is shared between USB host and device controllers. The shared port is under control of a switch which is defined in the Intel vendor defined extended capability for xHCI. This patch adds the support to detect and create the platform device for the port mu

Crash when resuming system (related to USB?) with 4.4

2016-03-19 Thread Frederik Himpe
Half of the time when resuming my system, it completely hangs. I managed to find this trace in pstore: ==./dmesg-efi-145829002001001== Oops#1 Part1 <4>[20505.738344]  [] ? hub_event+0x75d/0x14f0 [usbcore] <4>[20505.738413]  [] ? process_one_work+0x157/0x410 <4>[20505.738474]  [] ? worker_thread+

Re: [PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-19 Thread Chanwoo Choi
Hi Lu, On 2016년 03월 17일 16:16, Lu Baolu wrote: > Hi Chanwoo, > > On 03/17/2016 02:07 PM, Chanwoo Choi wrote: >> Hi Lu, >> >> To handle extcon (external connector), I implemented the unique id >> for each external connector on patch[1] instead of using the ambiguous >> string type. >> [1] 2a9de9

[PATCH v2 08/11] ARM: dt: da850: Add usb phy node

2016-03-19 Thread David Lechner
Add a node for the new usb phy driver. Signed-off-by: David Lechner --- v2 changes: This is new patch in v2. arch/arm/boot/dts/da850.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 591660d..06f36cd 100644 --- a/a

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-19 Thread Mark Brown
On Wed, Mar 16, 2016 at 01:05:27PM +0200, Felipe Balbi wrote: > Mark Brown writes: > > On Mon, Feb 29, 2016 at 11:22:12PM +0900, Mark Brown wrote: > >> On Mon, Jan 04, 2016 at 11:04:26AM +0800, Baolin Wang wrote: > > I see Felipe is no longer at TI so his e-mail was bouncing - let's > > resend th

Re: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

2016-03-19 Thread Sergei Shtylyov
Hello. On 3/16/2016 1:37 AM, David Lechner wrote: Up to this point, the USB phy clock configuration was handled manually in the board files and in the usb drivers. This adds proper clocks so that the usb drivers can use clk_get and clk_enable and not have to worry about the details. Also, the r

[PATCH 0/2] usb: dwc3: gadget: Fix erratic interrupts and delayed enumeration

2016-03-19 Thread Roger Quadros
Hi, The existing workaround (for STAR#9000525659) of forcing DEVSPD to SUPER_SPEED for HIGH_SPEED ports is causing another side effect which causes erratic interrupts and delayed gadget enumeration of upto 2 seconds. Work around the run/stop issue by detecting if it happened using debug LTSSM sta

Re: [PATCH] usb_driver_claim_interface: add sanity checking

2016-03-19 Thread Alan Stern
On Wed, 16 Mar 2016, Oliver Neukum wrote: > On Wed, 2016-03-16 at 10:08 -0400, Alan Stern wrote: > > On Wed, 16 Mar 2016, Oliver Neukum wrote: > > > > > Attacks that trick drivers into passing a NULL pointer > > > to usb_driver_claim_interface() using forged descriptors are > > > known. This thwa

Re: [PATCH v2 09/11] usb: ohci-da8xx: Remove code that references mach

2016-03-19 Thread Sergei Shtylyov
On 3/17/2016 5:26 AM, David Lechner wrote: Including mach/* is frowned upon in device drivers, so get rid of it. This replaces usb20_clk and code that pokes CFGCHIP2 with a proper phy driver. Signed-off-by: David Lechner --- v2 changes: Uses the new phy driver instead of using a second clock

Re: [PATCH] usb/core: usb_alloc_dev(): fix setting of ->portnum

2016-03-19 Thread Nicolai Stange
Please drop in favour of v2 where the issue reported by the kbuild test robot has been fixed. Thanks and sorry, Nicolai -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo

Re: [PATCH] cypress_m8: add sanity checking

2016-03-19 Thread Johan Hovold
On Wed, Mar 16, 2016 at 03:19:49PM +0100, Oliver Neukum wrote: > An attack using missing endpoints exists. > CVE-2016-3137 > > Signed-off-by: Oliver Neukum > CC: sta...@vger.kernel.org > --- > drivers/usb/serial/cypress_m8.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/us

[RFT] digi_acceleport: do sanity checking for the number of ports

2016-03-19 Thread Oliver Neukum
The driver can be crashed with devices that expose crafted descriptors with too few endpoints. See: http://seclists.org/bugtraq/2016/Mar/61 Signed-off-by: Oliver Neukum --- drivers/usb/serial/digi_acceleport.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/serial/digi_accel

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-19 Thread David Miller
From: Schemmel Hans-Christoph Date: Thu, 17 Mar 2016 10:07:56 + > Added support for Gemalto's Cinterion PHxx WWAN interfaces > by adding QMI_FIXED_INTF with Cinterion's VID and PID. > > PHxx can have: > 2 RmNet Interfaces (PID 0x0082) or > 1 RmNet + 1 USB Audio interface (PID 0x0083). > >

RE: [PATCH 2/3] usb: dwc3: increase maximum number of TRBs per endpoint

2016-03-19 Thread Felipe Balbi
Hi, David Laight writes: > [ text/plain ] > From: Felipe Balbi >> Bin Liu writes: >> > [ text/plain ] >> > Hi, >> > >> > On Fri, Mar 11, 2016 at 6:54 AM, Felipe Balbi >> > wrote: >> >> previously we were using a maximum of 32 TRBs per >> >> endpoint. With each TRB being 16 bytes long, we were

Re: [Intel-gfx] [PATCH 1/3] pinctrl: Intel: add RX invertion config

2016-03-19 Thread Jani Nikula
On Thu, 17 Mar 2016, Linus Walleij wrote: > On Wed, Mar 16, 2016 at 2:34 PM, Daniel Vetter wrote: >> On Wed, Mar 16, 2016 at 01:27:49PM +0100, Linus Walleij wrote: > >>> - What is a HPD interrupt? >> >> hotplug interrupt, fires when you plug in a cable. >> >>> - What is a Type-C DP HPD? >> >> usb

Re: [PATCH] USB: serial: ftdi_sio: Add support for ICP DAS I-756xU devices

2016-03-19 Thread Josh Boyer
On Thu, Mar 10, 2016 at 9:48 AM, Josh Boyer wrote: > A Fedora user reports that the ftdi_sio driver works properly for the > ICP DAS I-7561U device. Further, the user manual for these devices > instructs users to load the driver and add the ids using the sysfs > interface. > > Add support for the

[PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks

2016-03-19 Thread David Lechner
Up to this point, the USB phy clock configuration was handled manually in the board files and in the usb drivers. This adds proper clocks so that the usb drivers can use clk_get and clk_enable and not have to worry about the details. Also, the related code is removed from the board files. Signed-o

Re: USB Sound oops in Linus's latest tree

2016-03-19 Thread Greg KH
On Fri, Mar 18, 2016 at 11:43:43PM +0100, Nicolai Stange wrote: > Greg KH writes: > > > Hi, > > > > I'm getting the following oops with my USB sound device using Linus's > > latest tree of the moment, which has the sound tree pull in it. Anyone > > seen this before? > > Yes, and a fix is on its

Re: [PATCH 3/5] ARM: davinci: da8xx: add cfgchip2 to resources

2016-03-19 Thread Sergei Shtylyov
On 03/16/2016 07:57 AM, David Lechner wrote: No, this register is shared b/w MUSB and OHCI. The proper thing to do is to write the PHY driver and let it control this shared register. OK. I've started working on this. I am looking at using struct usb_phy, however, enum usb_phy_type only has

Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework

2016-03-19 Thread Oliver Neukum
On Wed, 2016-03-16 at 19:46 +0800, Baolin Wang wrote: > This patch introduces the usb charger driver based on usb gadget that > makes an enhancement to a power driver. It works well in practice but > that requires a system with suitable hardware. > > The basic conception of the usb charger is that

Re: [PATCH] digi_acceleport: do sanity checking for the number of ports

2016-03-19 Thread Johan Hovold
On Wed, Mar 16, 2016 at 02:43:02PM +0100, Oliver Neukum wrote: > The driver can be crashed with devices that expose crafted > descriptors with too few endpoints. > See: > http://seclists.org/bugtraq/2016/Mar/61 > > Signed-off-by: Oliver Neukum > --- > drivers/usb/serial/digi_acceleport.c | 5 +++

Re: [Xen-devel] [Patch V4 0/3] xen, usb: support pvUSB frontend driver

2016-03-19 Thread Juergen Gross
Hi Oleksandr, On 17/03/16 20:43, Oleksandr Tyshchenko wrote: > Hi Juergen, All. > > I would like to apply PVUSB drivers for using in our platform while > PVUSB stuff doesn't reach upstream. > > Unfortunately, I couldn't find more recent version of "kernel based" > backend driver in mailing list.

Re: problems with cp210x

2016-03-19 Thread walter harms
Am 17.03.2016 18:04, schrieb Greg KH: > On Thu, Mar 17, 2016 at 05:41:13PM +0100, walter harms wrote: >> >> >> Am 29.02.2016 17:10, schrieb Greg KH: >>> On Mon, Feb 29, 2016 at 02:47:45PM +0100, walter harms wrote: Hello List, is someone aware of a problem with DTR in that driver ?

RE: USB Ethernet/RNDIS Gadget issue

2016-03-19 Thread Gil Weber
Hi, I finally bisect the kernel (I didn't known that command, thanks for the tip) and found that it doesn't work anymore from this commit : b0bac2581c1918cc4ab0aca01977ad69f0bc127a is the first bad commit commit b0bac2581c1918cc4ab0aca01977ad69f0bc127a Author: R

Re: [PATCH] USB: qmi_wwan: add Dell Wireless 5809e Gobi 4G HSPA+ (rev3)

2016-03-19 Thread Bjørn Mork
Patrik Halfar writes: > --- a/drivers/net/usb/qmi_wwan.c > +++ b/drivers/net/usb/qmi_wwan.c > @@ -884,6 +884,7 @@ static const struct usb_device_id products[] = { > {QMI_FIXED_INTF(0x413c, 0x81a8, 8)},/* Dell Wireless 5808 Gobi(TM) > 4G LTE Mobile Broadband Card */ > {QMI_FIXED_I

Re: [GIT PULL] USB driver patches for 4.6-rc1

2016-03-19 Thread Linus Torvalds
On Fri, Mar 18, 2016 at 2:43 PM, Linus Torvalds wrote: > > Something in this - or possibly the tty pull, but that doesn't sound > very likely - has killed my USB keyboard on my desktop. Yeah, the bisect is now solidly in the usb part. The machine has 00:14.0 USB controller: Intel Corporation Su

[PATCH 4/5] usb: host: xhci-plat: enable BROKEN_PE quirk if platform requested

2016-03-19 Thread Roger Quadros
From: Felipe Balbi In case a broken pe flag is passed in via pdata, we should enable the corresponding BROKEN_PE quirk flag for XHCI core. Signed-off-by: Felipe Balbi Signed-off-by: Sekhar Nori Signed-off-by: Roger Quadros --- drivers/usb/host/xhci-plat.c | 3 +++ 1 file changed, 3 insertion

[PATCH v5 2/6] extcon: usb-gpio: add support for ACPI gpio interface

2016-03-19 Thread Lu Baolu
GPIO resource could be retrieved through APCI as well. Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi Acked-by: Chanwoo Choi --- drivers/extcon/extcon-usb-gpio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-us

Re: [PATCH 3/5] ARM: davinci: da8xx: add cfgchip2 to resources

2016-03-19 Thread David Lechner
On 03/16/2016 01:22 PM, Sergei Shtylyov wrote: The set_mode() method doesn't have anything to do with the predefined roles. What CFGCHIP2 setting do is to override the ID input (and also the VBUS level comparator). This is not required for the normal functioning of either host or peripheral

Re: PROBLEM: Osprey 2 Mini sometimes resets every 200ms forever

2016-03-19 Thread ais523
On Thu, 2016-03-17 at 13:32 -0400, Alan Stern wrote: > In fact both logs show a loop of resets. I'll focus on just the > first reset. > > > No reset loop: > ... > > 880118636a80 189630599 S Bo:1:006:1 -115 31 = 55534243 1f00 > 0200 80010a51 0002 00 > > 88

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-19 Thread Stefan Wahren
Hi, > Eric Anholt hat am 19. März 2016 um 03:17 geschrieben: > > > Stefan Wahren writes: > > > Hi Eric, > > hi Martin, > > > >> John Youn hat am 16. März 2016 um 19:28 > >> geschrieben: > >> > >> > >> On 3/10/2016 11:14 AM, John Youn wrote: > >> > On 3/9/2016 11:06 AM, Doug Anderson wrote: > >>

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-19 Thread Stefan Wahren
Hi, > Martin Sperl hat am 19. März 2016 um 08:44 > geschrieben: > > > > > On 19.03.2016, at 03:17, Eric Anholt wrote: > > > > Stefan Wahren writes: > > > >> Hi Eric, > >> hi Martin, > >> > >>> John Youn hat am 16. März 2016 um 19:28 > >>> geschrieben: > >>> > >>> > >>> On 3/10/2016 11:14 AM, J

[PATCH] uas: Limit qdepth at the scsi-host level

2016-03-19 Thread Hans de Goede
Commit 64d513ac31bd ("scsi: use host wide tags by default") causes the scsi-core to queue more cmnds then we can handle on devices with multiple LUNs, limit the qdepth at the scsi-host level instead of per slave to fix this. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1315013 Cc: sta...@v

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-19 Thread Martin Sperl
> On 19.03.2016, at 10:52, Stefan Wahren wrote: > > Hi, > >> Martin Sperl hat am 19. März 2016 um 08:44 >> geschrieben: >> >> >> >>> On 19.03.2016, at 03:17, Eric Anholt wrote: >>> >>> Stefan Wahren writes: >>> Hi Eric, hi Martin, > John Youn hat am 16. März 2016 um

Re: [PATCH 2/2] usb: dwc3: gadget: usb: dwc3: run/stop metastability workaround

2016-03-19 Thread Felipe Balbi
Roger Quadros writes: > [ text/plain ] > The existing workaround of forcing DEVSPD to SUPER_SPEED > for HIGH_SPEED ports is causing another side effect > which causes erratic interrupts and delayed gadget > enumeration of upto 2 seconds. > > Work around the run/stop issue by detecting if > it hap

Re: Composite USB device reset /drivers/usb/core/hub.c - binding order problem

2016-03-19 Thread Alan Stern
On Thu, 17 Mar 2016, Mikolaj Ch wrote: > Hi, > > I have a composite usb device where order of binding the drivers to > interfaces matters. > When the device is plugged in binding is from 0-th till n-th interface > but in usb_reset_device function in /drivers/usb/core/hub.c after > reset binding

Re: [PATCH 5/5] usb: musb-da8xx: remove board-specific clock handling

2016-03-19 Thread Sergei Shtylyov
Hello. On 3/16/2016 1:37 AM, David Lechner wrote: This driver should not have to worry about how the clocks are configured on a system. Added a usb20_phy clock to handle the USB 2.0 PLL clock externally. Also changed to using devm_ to simplify code a bit. This should preferably be split t

Re: PROBLEM: Osprey 2 Mini sometimes resets every 200ms forever

2016-03-19 Thread Alan Stern
On Wed, 16 Mar 2016, ais523 wrote: > On Wed, 2016-03-16 at 10:07 -0400, Alan Stern wrote: > > On Wed, 16 Mar 2016, ais523 wrote: > > > One line summary of the problem: > > > Connecting an Osprey 2 Mini sometimes causes it to reset every > > 200ms > > > > Please post a usbmon trace showing what hap

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-19 Thread Peter Chen
On Thu, Mar 17, 2016 at 04:52:55PM +0100, Arnd Bergmann wrote: > On Monday 14 March 2016 18:51:08 Peter Chen wrote: > > On Wed, Mar 09, 2016 at 05:16:50PM -0600, Li Yang wrote: > > > On Tue, Mar 8, 2016 at 9:40 PM, Bjorn Andersson > > > wrote: > > > > On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrot

[PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-19 Thread Schemmel Hans-Christoph
Added support for Gemalto's Cinterion PHxx WWAN interfaces by adding QMI_FIXED_INTF with Cinterion's VID and PID. PHxx can have: 2 RmNet Interfaces (PID 0x0082) or 1 RmNet + 1 USB Audio interface (PID 0x0083). Signed-off-by: Hans-Christoph Schemmel --- patch is against linux-4.5 --- linux/drive

Re: usb: dwc2: Kernel 4.5 and socfpga problem

2016-03-19 Thread Phil Reid
On 18/03/2016 10:41 PM, Dinh Nguyen wrote: On 03/17/2016 09:35 PM, Phil Reid wrote: G'day, Has anyone successful run the usb dwc2 from kenerl 4.5 on an socfpga. Yes. I just tested on the devkit and USB is working fine: [0.655761] ffb4.usb supply vusb_d not found, using dummy regula

Re: problems with cp210x

2016-03-19 Thread Greg KH
On Thu, Mar 17, 2016 at 05:41:13PM +0100, walter harms wrote: > > > Am 29.02.2016 17:10, schrieb Greg KH: > > On Mon, Feb 29, 2016 at 02:47:45PM +0100, walter harms wrote: > >> Hello List, > >> > >> is someone aware of a problem with DTR in that driver ? > >> > >> I use: Linux version 3.4.53-MMI-

Re: [PATCH v7 2/4] gadget: Support for the usb charger framework

2016-03-19 Thread kbuild test robot
Hi Baolin, [auto build test WARNING on v4.5-rc7] [also build test WARNING on next-20160316] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Baolin-Wang/Introduce-usb-charger-framework-to-deal-w

Re: [PATCH] usb_driver_claim_interface: add sanity checking

2016-03-19 Thread Alan Stern
On Wed, 16 Mar 2016, Oliver Neukum wrote: > Attacks that trick drivers into passing a NULL pointer > to usb_driver_claim_interface() using forged descriptors are > known. This thwarts them by sanity checking. I'm curious -- how do these attacks carry out their trickery? Alan Stern -- To unsubsc

Re: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit()

2016-03-19 Thread Felipe Balbi
heh, +john Felipe Balbi writes: > [ text/plain ] > > Hi, > > Roger Quadros writes: >> [ text/plain ] >> We will need this function for a workaround. >> The function issues a softreset only to the device >> controller and performs minimal re-initialization >> so that the device controller can be

[PATCH v2 00/11] da8xx USB clocks

2016-03-19 Thread David Lechner
OK, ready for round two. I've added a new callback in the davinci clocks so that they can properly handle clock muxing. The clock functions are pretty much the same as in the previous patch set other than clk_set_parent() now works. The next new thing is a phy driver for the CFGCHIP2 register tha

[PATCH] usb: dwc2: do not override forced dr_mode in gadget setup

2016-03-19 Thread Przemek Rudy
The host/device mode set with dr_mode should be kept all the time, not being changed to OTG in gadget setup (by overriding CFGUSB_FORCEDEVMODE and CFGUSB_FORCEHOSTMODE bits). Signed-off-by: Przemek Rudy --- drivers/usb/dwc2/gadget.c | 23 ++- 1 file changed, 18 insertions(+),

Re: [PATCH] digi_acceleport: do sanity checking for the number of ports

2016-03-19 Thread Oliver Neukum
On Wed, 2016-03-16 at 10:58 -0400, Johan Hovold wrote: > Note that this needs to be done for not just the port structure > (ds_oob_port) by making sure that the serial->num_ports is large > enough, > but also that the oob-port has indeed got a write urb allocated (i.e. > that all expected bulk-out

RE: RE

2016-03-19 Thread Robert
Please confirm receipt of my previous mail..When can i call you -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 11/11] usb: musb: da8xx: Remove mach code

2016-03-19 Thread David Lechner
Use the new phy-da8xx-usb driver to take the place of the mach code that pokes CFGCHIP2 in the da8xx musb glue driver. Signed-off-by: David Lechner --- v2 changes: This is part of a previous patch that was split. This version uses the new phy driver instead of a second clock. It also gets rid of

[PATCH] Input: gtco: fix crash on detecting device without endpoints

2016-03-19 Thread Vladis Dronov
The gtco driver expects at least one valid endpoint. If given malicious descriptors that specify 0 for the number of endpoints, it will crash in the probe function. Ensure there is at least one endpoint on the interface before using it. Fix minor coding style issue. The full report of this issue c

[PATCH v5 3/6] usb: mux: add common code for Intel dual role port mux

2016-03-19 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. A usb port mux could be abstracted as the following elements: 1) mux state: HOST or PERIPHERAL; 2) an extcon cable which triggers the change of mux state between HO

RE: USB Ethernet/RNDIS Gadget issue

2016-03-19 Thread Gil Weber
Hi, > > I finally bisect the kernel (I didn't known that command, thanks for the > > tip) > > and found that it doesn't work anymore from this commit : > > > > b0bac2581c1918cc4ab0aca01977ad69f0bc127a is the first bad commit > > commit b0bac2581c1918cc4ab0aca01977ad69f0bc127a > > Author: Robert B

[PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit()

2016-03-19 Thread Roger Quadros
We will need this function for a workaround. The function issues a softreset only to the device controller and performs minimal re-initialization so that the device controller can be usable. As some code is similar to dwc3_core_init() take out common code into dwc3_get_gctl_quirks(). We add a new

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-19 Thread Stefan Wahren
Hi, > Martin Sperl hat am 19. März 2016 um 11:10 > geschrieben: > > > > On 19.03.2016, at 10:52, Stefan Wahren wrote: > > > > Hi, > > > >> Martin Sperl hat am 19. März 2016 um 08:44 > >> geschrieben: > >> > >> > >> > >>> On 19.03.2016, at 03:17, Eric Anholt wrote: > >>> > >>> Stefan Wahren wr

[PATCH v3] cypress_m8: add sanity checking

2016-03-19 Thread Oliver Neukum
An attack using missing endpoints exists. CVE-2016-3137 Signed-off-by: Oliver Neukum CC: sta...@vger.kernel.org v1 - add sanity check v2 - add error logging v3 - correct error message --- drivers/usb/serial/cypress_m8.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --g

Re: ehci and ohci reset number doubt

2016-03-19 Thread gre...@linuxfoundation.org
On Thu, Mar 17, 2016 at 02:16:56AM +, Lipengcheng wrote: > > > Hi, Please resend in non-html format so that the mailing list does not reject your messages. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger

Re: [PATCH v2 09/11] usb: ohci-da8xx: Remove code that references mach

2016-03-19 Thread Alan Stern
On Wed, 16 Mar 2016, David Lechner wrote: > Including mach/* is frowned upon in device drivers, so get rid of it. > > This replaces usb20_clk and code that pokes CFGCHIP2 with a proper phy > driver. > > Signed-off-by: David Lechner > --- > > v2 changes: Uses the new phy driver instead of using

Re: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

2016-03-19 Thread David Lechner
On 03/16/2016 07:27 AM, Sergei Shtylyov wrote: +static struct clk usb20_clk = { +.name= "usb20", +.parent= &pll0_sysclk2, +.lpsc= DA8XX_LPSC1_USB20, +.gpsc= 1, +}; Why move it? For organization, to keep all of the USB clocks together. I can

[PATCH] usb/core: usb_alloc_dev(): fix setting of ->portnum

2016-03-19 Thread Nicolai Stange
With commit 69bec7259853 ("USB: core: let USB device know device node"), the port1 argument of usb_alloc_dev() gets overwritten as follows: ... usb_alloc_dev(..., unsigned port1) { ... if (!parent->parent) { port1 = usb_hcd_find_raw_port_number(..., port1); } ... } Lat

Re: [PATCH 2/2] usb: dwc3: gadget: usb: dwc3: run/stop metastability workaround

2016-03-19 Thread Roger Quadros
On 16/03/16 15:14, Felipe Balbi wrote: > Roger Quadros writes: > >> [ text/plain ] >> The existing workaround of forcing DEVSPD to SUPER_SPEED >> for HIGH_SPEED ports is causing another side effect >> which causes erratic interrupts and delayed gadget >> enumeration of upto 2 seconds. >> >> Work

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-19 Thread Arnd Bergmann
On Monday 14 March 2016 18:51:08 Peter Chen wrote: > On Wed, Mar 09, 2016 at 05:16:50PM -0600, Li Yang wrote: > > On Tue, Mar 8, 2016 at 9:40 PM, Bjorn Andersson > > wrote: > > > On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrote: > > >> On Wed, Mar 2, 2016 at 4:59 PM, Li Yang wrote: > > >>> On Mon,

Re: [PATCH 4/5] usb: ohci-da8xx: Remove clock code that references mach

2016-03-19 Thread David Lechner
On 03/16/2016 09:50 AM, Alan Stern wrote: Is it theoretically impossible for a da8xx platform to have more than one OHCI controller? If it isn't, you better not use static variables to hold per-device data. Yes, it is theoretically impossible, but probably better to not use static variables

[PATCH v2] usb/core: usb_alloc_dev(): fix setting of ->portnum

2016-03-19 Thread Nicolai Stange
With commit 69bec7259853 ("USB: core: let USB device know device node"), the port1 argument of usb_alloc_dev() gets overwritten as follows: ... usb_alloc_dev(..., unsigned port1) { ... if (!parent->parent) { port1 = usb_hcd_find_raw_port_number(..., port1); } ... } Lat

Re: PROBLEM: Osprey 2 Mini sometimes resets every 200ms forever

2016-03-19 Thread Alan Stern
On Wed, 16 Mar 2016, ais523 wrote: > One line summary of the problem: > Connecting an Osprey 2 Mini sometimes causes it to reset every 200ms > > Full description of the problem/report: > This report is about a hardware compatibility issue related to the > Osprey 2 Mini, a cellular router that can

Re: [PATCH 3/5] ARM: davinci: da8xx: add cfgchip2 to resources

2016-03-19 Thread Sergei Shtylyov
Hello. On 3/16/2016 6:46 AM, David Lechner wrote: No, this register is shared b/w MUSB and OHCI. The proper thing to do is to write the PHY driver and let it control this shared register. OK. I've started working on this. I am looking at using struct usb_phy, however, enum usb_phy_type o

[PATCH 0/5] usb: dwc3: xhci: Add quirk for defective Port Enable/disable

2016-03-19 Thread Roger Quadros
Hi, Some devices from Texas Instruments suffer from a silicon bug where XHCI Port Enabled/Disabled bit should not be used to silence an erroneous device. The bug is so that if port is disabled with PED bit, an IRQ for device removal (or attachment) will never fire. Just for the sake of c

Re: [PATCH] cypress_m8: add sanity checking

2016-03-19 Thread Johan Hovold
On Thu, Mar 17, 2016 at 11:07:31AM +0100, Oliver Neukum wrote: > An attack using missing endpoints exists. > CVE-2016-3137 > > Signed-off-by: Oliver Neukum > CC: sta...@vger.kernel.org > --- > drivers/usb/serial/cypress_m8.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) >

[PATCH 2/5] usb: dwc3: core: define macros for newest revisions

2016-03-19 Thread Roger Quadros
From: Felipe Balbi dwc3 has released two other versions (2.90a and 3.00a), this patch just adds revision macros. Signed-off-by: Felipe Balbi Signed-off-by: Sekhar Nori Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/d

[PATCH v5 1/6] extcon: usb-gpio: add device binding for platform device

2016-03-19 Thread Lu Baolu
This is needed to handle the GPIO connected USB ID pin found on Intel Baytrail devices. Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi Acked-by: Chanwoo Choi --- drivers/extcon/extcon-usb-gpio.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/extcon/extcon-usb-gpio.c b/dr

Re: [PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-19 Thread Chanwoo Choi
Hi Lu, To handle extcon (external connector), I implemented the unique id for each external connector on patch[1] instead of using the ambiguous string type. [1] 2a9de9c0f08d6 (extcon: Use the unique id for external connector instead of string) So I recommend that you should use the unique id

Re: [RFC PATCH 1/4] usb: chipidea: Do not rely on OTG while using extcon

2016-03-19 Thread Chanwoo Choi
Hi Sanchayan, I recommend that you use the unique id (ex. EXTCON_USB, EXTCON_USB_HOST) when getting/setting the state of external connector with extcon functions - extcon_get_cable_state() is deprecated -> extcon_get_cable_state_() - extcon_set_cable_state() is deprecated -> extcon_set_cable_state

Re: [PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-19 Thread Lu Baolu
Hi Chanwoo, On 03/17/2016 02:07 PM, Chanwoo Choi wrote: > Hi Lu, > > To handle extcon (external connector), I implemented the unique id > for each external connector on patch[1] instead of using the ambiguous string > type. > [1] 2a9de9c0f08d6 (extcon: Use the unique id for external connector in

Re: [PATCH v10 2/9] dt-bindings: pinctrl: Deprecate Tegra XUSB pad controller binding

2016-03-19 Thread Stephen Warren
On 03/04/2016 09:19 AM, Thierry Reding wrote: From: Thierry Reding This is an old version of the binding that isn't flexible enough to describe all aspects of the XUSB pad controller. Specifically with the addition of XUSB support (for SuperSpeed USB) the existing binding is no longer suitable.

Re: [PATCH v10 6/9] dt-bindings: usb: Add NVIDIA Tegra XUSB controller binding

2016-03-19 Thread Stephen Warren
On 03/04/2016 09:19 AM, Thierry Reding wrote: From: Thierry Reding Add device-tree binding documentation for the XUSB controller present on Tegra124 and later SoCs. This controller supports USB 3.0 via an xHCI compliant interface. Based on work by Andrew Bresticker . diff --git a/Documentat

[PATCH v2 07/11] ARM: davinci: da8xx: Add USB PHY platform declaration

2016-03-19 Thread David Lechner
There is now a proper phy driver for the DA8XX SoC USB PHY. This adds the platform device declarations needed to use it. Signed-off-by: David Lechner --- v2 changes: This is new patch in v2. arch/arm/mach-davinci/include/mach/da8xx.h | 1 + arch/arm/mach-davinci/usb.c| 24 +++

Re: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit()

2016-03-19 Thread Felipe Balbi
Hi, Roger Quadros writes: > [ text/plain ] > We will need this function for a workaround. > The function issues a softreset only to the device > controller and performs minimal re-initialization > so that the device controller can be usable. > > As some code is similar to dwc3_core_init() take o

Re: [PATCH] uas: Limit qdepth at the scsi-host level

2016-03-19 Thread Sergei Shtylyov
Hello. On 3/19/2016 11:59 AM, Hans de Goede wrote: Commit 64d513ac31bd ("scsi: use host wide tags by default") causes the scsi-core to queue more cmnds then we can handle on devices with SCSI core? Commands? multiple LUNs, limit the qdepth at the scsi-host level instead of Queue dep

[PATCH v5 5/6] usb: mux: add driver for Intel drcfg controlled port mux

2016-03-19 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register. Signed-off-by: Heikki Krogerus Signed-off-by: Lu Baolu Signed-off-by: Wu Hao Reviewed-by: Felipe Ba

Re: [PATCH v1] usb: xhci: applying XHCI_PME_STUCK_QUIRK to Intel BXT B0 host

2016-03-19 Thread Greg KH
On Wed, Mar 16, 2016 at 11:41:50AM +0100, Robert Dobrowolski wrote: > From: Rafal Redzimski > > Signed-off-by: Rafal Redzimski We can't take patches without any changelog entry :( -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger

Re: [PATCH 2/3] usb: dwc3: increase maximum number of TRBs per endpoint

2016-03-19 Thread Felipe Balbi
Hi, Bin Liu writes: > [ text/plain ] > Hi, > > On Fri, Mar 11, 2016 at 6:54 AM, Felipe Balbi > wrote: >> previously we were using a maximum of 32 TRBs per >> endpoint. With each TRB being 16 bytes long, we were >> using 512 bytes of memory for each endpoint. >> >> However, SLAB/SLUB will always

  1   2   >