Re: [PATCH] usb: dwc3: Fix assignment of EP transfer resources

2016-02-10 Thread Felipe Balbi
Hi, John Youn writes: >> John Youn writes: >>> The assignement of EP transfer resources was not handled properly in the >>> dwc3 driver. Commit aebda6187181 ("usb: dwc3: Reset the transfer >>> resource index on SET_INTERFACE") previously fixed one aspect of this >>> where resources may be exhau

[PATCH] cdc-acm: implement put_char() and flush_chars()

2016-02-10 Thread Oliver Neukum
This should cut down latencies and waste if the tty layer writes single bytes. Signed-off-by: Oliver Neukum >oneu...@suse.com> --- drivers/usb/class/cdc-acm.c | 67 + drivers/usb/class/cdc-acm.h | 1 + 2 files changed, 68 insertions(+) diff --git a/dr

Re: [PATCH] usb: dwc3: Fix assignment of EP transfer resources

2016-02-10 Thread John Youn
On 2/10/2016 12:44 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >>> John Youn writes: The assignement of EP transfer resources was not handled properly in the dwc3 driver. Commit aebda6187181 ("usb: dwc3: Reset the transfer resource index on SET_INTERFACE") previously fi

Re: [PATCH] usb: dwc3: Fix assignment of EP transfer resources

2016-02-10 Thread Felipe Balbi
Hi, John Youn writes: >> If it wasn't for that flag, we would always allocate transfer resource 3 >> for every newly enabled endpoint. Can you check with your RTL engineers >> if it's valid to *always* issue DEPSTARTCFG with a proper parameter >> depending on endpoint number ? Basically, somet

Re: [PATCH 1/2] usb: dwc3: drop FIFO resizing logic

2016-02-10 Thread Felipe Balbi
Hi, Kishon Vijay Abraham I writes: > Hi Felipe, > > On Thursday 04 February 2016 05:48 PM, Felipe Balbi wrote: >> That FIFO resizing logic was added to support OMAP5 >> ES1.0 which had a bogus default FIFO size. I can't >> remember the exact size of default FIFO, but it was >> less than one bulk

Re: [PATCH 1/2] usb: dwc3: drop FIFO resizing logic

2016-02-10 Thread Kishon Vijay Abraham I
Hi, On Wednesday 10 February 2016 03:43 PM, Felipe Balbi wrote: > > Hi, > > Kishon Vijay Abraham I writes: >> Hi Felipe, >> >> On Thursday 04 February 2016 05:48 PM, Felipe Balbi wrote: >>> That FIFO resizing logic was added to support OMAP5 >>> ES1.0 which had a bogus default FIFO size. I can'

Re: [PATCH 3/3] usb: type-c: UCSI ACPI driver

2016-02-10 Thread Heikki Krogerus
On Tue, Feb 09, 2016 at 10:22:46AM -0800, Greg KH wrote: > On Tue, Feb 09, 2016 at 07:01:23PM +0200, Heikki Krogerus wrote: > > Driver for ACPI enumerated UCSI devices. > > What does this mean? > > What does the driver do? Why would we care? > > > > > Signed-off-by: Heikki Krogerus > > --- >

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Heikki Krogerus
On Tue, Feb 09, 2016 at 10:21:55AM -0800, Greg KH wrote: > On Tue, Feb 09, 2016 at 07:01:22PM +0200, Heikki Krogerus wrote: > > USB Type-C Connector System Software Interface (UCSI) is a > > specification that defines registers and data structures > > used to interface with the USB Type-C connector

[PATCH] usb: retry reset if a device times out

2016-02-10 Thread Oliver Neukum
Some devices I got show an inability to operate right after power on if they are already connected. They are beyond recovery if the descriptors are requested multiple times. So in case of a timeout we rather bail early and reset again. But it must be done only on the first loop lest we get into a r

Re: [PATCH 1/3] usb: USB Type-C Connector Class

2016-02-10 Thread Heikki Krogerus
On Tue, Feb 09, 2016 at 10:20:45AM -0800, Greg KH wrote: > On Tue, Feb 09, 2016 at 07:01:21PM +0200, Heikki Krogerus wrote: > > The purpose of this class is to provide unified interface > > for user space to get the status and basic information about > > USB Type-C Connectors in the system, control

Re: [PATCH 1/3] usb: USB Type-C Connector Class

2016-02-10 Thread Oliver Neukum
On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: > The purpose of this class is to provide unified interface > for user space to get the status and basic information about > USB Type-C Connectors in the system, control data role > swapping, and when USB PD is available, also power role > s

Re: [PATCH 1/3] usb: USB Type-C Connector Class

2016-02-10 Thread Andy Shevchenko
On Wed, Feb 10, 2016 at 12:49 PM, Oliver Neukum wrote: > On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: >> The purpose of this class is to provide unified interface >> for user space to get the status and basic information about >> USB Type-C Connectors in the system, control data role

Re: [PATCH 1/3] usb: USB Type-C Connector Class

2016-02-10 Thread Heikki Krogerus
On Wed, Feb 10, 2016 at 01:05:27PM +0200, Andy Shevchenko wrote: > On Wed, Feb 10, 2016 at 12:49 PM, Oliver Neukum wrote: > > On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: > >> The purpose of this class is to provide unified interface > >> for user space to get the status and basic inf

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Oliver Neukum
> +static int ucsi_run_cmd(struct ucsi *ucsi, void *data, size_t size) > +{ > + int status; > + int ret; > + > + dev_vdbg(ucsi->dev, "%s control 0x%llx\n", __func__, > + ucsi->ppm->data->control); > + > + ret = ucsi->ppm->cmd(ucsi->ppm); > + if (ret) > +

Re: [PATCH 1/3] usb: USB Type-C Connector Class

2016-02-10 Thread Heikki Krogerus
Hi Oliver, > > +static ssize_t alternate_mode_store(struct device *dev, > > + struct device_attribute *attr, > > + const char *buf, size_t size) > > +{ > > + struct typec_port *port = to_typec_port(dev); > > + struct typec_alt_mode al

Re: [PATCH 1/2] usb: dwc3: drop FIFO resizing logic

2016-02-10 Thread Felipe Balbi
Hi, Kishon Vijay Abraham I writes: >> Kishon Vijay Abraham I writes: >>> Hi Felipe, >>> >>> On Thursday 04 February 2016 05:48 PM, Felipe Balbi wrote: That FIFO resizing logic was added to support OMAP5 ES1.0 which had a bogus default FIFO size. I can't remember the exact size of

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-10 Thread Petr Kulhavy
On 09.02.2016 11:50, Sergei Shtylyov wrote: Doesn't usb_get_dr_mode() work for you? I can't really say because I can't test it. Is this the replacement for of_usb_get_dr_mode() ? Seems so. The call in musb_dsps.c was just replaced. Thanks, Sergei. Yesterday I submitted the (hopeful

Re: [PATCH 1/3] usb: USB Type-C Connector Class

2016-02-10 Thread Andy Shevchenko
On Wed, Feb 10, 2016 at 1:11 PM, Heikki Krogerus wrote: > On Wed, Feb 10, 2016 at 01:05:27PM +0200, Andy Shevchenko wrote: >> On Wed, Feb 10, 2016 at 12:49 PM, Oliver Neukum wrote: >> > On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: >> >> The purpose of this class is to provide unified

Re: [PATCHv2 1/2] usb: dwc3: pci: use build-in properties instead of platform data

2016-02-10 Thread Heikki Krogerus
Hi John, > Hi Heikki, > > The properties are now set using your patch. > > However I get a use-after-free error when I unload the driver: OK. I need to prepare proper fixes for the fwnode handling, but I think these patches are in any case OK. Though they now depend on those fixes of course.

Re: ULPI Driver help

2016-02-10 Thread Heikki Krogerus
Hi Sudhakar, On Mon, Feb 08, 2016 at 11:20:44PM -0800, Sudhakar Krishnan wrote: > Hi Heikki, > > First of all I would like to apologize for sending you random email. I > found your name from ULPI driver change list > > I am hobbyist developer using baytrail tablet (atom Z3537) and trying to > po

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Andy Shevchenko
On Tue, Feb 9, 2016 at 7:01 PM, Heikki Krogerus wrote: > USB Type-C Connector System Software Interface (UCSI) is a > specification that defines registers and data structures > used to interface with the USB Type-C connectors on a system. > > The specification is public and available at: > http://

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Heikki Krogerus
On Wed, Feb 10, 2016 at 12:19:53PM +0100, Oliver Neukum wrote: > > > +static int ucsi_run_cmd(struct ucsi *ucsi, void *data, size_t size) > > +{ > > + int status; > > + int ret; > > + > > + dev_vdbg(ucsi->dev, "%s control 0x%llx\n", __func__, > > +ucsi->ppm->data->control); > > +

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Oliver Neukum
On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: > +#define UCSI_CONSTAT_BC_NOT_CHARGING 0 > +#define UCSI_CONSTAT_BC_NOMINAL_CHARGING 1 > +#define UCSI_CONSTAT_BC_SLOW_CHARGING 2 > +#define UCSI_CONSTAT_BC_TRICLE_CHARGING3 typo. It is spelled TRIC

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Oliver Neukum
On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote: > > +out: > > CodingStyle suggests to do a better label naming. Names coming from specs are what they are. There is no place for coding style here. Regards Oliver -- To unsubscribe from this list: send the line "

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Andy Shevchenko
On Wed, Feb 10, 2016 at 3:21 PM, Oliver Neukum wrote: > On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote: >> > +out: >> >> CodingStyle suggests to do a better label naming. > > Names coming from specs are what they are. There is > no place for coding style here. Yes, and how is it related

Re: [PATCH 2/2] USB: musb: DA8xx: Add DT support for the DA8xx driver

2016-02-10 Thread Sergei Shtylyov
Hello. On 2/9/2016 3:23 PM, Petr Kulhavy wrote: Adds DT support for the TI DA830 and DA850 USB driver. Signed-off-by: Petr Kulhavy --- drivers/usb/musb/da8xx.c | 136 +++ drivers/usb/musb/musb_core.c | 24 drivers/usb/musb/musb_core.h

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-10 Thread Sergei Shtylyov
On 2/10/2016 2:26 PM, Petr Kulhavy wrote: Doesn't usb_get_dr_mode() work for you? I can't really say because I can't test it. Is this the replacement for of_usb_get_dr_mode() ? Seems so. The call in musb_dsps.c was just replaced. Thanks, Sergei. Yesterday I submitted the (hopefully)

Re: [PATCH 2/2] USB: musb: DA8xx: Add DT support for the DA8xx driver

2016-02-10 Thread Sergei Shtylyov
On 2/10/2016 5:05 PM, Sergei Shtylyov wrote: Adds DT support for the TI DA830 and DA850 USB driver. And I'd write this as DAA8xx/OMAP-L1x/AM17xx/AM18xx. No need to be specific here. Signed-off-by: Petr Kulhavy [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-10 Thread Sergei Shtylyov
On 2/10/2016 5:07 PM, Sergei Shtylyov wrote: [...] Thanks, Sergei. Yesterday I submitted the (hopefully) final version version Hope dies last. :-) There's too much cut&pasted code in your patch still... of the patch based on Felipe's "next" branch and incorporating all you guys' f

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Oliver Neukum
On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote: > > +err: > > + if (i > 0) > > + for (; i >= 0; i--, con--) > > + typec_unregister_port(con->port); > > Perhaps > > while (--i >= 0) { > ... > } While we are at it. No we should not change the se

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Andy Shevchenko
On Wed, Feb 10, 2016 at 4:15 PM, Oliver Neukum wrote: > On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote: >> > +err: >> > + if (i > 0) >> > + for (; i >= 0; i--, con--) >> > + typec_unregister_port(con->port); >> >> Perhaps >> >> while (--i >= 0) {

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-10 Thread Petr Kulhavy
On 10.02.2016 15:12, Sergei Shtylyov wrote: of the patch based on Felipe's "next" branch and incorporating all you guys' feedback. Also the binding was submitted separately. I'll go find it, haven't seen yet. I just haven't received it. Please make sure to CC at least linux-usb next

[PATCH 02/21] usb: add HAS_IOMEM dependency to USB_NET2272

2016-02-10 Thread Vegard Nossum
drivers/usb/gadget/udc/net2272.c: In function ‘net2272_remove’: drivers/usb/gadget/udc/net2272.c:2232:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] iounmap(dev->base_addr); ^ drivers/usb/gadget/udc/net2272.c: In function ‘net2272_plat_probe’: driv

[PATCH 03/21] usb: Add HAS_IOMEM dependency to USB_M66592

2016-02-10 Thread Vegard Nossum
drivers/usb/gadget/udc/m66592-udc.c: In function ‘m66592_remove’: drivers/usb/gadget/udc/m66592-udc.c:1538:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] iounmap(m66592->reg); ^ drivers/usb/gadget/udc/m66592-udc.c: In function ‘m66592_probe’: drive

[PATCH 19/21] usb: add HAS_IOMEM dependency to USB_ISP1362_HCD

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `isp1362_probe': /home/vegard/linux/drivers/usb/host/isp1362-hcd.c:2668: undefined reference to `devm_ioremap_resource' Signed-off-by: Vegard Nossum --- drivers/usb/host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/Kconfig b/driver

[PATCH 01/21] usb: add HAS_IOMEM dependency to USB_ISP116X_HCD

2016-02-10 Thread Vegard Nossum
drivers/usb/host/isp116x-hcd.c: In function ‘isp116x_remove’: drivers/usb/host/isp116x-hcd.c:1552:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] iounmap(isp116x->data_reg); ^ drivers/usb/host/isp116x-hcd.c: In function ‘isp116x_probe’: drivers/usb/

Re: [PATCH 21/21] usb: remove HAS_IOMEM dependency from USB_SUPPORT

2016-02-10 Thread Richard Weinberger
Am 10.02.2016 um 15:29 schrieb Vegard Nossum: > USB has not been usable on UML since this commit: > > commit e25df1205f37c7bff3ab14fdfc8a5249f3c69c82 > Author: Martin Schwidefsky > Date: Thu May 10 15:45:57 2007 +0200 > > [S390] Kconfig: menus with depends on HAS_IOMEM. > > Add "depen

[PATCH 20/21] usb: support building without CONFIG_HAS_DMA

2016-02-10 Thread Vegard Nossum
Some platforms don't have DMA, but we should still be able to build USB drivers for these platforms. They could still be used through vhci_hcd, usbip_host, or maybe something like USB passthrough in UML from a capable host. This is admittedly ugly with all the #ifdefs, but it is necessary to get a

[PATCH 10/21] usb: add HAS_IOMEM dependency to USB_EHCI_HCD

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `ehci_platform_probe': /home/vegard/linux/drivers/usb/host/ehci-platform.c:282: undefined reference to `devm_ioremap_resource' drivers/built-in.o: In function `oxu_drv_probe': /home/vegard/linux/drivers/usb/host/oxu210hp-hcd.c:3821: undefined reference to `devm_ior

[PATCH 15/21] usb: add HAS_IOMEM dependency to USB_APPLEDISPLAY

2016-02-10 Thread Vegard Nossum
warning: (USB_APPLEDISPLAY) selects BACKLIGHT_LCD_SUPPORT which has unmet direct dependencies (HAS_IOMEM) Signed-off-by: Vegard Nossum --- drivers/usb/misc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig index f7a7fc2..ea10059 1006

[PATCH 12/21] usb: add HAS_IOMEM dependency to USB_FOTG210_HCD

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `fotg210_hcd_probe': /home/vegard/linux/drivers/usb/host/fotg210-hcd.c:5637: undefined reference to `devm_ioremap_resource' Signed-off-by: Vegard Nossum --- drivers/usb/host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/Kconfig b/dr

[PATCH 18/21] usb: add HAS_IOMEM dependency to USB_OXU210HP_HCD

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `oxu_drv_probe': /home/vegard/linux/drivers/usb/host/oxu210hp-hcd.c:3821: undefined reference to `devm_ioremap_resource' Signed-off-by: Vegard Nossum --- drivers/usb/host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/Kconfig b/drive

[PATCH 21/21] usb: remove HAS_IOMEM dependency from USB_SUPPORT

2016-02-10 Thread Vegard Nossum
USB has not been usable on UML since this commit: commit e25df1205f37c7bff3ab14fdfc8a5249f3c69c82 Author: Martin Schwidefsky Date: Thu May 10 15:45:57 2007 +0200 [S390] Kconfig: menus with depends on HAS_IOMEM. Add "depends on HAS_IOMEM" to a number of menus to make them disappear

[PATCH 17/21] usb: add HAS_IOMEM dependency to USB_PXA27X

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `pxa_udc_probe': /home/vegard/linux/drivers/usb/gadget/udc/pxa27x_udc.c:2430: undefined reference to `devm_ioremap_resource' Signed-off-by: Vegard Nossum --- drivers/usb/gadget/udc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc

[PATCH 14/21] usb: add HAS_IOMEM dependency to USB_PXA25X

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `pxa_udc_probe': /home/vegard/linux/drivers/usb/gadget/udc/pxa27x_udc.c:2430: undefined reference to `devm_ioremap_resource' Signed-off-by: Vegard Nossum --- drivers/usb/gadget/udc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc

[PATCH 04/21] usb: add HAS_IOMEM dependency to USB_XHCI_MVEBU

2016-02-10 Thread Vegard Nossum
drivers/usb/host/xhci-mvebu.c: In function ‘xhci_mvebu_mbus_init_quirk’: drivers/usb/host/xhci-mvebu.c:58:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] base = ioremap(res->start, resource_size(res)); ^ drivers/usb/host/xhci-mvebu.c:58:7: warning:

[PATCH 07/21] usb: add HAS_IOMEM dependency to USB_C67X00_HCD

2016-02-10 Thread Vegard Nossum
CC drivers/usb/c67x00/c67x00-drv.o drivers/usb/c67x00/c67x00-drv.c: In function ‘c67x00_drv_probe’: drivers/usb/c67x00/c67x00-drv.c:148:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] c67x00->hpi.base = ioremap(res->start, resource_size(res));

[PATCH 09/21] usb: add HAS_IOMEM dependency to USB_DWC2

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `dwc2_driver_probe': /home/vegard/linux/drivers/usb/dwc2/platform.c:491: undefined reference to `devm_ioremap_resource' Signed-off-by: Vegard Nossum --- drivers/usb/dwc2/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/Kconfig b/driver

[PATCH 16/21] usb: add HAS_IOMEM dependency to USB_OHCI_HCD

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `ohci_platform_probe': /home/vegard/linux/drivers/usb/host/ohci-platform.c:246: undefined reference to `devm_ioremap_resource' Signed-off-by: Vegard Nossum --- drivers/usb/host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/Kconfig b

[PATCH 11/21] usb: add HAS_IOMEM dependency to USB_XHCI_HCD

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `xhci_plat_probe': /home/vegard/linux/drivers/usb/host/xhci-plat.c:160: undefined reference to `devm_ioremap_resource' Signed-off-by: Vegard Nossum --- drivers/usb/host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/Kconfig b/drivers

[PATCH 06/21] usb: add HAS_IOMEM dependency to USB_MUSB_TUSB6010

2016-02-10 Thread Vegard Nossum
CC drivers/usb/musb/tusb6010.o drivers/usb/musb/tusb6010.c: In function ‘tusb_musb_init’: drivers/usb/musb/tusb6010.c:1133:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] sync = ioremap(mem->start, resource_size(mem)); ^ drivers/usb/musb/tusb

[PATCH 08/21] usb: add HAS_IOMEM dependency to USB_SL811_HCD

2016-02-10 Thread Vegard Nossum
CC drivers/usb/host/xhci-mtk.o drivers/usb/host/xhci-mtk.c:135:12: warning: ‘xhci_mtk_host_disable’ defined but not used [-Wunused-function] static int xhci_mtk_host_disable(struct xhci_hcd_mtk *mtk) ^ drivers/usb/host/xhci-mtk.c:313:13: warning: ‘usb_wakeup_enable’ defined but

[PATCH 13/21] usb: add HAS_IOMEM dependency to USB_MUSB_HDRC

2016-02-10 Thread Vegard Nossum
drivers/built-in.o: In function `musb_probe': /home/vegard/linux/drivers/usb/musb/musb_core.c:2304: undefined reference to `devm_ioremap_resource' Signed-off-by: Vegard Nossum --- drivers/usb/musb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/Kconfig b/drivers/usb

[PATCH 05/21] usb: add HAS_IOMEM dependency to USB_R8A66597_HCD

2016-02-10 Thread Vegard Nossum
CC drivers/usb/host/r8a66597-hcd.o drivers/usb/host/r8a66597-hcd.c: In function ‘r8a66597_remove’: drivers/usb/host/r8a66597-hcd.c:2401:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] iounmap(r8a66597->reg); ^ drivers/usb/host/r8a66597-hcd.c:

Re: [PATCH 21/21] usb: remove HAS_IOMEM dependency from USB_SUPPORT

2016-02-10 Thread Vegard Nossum
On 02/10/2016 03:35 PM, Richard Weinberger wrote: Am 10.02.2016 um 15:29 schrieb Vegard Nossum: USB has not been usable on UML since this commit: commit e25df1205f37c7bff3ab14fdfc8a5249f3c69c82 Author: Martin Schwidefsky Date: Thu May 10 15:45:57 2007 +0200 [S390] Kconfig: menus with d

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Oliver Neukum
On Wed, 2016-02-10 at 16:24 +0200, Andy Shevchenko wrote: > On Wed, Feb 10, 2016 at 4:15 PM, Oliver Neukum wrote: > > On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote: > >> > +err: > >> > + if (i > 0) > >> > + for (; i >= 0; i--, con--) > >> > + ty

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Bjørn Mork
Andy Shevchenko writes: > On Wed, Feb 10, 2016 at 3:21 PM, Oliver Neukum wrote: >> On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote: >>> > +out: >>> >>> CodingStyle suggests to do a better label naming. >> >> Names coming from specs are what they are. There is >> no place for coding style

Re: [PATCH 2/2] USB: musb: DA8xx: Add DT support for the DA8xx driver

2016-02-10 Thread Petr Kulhavy
Hello Sergei, On 10.02.2016 15:05, Sergei Shtylyov wrote: @@ -1,6 +1,9 @@ /* * Texas Instruments DA8xx/OMAP-L1x "glue layer" * + * DT support + * Copyright (c) 2016 Petr Kulhavy, Barix AG + * Could you place this after MV's copyright? I was trying to preserve the descending date

Re: [PATCH 02/21] usb: add HAS_IOMEM dependency to USB_NET2272

2016-02-10 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2016 at 03:29:37PM +0100, Vegard Nossum wrote: > drivers/usb/gadget/udc/net2272.c: In function ‘net2272_remove’: > drivers/usb/gadget/udc/net2272.c:2232:2: error: implicit declaration of > function ‘iounmap’ [-Werror=implicit-function-declaration] > iounmap(dev->base_addr); > ^

Re: [PATCH 02/21] usb: add HAS_IOMEM dependency to USB_NET2272

2016-02-10 Thread Richard Weinberger
Am 10.02.2016 um 17:28 schrieb Vegard Nossum: > I don't think there is a "correct function" for when HAS_IOMEM is not > enabled. There is no IO address space on UML, so it doesn't make sense > to compile these drivers in the first place. > > Or do you mean to use the dummy implementation from asm-

Re: [PATCH 02/21] usb: add HAS_IOMEM dependency to USB_NET2272

2016-02-10 Thread Vegard Nossum
On 02/10/2016 05:15 PM, Greg Kroah-Hartman wrote: On Wed, Feb 10, 2016 at 03:29:37PM +0100, Vegard Nossum wrote: drivers/usb/gadget/udc/net2272.c: In function ‘net2272_remove’: drivers/usb/gadget/udc/net2272.c:2232:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-

Re: [PATCH] usb: host: xhci: Replace bus lock with host controller lock

2016-02-10 Thread Mathias Nyman
On 05.02.2016 17:14, Chris Bainbridge wrote: Running task list at fail point: ... Some of the functions appear to be inlined, the exact call chain is: hub_port_init usb_get_device_descriptor usb_get_descriptor usb_control_msg usb_internal_control_m

Re: [PATCH] usb: core: hub: hub_port_init lock controller instead of bus

2016-02-10 Thread Mathias Nyman
On 08.02.2016 15:49, Chris Bainbridge wrote: The XHCI controller presents two USB buses to the system - one for USB 2 and one for USB 3. When only one bus is locked there is a race condition with two threads in hub_port_init: [8.984500] Call Trace: [8.985698] [] schedule+0x37/0x90 [

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

2016-02-10 Thread Greg KH
On Wed, Feb 10, 2016 at 12:30:42PM +0200, Heikki Krogerus wrote: > On Tue, Feb 09, 2016 at 10:21:55AM -0800, Greg KH wrote: > > On Tue, Feb 09, 2016 at 07:01:22PM +0200, Heikki Krogerus wrote: > > > USB Type-C Connector System Software Interface (UCSI) is a > > > specification that defines register

Re: [PATCH 1/3] usb: USB Type-C Connector Class

2016-02-10 Thread Greg KH
On Wed, Feb 10, 2016 at 12:38:40PM +0200, Heikki Krogerus wrote: > > And what is userspace going to do with these files? Why does it care? > > The OS policy regarding USB Type-C ports needs to come from user > space. What drives this "need"? > The user must be allowed to select the USB data rol

Re: usb: musb: slower system resume

2016-02-10 Thread Vishal Thanki
Hi, On Tue, Feb 9, 2016 at 3:51 PM, Vishal Thanki wrote: > On Mon, Feb 08, 2016 at 08:44:19PM +0200, Felipe Balbi wrote: >> >> Hi, >> >> Vishal Thanki writes: >> > It is vanilla kernel v4.0, except for some ASoC patches and v5 of Dave's PM >> > series from kernel v3.19-rc5 rebased to it. >> >> C

Re: [PATCH 2/2] USB: musb: DA8xx: Add DT support for the DA8xx driver

2016-02-10 Thread Sergei Shtylyov
Hello. On 02/10/2016 07:01 PM, Petr Kulhavy wrote: @@ -1,6 +1,9 @@ /* * Texas Instruments DA8xx/OMAP-L1x "glue layer" * + * DT support + * Copyright (c) 2016 Petr Kulhavy, Barix AG + * Could you place this after MV's copyright? I was trying to preserve the descending date orde

Re: [PATCH] usb: dwc3: Fix assignment of EP transfer resources

2016-02-10 Thread John Youn
On 2/10/2016 2:11 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: > > >>> If it wasn't for that flag, we would always allocate transfer resource 3 >>> for every newly enabled endpoint. Can you check with your RTL engineers >>> if it's valid to *always* issue DEPSTARTCFG with a proper par

Re: [PATCH] usb: dwc3: Fix assignment of EP transfer resources

2016-02-10 Thread Felipe Balbi
John Youn writes: >>> Basically assign all the resources in advance. >> >> I thought about that, but wouldn't this, essentially, enable all >> endpoints unconditionally ? This could, potentially, increase power >> consumption on some systems, right ? This could also cause "spurious" >> interrupts

Re: [PATCH 21/21] usb: remove HAS_IOMEM dependency from USB_SUPPORT

2016-02-10 Thread kbuild test robot
Hi Vegard, [auto build test WARNING on usb/usb-testing] [also build test WARNING on v4.5-rc3 next-20160210] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Vegard-Nossum/usb-add-HAS_IOMEM

[PATCH] usb: storage: make US_DEBUGPX print with LOGLEVEL_DEBUG

2016-02-10 Thread Victor Dodon
The US_DEBUGPX macro uses printk without specifying a kernel log level, so the default kernel log level is used, which may not match LOGLEVEL_DEBUG used in usb_stor_dbg. Use printk_emit with LOGLEVEL_DEBUG instead. Signed-off-by: Victor Dodon --- drivers/usb/storage/debug.h | 10 -- 1 fi

Business Partnership

2016-02-10 Thread EYADEMA
Hello, I am Mr. LAURENT EYADEMA from Republic of Togo.please read the attached proposal. Thanks in anticipation of your urgent response, LAURENT EYADEMA proposal.docx Description: Binary data

Business Partnership

2016-02-10 Thread EYADEMA
Hello, I am Mr. LAURENT EYADEMA from Republic of Togo.please read the attached proposal. Thanks in anticipation of your urgent response, LAURENT EYADEMA proposal.docx Description: Binary data

Re: [PATCH] cdc-acm: implement put_char() and flush_chars()

2016-02-10 Thread Oliver Neukum
On Wed, 2016-02-10 at 11:58 -0800, Peter Hurley wrote: > > I was just suggesting that sometimes a > > temporary hack which makes things work and can later be removed when > > there is a proper fix for the problem is better than having it > broken > > for five years straight. > > My preference woul

Business Partnership

2016-02-10 Thread EYADEMA
Hello, I am Mr. LAURENT EYADEMA from Republic of Togo.please read the attached proposal. Thanks in anticipation of your urgent response, LAURENT EYADEMA proposal.docx Description: Binary data